[10:54] ¡Muy buenos días a todos! [11:04] Morning facubatista : early today ! [11:04] hola bthomas [11:04] bthomas, it's around the same time as always, my 8am, or did change any timezone because of spring/autumn? [11:07] Ok. facubatista : I pushed a cleaned up version of doc strings for charm.py in operator to https://github.com/balbirthomas/operator . There is only a single commit. I have not created pull request because I was not sure about a few attributes in the *Meta classes (see TODO at bottom of file). After you settle in and are free to do a quick 1:1 I can update them and create a pull request. I am now reading prometheus manual but ca [11:07] back to docstrings for framework.py after chat. [11:08] bthomas, but why not doing a PR and I can review it as always? [11:08] even if you make it "draft" [11:08] Ok will do a draft Pr now. [11:10] PR operator#417 opened: Added a few doc strings to charm module [14:13] bthomas, I took a look to your PR... do you think there's a chance of proposing part of that as a ready-for-review PR? Just remove the stuff you're unsure or it's not finished, and propose the rest [14:13] bthomas, this way the PR is shorter, and gives us time to decide on the rest [14:16] facubatista: I am perfectly fine with making that a PR. Are you ok with me leaving a TODO in there so it reminds us that a few things need to be added in. Alternatively if you have a couple of mininutes we can try and pair over hangouts and see if those things can be quickly filled in. [14:17] Just do a search for "TODO" on that page. There are only a couple. [14:21] bthomas, remove those with TODOs and leave them for the second wave [14:22] facubatista: ok then. [14:28] thanks [14:42] facubatista: FYI removed TODO and converted to PR [14:44] thanks! [16:06] * facubatista -> lunch [17:03] * facubatista isback [21:10] * facubatista eods and eows [21:10] see you all on monday!