achilleasacan I get a CR on https://github.com/juju/juju/pull/12025?09:01
=== salmankhan1 is now known as salmankhan
stickupkidachilleasa, i'm unsure if we're allowed to bump Client facade11:15
stickupkidanybody know?11:15
stickupkidor is it just the fact that we want to kill it with fire?11:15
stickupkidachilleasa, manadart thoughts on this draft https://github.com/juju/juju/pull/1205711:24
achilleasastickupkid: I bumped it because we are not supposed to break pylibjuju by adding new fields to params without bumping the version, right?11:25
stickupkidachilleasa, correct, but I believe (could be wrong) that the Client facade is "special"11:25
achilleasastickupkid: the PR would be *much* much smaller if I could simply add the new field to the payload :D11:35
achilleasajam: so, is the solution to add a "SupportsIPV6FirewallRules" method to the firewall interfaces (global/instance) and use this information to filter the ingress rule list when I diff?13:55
achilleasa(+ log warnings when a non-wildcard CIDR is filtered out)13:56
achilleasashouldn't be too much work if we want to do it that way and we still get to keep the existing IPV6-friendly logic13:56
achilleasaseems, EC2 is fixable though (might need a version bump of our amz dep): https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateNetworkAclEntry.html (see: Ipv6CidrBlock)14:00
hmlstickupkid: i have a question on the bundle addApplication changes for 12054, in the PR.15:13
stickupkidhml, ta15:14
stickupkidOT: I hate our tests soo much, inserted a errors.Trace() in the wrong place and our test suite explodes15:15
achilleasastickupkid: I updated the diff-bundle PR; can you take another look?15:27
stickupkidachilleasa, sure give me a few15:28
=== salmankhan1 is now known as salmankhan
stickupkidachilleasa, or hml CR please https://github.com/juju/juju/pull/1205816:15

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!