[09:01] <achilleasa> can I get a CR on https://github.com/juju/juju/pull/12025?
=== salmankhan1 is now known as salmankhan
[11:15] <stickupkid> achilleasa, i'm unsure if we're allowed to bump Client facade
[11:15] <stickupkid> anybody know?
[11:15] <stickupkid> or is it just the fact that we want to kill it with fire?
[11:24] <stickupkid> achilleasa, manadart thoughts on this draft https://github.com/juju/juju/pull/12057
[11:25] <achilleasa> stickupkid: I bumped it because we are not supposed to break pylibjuju by adding new fields to params without bumping the version, right?
[11:25] <stickupkid> achilleasa, correct, but I believe (could be wrong) that the Client facade is "special"
[11:35] <achilleasa> stickupkid: the PR would be *much* much smaller if I could simply add the new field to the payload :D
[13:55] <achilleasa> jam: so, is the solution to add a "SupportsIPV6FirewallRules" method to the firewall interfaces (global/instance) and use this information to filter the ingress rule list when I diff?
[13:56] <achilleasa> (+ log warnings when a non-wildcard CIDR is filtered out)
[13:56] <achilleasa> shouldn't be too much work if we want to do it that way and we still get to keep the existing IPV6-friendly logic
[14:00] <achilleasa> seems, EC2 is fixable though (might need a version bump of our amz dep): https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateNetworkAclEntry.html (see: Ipv6CidrBlock)
[15:13] <hml> stickupkid: i have a question on the bundle addApplication changes for 12054, in the PR.
[15:14] <stickupkid> hml, ta
[15:15] <stickupkid> OT: I hate our tests soo much, inserted a errors.Trace() in the wrong place and our test suite explodes
[15:27] <achilleasa> stickupkid: I updated the diff-bundle PR; can you take another look?
[15:28] <stickupkid> achilleasa, sure give me a few
=== salmankhan1 is now known as salmankhan
[16:15] <stickupkid> achilleasa, or hml CR please https://github.com/juju/juju/pull/12058