[05:25] <mborzecki> morning
[05:36] <mborzecki> school run, back in 30
[05:58] <mvo> hey mborzecki - good morning
[06:11] <mborzecki> re
[06:12] <mborzecki> mvo: hey
[06:17] <mborzecki> hmm https://www.reddit.com/r/openSUSE/comments/j0zcs1/snap_cannot_open_display_0/
[06:18] <mborzecki> similar thing was reported in the forums, but fixed apparently? https://forum.snapcraft.io/t/opensuse-tumbleweed-snap-application-cannot-open-display-0/19093
[06:34] <zyga> good morning
[06:39] <mborzecki> mvo: can you take a look at https://github.com/snapcore/snapd/pull/9401 ?
[06:39] <mup> PR #9401:  gadget: allow content observer to have opinions about a change  <Simple 😃> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9401>
[06:39] <zyga> mvo: some question for you wrt nested https://github.com/snapcore/snapd/pull/9414#pullrequestreview-497220829
[06:39] <mup> PR #9414: tests: new nested tool <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9414>
[06:39] <zyga> since you looked at nested recently
[06:39] <zyga> but feel free to defer to ian if you are too busy
[06:44] <zyga> groovy's handling of intel graphics is terrible
[06:44] <zyga> I have screen artefacts, tearing and triangles while I scroll anything
[07:00] <pstolowski> morning
[07:03] <mvo> pstolowski: good morning
[07:03] <pstolowski> o/
[07:04] <mvo> zyga, mborzecki sorry, was distracted but will look at your questions now
[07:04] <mborzecki> pstolowski: hey
[07:17] <mup> PR snapd#9401 closed:  gadget: allow content observer to have opinions about a change  <Simple 😃> <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9401>
[07:18] <mvo> 9383 needs a second review but maybe something for ian
[07:19]  * mvo hugs zyga for all his code reviews this morning
[07:33] <mvo> pstolowski: is the "Thank you" in 9404 a "Approve" ?
[07:35] <pstolowski> mvo: ah, not really, i though i made that comment under the original PR (where I asked about this line). i'll review this one in full
[07:35] <pstolowski> *though
[07:35] <pstolowski> *thought
[07:35] <pstolowski> grr
[08:28] <mborzecki> mvo: uc20 does not boot with 256mb of ram
[08:29] <mborzecki> mvo: https://i.imgur.com/ZGUrsi4.png
[08:32] <mup> PR snapd#9420 opened: tests/nested/manual/minimal-smoke: revert to using 256MB for nested UC20 <Run nested> <UC20> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9420>
[08:42] <mup> PR snapd#9404 closed: asserts: deserialize grouping only once in Pool.AddBatch if needed <Bulk assert refresh :scroll::scroll::scroll:> <Created by pedronis> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9404>
[08:56] <mborzecki> mvo: i've filed https://bugs.launchpad.net/snapd/+bug/1897533 please adjust the priority
[08:56] <mup> Bug #1897533: pc-kernel does not boot on a system with 256MB of RAM <snapd:New> <https://launchpad.net/bugs/1897533>
[09:14] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/9420 will this run nested after you added the label?
[09:14] <mup> PR #9420: tests/nested/manual/minimal-smoke: revert to using 256MB for nested UC20 <Run nested> <UC20> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9420>
[09:15] <mborzecki> zyga: yes, some of the nested runs already finished
[09:15] <zyga> or is the UI confusing and it was done initially?
[09:15] <zyga> ok
[09:15] <mborzecki> zyga: yup, i was added when i opened the issue
[09:16] <mborzecki> zyga: anyways, uc20 will fail there :/
[09:18] <mvo> mborzecki: nice, thanks for this one
[09:23] <zyga> ack
[09:27] <mup> PR snapd#9421 opened: Added Ledger to U2F devices list in interfaces/builtin <Created by TamtamHero> <https://github.com/snapcore/snapd/pull/9421>
[09:29] <zyga> sigh
[09:30] <zyga> 20.10 broke or hid cellular connection control
[09:47] <mup> PR snapd#9041 closed: osutil/group.go: treat all non-nil errs from user.Lookup{Group,} as Unknown* <Bug> <Needs security review> <Preseeding 🍞> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9041>
[09:52] <pedronis> degville: mvo: I commented in #9399
[09:52] <mup> PR #9399: snap: snap help output refresh <Needs Samuele review> <Created by degville> <https://github.com/snapcore/snapd/pull/9399>
[09:52] <mvo> pedronis: ta
[09:53] <mvo> pedronis: sounds good
[09:53] <mvo> (just read it)
[10:20] <degville> pedronis: mvo: thank you! I've left a few comments after your comments.
[10:32]  * zyga splits first branch of the export manager 
[11:28] <pedronis> degville: thanks, I will try to look at it again later today. What do you think of the idea of organizing/splitting Other into real categories for snap help --all ?
[11:36] <degville> pedronis: np - hopefully the latest update is easier to look over. I think splitting Other into real categories for snap help --all is a good idea!
[11:38] <mup> PR snapd#9411 closed: cmd/snap/auto-import: stop importing system user assertions from initramfs mnts <Bug> <Simple 😃> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9411>
[11:58] <mup> PR snapd#9422 opened: overlord: add link participant for linkage transitions <Created by zyga> <https://github.com/snapcore/snapd/pull/9422>
[12:13] <zyga> FYI, on groovy I have errors in master related to user lookup
[12:13] <zyga> user_test.go:552:
[12:13] <zyga>     c.Assert(err, check.ErrorMatches, "useradd failed with: some error")
[12:13] <zyga> ... error string = "user: lookup username lakatos: no such file or directory"
[12:13] <zyga> ... regex string = "useradd failed with: some error"
[12:14] <zyga> has anyone else seen this?
[12:14] <zyga> I didn't debug it yet
[12:14] <zyga> go 1.14.7
[12:23]  * zyga goes for a walk
[12:26] <mvo> zyga: one PR from ian landed recently, let me try this
[12:30] <pedronis> mvo: that PR was very old, it probably needed a master merge and test run before landing
[12:30] <mvo> pedronis: oh no
[12:30] <pedronis> I mean, it was open and untouched for months
[12:30] <mvo> pedronis: I will fix
[12:30] <mvo> pedronis: yeah
[12:31] <mvo> pedronis: but probably after the meeting
[13:14] <micah> hi, i've just installed the grafana snap, and I'm trying to find where the typical config.ini would be located, I see there is a ~/snap/grafana/current, but there isn't anything in there
[13:36] <mborzecki> mvo: pushed a little fix to https://github.com/snapcore/snapd/pull/9383
[13:36] <mup> PR #9383: snap-repair: add uc20 support <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9383>
[13:36] <mvo> mborzecki: aha, nice
[13:36] <mvo> mborzecki: thanks!
[13:48] <ijohnson> mborzecki: pedronis: should I add #8947 back to be reviewed again?
[13:48] <mup> PR #8947: many: update managed boot config when refreshing snapd <UC20> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8947>
[13:49] <ijohnson> pedronis: mvo: I thought I recently pushed a master merge to that gid/uid branch, perhaps I didn't
[13:49] <ijohnson> yeah I merged master 10 days
[13:49] <ijohnson> ago
[13:50] <ijohnson> jdstrand: do we still need security review for pr's like #9421, which are just adding additional devices to the U2F interface? We've gotten a few of these from external contributors the past few months, and while simple perhaps we still should get security review for them
[13:50] <mup> PR #9421: interfaces/utf: Add Ledger to U2F devices <Created by TamtamHero> <https://github.com/snapcore/snapd/pull/9421>
[13:55] <jdstrand> ijohnson: yes, anything touching interface policy should get an ack from our team. you can ping me and I can try to find someone to do it
[13:55] <jdstrand> ijohnson: for that on, I just now commented: https://github.com/snapcore/snapd/pull/9421/files#r495957919
[13:55] <mup> PR #9421: interfaces/utf: Add Ledger to U2F devices <Created by TamtamHero> <https://github.com/snapcore/snapd/pull/9421>
[13:55] <ijohnson> jdstrand: ok, sounds good I will add "needs security review" to that pr and any new ones that come in too
[13:55] <jdstrand> one*
[13:56] <ijohnson> awesome thanks jdstrand
[13:56] <ijohnson> in that case I don't even need to add "needs security review" to that pr :-)
[13:56] <jdstrand> I don't think so :)
[14:05] <ijohnson> :-D
[14:15] <zyga> mborzecki: can you do a review for https://github.com/snapcore/snapd/pull/7614#pullrequestreview-497176348
[14:15] <mup> PR #7614: cmd/snap-confine: implement snap-device-helper internally <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/7614>
[14:15] <zyga> it got a security review last night so we are good to have it in, finally :)
[14:15] <zyga> I know you +1 already but having a new review would be good
[14:16] <zyga> thanks!
[14:20]  * zyga is hungry, time for dinner 
[14:54] <micah> where does data get saved when I use a snap and save something?
[14:56] <zyga> micah: I think /var/lib/snapd/snapshots
[14:57] <micah> zyga: huh, ok... thanks
[15:12] <ijohnson> micah: do you mean you can't find a file you meant to save in $HOME? it could be in $HOME/snap/<snap-name>/current
[15:32] <micah> ijohnson: i saved a grafana dashboard, and I am wondering where it 'saved' to
[15:34] <ijohnson> micah: probably somewhere in /var/snap/grafana/current
[15:35] <micah> ijohnson: unfortunately, that directory is just empty :o
[15:35] <ijohnson> micah: what about /var/snap/grafana/common ?
[15:36] <ijohnson> micah: also to confirm what is the name of the snap that you used when you are running grafana? I am just assuming it's "grafana" verbatim
[15:39] <mup> PR snapd#9395 closed:  o/snapstate/check_snap_test.go: mock osutil.Find{U,G}id to avoid bug in test <Bug> <Test Robustness> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9395>
[15:39] <mup> PR snapd#9423 opened: tests/nested/manual/preseed: include a system-usernames snap when preseeding <Preseeding 🍞> <Run nested> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9423>
[15:47]  * cachio lunch
[17:09] <mup> PR snapd#9348 closed: tests: print all the serial logs for the nested test <Run nested> <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9348>
[17:28] <pedronis> mmh, you can't leave out commands apparently: SnapSuite.TestHelpCategories
[18:19] <mup> PR snapd#9424 opened: cmd/snap: allow snap help vs --all to diverge purposefully <Created by pedronis> <https://github.com/snapcore/snapd/pull/9424>
[18:24] <pedronis> degville: ^  the things I discussed this morning about snap help
[18:25] <degville> pedronis: just looking now - thanks!
[18:56] <pedronis> degville: thx, I answered your comments. Any input on the special purpose section?
[19:04] <degville> pedronis: sorry Samuele - just about to record a podcast. I couldn't think of anything quickly, but I'll give it some thought tonight (if that's not too late). I think it's fundamentally fine as it is though.
=== JanC is now known as Guest49463
=== JanC_ is now known as JanC
[19:30] <mup> PR snapd#9425 opened: tests: new tests.backup tool <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9425>
[20:36] <mup> PR snapcraft#2673 closed: docker: parametrize risk and OS for image builds (core18 etc) <Created by abitrolly> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2673>
[20:41] <mup> PR snapcraft#2871 closed: snaps: account for forwarded (effective) installation channels <Created by cjp256> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2871>
[20:53]  * cachio afk
[20:56] <mup> PR # closed: snapcraft#2971, snapcraft#3062, snapcraft#3127, snapcraft#3287
[21:06] <mup> PR snapcraft#3234 closed: project loader: refactor errors to conform to SnapcraftException <Created by cjp256> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3234>
[21:11] <mup> PR snapcraft#3221 closed: repo: install requested build-package versions <bug> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3221>
[21:16] <mup> PR snapcraft#3256 closed: [wip] repo: consolidate BaseRepo and Ubuntu & reorganize package <enhancement> <Created by cjp256> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3256>
[21:16] <mup> PR snapcraft#3297 closed: cli: support snap --output <directory> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3297>