ItzSwirlzHey guys, is anyone able to assist with Bug #188731200:01
ubottubug 1887312 in cinnamon-session (Ubuntu) "[SRU] Cinnamon session doesn't shutdown until all apps close regardless if they act to Cinnamon's logout request" [Low,In progress] https://launchpad.net/bugs/188731200:01
ItzSwirlzI guess everyone's sleeping right now, it's 8:36 PM for me. Goodnight /o00:36
rbasakteward, AsciiWolf: could teward maybe triage the bugs a little for torbrowser-launcher please - get rid of the "master bug", etc?11:27
rbasak"Do not create a meta-bug with a title like "Please SRU this" rather than using existing bug reports. It is redundant and is opaque to original bug reporters, whose feedback is valuable for verification, so these bugs will be invalidated by the SRU team and corresponding uploads will be rejected from the queue." from https://wiki.ubuntu.com/StableReleaseUpdates#Procedure11:27
rbasakeg. dupe things around - so there's just one bug per root cause left11:28
rbasakFeel free to adjust bug titles to match their root causes11:28
rbasakAnd then as Thomas said they're missing SRU information11:29
rbasakThat's step 3 at https://wiki.ubuntu.com/StableReleaseUpdates#Procedure11:29
AsciiWolfrbasak, sorry, I was offline on IRC, it was just my bouncer online :)12:58
tewardrbasak: easy to nix the master bug.  I can just close it.13:01
tewardthe other bugs need the SRU template13:01
AsciiWolfrbasak, sure, teward, feel free to edit the original bug reports if there is anything wrong in them :) and also feel free to triage them13:02
tewardthen they can all be lumped together13:02
AsciiWolfI have already tested the new torbrowser-launcher build and everything seems to work fine now :)13:02
tewardAsciiWolf: templates.  thats where me uploading this to proposrd and providing a diff for rbasak to look at is blocked13:02
tewardasciiwolf: yep i saw your comment.13:02
AsciiWolfteward, if the SRU templates for other bugs are needed, could you please add them? I am quite busy today and will have to go away in ~15 minutes :/13:04
AsciiWolfteward, btw. there's a small typo in the changelog13:10
AsciiWolf"found in the Tor Browser launcehr package."13:10
teward@AsciiWolf: i can add the templates but will need to analyze regression risk13:20
tewardi'll spellcheck before a final upload lol13:20
tewardAsciiWolf: original bug retired, the remaining 4 got the template, it seems the issue is alos on Xenial per some bugs.14:12
tewardrbasak: ^ for awareness14:12
AsciiWolfteward, I have added a comment here regsrding not fixing the missing gnupg dependency: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1897306/comments/215:32
ubottuLaunchpad bug 1897306 in torbrowser-launcher (Ubuntu) "[SRU] torbrowser-launcher has missing gnupg dependency" [Undecided,Fix released]15:32
tewardrbasak: ^15:32
tewardrbasak is higher than me on the decision tree ;)15:32
teward>This issue happens on all custom (for example installed by netinst with custom package set) Ubuntu systems.< 'custom' sets of packages are sliiiiightly beyond the scope of standard SRU coverage15:33
tewardso unless rbasak changes their mind in this case...15:33
AsciiWolftrue, but this is still a torbrowser-launcher packaging bug15:34
AsciiWolfmissing dependency on a core component that torbrowser-launcher uses and won't work at all without this component installed15:34
AsciiWolfWhat about the alternative solution that I suggested (not adding the patch, just adding "gnupg2" to debian/control? :)15:36
teward`gnupg2` doesn't exist as a package anymore - it's `gnupg` now15:38
tewardit's a dummy transitional package though15:38
tewardso... that could go away at any time15:38
tewardthereby going back to the original fix of using the gnupg binary.  BUT again, if this is a 'nonstandard' installation edge fix, SRU might not want to include such an edge-fix15:39
teward(this is why I poked rbasak)15:39
AsciiWolfwell, if gnupg2 will go away at some point in the 20.04 life cycle, torbrowser-launcher will stop working without the patch anyway15:41
AsciiWolfalso, I wonder whether the gnupg2 package is even preinstalled on Ubuntu 20.04.1... I don't have any Ubuntu system/vm here at the moment, so can't check it15:42
rbasak"This issue happens on all custom (for example installed by netinst with custom package set) Ubuntu systems."15:43
rbasakI agree it's a bug.15:43
rbasakWe fix bugs in the development release.15:43
rbasakFor stable release updates, we try not to disrupt things.15:43
rbasakSo they need further justification, such as more concrete use cases actually impacted15:44
rbasakRather than theoretical impacts15:44
rbasakPeople using custom installation methods can just add the package they want.15:44
rbasakThe workaround for them is trivial as they have a package list anyway15:45
rbasakAsciiWolf: ^ you're welcome to expand on what use cases are broken to change my mind15:45
rbasakBut I need actual justifications please, rather than theoretical ones15:45
rbasakFor example: find me someone who is actually impacted, so I can understand why the SRU is necessary for them15:46
rbasak(and how what they're doing is already broken)15:46
rbasak(and how what they're doing *isn't* already broken)15:46
rbasakI can phrase that better15:47
rbasakHow they're *method* isn't already broken15:47
rbasakHow their *method* isn't already broken15:47
* rbasak isn't with it right now apparently. Sorry.15:47
AsciiWolfrbasak, are you sure that all of the official Ubuntu flavors have gnupg2 (that is, as teward said, "a dummy transitional package that can go away at any time") in their base installation?15:53
AsciiWolfand if you want actual example, I can give you one of my own use cases :)15:53
tewardhere's a question that's valid15:53
tewardAsciiWolf: are you using Ubuntu or Mint?15:54
AsciiWolfboth :)15:54
AsciiWolfneither of them on this machine, but I am using various distros15:54
AsciiWolfusually test things on a clean Ubuntu 20.04 VMs15:54
AsciiWolfbut I am currently not at home and have an ancient mint desktop here and a Fedora laptop15:55
AsciiWolfanyway, to give you the "actual example":15:56
AsciiWolfI have Ubuntu Server installed on one of my machines at home and have xrdp installed there... it is a headless server, but I also use it as a "terminal server" for GUI apps15:58
AsciiWolfif I install torbrowser-launcher on this machine, it won't work15:59
AsciiWolfif I am not mistaken (but cannot check it now), there is no gnupg2 dummy package preinstalled on Ubuntu Server (at least on the minimal installation that I have) out-of-box16:00
AsciiWolfby the way, I am now downloading Xubuntu 20.04.1 to check whether the gnupg2 package is included out-of-box there :) will let you know...16:02
teward> ancient Mint16:02
tewardthere's problem #1 because that's ancient Ubuntu base ;)16:02
AsciiWolfno, the Mint installation is latest :)16:04
AsciiWolfI meant ancient PC, not ancient Mint ;)16:04
AsciiWolfLinux Mint 20 that I have there is based on Ubuntu 20.04.116:04
rbasakAsciiWolf: in your response to your question, I don't know, but that's the way round we drive SRUs.16:18
rbasakWe make a decision to apply an SRU (and take the consequent risk of user regression) on the basis of concrete problems reported that are impacting users that need fixing.16:19
rbasakIf nobody tells us about a problem, then we assume it's safer not to risk regressing existing happy users and only fix it for the next release.16:20
AsciiWolfrbasak, I am downloading Xubuntu to test whether gnupg2 is preinstalled there and will also test some other official Ubuntu flavors today16:20
rbasakThe reverse applies when considering regression risk of course16:20
AsciiWolf*Xubuntu 20.04.116:21
rbasakAsciiWolf: sure. If you find that torbrowser-launcher is broken when using an Ubuntu flavour in its default configuration for example, that's SRU justification enough to fix it. If non-default then we'd have to consider the individual case.16:21
rbasakCorrection: in your response to your question, I don't know, but that's *not* the way round we drive SRUs. I don't know what's with me today, sorry.16:22
rbasakMy fingers don't seem to type what I'm thinking today16:22
rbasakNote that a transitional package will stay for lifetime of a release.16:23
AsciiWolfrbasak, that's a good news, thanks16:24
AsciiWolfthis means that the easiest (and still safe) way to fix this in Focal would be adding "gnupg2" to torbrowser-launcher's debian/control ;)16:26
rbasakHave you considered the regression risk associated with that?16:27
rbasakFor example, does anything in the archive currently conflict with gnupg2?16:27
rbasakIf not, what about all the things like that I haven't thought of right now?16:28
rbasakMy point is just that it's not possible to think of everything :)16:28
rbasakhttps://xkcd.com/1172/ is relevant here :)16:29
AsciiWolfyeah, true16:30
tewardrbasak: coffee.16:52
tewardyou need some :P16:52
* rbasak can't stand the stuff16:53
AsciiWolfrbasak, teward, so, I have just installed Ubuntu 20.04.1 in vm...17:01
AsciiWolffrom latest ubuntu-20.04.1-desktop-amd64.iso17:01
tewardrbasak: would you prefer injectable caffeine?  ;)17:01
tewardAsciiWolf: and?17:01
AsciiWolfand there's no gnupg2 package preinstalled as well17:01
AsciiWolf"Command 'gpg2' not found, but can be installed with:"17:01
tewardso we need to just make it use standard gpg instead of gpg217:02
tewardthat's trivial (and still the patch)17:02
tewardrbasak: ^17:02
tewarddep on gnupg: no17:02
AsciiWolfteward, ok, sounds fine :)17:02
tewardpatch to make it use /usr/bin/gpg instead of /usr/bin/gpg217:02
tewardIF that's the case17:02
tewardrbasak: ^ my analysis on that17:02
tewardAsciiWolf: add this test documentation to the bug17:02
tewardand make sure you reference Xubuntu as the test17:03
tewardnot Mint, etc.17:03
AsciiWolfok :)17:03
AsciiWolfwait, I will also try Xubuntu 20.04.1 and Ubuntu Server17:03
AsciiWolfto be sure there's gpg (not gpg2) preinstalled there17:04
AsciiWolfbut I think it will, I think apt depends on it17:04
tewardubuntu server doens't have a GUI17:05
tewardAsciiWolf: yes I'm pretty sure gpg is there because apt, etc. need it17:05
tewardi know server has gpg there because I deploy that heavily ;:)17:07
teward;) *17:07
AsciiWolf:) ok17:08
tewardAsciiWolf: you're not updating the bugs ;)17:19
tewardso i did for you17:19
AsciiWolfoops, I was just writing it... did not notice that you already sent the update comment :D17:22
AsciiWolfsorry, I am a little bit slow... too much other things I work on at the moment17:22
AsciiWolfteward, should I edit the original bug description to reflect the changes?17:24
tewardnah just add a comment17:25
tewardthat it affects xubuntu, etc.17:25
tewardMint doesn't matter in this case xD17:25
AsciiWolfwell, it seems that it affects *all* flavors including main Ubuntu Desktop :)17:26
tewardwell except for an upgrade from 18.04 to 20.04 :P17:26
tewardwhich has gpg2 on my end17:26
AsciiWolfteward, I have added a new comment mentioning this17:30
tewardi saw17:35
tewardAsciiWolf: rbasak'll review when he can, he EOD'd already so it's on Robie's plate for now20:05
tewardsince he and I and you have already had in-depth discussions on that package20:05

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!