| mup | PR snapcraft#3258 closed: schema/snapcraft.json: allow type: os with build-base <enhancement> <Created by anonymouse64> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3258> | 00:42 |
|---|---|---|
| === JanC_ is now known as JanC | ||
| zyga | good morning | 06:05 |
| * zyga comes in too early | 06:05 | |
| zyga | mborzecki: good morning | 06:13 |
| mborzecki | morning | 06:14 |
| zyga | mvo: good morning | 06:17 |
| zyga | mvo: I'll start with feedback I got so far | 06:17 |
| mup | PR snapd#9383 closed: snap-repair: add uc20 support <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9383> | 06:22 |
| zyga | mvo: could you re-review https://github.com/snapcore/snapd/pull/9410 | 06:24 |
| mup | PR #9410: desktop/notification: add bindings for FDO notifications <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9410> | 06:24 |
| mvo | zyga: good morning, sure | 06:33 |
| * mvo hugs zyga | 06:34 | |
| zyga | thanks :) | 06:35 |
| zyga | 2/3 kids are off to school | 06:35 |
| zyga | one is still a bit too small ;-) | 06:35 |
| zyga | woot, thanks | 06:35 |
| zyga | I'll add a few tests so that there are _some_ at least | 06:36 |
| mup | PR snapd#9426 opened: debian: update changelog <Run nested> <⛔ Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9426> | 06:37 |
| zyga | mvo: I'll send follow-ups with tests soon | 06:51 |
| zyga | tests are all just boring in that package | 06:51 |
| pstolowski | morning | 07:02 |
| zyga | pstolowski: hey | 07:02 |
| zyga | pstolowski: I need a 2nd review for https://github.com/snapcore/snapd/pull/9410 | 07:02 |
| mup | PR #9410: desktop/notification: add bindings for FDO notifications <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9410> | 07:02 |
| mvo | good morning pstolowski | 07:03 |
| pstolowski | o/ | 07:03 |
| pstolowski | zyga: i'll take a look | 07:21 |
| pstolowski | zyga: amazing, when fixing current typo in the PR you reviewed I made another typo /o\. Thankfully tests in the followup branch revealed that | 08:05 |
| zyga | pstolowski: :DDD | 08:05 |
| zyga | pstolowski: what was the typo? | 08:05 |
| pstolowski | cuurrent -> curent | 08:05 |
| zyga | lol | 08:05 |
| zyga | I noticed that typo thanks to VScode spellchecker | 08:05 |
| zyga | ok, I have most of the unit tests now | 08:23 |
| zyga | only signal delivery needs tests but that's a little bit more complicated | 08:23 |
| zyga | pstolowski: I can add existing unit tests to https://github.com/snapcore/snapd/pull/9410 | 08:24 |
| mup | PR #9410: desktop/notification: add bindings for FDO notifications <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9410> | 08:24 |
| zyga | pstolowski: or push them separately | 08:24 |
| zyga | pstolowski: what would you prefer? | 08:24 |
| pstolowski | zyga: i'm fine if it's a separate PR | 08:25 |
| zyga | k | 08:25 |
| pstolowski | zyga: up to you, i haven't started reviewing yet, about to do that | 08:26 |
| zyga | ok, review this | 08:26 |
| zyga | it's already pretty long | 08:26 |
| zyga | though really really simple | 08:27 |
| mup | PR snapd#9428 opened: tests/lib: move to new directory when restoring PWD, cleanup unpacked unpacked snap directories <Run nested> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9428> | 08:38 |
| mup | PR snapd#9429 opened: [RFC] o/daemon: validation sets api and basic spread test <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9429> | 08:38 |
| mborzecki | hmmm, broke something in 9428 | 08:46 |
| mborzecki | glad we have the spread tests to catch that | 08:46 |
| mvo | mborzecki: heh, maybe that's an indication that "simple" should be removed then ;) | 09:03 |
| mborzecki | mvo: uh, not that PR #9427 :0 | 09:04 |
| mvo | mborzecki: haha - sorry | 09:05 |
| mvo | mborzecki: btw, I see that snap run --strace is hanging again more frequently, I wonder if some new kernel syscall is used we also need to exclude. did you notice anything here too (maybe it's just a fluke) | 09:05 |
| zyga | pstolowski: I've added unit tests now at https://github.com/snapcore/snapd/pull/9431 | 09:06 |
| mup | PR #9431: desktop/notification: add unit tests <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9431> | 09:06 |
| mup | PR snapd#9431 opened: desktop/notification: add unit tests <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9431> | 09:08 |
| mborzecki | mvo: no, i didn't but i can check if i can reproduce that on arch | 09:09 |
| pstolowski | zyga: ack | 09:09 |
| mborzecki | can't quite reproduce that locally | 09:15 |
| zyga | pstolowski: should I link to the spec in each of those places | 09:47 |
| zyga | or is linking to it once in the package doc enough? | 09:47 |
| pstolowski | zyga: might be a good idea to link it in all places imho | 09:48 |
| zyga | ok | 09:48 |
| zyga | pstolowski: pushed | 09:51 |
| zyga | pstolowski: thanks! | 10:04 |
| pstolowski | ty | 10:04 |
| zyga | pstolowski: I have the duration follow-up | 10:08 |
| pstolowski | nie | 10:08 |
| pstolowski | *nice | 10:08 |
| zyga | pstolowski: but it would help if you could review tests as it affects it | 10:08 |
| zyga | pstolowski: tests are in https://github.com/snapcore/snapd/pull/9431 | 10:09 |
| zyga | I'll rebase/merge master as soon as possible | 10:09 |
| zyga | but you can also just look at the only patch there: https://github.com/snapcore/snapd/pull/9431/commits/da7942032d3aa770d939e90c96cda19ac0efc020 | 10:09 |
| zyga | mvo: please merge https://github.com/snapcore/snapd/pull/9430 | 10:14 |
| zyga | ok, that's something that can be used soon :) | 10:26 |
| pedronis | mborzecki: I haven't looked super closely but I did a first pass on #9427, couple of questions there | 11:41 |
| mborzecki | pedronis: thanks | 11:41 |
| zyga | cachio: are we testing snapdragon with ubuntu core? | 11:56 |
| cachio | zyga, hi, yes | 11:58 |
| zyga | cachio: could you update the state of bug https://bugs.launchpad.net/snapd/+bug/1846397 | 11:58 |
| cachio | the dragonboard right? | 11:58 |
| zyga | correct | 11:58 |
| cachio | zyga, this was an issue that is already fixed | 11:59 |
| zyga | can you comment on the bug please | 11:59 |
| zyga | close it if necessary please | 11:59 |
| cachio | sure | 12:00 |
| zyga | cachio: how about pi4? https://bugs.launchpad.net/snapd/+bug/1888691 | 12:01 |
| cachio | zyga, checking | 12:02 |
| cachio | mvo, do you know the status of this? https://bugs.launchpad.net/snapd/+bug/1888691 | 12:04 |
| cachio | is it related to the chagnes you were doing related to the DTB? | 12:04 |
| mvo | cachio: yes, I think that's the issue | 12:13 |
| cachio | mvo, is that fixed right? | 12:14 |
| mvo | cachio: not yet, we have some code but nothing has landed yet | 12:15 |
| cachio | mvo, ah, ok, thanks | 12:15 |
| zyga | ondra: could you please look at the question on https://bugs.launchpad.net/snapd/+bug/1846397 | 12:29 |
| zyga | ijohnson: is stopping sockets when we stop services still something that we plan to do? | 12:46 |
| zyga | ijohnson: the context is this bug: https://bugs.launchpad.net/snapd/+bug/1842259 | 12:46 |
| zyga | cmatsuoka: can you look at and evaluate https://bugs.launchpad.net/snapd/+bug/1897573 please | 12:53 |
| cmatsuoka | sure, just a sec | 12:53 |
| ijohnson | zyga: hey, regarding that bug it is still planned I just didn't get around to doing it yet unfortunately | 14:05 |
| ijohnson | degville: hey can we update https://ubuntu.com/download/kvm to mention something about uc20 not working with that guide ? | 14:05 |
| zyga | re, ack ijohnson | 14:06 |
| * zyga needs to break for the chaos at home :) | 14:06 | |
| zyga | back shortly | 14:06 |
| zyga | (I hope) | 14:06 |
| degville | ijohnson: I'll get it updated, thanks! | 14:06 |
| ijohnson | thanks degville | 14:07 |
| mvo | can someone please review 9432 ? should be very simple | 14:37 |
| zyga | just did | 14:42 |
| zyga | I could use a review for https://github.com/snapcore/snapd/pull/9431 to complete that part | 14:42 |
| * cachio afk lunch | 14:47 | |
| === diddledan5 is now known as diddledan | ||
| mvo | cachio: snapd/core 2.47 should be in beta in ~30min | 15:35 |
| mvo | cachio: once validation looks good this can go to candidate | 15:37 |
| cachio | mvo, nice, thanks | 16:11 |
| zyga | cachio is debian sid broken? I'm getting syntax error in sudoers file | 17:29 |
| cachio | I pushed a fix for that | 17:29 |
| cachio | zyga, waiting for tests to merge it | 17:30 |
| cachio | #9436 | 17:30 |
| zyga | cachio ack | 17:31 |
| mvo | cachio: hm, looks like LP is in an unhappy place right now, I have no builds in the ppa or for the snpad snap yet :/ | 17:57 |
| cachio | mvo, ok, np, I'll wait until it is ready | 18:01 |
| mvo | cachio: I keep an eye on it, but at least the snapd snap should automatically appear in the beta channel | 18:02 |
| cjwatson | mvo: Not so much unhappy as under maintenance | 18:08 |
| mvo | cjwatson: aha, thank you! | 18:08 |
| mvo | cjwatson: anything I can/should follow to see timelines etc? | 18:08 |
| cjwatson | mvo: ~launchpad on MM | 18:09 |
| cjwatson | But it should be back up shortly anyway | 18:09 |
| cjwatson | Took a bit longer than expected to move ftpmaster to a new host | 18:10 |
| mvo | cjwatson: nice, thank you. I will join that then :) | 18:10 |
| zyga | cachio I restated that PR | 18:32 |
| zyga | hopefully it can land shortly | 18:32 |
| cachio | zyga, thanks | 18:34 |
| * cachio afk | 20:49 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!