mupPR snapcraft#3258 closed: schema/snapcraft.json: allow type: os with build-base <enhancement> <Created by anonymouse64> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3258>00:42
=== JanC_ is now known as JanC
zygagood morning06:05
* zyga comes in too early 06:05
zygamborzecki: good morning06:13
zygamvo: good morning06:17
zygamvo: I'll start with feedback I got so far06:17
mupPR snapd#9383 closed: snap-repair: add uc20 support <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9383>06:22
zygamvo: could you re-review https://github.com/snapcore/snapd/pull/941006:24
mupPR #9410: desktop/notification: add bindings for FDO notifications <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9410>06:24
mvozyga: good morning, sure06:33
* mvo hugs zyga06:34
zygathanks :)06:35
zyga2/3 kids are off to school06:35
zygaone is still a bit too small ;-)06:35
zygawoot, thanks06:35
zygaI'll add a few tests so that there are _some_ at least06:36
mupPR snapd#9426 opened: debian: update changelog <Run nested> <⛔ Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9426>06:37
zygamvo: I'll send follow-ups with tests soon06:51
zygatests are all just boring in that package06:51
zygapstolowski: hey07:02
zygapstolowski: I need a 2nd review for https://github.com/snapcore/snapd/pull/941007:02
mupPR #9410: desktop/notification: add bindings for FDO notifications <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9410>07:02
mvogood morning pstolowski07:03
pstolowskizyga: i'll take a look07:21
pstolowskizyga: amazing, when fixing current typo in the PR you reviewed I made another typo /o\. Thankfully tests in the followup branch revealed that08:05
zygapstolowski: :DDD08:05
zygapstolowski: what was the typo?08:05
pstolowskicuurrent -> curent08:05
zygaI noticed that typo thanks to VScode spellchecker08:05
zygaok, I have most of the unit tests now08:23
zygaonly signal delivery needs tests but that's a little bit more complicated08:23
zygapstolowski: I can add existing unit tests to https://github.com/snapcore/snapd/pull/941008:24
mupPR #9410: desktop/notification: add bindings for FDO notifications <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9410>08:24
zygapstolowski: or push them separately08:24
zygapstolowski: what would you prefer?08:24
pstolowskizyga: i'm fine if it's a separate PR08:25
pstolowskizyga: up to you, i haven't started reviewing yet, about to do that08:26
zygaok, review this08:26
zygait's already pretty long08:26
zygathough really really simple08:27
mupPR snapd#9428 opened: tests/lib: move to new directory when restoring PWD, cleanup unpacked unpacked snap directories <Run nested> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9428>08:38
mupPR snapd#9429 opened: [RFC] o/daemon: validation sets api and basic spread test <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9429>08:38
mborzeckihmmm, broke something in 942808:46
mborzeckiglad we have the spread tests to catch that08:46
mvomborzecki: heh, maybe that's an indication that "simple" should be removed then ;)09:03
mborzeckimvo: uh, not that PR #9427 :009:04
mvomborzecki: haha - sorry09:05
mvomborzecki: btw, I see that snap run --strace is hanging again more frequently, I wonder if some new kernel syscall is used we also need to exclude. did you notice anything here too (maybe it's just a fluke)09:05
zygapstolowski: I've added unit tests now at https://github.com/snapcore/snapd/pull/943109:06
mupPR #9431: desktop/notification: add unit tests <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9431>09:06
mupPR snapd#9431 opened: desktop/notification: add unit tests <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9431>09:08
mborzeckimvo: no, i didn't but i can check if i can reproduce that on arch09:09
pstolowskizyga: ack09:09
mborzeckican't quite reproduce that locally09:15
zygapstolowski: should I link to the spec in each of those places09:47
zygaor is linking to it once in the package doc enough?09:47
pstolowskizyga: might be a good idea to link it in all places imho09:48
zygapstolowski: pushed09:51
zygapstolowski: thanks!10:04
zygapstolowski: I have the duration follow-up10:08
zygapstolowski: but it would help if you could review tests as it affects it10:08
zygapstolowski: tests are in https://github.com/snapcore/snapd/pull/943110:09
zygaI'll rebase/merge master as soon as possible10:09
zygabut you can also just look at the only patch there: https://github.com/snapcore/snapd/pull/9431/commits/da7942032d3aa770d939e90c96cda19ac0efc02010:09
zygamvo: please merge https://github.com/snapcore/snapd/pull/943010:14
zygaok, that's something that can be used soon :)10:26
pedronismborzecki: I haven't looked super closely but I did a first pass on #9427, couple of questions there11:41
mborzeckipedronis: thanks11:41
zygacachio: are we testing snapdragon with ubuntu core?11:56
cachiozyga, hi, yes11:58
zygacachio: could you update the state of bug https://bugs.launchpad.net/snapd/+bug/184639711:58
cachiothe dragonboard right?11:58
cachiozyga, this was an issue that is already fixed11:59
zygacan you comment on the bug please11:59
zygaclose it if necessary please11:59
zygacachio: how about pi4? https://bugs.launchpad.net/snapd/+bug/188869112:01
cachiozyga, checking12:02
cachiomvo, do you know the status of this? https://bugs.launchpad.net/snapd/+bug/188869112:04
cachiois it related to the chagnes you were doing related to the DTB?12:04
mvocachio: yes, I think that's the issue12:13
cachiomvo, is that fixed right?12:14
mvocachio: not yet, we have some code but nothing has landed yet12:15
cachiomvo, ah, ok, thanks12:15
zygaondra: could you please look at the question on https://bugs.launchpad.net/snapd/+bug/184639712:29
zygaijohnson: is stopping sockets when we stop services still something that we plan to do?12:46
zygaijohnson: the context is this bug: https://bugs.launchpad.net/snapd/+bug/184225912:46
zygacmatsuoka: can you look at and evaluate https://bugs.launchpad.net/snapd/+bug/1897573 please12:53
cmatsuokasure, just a sec12:53
ijohnsonzyga: hey, regarding that bug it is still planned I just didn't get around to doing it yet unfortunately14:05
ijohnsondegville: hey can we update https://ubuntu.com/download/kvm to mention something about uc20 not working with that guide ?14:05
zygare, ack ijohnson14:06
* zyga needs to break for the chaos at home :)14:06
zygaback shortly14:06
zyga(I hope)14:06
degvilleijohnson: I'll get it updated, thanks!14:06
ijohnsonthanks degville14:07
mvocan someone please review 9432 ? should be very simple14:37
zygajust did14:42
zygaI could use a review for https://github.com/snapcore/snapd/pull/9431 to complete that part14:42
* cachio afk lunch14:47
=== diddledan5 is now known as diddledan
mvocachio: snapd/core 2.47 should be in beta in ~30min15:35
mvocachio: once validation looks good this can go to candidate15:37
cachiomvo, nice, thanks16:11
zyga  cachio is debian sid broken? I'm getting syntax error in sudoers file17:29
cachioI pushed a fix for that17:29
cachiozyga, waiting for tests to merge it17:30
zygacachio ack17:31
mvocachio: hm, looks like LP is in an unhappy place right now, I have no builds in the ppa or for the snpad snap yet :/17:57
cachiomvo, ok, np, I'll wait until it is ready18:01
mvocachio: I keep an eye on it, but at least the snapd snap should automatically appear in the beta channel18:02
cjwatsonmvo: Not so much unhappy as under maintenance18:08
mvocjwatson: aha, thank you!18:08
mvocjwatson: anything I can/should follow to see timelines etc?18:08
cjwatsonmvo: ~launchpad on MM18:09
cjwatsonBut it should be back up shortly anyway18:09
cjwatsonTook a bit longer than expected to move ftpmaster to a new host18:10
mvocjwatson: nice, thank you. I will join that then :)18:10
zygacachio I restated that PR18:32
zygahopefully it can land shortly18:32
cachiozyga, thanks18:34
* cachio afk20:49

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!