| === _thumper_ is now known as thumper | ||
| stickupkid | manadart, https://github.com/juju/juju/pull/12093 | 08:04 |
|---|---|---|
| stickupkid | achilleasa, something wrong with your check | 09:31 |
| stickupkid | [m[31mexpected opened-ports output to be: -e 1234/tcp 1337-1339/tcp GOT: 1234/tcp 1337-1339/tcp[m | 09:31 |
| stickupkid | achilleasa, strange because it's the right value as well | 09:32 |
| stickupkid | haha | 09:32 |
| achilleasa | hmmmm... it passes for me. | 09:32 |
| achilleasa | yeah, I had to 'echo -e' it for the line-feeds to work | 09:32 |
| achilleasa | are you using dash? | 09:32 |
| stickupkid | zsh | 09:32 |
| achilleasa | try it with dash | 09:33 |
| stickupkid | ha, no | 09:33 |
| achilleasa | it would be much easier if we simply used bash :D | 09:33 |
| stickupkid | because they're meant to be transportable | 09:33 |
| achilleasa | why though? | 09:33 |
| achilleasa | it's not like someone else will be running them anyway ;-) | 09:33 |
| stickupkid | burn | 09:33 |
| stickupkid | but it should work in bash, dash, zsh, etc | 09:34 |
| achilleasa | hmmm... I am not sure why that comparison fails for you though :-( | 09:34 |
| achilleasa | can you add a 'hexdump -C' for both values? | 09:34 |
| achilleasa | they should be identical | 09:34 |
| achilleasa | if comparisons with line-feeds do not work, we will have to md5sum them which sucks | 09:35 |
| stickupkid | just running another test, will check after that | 09:35 |
| stickupkid | echo "${got}" | tr '\n' ' ' | 09:37 |
| stickupkid | rip out the new line | 09:37 |
| achilleasa | yeah, you can tr -d '\n' but that's ugly... | 09:38 |
| stickupkid | everything is ugly | 09:39 |
| stickupkid | haha | 09:39 |
| achilleasa | ok, let me try that to see if it works :D | 09:39 |
| stickupkid | i'm trying it atm | 09:39 |
| stickupkid | achilleasa, well that didn't work | 10:05 |
| stickupkid | achilleasa, expected opened-ports output to be: -e 1234/tcp1337-1339/tcp GOT: 1234/tcp1337-1339/tcp | 10:06 |
| stickupkid | sigh | 10:06 |
| achilleasa | I think I know why... waiting for my test to finish | 10:06 |
| achilleasa | we should really quote the exp/got parts | 10:06 |
| stickupkid | ah | 10:06 |
| achilleasa | there is a trailing space due to the \n from juju run | 10:07 |
| stickupkid | son of a | 10:07 |
| achilleasa | stickupkid: pushed a change + your patch (extra commit). It should work for you now (fingers crossed!) | 10:12 |
| stickupkid | achilleasa, works | 10:21 |
| stickupkid | lovely | 10:21 |
| manadart | stickupkid, achilleasa: Either of you able to review https://github.com/juju/juju/pull/12067 ? | 11:24 |
| achilleasa | manadart: I can look in about 15min | 11:25 |
| stickupkid | manadart, updated the PR for wait-for | 14:34 |
| manadart | stickupkid: Ack. | 14:34 |
| manadart | stickupkid: https://github.com/juju/juju/pull/12074 is awesome. Check my comment. | 15:00 |
| stickupkid | manadart, I saw, I do wonder about GT, LT, LTE or GTE on strings, but then you're daft if you use it on string | 15:10 |
| stickupkid | hml, so it begins :) https://github.com/juju/description/pull/88 | 16:03 |
| hml | stickupkid: w00t | 16:03 |
| hml | stickupkid: what’s juju:v2 ? | 16:04 |
| hml | stickupkid: nm | 16:05 |
| stickupkid | hml, shouldn't that be `description:v2`?? | 16:05 |
| hml | stickupkid: brain fart, i thought it was going into juju/juju not description. ;-) | 16:05 |
| stickupkid | hml, yeah but still, i think that's wrong | 16:06 |
| hml | juju is using v2 for description right now | 16:06 |
| hml | stickupkid: quick one: https://github.com/juju/juju/pull/12095 | 16:14 |
| hml | stickupkid: approved 88 | 16:15 |
| stickupkid | hml, approved yours... this is what I wanted ages ago | 16:16 |
| stickupkid | get rid of the hack | 16:16 |
| stickupkid | WIN | 16:16 |
| hml | yes! the data was finally available… | 16:16 |
| === jose- is now known as jose | ||
| JackStorm | So with the later versions juju-gui is baked in, and "juju gui" confirms the new dashboard is avalible on my controller after bootstraping...but how do you expose the dashboard now? (I could do it OOB, but would rather not start one offing things) since it's not an app that expose understands | 19:08 |
| bradm | I'm seeing some weird error messages from juju after I've bootstrapped when I'm trying to add new machines to the environment: | 21:56 |
| bradm | 2020-10-06 06:13:13 ERROR juju.core.raftlease store.go:265 timeout waiting for Command(ver: 1, op: claim, ns: singular-controller, model: 347130, lease: fbab0193-797f-42f0-8146-7d3eb70d642c, holder: machine-0) to be processed | 21:56 |
| bradm | 2020-10-06 17:08:06 WARNING juju.worker.httpserver log.go:181 http: TLS handshake error from x.y.z.18:59472: EOF | 21:57 |
| bradm | the TLS handshake error appears every time a machine tries to download the agent binaries | 21:57 |
| bradm | just filed https://bugs.launchpad.net/juju/+bug/1898802 about it, if anyone has any ideas I'd appreciate it. | 23:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!