| zyga | o/ | 05:34 |
|---|---|---|
| mborzecki | morning | 05:36 |
| zyga | mborzecki: hey | 05:40 |
| mborzecki | zyga: heya | 05:40 |
| mborzecki | crappy weather today (this week) | 05:41 |
| zyga | oh yeah | 05:42 |
| zyga | I wanted to mention that just now | 05:42 |
| zyga | Janek is just leaving for school | 05:42 |
| zyga | I had one fun experience this weekend, | 05:42 |
| zyga | I was playing QFG:1 and drawing a map in a paper notebook | 05:43 |
| zyga | and then realized that some of the screen transitions are jumps in the grid pattern as the map does not line up and rooms would overlap | 05:43 |
| zyga | I was playing this game when I was in primary school and it just hit me now that this happens, I never drew a map before | 05:43 |
| zyga | I was also playing with my benchmark code and ported it to windows now | 05:44 |
| zyga | how was your weekend? | 05:44 |
| mborzecki | zyga: boring, aching back, did some gardening, then helper my father cut & move some wood since they preemptively fell some birch trees | 05:46 |
| zyga | mborzecki: preemptively? | 05:46 |
| zyga | mborzecki: I had one fun gardening surprise | 05:46 |
| zyga | well, maybe two | 05:46 |
| zyga | some dates we planted as an experiment are growing | 05:46 |
| mborzecki | zyga: yeah, birch trees have a tendency to rot from inside and then fall down during strong winds | 05:46 |
| zyga | and the tomatoes we planted this pring and now removed (we just cut the part above the ground) are growing back, I didn't knew they could do this | 05:47 |
| zyga | ah, I didn't know that | 05:47 |
| mborzecki | hmm https://forum.snapcraft.io/t/why-snap-set-system-does-need-sudo/20484 looks like an ommision on our side | 05:47 |
| zyga | omission? | 05:47 |
| zyga | ah | 05:48 |
| zyga | I understand | 05:48 |
| zyga | yeah | 05:48 |
| zyga | we should also support polkit or being signed in | 05:48 |
| zyga | replied on the threa | 05:49 |
| zyga | *thread | 05:49 |
| mborzecki | heh https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1643706 also getting some heat over the weekend | 05:49 |
| zyga | I read that | 05:49 |
| mborzecki | zyga: wasn't there an idea to have the list of accessible locations extensible at some point? | 05:50 |
| zyga | I wonder what do they mean that it works better in flatpak | 05:50 |
| zyga | IIRC it doesn't work at all unless your app is fully portal aware or you disable the sandbox | 05:50 |
| mborzecki | zyga: well, you can mount arbitrary locations iirc | 05:50 |
| zyga | mborzecki: in flatpak you mean? | 05:50 |
| mborzecki | yeah, let me check that | 05:50 |
| zyga | mborzecki: we could have a hack that reads a global config file | 05:50 |
| zyga | and mounts any directories there to /run/mnt or something | 05:51 |
| mborzecki | sounds a bit hackish | 05:51 |
| zyga | with open permissions | 05:51 |
| zyga | with open permissions | 05:51 |
| zyga | er | 05:51 |
| zyga | do you have an idea to make it better? | 05:51 |
| zyga | I need to take Bit out | 05:53 |
| mborzecki | zyga: i have a vague recollection of some hallway talk to maybe allow adding custom directories to one of the interfaces (media was it?) | 05:53 |
| zyga | Lucy is still sleeping | 05:53 |
| zyga | mborzecki: how would you define extra directories? | 05:53 |
| mborzecki | zyga: as in actual mechanics of that? | 05:54 |
| zyga | yes | 05:54 |
| zyga | what would the user have to do | 05:54 |
| mborzecki | idk, we don't have anything else than snap set or connect | 05:55 |
| mborzecki | zyga: and we can't add attributes to slots & plugs dynamically from the cli | 05:56 |
| mborzecki | mvo: hey | 05:57 |
| zyga | re | 06:04 |
| zyga | mvo: hello | 06:04 |
| zyga | mborzecki: well, I think doing that technically is not hard | 06:04 |
| zyga | but we have a busy schedule | 06:04 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/9485 is a low hanging fruit that needs a 2nd review | 06:06 |
| mborzecki | mup: ping | 06:06 |
| mborzecki | brb, need to drive my daughter to school | 06:14 |
| zyga | ok | 06:19 |
| mvo | hey mborzecki and zyga ! good morning | 06:27 |
| mvo | zyga: looking | 06:27 |
| mborzecki | re | 06:41 |
| jamesh | zyga: I think the error reporting is busted on #9485 | 06:55 |
| zyga | jamesh: looking | 06:55 |
| zyga | oh?! | 06:55 |
| mvo | jamesh: tell us more please | 06:55 |
| zyga | oh, of course | 06:55 |
| zyga | thank you, I'll fix this in a moment | 06:56 |
| jamesh | mvo: it's reusing loop iteration variables after the loops | 06:56 |
| mvo | jamesh: oh, nice catch | 06:56 |
| jamesh | basically all failures get assigned to last suite/section | 06:56 |
| zyga | I noticed some failures when I broke the tree but I didn't look too hard | 06:56 |
| zyga | jamesh: https://github.com/snapcore/snapd/pull/9491 | 07:05 |
| zyga | mvo: bump to 14 days: https://github.com/snapcore/snapd/pull/9492 | 07:06 |
| mvo | zyga: what's missing for the notification refresh work to land? anything I can/should review? | 07:09 |
| zyga | mvo: tests | 07:09 |
| zyga | mvo: I need to write some tests before that can land | 07:09 |
| zyga | mvo: also, probably, mock that away in tests of the package | 07:10 |
| zyga | mvo: I was thinking if I should keep the warning | 07:10 |
| mvo | zyga: why would we keep the warning? | 07:10 |
| mvo | zyga: honest question :) | 07:11 |
| zyga | mvo: it's easier to test, it's also something that works in headless systems | 07:11 |
| zyga | but I think those are weak reasons | 07:11 |
| * zyga needs a coffee, made three for his wife today but none for himself | 07:12 | |
| zyga | brb | 07:12 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/9490#pullrequestreview-506349703 | 07:17 |
| mvo | zyga: aha, good point | 07:22 |
| zyga | mvo: we can land yours and I can follow up | 07:22 |
| zyga | or you can make changes inline | 07:22 |
| zyga | up to you | 07:22 |
| mvo | zyga: it's fine, I will just do it, have it almost ready I think | 07:24 |
| zyga | ok | 07:24 |
| mvo | zyga: except that my approach (just passing the executor) | 07:25 |
| mvo | zyga: does not work :/ | 07:25 |
| mvo | zyga: so if you have something that works, feel free to push to the PR | 07:26 |
| zyga | ok | 07:26 |
| zyga | mvo: we can close your branch then | 07:32 |
| mvo | zyga: sure, just do that then | 07:33 |
| mvo | zyga: once the other one is up | 07:33 |
| * mvo needs to run out for a few min | 07:34 | |
| zyga | ok | 07:34 |
| zyga | done | 07:37 |
| zyga | mborzecki: perhaps you can look at https://github.com/snapcore/snapd/pull/9493 | 07:37 |
| zyga | hmm, with increased concurrency, my slow system is hitting the 10 second itmeout | 07:44 |
| zyga | *timeout | 07:44 |
| zyga | mborzecki: was this done because shellcheck hangs on some input? | 07:44 |
| mborzecki | zyga: not that i know of, it was there to have an upper bound on shellcheck execution | 07:48 |
| mborzecki | also, shellcheck isn't super fast apaprently | 07:48 |
| zyga | hmm | 07:49 |
| mborzecki | ijohnson is on vacation this week? | 07:49 |
| zyga | but what is the bound for? | 07:49 |
| zyga | mborzecki: correct | 07:49 |
| mborzecki | zyga: what do you mean? | 07:51 |
| zyga | re | 07:59 |
| zyga | hmm, cannot connect from hexchat again | 07:59 |
| * zyga greatly enjoys https://aubreyhodges.bandcamp.com/album/quest-for-glory-shadows-of-darkness-official-soundtrack | 08:00 | |
| zyga | should buy the album for the sheer love that went into making something so niche | 08:00 |
| zyga | mvo you said you wanted to have the 1:1? | 08:05 |
| zyga-x240 | re | 08:05 |
| zyga-x240 | restarting hexchat helped | 08:05 |
| mborzecki | zyga: wdyt about https://github.com/snapcore/snapd/pull/9493#discussion_r503110724 ? | 08:07 |
| zyga | mborzecki nice idea | 08:08 |
| zyga | more responsiveness | 08:08 |
| zyga | I'd like to have this in a follow up, so that a correct version is merged first | 08:08 |
| mvo | zyga sorry, was not paying attention earlier | 08:12 |
| mvo | zyga: 9491 has a strange error in the unit tests | 09:02 |
| zyga | looking | 09:02 |
| zyga | yeah this is explained in | 09:02 |
| zyga | https://github.com/snapcore/snapd/pull/9493/commits/afc1008ad9943c0f25cb096c24febfe1c400741f | 09:03 |
| mvo | zyga: nice | 09:06 |
| zyga | mvo we could close 9491 and just merge https://github.com/snapcore/snapd/pull/9493 | 09:09 |
| * zyga missed one test | 09:15 | |
| mvo | zyga ok | 09:26 |
| zyga | something is broken in tumbleweed, should look at that as well | 09:26 |
| zyga | but first iteration on existing PRs | 09:26 |
| zyga-x240 | I reviewed Ian's maintenance branch https://github.com/snapcore/snapd/pull/9489#pullrequestreview-506453347 | 09:41 |
| mvo | mup: hello? | 09:48 |
| mvo | niemeyer: could you please restart mup? it seems to be unhappy | 09:48 |
| niemeyer | mup: Let me look into it | 09:48 |
| zyga-x240 | mvo: quick pass over the FDE hook https://github.com/snapcore/snapd/pull/9488#pullrequestreview-506460961 | 09:51 |
| mvo | zyga: nice, thnak you | 09:53 |
| mvo | zyga: excellent points, especially about the environment passing. I'm also checking now how to teach systemd-run to have a execution-max-time | 09:54 |
| zyga | mvo I looked at that and I'm sure there was something | 09:54 |
| zyga | but there's a difference between services and other things, | 09:55 |
| zyga | I cannot find it, it's probably a property on one of the unit types | 09:55 |
| zyga | it could be that I misread something before and there's no execution time limit | 09:55 |
| zyga | but we can always close the unit | 09:55 |
| zyga | but that might also require us to use DBus directyl | 09:55 |
| zyga | *directly | 09:55 |
| mup | PR #9431: desktop/notification: add unit tests <Skip spread> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9431> | 09:56 |
| mup | Bug #1846397: snapdragon uc18 image fails to boot (current stable) <snapd:Incomplete by ondrak> <https://launchpad.net/bugs/1846397> | 09:56 |
| mup | Bug #1888691: [uc20] rpi4 does not boot with armhf on recent 5.4 kernel snaps <uc20> <snapd:Triaged> <linux-raspi (Ubuntu):Invalid> <linux-raspi (Ubuntu Focal):Invalid> <https://launchpad.net/bugs/1888691> | 09:56 |
| zyga | brb, small tweak | 09:56 |
| mup | PR #9430: dbustest: fix stale comment references <Simple 😃> <Skip spread> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9430> | 09:56 |
| mup | Bug #1842259: snap stop --disable svc with socket doesn't disable the socket <snapd:Confirmed for anonymouse67> <https://launchpad.net/bugs/1842259> | 09:56 |
| mup | Bug #1897573: ubuntu core 20 with secure boot, install fails <snapd:Triaged by cmatsuoka> <https://launchpad.net/bugs/1897573> | 09:56 |
| mup | PR #9427: boot, gadget, bootloader: observer preserves managed bootloader configs <Run nested> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9427> | 09:56 |
| mup | PR #9436: tests: fix sudo-env test <Simple 😃> <Created by sergiocazzolato> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9436> | 09:56 |
| zyga | oh | 09:56 |
| zyga | welcome back mup :) | 09:56 |
| mup | PR #9424: cmd/snap: allow snap help vs --all to diverge purposefully <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9424> | 09:56 |
| mup | mborzecki: Plugin "ldap" is not enabled here. | 09:56 |
| mup | PR #9417: o/snapshotstate: set snapshot set id from its filename <Needs Samuele review> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9417> | 09:56 |
| mup | Bug #1897984: snapd not wiring alias for 'dotnet' that is in snap assertion <snapd:Invalid> <https://launchpad.net/bugs/1897984> | 09:56 |
| mup | Bug #1898038: docker-support/multipass-support broken with system apparmor3 (20.10) <docker:New> <snapd:Triaged by alexmurray> <snapd (Ubuntu):Triaged> <https://launchpad.net/bugs/1898038> | 09:56 |
| mup | PR #9434: o/snapshotstate: improve allocation of new set IDs <Needs Samuele review> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9434> | 09:56 |
| mup | PR #9438: desktop/notification: switch ExpireTimeout to time.Duration <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9438> | 09:56 |
| mup | PR #8573: overlord/snapstate: inhibit startup while unlinked <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8573> | 09:57 |
| mborzecki | mup is back! | 09:57 |
| mup | PR #7700: cmd/snap: wait while inhibition file is present <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/7700> | 09:57 |
| mup | PR #9442: o/snapshotstate: pass set id to backend.Open, update tests <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9442> | 09:57 |
| mup | PR #9440: gadget: preserve files when indicated by content change observer <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9440> | 09:57 |
| mup | PR #9450: many: scaffolding for snapshots import API <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9450> | 09:57 |
| mup | PR #9247: secboot: use EFIImage type in load sequences <Simple 😃> <UC20> <Created by cmatsuoka> <Closed by cmatsuoka> <https://github.com/snapcore/snapd/pull/9247> | 09:57 |
| mup | PR #9036: snapshots: import of a snapshot set <Needs Samuele review> <Skip spread> <Created by slimjim777> <https://github.com/snapcore/snapd/pull/9036> | 09:57 |
| mup | Bug #1863613: spotify fails to load (Trace/breakpoint trap (core dumped)) <snapd:Confirmed> <https://launchpad.net/bugs/1863613> | 09:57 |
| mup | Bug #1898622: uc20 grade dangerous images don't seed properly with devmode snaps in them <snapd:Triaged by anonymouse67> <https://launchpad.net/bugs/1898622> | 09:57 |
| mup | PR #9454: client: cleanup the Client.raw* and Client.do* method families <Cleanup :broom:> <Created by pedronis> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9454> | 09:57 |
| mup | PR #9443: gadget, gadget/install: support for ubuntu-save, create one during install if needed <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9443> | 09:57 |
| mup | PR #9467: daemon: limit reading from snapshot import to Content-Length <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9467> | 09:57 |
| mup | PR CanonicalLtd/ubuntu-image#186: Some options are unsupported for UC20 builds <Created by sil2100> <Merged by sil2100> <https://github.com/CanonicalLtd/ubuntu-image/pull/186> | 09:57 |
| mup | PR #9378: tests/nested/manual: add uc20 grade signed cloud-init test <Run nested> <Squash-merge> <Test Robustness> <UC20> <Created by anonymouse64> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9378> | 09:57 |
| mup | PR #9391: o/assertstate: introduce ValidationTrackingKey/ValidationSetTracking and basic methods <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9391> | 09:57 |
| mup | PR #9471: cmd/snap-bootstrap/initramfs-mounts: also copy /etc/machine-id for same IP addr <Bug> <Simple 😃> <UC20> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9471> | 09:57 |
| mup | PR #9472: cmd/snap-bootstrap/initramfs-mounts: split off new helper for misc recover files <Simple 😃> <UC20> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9472> | 09:57 |
| mup | PR #9475: tests: add tests.cleanup pop sub-command <Created by zyga> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9475> | 09:57 |
| mup | PR #9425: tests: new tests.backup tool <Run nested> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9425> | 09:57 |
| mup | PR #9478: spread: remove workaround for openSUSE go issue <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9478> | 09:57 |
| mup | PR #44: Proposal fix for Bug #1496319 <Created by clobrano> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/44> | 09:57 |
| mup | PR #9482: bootloader/assets/grub: adjust fwsetup menuentry label <Created by xnox> <https://github.com/snapcore/snapd/pull/9482> | 09:57 |
| mup | PR #9414: tests: new nested tool <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9414> | 09:57 |
| mup | PR #9474: boot, overlord/devicestate: list trusted and managed assets upfront <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9474> | 09:57 |
| mup | PR #9418: many: implement snap routine console-conf-start for synchronizing auto-refreshes <Needs Samuele review> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9418> | 09:57 |
| mup | PR #9484: spread-shellcheck: process paths from arguments in parallel <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9484> | 09:57 |
| mup | mborzecki: I apologize, but I'm pretty strict about only responding to known commands. | 09:57 |
| mup | Bug #1643706: snap apps need to be able to browse outside of user $HOME dir. for Desktop installs <amd64> <apport-bug> <package-from-proposed> <zesty> <snapd (Ubuntu):Fix Released by jdstrand> <https://launchpad.net/bugs/1643706> | 09:57 |
| mup | PR #9485: spread-shellcheck: speed up spread-shellcheck even more <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9485> | 09:57 |
| mup | PR #9491: spread-shellcheck: correctly attribute suite errors <Bug> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9491> | 09:57 |
| mup | PR #9492: overlord: increase refresh postpone limit to 14 days <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/9492> | 09:57 |
| mup | mvo: In-com-pre-hen-si-ble-ness. | 09:57 |
| mup | niemeyer: Roses are red, violets are blue, and I don't understand what you just said. | 09:57 |
| mup | PR #9490: spread-shellcheck: respect --max-procs in checkfile() <Created by mvo5> <Closed by zyga> <https://github.com/snapcore/snapd/pull/9490> | 09:57 |
| mup | PR #9493: spread-shellcheck: use single thread pool executor <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9493> | 09:57 |
| mup | PR #9488: [RFC] boot/fdehook: add skeleton fdehook support <â›” Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9488> | 09:57 |
| niemeyer | /o\ | 09:58 |
| niemeyer | I suspect this has something to do with the internal IRC server going away, for too long | 10:03 |
| niemeyer | mup: Are you okay now? | 10:12 |
| mup | niemeyer: I apologize, but I'm pretty strict about only responding to known commands. | 10:12 |
| niemeyer | mvo: It was in trouble after too many weeks of pending communication with the internal servers | 10:12 |
| niemeyer | mvo: Should be in better shape now | 10:13 |
| niemeyer | mvo: If anything weird happens please do ping me so I can have a look | 10:13 |
| mvo | niemeyer: thank you! | 10:16 |
| niemeyer | My pleasure | 10:16 |
| mup | PR snapd#9492 closed: overlord: increase refresh postpone limit to 14 days <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/9492> | 10:25 |
| zyga | mvo reviewed https://github.com/snapcore/snapd/pull/9480#pullrequestreview-506492965 | 10:26 |
| mup | PR #9480: snap: support different exit-code in the snap command [RFC] <Created by mvo5> <https://github.com/snapcore/snapd/pull/9480> | 10:26 |
| mvo | zyga: yay, you rock | 10:33 |
| pedronis | zyga: I reviewed #9474, it needs a 2nd re-review though | 11:19 |
| mup | PR #9474: boot, overlord/devicestate: list trusted and managed assets upfront <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9474> | 11:19 |
| pedronis | sorry | 11:19 |
| pedronis | wrong PR | 11:19 |
| zyga | pedronis right | 11:19 |
| pedronis | zyga: I meant #8573 | 11:19 |
| mup | PR #8573: overlord/snapstate: inhibit startup while unlinked <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8573> | 11:19 |
| zyga | thank you, looking | 11:19 |
| zyga | cool, I'll rename those in a moment | 11:20 |
| zyga | pedronis I noticed you noticed that I was thinking about moving the run inhibition to soft check later, on this is something we could think about, but it would have the property that we really download the update and apply it by refusing to start the app during this process | 11:20 |
| zyga | so the app is linked still, but you cannot run it now, because that would "ruin" the update | 11:21 |
| zyga | it's not something I want immediately but I think the experience would be better | 11:21 |
| pedronis | zyga: the problem is how to make sure we unlock, right now that is tied to the handlers | 11:21 |
| pedronis | so we always have / try to have undo paths | 11:21 |
| zyga | we should unlock if the task is undone or when we complete a later task (link snap) | 11:22 |
| pedronis | if we lock in non-handler code it gets more complicated | 11:22 |
| zyga | I agree it is delicate and has to be done right | 11:22 |
| zyga | indeed | 11:22 |
| zyga | this would have that property | 11:22 |
| zyga | we might actually lock in one of the other tasks | 11:22 |
| zyga | so soft check could stay soft | 11:22 |
| zyga | and then do a "binding check" | 11:22 |
| zyga | that is started at the same time we download | 11:23 |
| zyga | then we only lock in handlers | 11:23 |
| zyga | and have the same overall user experience | 11:23 |
| zyga | soft check tells you no quickly (as now) | 11:23 |
| zyga | hard check prevents data loss | 11:23 |
| zyga | and this would be "usability check" in a way ;-) | 11:23 |
| pedronis | the dates in the SU doc were a bit off | 11:25 |
| pedronis | fixed (hopefully) | 11:25 |
| zyga-x240 | pedronis: reviewing https://github.com/snapcore/snapd/pull/9422 would be great, this would unblock the export manager | 11:28 |
| mup | PR #9422: overlord: add link participant for linkage transitions <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/9422> | 11:28 |
| zyga-x240 | or some guidance if that is on the right path | 11:29 |
| pedronis | hopefully tomorrow | 11:31 |
| zyga-x240 | great | 11:35 |
| zyga-x240 | I'll iterate on some sprint bits and on the other branches in the meantime | 11:36 |
| zyga-x240 | pedronis: applied both renames, | 11:44 |
| * zyga-x240 grabs some hot soup | 11:44 | |
| zyga | jdstrand, amurray: do we need to add close_range to seccomp templates, I can send a patch if you say so | 11:47 |
| mborzecki | zyga: hmm, https://paste.ubuntu.com/p/CnVGSKzn3C/ too much load on the system? | 12:21 |
| zyga | mborzecki re | 12:44 |
| zyga | sorry, I was in a call | 12:44 |
| zyga | looking | 12:44 |
| zyga | hmmm | 12:44 |
| zyga | maybe we should log with -v | 12:44 |
| zyga | and see if there's something fishy going on | 12:45 |
| zyga | but yeah | 12:45 |
| zyga | it's a new thing, we can revert it if's smelly | 12:45 |
| zyga | or | 12:45 |
| zyga | we could use a thread pool executor with one worker | 12:45 |
| zyga | I think that would be an easy way to sort out the immediate problem (I hope, could be wrong if it's some deadlock) | 12:45 |
| * zyga goes to check on family and make coffee for the 2nd part of the day | 13:30 | |
| mborzecki | mvo: do you have an idea where it's picking up the @users.noreply.github.com from https://github.com/snapcore/snapd/pull/9482/checks?check_run_id=1242371209 ? | 13:53 |
| mup | PR #9482: bootloader/assets/grub: adjust fwsetup menuentry label <Created by xnox> <https://github.com/snapcore/snapd/pull/9482> | 13:53 |
| mvo | mborzecki: in a meeting but I think we can just recommit this with --author="Dimitri..." | 14:20 |
| mvo | mborzecki: and then force push | 14:20 |
| mborzecki | mvo: that's what i did | 14:20 |
| mvo | mborzecki: \o/ | 14:20 |
| mborzecki | and it still fails :P | 14:21 |
| mvo | mborzecki: oh no :( | 14:38 |
| mvo | sil2100: hey, do you think you have time today to allow snapd 2.47.1 to *-proposed? | 14:50 |
| mvo | sil2100: it's in the SRU queue (hope I got it right that monday is your sru day) | 14:51 |
| jdstrand | zyga: I'm going to defer to amurray. we have a syscall detector and a) there might be other things and b) amurray may already have the answer for this | 14:51 |
| zyga | jdstrand ack | 14:52 |
| sil2100 | mvo: sure! I can take a look o/ | 14:53 |
| * mvo hugs sil2100 | 14:55 | |
| zyga | mborzecki maybe new privacy thing? | 14:55 |
| mvo | zyga: what are close-range seccomp filters? | 14:55 |
| mborzecki | zyga: idk why it's finding 3 email addresses instead of only 2 like i see locally | 14:57 |
| zyga | mvo: not seccomp filters, just a new system call to close a range of file descriptors quickly | 14:57 |
| zyga | mborzecki from one or more than one user? | 14:57 |
| mvo | zyga: oh, neat | 14:57 |
| zyga | mborzecki maybe some privacy thing is at play? | 14:58 |
| mborzecki | uhh errands | 15:09 |
| mborzecki | ah, or not yet | 15:09 |
| mup | PR snapd#9486 closed: logger: fix snapd.debug=1 parsing <Bug> <Simple 😃> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9486> | 15:27 |
| mup | PR snapd#9494 opened: logger: use strutil.KernelCommandLineSplit in debugEnabledOnKernelCmdline <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9494> | 15:27 |
| pedronis | &away off | 17:36 |
| zyga-x240 | mvo: HMM | 18:51 |
| zyga-x240 | er | 18:52 |
| zyga-x240 | hmm | 18:52 |
| zyga-x240 | something weird | 18:52 |
| mvo | zyga-x240: hm? | 18:57 |
| zyga-x240 | werid, we merged the 14 day refresh window | 18:57 |
| zyga-x240 | but I pulled master and my test, that measures old 7 passes | 18:58 |
| zyga-x240 | maybe some fast-forward thing | 18:58 |
| * zyga-x240 looks | 18:58 | |
| * zyga-x240 wrote all the tests for the new desktop notifications | 18:58 | |
| zyga-x240 | just looking anything is missing | 18:58 |
| zyga-x240 | pushed to https://github.com/snapcore/snapd/pull/9446 | 18:59 |
| mup | PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446> | 18:59 |
| zyga-x240 | mvo: I'll work on a spread test tomorrow | 19:01 |
| zyga-x240 | I think the new git defaults ff only | 19:01 |
| zyga-x240 | and I need to merge now | 19:01 |
| zyga-x240 | oh well | 19:01 |
| * zyga-x240 resolves conflict | 19:02 | |
| mvo | zyga-x240: ok | 19:02 |
| zyga-x240 | mvo: https://github.com/snapcore/snapd/pull/9446 is ready for review | 19:06 |
| mup | PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446> | 19:06 |
| mvo | zyga-x240: re 9446> supernice! I will have a look in my morning, too tired now | 19:21 |
| amurray | zyga-mbp: yeah close_range is on my list of stuff to look at (we ideally also would want a newer libseccomp as well so we get openat2 and a few others as well - https://pastebin.ubuntu.com/p/zJRczX4BFk/) | 22:38 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!