[08:09] <Chipaca> morning all!
[08:21] <bthomas> morning
[09:57] <Chipaca> bthomas: I pushed a bunch of changes to #417, mostly focused on fixing the rst but also some other misc
[09:57] <mup> PR #417: Added a few doc strings to charm module <Created by balbirthomas> <https://github.com/canonical/operator/pull/417>
[09:57] <Chipaca> shout if you don't like any of it :)
[09:57] <bthomas> Chipaca: Will have a look. Thank you. Trust your judgement :)
[09:57] <Chipaca> *I* don't, but thanks
[09:58] <Chipaca> bthomas: I suggest you install docs/requirements.txt and run ./build_docs, and look at docs/_build/html/index.html in your browser
[09:58] <bthomas> ok
[09:58] <Chipaca> that's what i did, lacking aforementioned trust in my own judgement 🙂
[09:58] <bthomas> he he
[09:59] <Chipaca> sphinx seems a lot happier now
[10:16] <Chipaca> workers are sawing up the road outside my window
[10:16] <Chipaca> and it's almost lunchtime
[10:16] <Chipaca> so, runch
[10:16]  * Chipaca ⇝ runch
[10:39] <facubatista> ¡Muy buenos días a todos!
[10:40] <bthomas> नमस्ते facubatista
[10:40] <bthomas> Chipaca: read through the built docs. The formatting looks clean. Thank you. There are things about the content I can still work on though, and will do so as my understanding grows and have some time. For instance in ops.Charm.CharmBase and and a few other classes repeat the information/example of EventSource/EventBase multiple times. It may be more illuminating to provide more contextual examples. But I guess this is a job for me, for
[10:40] <bthomas> another day.
[10:40] <facubatista> hola bthomas
[11:27]  * bthomas -> munch, munch
[11:34] <Chipaca> facubatista: buen día señor!
[11:50] <facubatista> hola Chipaca :)
[13:56]  * facubatista brb, errands
[15:24] <facubatista> WELL
[15:24] <facubatista> AssertionError: Please fix files as suggested by pydocstyle (461 issues):
[15:24]  * facubatista is adding docstring check to ops
[15:25] <facubatista> (note that count is ignoring test cases and special methods)
[15:27] <Chipaca> facubatista: ooh, i was looking at that earlier today too
[15:27] <mup> PR operator#424 opened: Added docstrings checks <Created by facundobatista> <https://github.com/canonical/operator/pull/424>
[15:28] <Chipaca> facubatista: pydocstyle --convention=google --add-ignore=D105,D107 ops
[15:28] <Chipaca> facubatista: still a long way to go
[15:28] <bthomas> Nice
[15:29] <Chipaca> facubatista: i don't know what the equivalent of --convention=google is but please do that also :)
[15:32] <facubatista> much better now!
[15:32] <facubatista> AssertionError: Please fix files as suggested by pydocstyle (102 issues):
[15:32] <Chipaca> facubatista: stand up?
[15:33] <facubatista> oops
[17:03] <Chipaca> this is EOD for me peeps
[17:03] <Chipaca> 👋
[17:16]  * bthomas dito
[17:36] <mup> PR operator#425 opened: Fixed several small details in lot of docstrings <Created by facundobatista> <https://github.com/canonical/operator/pull/425>
[17:36] <facubatista> Easy review! ↑
[17:44] <Chipaca> facubatista: can we block that until #417 is merged please
[17:44] <mup> PR #417: Added a few doc strings to charm module <Created by balbirthomas> <https://github.com/canonical/operator/pull/417>
[17:47] <facubatista> Uh, I forgot to talk about 417 today in the standup, it's almost 3 weeks now, do we see a light at the end of the tunnel for it?
[17:58] <bthomas> facubatista: I will also try and remember next standup. There are a lot of details that can be refined still. As long as Chipaca, jam and jldev are ok to merge we can merge it, and then make incremental changes as time passes. In response to some questions and comments by jam I suggested changes asking for his approval. If he accepts those suggestions I can make the changes before merge or we can do it later.
[18:23] <facubatista> bthomas, landing at 90% right and improve the remaining 10% is fine for me, I prefer that to waiting for it to be 101% right
[18:23] <facubatista> (it's similar to release early, release often)
[18:23] <bthomas> facubatista: agreed
[20:42] <facubatista> reviews appreciated, thanks! Improvements per ux review - https://github.com/canonical/charmcraft/pull/171
[20:42] <mup> PR charmcraft#171: Improvements per ux review <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/171>