[05:26] <zyga> o/
[05:26] <zyga> good morning
[05:36] <jamesh> zyga: based on your mention of i18n a few days ago, I was looking at the current state.  It looks like no new po template has been picked up by Launchpad since 2018.  Also, we don't seem to distribute translations outside of Ubuntu's langpacks
[05:36] <zyga> yes, that last bit is indeed sad and true
[05:37] <zyga> I was wondering if we could at some point really try to import translations at around beta time
[05:37] <zyga> commit them to the tree for real
[05:37] <jamesh> I think we'd need to have them in-tree to e.g. merge translations into the desktop file or polkit actions
[05:37] <zyga> and distribute them in releases
[05:37] <zyga> I agree stronglyt
[05:37] <zyga> *strongly
[05:37] <zyga> *sorry, my thinkpad lost a key and it's annoying to type on now
[05:38] <jamesh> If the Ubuntu packaging ran update-pot during build, that might be enough to have LP pick up new strings
[05:39] <zyga> mmm
[05:39] <zyga> how can we export translations from launchpad?
[05:39] <zyga> are they in a git anywhere?
[05:39] <jamesh> we can ask Launchpad to periodically write them to a Bazaar branch
[05:40] <zyga> oh that's interesting :D
[05:40] <zyga> but we can use actions to get that
[05:40] <zyga> a periodic action can checkout bzr repo
[05:40] <zyga> copy translations
[05:40] <jamesh> could have something to periodically copy those to git and create a pull request
[05:40] <zyga> and commit
[05:40] <zyga> or open a PR
[05:40] <zyga> yeah
[05:40] <zyga> it's doable with actions for sure
[05:43]  * zyga is a bit under the weather today, courtesy of all the rain lately
[05:43] <zyga> I'll get some tea and breakfast
[05:44] <zyga> jamesh: i would not overdo it for l10n yet
[05:44] <zyga> we can look at it more calmly after core20 ships and the team has more time
[05:44] <jamesh> and the message domain is still "snappy" :-)
[05:46] <zyga> lalala
[05:46] <zyga> :D
[06:03]  * zyga looks if store tests are happy now
[06:04] <zyga> 16 tests in progress
[06:04] <zyga> oh well, I'll take the dog for a walk and check again
[06:12] <mborzecki> morning
[06:18] <zyga> hey mborzecki
[06:18] <zyga> I restarted some tests but I see red
[06:18] <zyga> searching test still fails
[06:19] <mborzecki> zyga: hey
[06:19] <mborzecki> ehh, so no luch today either eh?
[06:20] <mborzecki> i suppose we can ask mvo to merge some of those PRs
[06:21] <zyga> mborzecki: we can propose a PR that ignores searching error
[06:21] <zyga> it's not a great test
[06:21] <zyga> it proves that things on the internet are not working sometimes
[06:21] <mborzecki> not great not terrible :P
[06:21] <zyga> if anything, store should run that test
[06:21] <zyga> not us
[06:28] <zyga-mbp> I'll start at around 9, need to run an errand at home
[06:46] <mborzecki> mvo: morning
[06:46] <mvo> good morning mborzecki
[06:46] <mvo> mborzecki: how are you? anything I can help with?
[06:46] <mborzecki> mvo: pinged you in a couple of PRs that could use a force merge
[06:47] <mvo> mborzecki: aha, I have a look
[06:47] <mborzecki> mvo: https://github.com/snapcore/snapd/pull/9420 https://github.com/snapcore/snapd/pull/9474 and https://github.com/snapcore/snapd/pull/9443
[06:47] <mup> PR #9420: tests/nested/manual/minimal-smoke: use 384MB of RAM for nested UC20 <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9420>
[06:47] <mup> PR #9474: boot, overlord/devicestate: list trusted and managed assets upfront <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9474>
[06:47] <mup> PR #9443: gadget, gadget/install: support for ubuntu-save, create one during install if needed <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9443>
[06:47] <zyga-mbp> hey mvo
[06:48] <mvo> good morning zyga-mbp
[06:49] <mvo> zyga-mbp: anything I can do for you this morning?
[06:49] <mup> PR snapd#9443 closed: gadget, gadget/install: support for ubuntu-save, create one during install if needed <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9443>
[06:49] <mup> PR snapd#9474 closed: boot, overlord/devicestate: list trusted and managed assets upfront <Run nested> <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9474>
[06:49] <zyga-mbp> mvo, mmm
[06:49] <zyga-mbp> mvo only a review for 9446 is something that is ready-to-go
[06:49] <mvo> mborzecki: done and thanks^2 for the TODO:UC20: about making the mem requirement official. I would actually really like to drive it down to 256 again but it seems we need kernel/foundations team help for this
[06:49] <zyga-mbp> I'm working on remaining comments to 9406
[06:50] <zyga-mbp> mvo last night I was trying to figure out how to sort out fsck on core16
[06:50] <mvo> zyga-mbp: sounds good
[06:50] <zyga-mbp> but I think that's something that can only be done in core itself
[06:50] <zyga-mbp> so I dropped that
[06:50] <mvo> zyga-mbp: fsck> what did you figure out?
[06:50] <mborzecki> mvo: i recall xnox said it may be a problem if we do an efi boot
[06:50] <zyga-mbp> mvo well, we just need the equivalent of systemd-fsck
[06:51] <zyga-mbp> but that's non-trivial
[06:51] <zyga-mbp> we should think about options and what we can do, I just dropped that because it was late and I was tired
[06:51] <zyga-mbp> I think I got the same cold my wife has now, so that was a factor as well :/
[06:52] <zyga-mbp> I had to wait for nearly an hour for the vet visit
[06:52] <zyga-mbp> and wasn't dressed for it
[06:53] <mborzecki> mvo: can you land https://github.com/snapcore/snapd/pull/9500 too?
[06:53] <mup> PR #9500: tests/main/sudo-env: snap bin is avaialble on Fedora <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9500>
[06:53] <mborzecki> pstolowski: hey
[06:53] <zyga-mbp> hey pawel
[06:53] <pstolowski> hey o/
[06:53] <mvo> good morning pstolowski
[06:53] <mvo> mborzecki: sure, done
[06:54] <mborzecki> mvo: thanks!
[06:54] <mup> PR snapd#9500 closed: tests/main/sudo-env: snap bin is avaialble on Fedora <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9500>
[06:54] <mvo> zyga-mbp: oh no! hope you get well soon (or at least not more unwell)
[07:01] <pstolowski> morning mvo
[07:03] <pstolowski> zyga-mbp: thanks for the review of 9501
[07:04] <zyga-mbp> :-)
[07:04] <pstolowski> looks like errors.Is is a new thing in go and we don't have it :(
[07:04] <mborzecki> pstolowski: we're using xerrors package for that
[07:04] <zyga-mbp> pstolowski you can probably just use == errno.EROFS
[07:04] <zyga-mbp> as errors.Is may rely on wrappers and interfaces that we are not using universally
[07:26] <mborzecki> mvo: are you looking into the sbuild errors in #9502?
[07:26] <mup> PR #9502: tests: more output for sbuild test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9502>
[07:26] <mvo> mborzecki: I haven't yet, looking now
[07:26] <mborzecki> mvo: i'll try to figoure out what's going on there, maybe we're missing some mocking
[07:27] <mvo> mborzecki: yeah, that seems likely
[07:27] <mvo> mborzecki: sbuild puts the process into a sandbox
[07:28] <mvo> mborzecki: maybe some implicit assumption that grub is installed or a valid bootloader or something?
[07:29] <mborzecki> mvo: idk, maybe, weird, cause we run the unit tests on sid too
[07:29] <mvo> mborzecki: hrm, hrm, yeah, there are more further down that are also strange
[07:30] <mborzecki> mvo: the panic/timeout is probably due to some assert in a callback
[07:33]  * mvo nods
[08:02] <mborzecki> mvo: heh, so tests are run with nosecboot tag
[08:03] <zyga_> mvo: destkop review call if you have the time to join
[08:05] <pstolowski> i just hit missing current symlink for snapd on failed refresh while working on a spread test for core18
[08:07] <mvo> mborzecki: ohhhh, nice
[08:09] <mvo> mborzecki: nice find
[08:14] <zyga-mbp> mborzecki in a call
[08:14] <mborzecki> kk
[08:31] <zyga-mbp> mborzecki not yet, last evening I wasn't feeling very well so I worked upstairs on PRs
[08:31] <zyga-mbp> mborzecki I plan to do that in my afternoon
[08:31] <zyga-mbp> brb,
[08:46] <zyga-mbp> back with tea
[08:49] <mup> PR snapd#9463 closed: seed/seedwriter/writer.go: check DevModeConfinement for dangerous features <Bug> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9463>
[09:33] <mborzecki> heh, initramfs-mounts unit tests seem to not be mocking everything correctly
[09:34] <zyga> mmm
[09:36] <zyga> mborzecki: I was wondering if it'd be possible to avoid global state
[09:36] <zyga> by organizing that anything done is accessed through arguments
[09:37] <zyga> including distant APIs
[09:44] <zyga> mborzecki: it might be more work at first but it would prevent "missing" a mock
[09:51] <mborzecki> ok, i think i got all the tests passing with nosecboot tag now
[10:12] <mborzecki> mvo: this was pretty annoying, but i got #9504 and it should unblock sid sbuild
[10:12] <mup> PR #9504: many: verify that unit tests work with nosecboot tag and without secboot package <Run nested> <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9504>
[10:15] <mup> PR snapd#9504 opened: many: verify that unit tests work with nosecboot tag and without secboot package <Run nested> <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9504>
[10:27] <mborzecki> duh, hate shell really
[10:30] <zyga> mborzecki: nice work
[10:34] <mvo> mborzecki: \o/
[10:34] <zyga-mbp> mborzecki +1
[10:34] <mvo> mborzecki: let me review
[10:34] <mvo> mborzecki: thanks so much
[10:34] <zyga-mbp> it's raining all day again
[10:34] <zyga-mbp> my wife is sick
[10:34] <zyga-mbp> they are about to close the city due to covid
[10:34] <zyga-mbp> and I need to pick up my fixed imac from the service center
[10:34] <zyga-mbp> and my dog is sick now too (though differently of course)
[10:34] <zyga-mbp> oh boy
[10:34] <zyga-mbp> what a morning
[10:35] <mvo> mborzecki: woah, that looks like it was hard indeed
[10:35] <mvo> zyga-mbp: oh no! that sounds horrible, stay strong!
[10:36] <zyga-mbp> dog just needs meds but I need to pick everything up today somehow
[10:36] <zyga-mbp> it's okay, we'll sort this out
[10:40] <mborzecki> heh ./run-checks: line 303: tags[@]: unbound variable, but passing locally here, wtf?
[10:40] <zyga-mbp> mborzecki bash version perhaps
[10:41] <zyga-mbp> try declare -A tags
[10:41] <zyga-mbp> but not 100% sure
[10:41] <mborzecki> zyga-mbp: there's an assignment a bit to the top, tags=()
[10:41] <zyga-mbp> I know
[10:41] <zyga-mbp> but ... it's shel
[10:41] <mborzecki> unless we need some magic incantation again
[10:41] <zyga-mbp> also known ash hell
[10:42] <mborzecki> zyga-mbp: but it's /usr/bin/bash now
[10:42] <zyga-mbp> yeah but bash _version_ matters
[10:42] <mborzecki> ehh
[10:42] <zyga-mbp> I was playing with arrays the other day and I noticed older versions didn't have some of the features
[10:42] <mborzecki> can't we use perl/tcl/python/any^shell
[10:42] <zyga-mbp> where does it fail"
[10:42] <zyga-mbp> mborzecki well
[10:42] <zyga-mbp> sure, we can
[10:46] <pstolowski> mvo: could you check for me how old (roughly) is snapd rev 8144 ?
[10:46] <zyga> pstolowski: checking
[10:47] <pstolowski> thanks
[10:47] <mvo> pstolowski: 2020-06-05 16:30 - 4 months, 1 week ago
[10:47] <zyga> oh
[10:47] <zyga> mvo was faster
[10:47] <zyga> btw, which command did you run?
[10:47] <pstolowski> mvo, zyga thank you :)
[10:48] <zyga> I tried snapcraft list-revisions snapd
[10:49] <mvo> zyga I used https://dashboard.snapcraft.io/snaps/snapd/revisions/8144/
[10:49] <mborzecki> zyga: omg, bash 4.3.48 (from enial) complains about unbound variable, bash 5.0.18 does not
[10:49] <zyga> mborzecki: did I win a cookie?
[10:50] <pstolowski> mvo: that page is not available for me
[10:50] <zyga> mborzecki: my advice is to revert backto sh
[10:50] <zyga> mvo: thanks
[10:50] <mborzecki> zyga: https://paste.ubuntu.com/p/Mc93wY3j5W/ this fails
[10:50] <zyga> right
[10:51] <zyga> mborzecki: use a variable and just append to it
[10:51] <zyga> sad as it is
[10:51] <mborzecki> zyga: that won't work if you want to passs say `'nosecboot foo'`, because shell will chop it up when expanding the variable
[10:52] <mborzecki> either that, or `shellcheck disable=SC2086` at every relevant place
[10:52] <zyga> mborzecki: not exactly, you can always quote it enough
[10:52] <zyga> or sharp dirty pieces of metal under one's fingertips
[10:52] <zyga> finger*nails*
[10:52] <zyga> not sure which is worse
[10:52] <mborzecki> zyga: afaik not really, it's array, function or try a differnt interpreter :P
[10:53] <zyga> mborzecki: hmm?
[10:53] <zyga> you can also if-then-else this
[10:53] <zyga> anyway, I'm sure it is solvable
[10:53] <mborzecki> zyga: yeah, but the tools are broken :/
[10:54] <mborzecki> heh, "${tags[@]-}" is apparently fine (?)
[10:57] <zyga-mbp> hmmmm
[10:57] <zyga-mbp> hmm
[10:58] <mvo> mborzecki, zyga-mbp fun, I was stumbling on the same wondering
[10:59] <zyga-mbp> I cannot find any documentation on what {foo-} stands for
[11:01] <zyga> pedronis: https://github.com/snapcore/snapd/pull/9406 is good to go now, I think
[11:01] <mup> PR #9406: many: allow ignoring running apps for specific request <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/9406>
[11:02] <cjwatson> zyga: it's documented under ${parameter:-word}, with the general comment above that "Omitting the colon results in a test only for a parameter that is unset"
[11:02] <zyga-mbp> oh
[11:03] <zyga-mbp> huh
[11:03] <zyga-mbp> mborzecki does it do what you expect?
[11:03] <zyga-mbp> cjwatson thank you!
[11:03] <cjwatson> np
[11:08] <zyga-mbp> pedronis do you think you will have time to have a quick look at the link participant PR?
[11:08] <zyga-mbp> pedronis +145,-0
[11:08] <pedronis> yes, I will try to look at it this afternoon
[11:08] <zyga-mbp> that is https://github.com/snapcore/snapd/pull/9422
[11:08] <mup> PR #9422: overlord: add link participant for linkage transitions <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/9422>
[11:09] <pedronis> at this point is 2nd or 3rd in my queue
[11:09] <zyga-mbp> that's excellent, thanks!
[11:18] <mborzecki> mvo: can you also update the golang-github-mvo5-goconfigparser-dev package in sid?
[11:20] <mborzecki> mvo: it is missing this fix: https://github.com/mvo5/goconfigparser/pull/6
[11:20] <mup> PR mvo5/goconfigparser#6: configparser: fix section header regex to not interfere with JSON data <Created by bboozzoo> <Merged by mvo5> <https://github.com/mvo5/goconfigparser/pull/6>
[11:25] <mborzecki> heh, so with {..-} we get `go build '' -v github.com/...` so useless
[11:26] <zyga-mbp> I'm going to pick up my imac now, I will do my best to get back home by standup but if I cannot I'll join from my phone
[11:30] <mvo> mborzecki: oh, yes
[11:38] <zyga> re, sorry, had to reboot to get LTE working
[11:49] <mvo> mborzecki: I prepared the goconfigparser upload, just waiting for an ack from vorlon to ensure I don't step on anyones toes (but I'm sure he will not mind if I take this debian package over from him)
[11:50] <mborzecki> mvo: thank you!
[11:50] <zyga> I need a review for https://github.com/snapcore/snapd/pull/9406
[11:50] <mup> PR #9406: many: allow ignoring running apps for specific request <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/9406>
[11:50] <zyga> it's pretty simple and not too long
[11:50] <pstolowski> pedronis, zyga : added some inisght into https://bugs.launchpad.net/snapd/+bug/1899665
[11:50] <mup> Bug #1899665: Failed refresh of snapd drops current symlink <snapd:Triaged> <https://launchpad.net/bugs/1899665>
[11:52] <zyga> mvo: shall we disable the searching test for now?
[11:52] <zyga> pstolowski: looking
[11:53] <mvo> zyga: yes
[11:53] <zyga> mvo: k
[11:53] <mvo> zyga: can we infer that the store is under load from the returned error?
[11:53] <zyga> I'll check
[11:54] <mvo> maybe we could adjust the test to not fail under these conditions
[11:54] <mvo> also funny that it seems everything else is working on the store side
[11:54] <zyga> we get 403
[11:56] <zyga> I think we can
[12:01] <zyga> mvo: how does https://github.com/snapcore/snapd/pull/9505 look like?
[12:01] <mup> PR #9505: tests: allow the searching test to fail under load <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/9505>
[12:05] <mup> PR snapd#9505 opened: tests: allow the searching test to fail under load <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/9505>
[12:08] <mvo> zyga: looks good, I was hoping the store would tell us a little bit more in their payload than just the 403 :/
[12:08] <mvo> zyga i can try to have a look (but will need lunch soon :)
[12:08] <mvo> zyga but maybe it really does not give us more info
[12:08] <mvo> (and maybe my idea is kind-a dumb)
[12:09] <zyga> I don't know
[12:09] <zyga> I think it's not that critical
[12:09] <zyga> and it's probably gonna vary over time
[12:09] <zyga> I marked the branch as ready for review
[12:09] <zyga> picking up my imac now, I'll re-connect later
[12:09] <mvo> ok
[12:09] <mvo> good luck
[12:10] <pedronis> it comes from the proxy/LB iirc
[12:13] <mup> PR pc-amd64-gadget#50 closed: grub: boot configuration is shipped and managed by snapd <Created by bboozzoo> <Merged by xnox> <https://github.com/snapcore/pc-amd64-gadget/pull/50>
[12:13] <mborzecki> yay
[12:24] <pedronis> zyga-mbp: I have a question in #9422
[12:24] <mup> PR #9422: overlord: add link participant for linkage transitions <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/9422>
[12:30] <mup> PR snapd#9506 opened: boot: skip some unit tests when running as root <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9506>
[12:42] <zyga> re
[12:57] <zyga> pstolowski, mborzecki: I will try to reproduce the old kernel upgrade of core18 after the standup
[12:57] <zyga> we can chat after I have the outcome, either way it's something we learn
[12:57] <zyga> I was also thinking we could stream compressed, non-empty blocks of the SD card
[12:57] <zyga> and probably re-image the device locally
[12:58] <zyga> that would eliminate all but SD card corruption
[12:58] <zyga> unless pi revisions matter but I hope not
[12:58] <zyga> pstolowski: nice analysis in https://bugs.launchpad.net/snapd/+bug/1899665
[12:58] <mup> Bug #1899665: Failed refresh of snapd drops current symlink <snapd:Triaged> <https://launchpad.net/bugs/1899665>
[12:59] <zyga> and last point is very sobering
[12:59] <zyga> because it means that bugs have a delayed fuse
[13:11] <pstolowski> yes
[13:57] <zyga-x240> re
[13:57] <zyga-x240> pstolowski: we're done, if you need to talk to mvo
[14:00] <pstolowski> zyga-x240: thanks; no, i was just joining back standup
[14:01] <zyga-x240> ah right
[14:02] <pedronis> zyga-x240: btw I looked at https://github.com/snapcore/snapd/pull/9497  I don't think it needs my review particularly, it does need one more on top of yours though
[14:02] <mup> PR #9497: usersession/agent: have session agent connect to the D-Bus session bus <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/9497>
[14:02] <zyga-mbp> pedronis checking
[14:03] <zyga-mbp> right, I will do a complete review
[14:03] <zyga-mbp> and then maybe pawel or maciek can look
[14:04] <zyga-mbp> mborzecki could you go for core desktop call?
[14:22] <zyga-mbp> jamesh https://github.com/snapcore/snapd/pull/9497#pullrequestreview-509416040
[14:22] <mup> PR #9497: usersession/agent: have session agent connect to the D-Bus session bus <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/9497>
[14:51]  * cachio lunch
[14:56] <mborzecki> zyga-mbp: sorry, late lunch
[14:56] <mborzecki> found a silly problem in snapshots though
[14:57] <mvo> mborzecki: in "snap snapshots"?
[14:57] <mborzecki> mvo: more liek snapshots backend, see https://github.com/snapcore/snapd/pull/9507
[14:57] <mup> PR #9507: overlord/snapshotstate/backend: specify tar format for snapshots <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9507>
[14:58] <mvo> mborzecki: nice!
[14:58] <mborzecki> mvo: somehow suse defaults to POSIX tar for format, so the unit tests of snapshot export failed because they assume a known archive size
[14:59] <mvo> mborzecki: right
[14:59] <zyga-mbp> uh,
[14:59] <zyga-mbp> nice!
[14:59] <mvo> mborzecki: nice find!
[14:59] <mup> Bug #1899992 opened: refresh.timer=managed prevents setting other configurations, e.g. proxy.http <Snappy:New> <https://launchpad.net/bugs/1899992>
[15:00] <zyga-mbp> mborzecki reviewed
[15:01] <mborzecki> zyga-mbp: yeah, doesn't look like we do a very strict checking of the archives
[15:01] <mup> PR snapd#9507 opened: overlord/snapshotstate/backend: specify tar format for snapshots <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9507>
[15:01] <mborzecki> anyways, i can look into that on monday, got some errands to run
[15:01] <zyga-mbp> understood
[15:01] <zyga-mbp> ok I should stop coding but I want one more thing
[15:01] <zyga-mbp> then I'll re-create that pi
[15:02] <zyga-mbp> I NEED PI(e)
[15:02] <zyga-mbp> ;-)
[15:02] <mborzecki> zyga-mbp: fwiw this came up when i tried to update the package on opensuse
[15:02] <zyga-mbp> mvo can I revert that last commit in 9505 and merge without any extra checks
[15:02] <mborzecki> zyga-mbp: so a distro patch will be needed
[15:02] <zyga-mbp> I don't want to dig into that (that other variant of the failure now)
[15:05] <vorlon> mvo: sorry, what ack are you waiting on from me re: goconfigparser? I don't see any email about this from you
[15:07] <zyga-mbp> mvo perhaps someone should attend https://developers.tpm.dev 's https://developers.tpm.dev/posts/tpmdev-2020-miniconf
[15:08] <mvo> vorlon: just a high-level ack :)
[15:08] <mvo> vorlon: if you are ok with that I will just upload if you prefer to review the diff that also works etc
[15:10] <vorlon> mvo: please go ahead
[15:11] <mvo> ta
[15:13] <mvo> zyga-mbp: yeah, just do it
[15:13] <zyga-mbp> ok
[15:14] <zyga-mbp> done
[15:14] <zyga-mbp> pstolowski can you review 9505 quickly
[15:14] <zyga-mbp> (tiny)
[15:14] <pstolowski> looking
[15:15] <zyga-mbp> https://github.com/snapcore/snapd/pull/8573 needs a 2nd review but not sure who has time for it
[15:15] <mup> PR #8573: overlord/snapstate: inhibit startup while unlinked <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8573>
[15:18] <mvo> zyga-mbp: in a meeting but I can do after, this one looks straightforward
[15:18] <zyga-mbp> woot, thanks
[15:43] <zyga-mbp> pedronis, pstolowski: question about link/unlink snap, some actions explicitly set Done/Undone status
[15:43] <zyga-mbp> but this is not consistent among the set of handlers that change linkage
[15:43] <zyga-mbp> is this by design or is there an omission somewhere?
[15:45] <pedronis> zyga-mbp: I need to recheck, in general is always ok to do it, it's really needed though if the task does internal state changes that are not clearly idempotent
[15:46] <zyga-mbp> mmm
[15:46] <pstolowski> zyga-mbp: yes, i noticed something similar thing wrt maybeRestart recently
[15:46] <zyga-mbp> we should scrutinize that then - I suspect there's a subtle bug there
[15:47] <pstolowski> this can be problematic if an unplanned restart happens and we re-execute same task
[15:50] <pedronis> zyga-mbp: basically adding it to the (un)doUnlinkCurrentSnap should be fine and maybe needed
[15:50] <zyga-mbp> I'll send a separate PR for that
[15:50] <pedronis> but OTOH I think pstolowski change that code again
[15:50] <pedronis> anyway as I said, it's never a bug to have it
[15:51] <pedronis> it might be a bug not to have it
[15:51] <pedronis> it's a bit of annoying property of our state/task model
[15:51]  * zyga-mbp nods
[15:51] <pstolowski> true
[15:52] <pedronis> I mean, assuming is done after any error path
[15:52] <zyga-mbp> right
[15:52] <zyga-mbp> pretty much at the bottom of those functions
[15:56] <mup> PR snapd#8573 closed: overlord/snapstate: inhibit startup while unlinked <Needs Samuele review> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8573>
[15:56] <zyga-mbp> \o/
[15:56] <zyga-mbp> thank you
[15:57] <mvo> zyga-mbp: *thank you*
[16:01] <pstolowski> mvo: reviewed snapshot import
[16:02] <pedronis> the next time we might revisit the runner we might want to consider holding the lock to be the default for tasks, and not holding it fully to be the exception
[16:03] <mvo> pstolowski: just saw it - thanks so much!
[16:03]  * mvo takes a dinner break
[16:04] <pedronis> we would need to see if it's true that most task do hold it
[16:04] <pedronis> when we started there were less tasks and some it was more mixed
[16:04] <pedronis> s/some/so/
[16:19] <pstolowski> so, after reordering removing of snap revisions undo looks more sane
[16:23] <zyga-mbp> \o/
[16:24] <pstolowski> the battle is not over to be clear ;), but at least i'm back with lxd snap and attempt to remove it again. no more errors from undo handlers because of wrong current
[16:25] <pstolowski> *can attempt*
[16:25] <pstolowski> eod, cu
[16:29] <zyga-mbp> o/
[16:44] <zyga-x240> eh, I messed up redirect in search fix
[16:44] <zyga-x240> I'll change that shortly
[17:13] <zyga-mbp> actually
[17:13] <zyga-mbp> I did not
[17:13] <zyga-mbp> some new error showed up
[17:14] <zyga-mbp> pedronis I've updated https://github.com/snapcore/snapd/pull/9422
[17:14] <mup> PR #9422: overlord: add link participant for linkage transitions <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/9422>
[17:14] <zyga-mbp> I will EOD now, need to help my family
[17:14] <zyga-mbp> see you tomorrow
[17:15] <zyga-mbp> mvo if you are back, consider merging https://github.com/snapcore/snapd/pull/9505
[17:15] <mup> PR #9505: tests: allow the searching test to fail under load <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/9505>
[17:15] <zyga-mbp> it's not perfect as other things failed now (store related)
[17:15] <zyga-mbp> but may be better
[17:15]  * zyga-x240 EODs
[17:57] <mup> PR snapd#9508 opened: tests: remove ausearch which fails during prepare <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9508>
[18:57] <mup> PR snapd#9505 closed: tests: allow the searching test to fail under load <Test Robustness> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9505>
[19:57] <mup> PR snapd#9509 opened: multipass/docker-support: Mount /etc/apparmor* from the base snap <Created by alexmurray> <https://github.com/snapcore/snapd/pull/9509>