=== mup_ is now known as mup
* Chipaca takes a break10:20
facubatista¡Muy buenos días a todos!11:05
bthomasनमस्ते facubatista11:08
facubatistahola bthomas11:08
* facubatista begs a 2nd review one https://github.com/canonical/operator/pull/42511:27
mupPR #425: Fixed several small details in lot of docstrings <Created by facundobatista> <https://github.com/canonical/operator/pull/425>11:27
bthomasdone reviewing 42511:29
facubatistabthomas, thanks!11:35
* facubatista begs a review on https://github.com/canonical/charmcraft/pull/17111:35
mupPR charmcraft#171: Improvements per ux review <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/171>11:35
mupPR operator#425 closed: Fixed several small details in lot of docstrings <Created by facundobatista> <Merged by facundobatista> <https://github.com/canonical/operator/pull/425>12:39
facubatistaChipaca, how are you running the OF tests these days? I get failures in the test.test_infra.ImportersTestCase.test_imports tests12:42
Chipacafacubatista: ./run_tests works, as does python3 -m unittest, as does pytest12:43
facubatistaChipaca, it doesn't here12:43
Chipacafacubatista: you're holding it wrong12:43
Chipacafacubatista: how are you trying to run them?12:44
facubatistaChipaca, `./run_tests` inside the venv12:44
Chipacafacubatista: how do you create the venv?12:44
facubatistaChipaca, following exactly the instructions in the README12:45
Chipacafacubatista: what's the output of printenv | grep ^PY | sort ?12:45
Chipacafacubatista: what happens if you «PYTHONPATH="" ./run_tests» ?12:46
facubatistasame, fail12:47
Chipacafacubatista: can you pastebin the failure please12:47
facubatista    self.assertEqual(proc.returncode, 0)12:47
facubatistaAssertionError: 1 != 012:47
facubatistaI'm suspecting what it can be, though12:48
facubatista            env={'PYTHONPATH': os.getcwd(), **os.environ})12:49
facubatistaChipaca, ^, if PYTHONPATH in environ, it's not getting what is set12:49
Chipacafacubatista: ah, so if you «unset PYTHONPATH» it works? ?12:50
Chipacafacubatista: easy to fix12:53
facubatistaright, removing those tests!12:53
* facubatista hides12:53
Chipacafacubatista: i'll push a pr in a bit12:53
facubatistaChipaca, https://github.com/canonical/operator/pull/42612:53
mupPR #426: Fixed environment in the import tests <Created by facundobatista> <https://github.com/canonical/operator/pull/426>12:53
Chipacaor that12:53
mupPR operator#426 opened: Fixed environment in the import tests <Created by facundobatista> <https://github.com/canonical/operator/pull/426>12:54
Chipacafacubatista: prepend, not append, plz?12:54
Chipacafacubatista: and use os.pathsep, not ':'12:54
facubatistathis will be shorter and more expressive in py3.912:57
facubatistaChipaca, pushed12:59
Chipacafacubatista: how does it look in 3.9?13:31
facubatistaChipaca, you can "merge" dicts with '|'13:33
Chipacafacubatista: but we'd still need to join rather than replace PYTHONPATH13:34
facubatistayeap, but it will be something like13:34
facubatistappath = os.getcwd() + os.pathsep + os.environ('PYTHONPATH', '')13:35
facubatistasubprocess(..., env=os.environ | {'PYTHONPATH': ppath})13:35
mupPR operator#426 closed: Fixed environment in the import tests <Created by facundobatista> <Merged by facundobatista> <https://github.com/canonical/operator/pull/426>14:34
mupPR operator#427 opened: A bunch of module level docstrings <Created by facundobatista> <https://github.com/canonical/operator/pull/427>14:49
facubatistaChipaca, bthomas, justinclark, review appreciated, thanks! https://github.com/canonical/charmcraft/pull/17314:59
mupPR charmcraft#173: Load only the indicated command (if any), not everything in advance <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/173>14:59
Chipacai need to run off to the boys' school15:00
Chipacaaren't i lucky15:00
facubatistaages since I haven't read that15:03
Chipacafacubatista: which that?15:05
Chipacafacubatista: <3 that pr, so many things fixed15:05
facubatistaChipaca, people going to kid's school15:05
Chipacafacubatista: it's weird and slightly terrifying, but it is15:06
Chipacaanyway, i need to go15:06
Chipacattfn! ttyl15:06
* facubatista eods22:03
facubatistaand eows! see you all on monday22:03

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!