[10:20]  * Chipaca takes a break
[11:05] <facubatista> ¡Muy buenos días a todos!
[11:08] <bthomas> नमस्ते facubatista
[11:08] <facubatista> hola bthomas
[11:27]  * facubatista begs a 2nd review one https://github.com/canonical/operator/pull/425
[11:27] <mup> PR #425: Fixed several small details in lot of docstrings <Created by facundobatista> <https://github.com/canonical/operator/pull/425>
[11:29] <bthomas> done reviewing 425
[11:35] <facubatista> bthomas, thanks!
[11:35]  * facubatista begs a review on https://github.com/canonical/charmcraft/pull/171
[11:35] <mup> PR charmcraft#171: Improvements per ux review <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/171>
[12:39] <mup> PR operator#425 closed: Fixed several small details in lot of docstrings <Created by facundobatista> <Merged by facundobatista> <https://github.com/canonical/operator/pull/425>
[12:42] <facubatista> Chipaca, how are you running the OF tests these days? I get failures in the test.test_infra.ImportersTestCase.test_imports tests
[12:43] <Chipaca> facubatista: ./run_tests works, as does python3 -m unittest, as does pytest
[12:43] <facubatista> Chipaca, it doesn't here
[12:43] <Chipaca> facubatista: you're holding it wrong
[12:44] <Chipaca> facubatista: how are you trying to run them?
[12:44] <facubatista> Chipaca, `./run_tests` inside the venv
[12:44] <Chipaca> facubatista: how do you create the venv?
[12:45] <facubatista> Chipaca, following exactly the instructions in the README
[12:45] <Chipaca> facubatista: what's the output of printenv | grep ^PY | sort ?
[12:45] <facubatista> PYTHONPATH=/home/facundo/.bin/pymods
[12:45] <facubatista> PYTHONSTARTUP=/home/facundo/.pythonrc
[12:46] <Chipaca> facubatista: what happens if you «PYTHONPATH="" ./run_tests» ?
[12:47] <facubatista> same, fail
[12:47] <Chipaca> facubatista: can you pastebin the failure please
[12:47] <facubatista>     self.assertEqual(proc.returncode, 0)
[12:47] <facubatista> AssertionError: 1 != 0
[12:48] <facubatista> I'm suspecting what it can be, though
[12:49] <facubatista>             env={'PYTHONPATH': os.getcwd(), **os.environ})
[12:49] <facubatista> Chipaca, ^, if PYTHONPATH in environ, it's not getting what is set
[12:50] <Chipaca> facubatista: ah, so if you «unset PYTHONPATH» it works? ?
[12:51] <facubatista> yeap
[12:53] <Chipaca> facubatista: easy to fix
[12:53] <facubatista> right, removing those tests!
[12:53]  * facubatista hides
[12:53] <Chipaca> facubatista: i'll push a pr in a bit
[12:53] <facubatista> Chipaca, https://github.com/canonical/operator/pull/426
[12:53] <mup> PR #426: Fixed environment in the import tests <Created by facundobatista> <https://github.com/canonical/operator/pull/426>
[12:53] <Chipaca> or that
[12:54] <mup> PR operator#426 opened: Fixed environment in the import tests <Created by facundobatista> <https://github.com/canonical/operator/pull/426>
[12:54] <Chipaca> facubatista: prepend, not append, plz?
[12:54] <Chipaca> facubatista: and use os.pathsep, not ':'
[12:54] <facubatista> ack
[12:57] <facubatista> this will be shorter and more expressive in py3.9
[12:59] <facubatista> Chipaca, pushed
[13:31] <Chipaca> facubatista: how does it look in 3.9?
[13:33] <facubatista> Chipaca, you can "merge" dicts with '|'
[13:34] <Chipaca> facubatista: but we'd still need to join rather than replace PYTHONPATH
[13:34] <facubatista> yeap, but it will be something like
[13:35] <facubatista> ppath = os.getcwd() + os.pathsep + os.environ('PYTHONPATH', '')
[13:35] <facubatista> subprocess(..., env=os.environ | {'PYTHONPATH': ppath})
[13:35] <facubatista> anyway
[14:34] <mup> PR operator#426 closed: Fixed environment in the import tests <Created by facundobatista> <Merged by facundobatista> <https://github.com/canonical/operator/pull/426>
[14:49] <mup> PR operator#427 opened: A bunch of module level docstrings <Created by facundobatista> <https://github.com/canonical/operator/pull/427>
[14:59] <facubatista> Chipaca, bthomas, justinclark, review appreciated, thanks! https://github.com/canonical/charmcraft/pull/173
[14:59] <mup> PR charmcraft#173: Load only the indicated command (if any), not everything in advance <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/173>
[15:00] <Chipaca> i need to run off to the boys' school
[15:00] <Chipaca> aren't i lucky
[15:03] <facubatista> ages since I haven't read that
[15:05] <Chipaca> facubatista: which that?
[15:05] <Chipaca> facubatista: <3 that pr, so many things fixed
[15:05] <facubatista> Chipaca, people going to kid's school
[15:06] <Chipaca> hehe
[15:06] <Chipaca> facubatista: it's weird and slightly terrifying, but it is
[15:06] <Chipaca> anyway, i need to go
[15:06] <Chipaca> ttfn! ttyl
[22:03]  * facubatista eods
[22:03] <facubatista> and eows! see you all on monday