=== mup_ is now known as mup [10:20] * Chipaca takes a break [11:05] ¡Muy buenos días a todos! [11:08] नमस्ते facubatista [11:08] hola bthomas [11:27] * facubatista begs a 2nd review one https://github.com/canonical/operator/pull/425 [11:27] PR #425: Fixed several small details in lot of docstrings [11:29] done reviewing 425 [11:35] bthomas, thanks! [11:35] * facubatista begs a review on https://github.com/canonical/charmcraft/pull/171 [11:35] PR charmcraft#171: Improvements per ux review [12:39] PR operator#425 closed: Fixed several small details in lot of docstrings [12:42] Chipaca, how are you running the OF tests these days? I get failures in the test.test_infra.ImportersTestCase.test_imports tests [12:43] facubatista: ./run_tests works, as does python3 -m unittest, as does pytest [12:43] Chipaca, it doesn't here [12:43] facubatista: you're holding it wrong [12:44] facubatista: how are you trying to run them? [12:44] Chipaca, `./run_tests` inside the venv [12:44] facubatista: how do you create the venv? [12:45] Chipaca, following exactly the instructions in the README [12:45] facubatista: what's the output of printenv | grep ^PY | sort ? [12:45] PYTHONPATH=/home/facundo/.bin/pymods [12:45] PYTHONSTARTUP=/home/facundo/.pythonrc [12:46] facubatista: what happens if you «PYTHONPATH="" ./run_tests» ? [12:47] same, fail [12:47] facubatista: can you pastebin the failure please [12:47] self.assertEqual(proc.returncode, 0) [12:47] AssertionError: 1 != 0 [12:48] I'm suspecting what it can be, though [12:49] env={'PYTHONPATH': os.getcwd(), **os.environ}) [12:49] Chipaca, ^, if PYTHONPATH in environ, it's not getting what is set [12:50] facubatista: ah, so if you «unset PYTHONPATH» it works? ? [12:51] yeap [12:53] facubatista: easy to fix [12:53] right, removing those tests! [12:53] * facubatista hides [12:53] facubatista: i'll push a pr in a bit [12:53] Chipaca, https://github.com/canonical/operator/pull/426 [12:53] PR #426: Fixed environment in the import tests [12:53] or that [12:54] PR operator#426 opened: Fixed environment in the import tests [12:54] facubatista: prepend, not append, plz? [12:54] facubatista: and use os.pathsep, not ':' [12:54] ack [12:57] this will be shorter and more expressive in py3.9 [12:59] Chipaca, pushed [13:31] facubatista: how does it look in 3.9? [13:33] Chipaca, you can "merge" dicts with '|' [13:34] facubatista: but we'd still need to join rather than replace PYTHONPATH [13:34] yeap, but it will be something like [13:35] ppath = os.getcwd() + os.pathsep + os.environ('PYTHONPATH', '') [13:35] subprocess(..., env=os.environ | {'PYTHONPATH': ppath}) [13:35] anyway [14:34] PR operator#426 closed: Fixed environment in the import tests [14:49] PR operator#427 opened: A bunch of module level docstrings [14:59] Chipaca, bthomas, justinclark, review appreciated, thanks! https://github.com/canonical/charmcraft/pull/173 [14:59] PR charmcraft#173: Load only the indicated command (if any), not everything in advance [15:00] i need to run off to the boys' school [15:00] aren't i lucky [15:03] ages since I haven't read that [15:05] facubatista: which that? [15:05] facubatista: <3 that pr, so many things fixed [15:05] Chipaca, people going to kid's school [15:06] hehe [15:06] facubatista: it's weird and slightly terrifying, but it is [15:06] anyway, i need to go [15:06] ttfn! ttyl [22:03] * facubatista eods [22:03] and eows! see you all on monday