| wallyworld | kelvinliu: here's a PR for the k8s issue https://github.com/juju/juju/pull/12161 | 02:30 |
|---|---|---|
| kelvinliu | looking | 02:31 |
| kelvinliu | wallyworld: lgtm ty | 03:19 |
| wallyworld | awesome, ty | 03:19 |
| kelvinliu | wallyworld: got this small pr to fix some of ci test issues. https://github.com/juju/juju/pull/12163 +1 plz | 04:52 |
| wallyworld | ty, looking | 04:53 |
| wallyworld | kelvinliu: ty, i'll merge directly since just a Python test fix | 04:55 |
| kelvinliu | ty | 04:55 |
| stickupkid | achilleasa, or manadart can you tick this one https://github.com/juju/juju/pull/12148 | 08:47 |
| stickupkid | manadart, also this one https://github.com/juju/juju/pull/12128 | 08:48 |
| achilleasa | stickupkid_: can you take a look at https://github.com/juju/juju/pull/12164? | 14:07 |
| achilleasa | Added some creative QA steps in there :D | 14:07 |
| hml | manadart: stickupkid_ are either of you reviewing 12164? | 14:48 |
| stickupkid_ | hml, i am | 14:48 |
| hml | and i answered my own quetion | 14:48 |
| stickupkid_ | well I will be if I propose my PR | 14:49 |
| hml | stickupkid_: i’ll review 12165 then | 14:49 |
| stickupkid_ | hml, ta | 14:50 |
| stickupkid_ | achilleasa, done | 14:53 |
| hml | stickupkid_: is there a missing dependency on my box? failing with “ mv: cannot move '/home/heather/work/src/github.com/juju/juju/tests/tmp.Tg8/2.8.6-focal-amd64.tar.gz' to './tests/suites/bootstrap/streams/tools/agent/': No such file or directory” | 15:17 |
| stickupkid_ | hml, https://github.com/juju/juju/pull/12165/commits/62ae965ffe24e32e223f5813bbc2ce8f722971f0 | 15:18 |
| stickupkid_ | pull down and re-run :) | 15:19 |
| hml | damn it… pulled down and re-ran 2 min too soon | 15:19 |
| hml | :-) | 15:19 |
| stickupkid_ | hml, I guess I wanted to test that we worked with a server, I'll add the metadata source as well | 15:57 |
| hml | stickupkid_: rgr. I was just thinking the other way was easier? | 15:58 |
| stickupkid_ | hml, I think we should have both tests :) | 15:58 |
| hml | cool | 15:58 |
| stickupkid_ | but you need to host your agent somewhere right? | 16:02 |
| stickupkid_ | hml, got a second? | 16:08 |
| hml | stickupkid_: sure | 16:09 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!