[00:21] <mup> PR snapcraft#3329 opened: cli: update revisions to use releases API <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3329>
[05:28] <mborzecki> morning
[06:06] <mup> PR snapd#9476 closed:  many: have install return encryption keys for data and save, improve tests <Run nested> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9476>
[06:37] <mborzecki> mvo: hey
[06:38] <mvo> hey mborzecki
[06:38] <mvo> good morning
[07:02] <mborzecki> pstolowski: hey
[07:03] <pstolowski> hi
[07:05] <mvo> good morning pstolowski
[07:05] <pstolowski> hey mvo
[07:05] <mvo> mborzecki: anything I should review for you? I'm doing zygas 9446 right now
[07:06] <mborzecki> mvo: no thanks, the reelvant prs have landed and i haven't opened anything new yet
[07:06] <mvo> mborzecki: cool
[07:10] <zyga> good morning everyone
[07:14] <mvo> zyga: goooood morning
[07:14] <zyga> indeed, it's a morning to be good on
[07:15] <mborzecki> zyga: heya
[07:15] <zyga> hey hey
[07:15] <zyga> I'm looking at tumbleweed failures
[07:15] <zyga> <kill-timeout reached>
[07:15] <mborzecki> zyga: more of those?
[07:15] <zyga> on quiet govendor sync
[07:16] <zyga> I'll debug interactively in a moment
[07:16] <mborzecki> zyga: that most likely is the kernel panic again
[07:16] <zyga> heh
[07:16] <zyga> fun
[07:16] <zyga> maybe kernel modules and kernel itself are skewed?
[07:25] <mborzecki> zyga: idk, last time the panic susgested problems with fs
[07:25] <zyga> hmm
[07:26] <zyga> I'll know soon
[07:46] <zyga> mborzecki passed without hanging or crashing
[07:47] <mborzecki> zyga: make sure there are no packages in the vendor directory (whcih should be the default with the changes to spread.yaml in master)
[07:47] <zyga> oh, good point
[07:48] <zyga> running again
[08:18] <pstolowski> huh, i think the download stalling issue is simply due to missing timeout, we create http.Client with default timeout 0 there, for reference https://golang.org/src/net/http/client.go?s=3300:3996#L97
[08:21] <mvo> pstolowski: hm, timeout is not easy because we just don't know how long it might take :/
[08:24] <pedronis> mvo: pstolowski: will have to think
[08:25] <pstolowski> mvo, pedronis i'd hope that this is smart enough to timeout of no response from transport, and otherwise be not affected by actual download time; func (b *cancelTimerBody) Read(p []byte) might be relevant there
[08:25] <mvo> zyga: 9446 has a review
[08:25] <zyga> ohh
[08:25] <zyga> thanks
[08:26] <pedronis> pstolowski: no, see the definition of timeout in the pkg, at least that timeout is not like that
[08:26] <mvo> pstolowski, pedronis I guess we would need something like "timeout-for-no-new-data-from-the-remote". not sure if that is available in go(?)
[08:27] <pedronis> mvo: pstolowski: we need to think a bit
[08:27] <pstolowski> pedronis: sorry, timeout in which pkg?
[08:27] <mvo> ok
[08:27] <pedronis> pstolowski: I mean, look at the doc of Client.Timeout
[08:28] <zyga> mvo: I'll go over the feedback after uboot
[08:29] <pstolowski> fwtw I found retry logic fine and tried with separate standalone code that uses same combo of strategies as snapd, and hits limit on every strategy correctly. so getting stuck in io.Copy is my main suspect now
[08:30] <pstolowski> ah, "... and will interrupt reading of the Response.Body". ok, I think i misunderstood the meaning of this
[08:36] <pstolowski> pedronis: some ideas here https://medium.com/@simonfrey/go-as-in-golang-standard-net-http-config-will-break-your-production-environment-1360871cb72b - see Variable timeout section, with ltime.AfterFunc, a loop around CopyN and timer.Reset that pushes timer back
[08:38] <pedronis> pstolowski: yea, let's discuss after standup or something, basically the issue is that using io.Copy for something that can take 10s of minutes was/is probably a bit naive
[08:42] <mup> PR snapd#9525 opened: packaging: make sure that static binaries are indeed static, fix openSUSE <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9525>
[08:50] <mvo> pedronis: a peek at 9373 would be good for uc1.0. it's a bit of a extra but it would be nice if console-conf could have the ability to show the recovery key. but your earlier comments made me wonder if this should be a proper API in snpad instead of a client command.
[08:52] <mup> PR snapd#9523 closed: store, snap-repair: fix use of retry strategies <Bug> <⛔ Blocked> <Created by stolowski> <Closed by stolowski> <https://github.com/snapcore/snapd/pull/9523>
[08:52] <pedronis> mvo: the blocker there is more that we need a bit more progress on save to know where exactly things are
[08:53] <mvo> pedronis: oh, good point
[09:57] <mup> PR snapd#9525 closed: packaging: make sure that static binaries are indeed static, fix openSUSE <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9525>
[10:32] <mup> PR snapd#9526 opened: snapshotstate: add clenup of abandonded snapshot imports <Created by mvo5> <https://github.com/snapcore/snapd/pull/9526>
[10:39] <zyga> ok
[10:52] <mborzecki> pedronis: mvo: we may need to have larger ubuntu-save to be able to encrypt it
[10:53] <mborzecki> cryptsetup open complains about `Requested offset is beyond real size of device /dev/vda4`, probably something about the backup header
[11:03] <pedronis> mborzecki: yes, moderm LUKS default use quite a bit of space
[11:04] <mborzecki> pedronis: ran luksFormat with --debug-json, if i'm not mistaken, just the keyslot area is 7MB
[11:11] <zyga> mvo I've managed to build uboot from the old tree
[11:11] <zyga> with the patch
[11:11] <zyga> going to boot it now
[11:14] <pedronis> mborzecki: there's  --luks2-metadata-size and --luks2-keyslot-size , but the doc are not very clear what are reasonable values
[11:14] <mborzecki> pedronis: the docs aren't very clear at all :P
[11:14] <mborzecki> pedronis: this is what i'm looking at currently: https://gitlab.com/cryptsetup/LUKS2-docs/blob/master/luks2_doc_wip.pdf
[11:15] <pedronis> mborzecki: afaik that one hasn't been updated to the larger defaults
[11:16] <pedronis> in 2.1 they: The default size of the LUKS2 header is increased to 16 MB.
[11:16] <pedronis> but that doc still uses the smaller old values iirc
[11:22] <mup> PR snapd#9527 opened: o/snapstate: implement undo handler for unlink-snap <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9527>
[11:30] <zyga> pstolowski tiny feedback on your branch
[11:47] <pstolowski> zyga: yes, saw that, thanks!
[11:47] <zyga> +1
[11:50] <pstolowski> zyga: hmm, did you mean boot.Participant ?
[11:51] <zyga> pstolowski no no
[11:51] <zyga> sorry I meant link participant
[11:51] <zyga> pstolowski merge master, there's a new call in all link* methods
[11:51] <zyga> near the end
[11:51] <pstolowski> aah
[11:52] <pstolowski> zyga: righ, I can see it now
[11:54] <zyga> mvo: I was thinking, snapd could perform this test as a part of seeding, at least on pi, we could try to reboot and see the bootloader increment the boot counter
[11:54] <zyga> mvo then we'd known instantly
[11:54] <zyga> and not at the next rare kernel update
[11:54] <zyga> or base update
[12:05] <pedronis> won't the kernel cache get in the way of naive testing?
[12:06] <pedronis> ah, you said try to reboot
[12:06] <zyga> yeah
[12:06] <zyga> pedronis there's one bit missing that is essential
[12:07] <zyga> pedronis I had a call with mvo where I described an extension to our boot protocol
[12:07] <zyga> pedronis where apart from setting snappy_mode, the compatible bootloader would operate on a snapd-provided cookie
[12:08] <zyga> pedronis the goal would be to be able to detect that bootloader can or cannot write to storage even on rollback
[12:08] <zyga> pedronis so snappy_write_cookie=pong on snappy_write_cookie=ping
[12:08] <zyga> or something similar
[12:08] <zyga> we could be smarter but something extremely basic like that
[12:08] <zyga> the bootloader script could contain another hint that this is supported at all
[12:09] <zyga> and if we detect that it is supported but bootloader could not write, we could report to the store
[12:10] <zyga> I've booted my build of uboot!
[12:16] <pedronis> zyga: to me, it's a bit unclear what's our goal here
[12:16] <zyga> pedronis to detect that bootloader cannot write to the storage and cannot ever upgrade certain snap types that require such writes
[12:17] <zyga> pedronis so that we can report this and get statistics about it, right now we are in the blind
[12:17] <pedronis> zyga: but we don't have a way to report statistics
[12:17] <pedronis> atm
[12:17] <zyga> one thing at a time
[12:17] <zyga> we could send error reports
[12:18] <zyga> it's better than nothing
[12:18] <zyga> we could send MMC card information as well
[12:18] <mup> PR snapd#9528 opened: cmd/snap-bootstrap: mount ubuntu-save during boot if present <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9528>
[12:26] <zyga> mvo: it's fixed
[12:27] <pedronis> mborzecki: question/comment in #9528
[12:27] <mup> PR #9528: cmd/snap-bootstrap: mount ubuntu-save during boot if present <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9528>
[12:31] <zyga> mvo: refreshed core18 just now
[12:31] <zyga> no write issues
[12:32] <zyga> refreshing the rest (kernel) to check if it's good in general
[12:34] <zyga> mvo: heh, updated kernel doesn't boot :D
[12:34] <zyga> hangs after starting kernel
[12:34] <zyga> pi and pi kernel well both following 18-pi/stable
[12:35] <mvo> zyga: oh no! why is it hanging?
[12:42] <zyga> mvo no idea, it rolls back the kernel on reboot
[12:42] <zyga> mvo the only message I get is "Starting kernel"
[12:42] <zyga> my hunch is as followw
[12:42] <zyga> *follows
[12:42] <zyga> if you build a new image using stable 18 everything
[12:42] <zyga> it will work
[12:43] <zyga> but upgrades are hitting dtb skew
[12:43] <zyga> and fail
[12:43] <zyga> I can check that easily by upgrading manually
[12:43] <zyga> (I'm running u-boot with fixed SD write support but otherwise matching revision 17)
[12:46] <zyga> refreshed gadget assets by hand, re-trying kernel update
[12:51] <zyga> so, the latest uboot we ship still has the write error
[12:51] <zyga> so it cannot make progress past that boot cycle
[12:51] <zyga> I'll build update u-boot with the patch and verify
[12:52] <zyga> but this is also interesting, it means that _no_ current uboot we have is good on this
[12:52] <zyga> and we can make images, and test them, that will just fail later
[12:58] <ogra> zyga, hangs after starting kernel usually points to mistmatch of ctb
[12:58] <ogra> *dtb
[12:59] <zyga> yeah
[12:59] <zyga> I'm sure that's the problem
[12:59] <ogra> well, you can easily test (on pre UC20 at least) by simply replacing it and moving the original one to *.bak
[12:59] <zyga> yeah :)
[13:00] <zyga> just one sec, no network ;)
[13:00] <zyga> standup first
[13:50] <pedronis> zyga: what's the gadget and original kernel are you testing? pi2 pi3 ?
[13:51] <zyga> pedronis: this is a pi3b+ with the snaps listed in https://bugs.launchpad.net/snapd/+bug/1900693 -- pi-kernel and pi (gadget) from 18-pi/stable tracks
[13:51] <mup> Bug #1900693: snapd cannot refresh on some SD cards due to uboot bug <snapd:New> <https://launchpad.net/bugs/1900693>
[13:52] <zyga> pedronis the particular affected revisions are listed ion the bug
[13:54] <mborzecki> this is unexpected `2020-10-21 13:54:01 Cannot allocate google-nested:ubuntu-18.04-64: cannot find any Google image matching "ubuntu-1804-64-virt-enabled" on project "computeengine" or "ubuntu-os-cloud"`
[14:58] <zyga> mvo: https://github.com/snapcore/snapd/pull/9149#pullrequestreview-513775434
[14:58] <mup> PR #9149: gadget: provide new gadget.ResolveContentPaths() (2/N) <Created by mvo5> <https://github.com/snapcore/snapd/pull/9149>
[15:13] <mvo> cachio: could you please check https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1895929 and sru validate it?
[15:13] <mup> Bug #1895929: [SRU] 2.47 <verification-needed> <verification-needed-bionic> <verification-needed-focal> <verification-needed-xenial> <snapd (Ubuntu):Fix Released>
[15:13] <mup> <snapd (Ubuntu Xenial):Fix Committed> <snapd (Ubuntu Bionic):Fix Committed> <snapd (Ubuntu Focal):Fix Committed> <https://launchpad.net/bugs/1895929>
[15:14]  * zyga breaks for now, more later
[15:14] <zyga> need to look after Lucy
[15:28] <cachio> mvo, sure
[15:34]  * cachio lunch
[18:19] <mup> PR snapcraft#3330 opened: package repositories: fix case where formats is empty <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3330>
[18:29] <mup> PR snapcraft#3331 opened: spread tests: move package-repositories test snaps into own dir <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3331>
[19:19] <mup> PR snapcraft#3324 closed: set ROS_PYTHON_VERSION for rosdep <Created by artivis> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3324>
[19:19] <mup> PR snapcraft#3326 closed: lxd unit tests: simplify command checking pattern <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3326>
[20:11] <cachio> cmatsuoka, ijohnson hey
[20:11] <cachio> I see the test uc20-create-partitions failing in 20.04
[20:11] <ijohnson> cachio: do you have logs?
[20:11] <cachio> ijohnson, yes
[20:12] <cachio> ijohnson, https://paste.ubuntu.com/p/qC5RvpCdVv/
[20:13] <RingtailedFox> since snapd isn't available for my distro, can i compile it from source?  i don't know if the fedora RPMs would work well with it...
[20:14] <RingtailedFox> i know you can have snapd install flatpak on ubuntu.. is there a reverse way of doing that? (using flatpak to install snapd)
[20:14] <ijohnson> cachio: the test needs to be updated, there was an update to the gadget snap
[20:14] <ijohnson> RingtailedFox: what distro are you on ?
[20:14] <cachio> ijohnson, ah, nice, do you know which update does it need?
[20:14] <RingtailedFox> Mageia Linux (aa descendent of Mandrake, later, Mandriva)
[20:15] <ijohnson> cachio: let me take a quick look
[20:15] <RingtailedFox> it's related to fellow forks ROSA, OpenMandriva and PCLinuxOS
[20:15] <ijohnson> RingtailedFox: does your distro use systemd as it's init system ?
[20:15] <RingtailedFox> yes
[20:15] <RingtailedFox> it has since the days of Mandriva 2011.0 :)
[20:16] <RingtailedFox> i sometimes miss sysvinit, but systemd has matured well enough to no longer suck :P
[20:16] <ijohnson> cachio: yes I know what to change, it's a simple 1-liner I will file a PR shortly
[20:16] <cachio> ijohnson, nice, thanks a lot
[20:16] <ijohnson> RingtailedFox: then you should be able to compile snapd from source if you want to, not sure what kind of package management that distro uses, you mentioned something about rpms ?
[20:17] <RingtailedFox> yeah it uses RPM and dnf
[20:17] <RingtailedFox> along with urpmi
[20:17] <RingtailedFox> github.com/snapcore/snapd/releases/tag/2.47.1/ shows three different versions (no-vendor, only-vendor, and vendor).. which would i use?
[20:17] <RingtailedFox> or should i just download the source tarball and try my luck with that?
[20:17] <ijohnson> you should be able to just compile/build the snapd rpm on your machine, you probably want the vendor version
[20:17] <RingtailedFox> i never had much luck with compiling from source to RPM...
[20:17] <ijohnson> hmm I'm not actually sure which version fedora builds from regarding vendorization ...
[20:18] <ijohnson> yeah I'm not an expert at building rpms at all either tbh
[20:18] <RingtailedFox> i have gotten some programs/libraries to work in the past by using fedora RPMs, but i try not to do that unless i have no other options
[20:18]  * ijohnson is barely been able to build debs :-)
[20:18] <RingtailedFox> i do have alien installed, so i can try to import a deb and convert it to rpm
[20:19] <ijohnson> maybe that works better? I dunno I have not uesed alien either
[20:19] <ijohnson> sorry I can't be more helpful
[20:19] <RingtailedFox> no no, you're still helpful
[20:19] <RingtailedFox> i'll try to compile the vendor version and see if that works. if not, compile from source. if not that... then try to see if someone has a flatpak containing snapd :P
[20:19] <RingtailedFox> i still find it hilarious i was able to get flatpak onto ubuntu through snap lol
[20:20] <RingtailedFox> ok. so snapd-2.47.1 is extracted... it looks like it's already coimpiled into binary format
[20:22] <ijohnson> cachio: see 9529
[20:22] <cachio> ijohnson, checking
[20:23] <cachio> +1
[20:25] <mup> PR snapd#9529 opened: tests/uc20-create-partitions: don't check for grub.cfg <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9529>
[20:31] <ijohnson> thanks cachio
[20:40] <RingtailedFox> so what do i do with snapd-2.47.1? shove it in /usr/bin/ or /opt/?
[21:29] <cmatsuoka> ijohnson: in core, what systemd unit file ultimately launches snapd?
[21:29] <ijohnson> cmatsuoka: which release of ubuntu core
[21:29] <cmatsuoka> 20
[21:29] <ijohnson> cmatsuoka: so after the system has been seeded that will be snapd.service which is shipped by the snapd snap
[21:29] <ijohnson> before that point, there is a systemd service file in the core20 snap which unpacks the snapd snap to run initially
[21:30] <ijohnson> let me find the name of that
[21:30] <ijohnson> cmatsuoka: it's `core.start-snapd.service`
[21:31] <cmatsuoka> uuhm ok, thanks, I'll have a look
[21:31] <cmatsuoka> it seems that the systemd keyring mode setting failed for some reason
[21:32] <ijohnson> cmatsuoka: is this for install mode or run mode?
[21:32] <cmatsuoka> it's run mode
[21:32] <cmatsuoka> and it seemed that snapd was executed by some other way and snapd.service was not used
[21:33] <ijohnson> cmatsuoka: well initially snapd in run mode for first seeding will be run from that `core.start-snapd.service` unit
[21:33] <ijohnson> so if you need to modify snapd.service, you may need to adjust that one too
[21:34] <ijohnson> but the core service should do minimal amount of work to set up the real snapd snap service, then re-exec there
[21:34] <cmatsuoka> thanks, I'll see what would be the best approach here
[21:34] <ijohnson> cmatsuoka: is the issue that you need to read something from systemd upon startup to save it?
[21:35] <ijohnson> cmatsuoka: if so, you might want your startup method to recognize if it's being run from core.start-snapd.service and if so then just skip that, and let the real snapd read that data
[21:35] <cmatsuoka> ijohnson: yes, so if this first execution doesn't attempt to reseal anything, I won't try to read the auth key
[21:35] <cmatsuoka> ijohnson: are you aware of a good method to detect that?
[21:35] <ijohnson> cmatsuoka: let me take a look
[21:36] <cmatsuoka> the way snapd bootstraps isn't exactly straightforward I see
[21:42] <ijohnson> cmatsuoka: what part of snapd uses the data that you are getting from systemd ?
[21:43] <ijohnson> in other words, what depends on it?
[21:44] <ijohnson> cmatsuoka: because what might be easiest is instead of a StartUp method on the devicemgr is to instead add a ensureSomething() that  gets called as part of the devicemgr.Ensure(), and that ensureSomething checks to make sure that the device is seeded, and then gets the data it needs from systemd, because the ephemeral snapd that is started by the core.start-snapd won't ever finish seeding
[21:44] <cmatsuoka> I collect the data in the device manager startup and use it when resealing
[21:44] <ijohnson> pedronis may disagree with me on this however, not sure how important it is that we get this data from systemd asap after starting up
[21:45] <ijohnson> cmatsuoka: ok, so we wouldn't reseal until at least after seeding is done
[21:45] <ijohnson> so my proposal doesn't sound too terrible
[21:45] <cmatsuoka> Ok, it sounds interesting, let's try that
[21:45] <cmatsuoka> thanks Ian
[21:46] <ijohnson> np, let me know if you need any help, but for example you coudl take a look at how ensureCloudInitRestricted is implemented, that is essentially doing the same thing, waiting for snapd to be seeded then doing something
[21:46] <cmatsuoka> I think the idea of doing it asap is to block access to the keyring before we run too much stuff
[21:47] <ijohnson> yeah that might be the reason why my ensure proposal isn't a good idea
[21:47] <ijohnson> cmatsuoka: so after getting this data we essentially destroy it or otherwise prevent ourselves from accessing it from snapd again ?
[21:48] <cmatsuoka> so you didn't find a good way to determine where snapd was started from?
[21:48] <cmatsuoka> ijohnson: yes, after reading it the user keyring is unlinked from the systemd session keyring
[21:48] <cmatsuoka> so it can't be accessed again
[21:50] <mup> PR snapd#9529 closed: tests/uc20-create-partitions: don't check for grub.cfg <Simple 😃> <Test Robustness> <Created by anonymouse64> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9529>
[21:51] <ijohnson> cmatsuoka: hmm so the other thing you could do in StartUp is to check what systemd service you are running as, the ephemeral one will be under "snapd-seeding" instead of snapd
[21:51] <cmatsuoka> ah interesting
[22:04]  * ijohnson EODs
[22:19] <mup> PR snapcraft#3330 closed: package repositories: fix case where formats is empty <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3330>
[23:04] <mup> PR snapcraft#3329 closed: cli: update revisions to use releases API <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3329>
[23:16] <mup> PR snapd#9519 closed: tests: moving the lib section from systems.sh helper to os.query tool <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9519>