mborzeckimvo: hey06:30
mvogood morning mborzecki !06:30
zygagood morning07:06
* zyga starts the day with https://github.com/snapcore/snapd/pull/944607:08
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>07:08
mborzeckizyga: pstolowski: hey07:20
mborzeckipedronis: hi, shall we have a chat at 10?07:39
pedronismborzecki: I have the desktop meeting at 1007:39
mborzeckipedronis: i can do now if you're not busy :)07:39
pedronisI can I suppose07:39
mborzeckiok, heading to standup HO07:39
zygamvo, https://forum.snapcraft.io/t/snapd-localisation/20696 (via jamesh)08:38
mvozyga: thank you! yeah, we should totally tackle this one08:42
mvozyga: and when I say we I should probably say I08:42
mvozyga: added to trello, have some things now but will look at it soon08:42
zygajamesh, building now, I'll just test it quickly on my system08:51
jameshzyga: awesome!08:55
zygavery tentative https://github.com/snapcore/snapd/compare/master...zyga:feature/share-x11-sockets?expand=109:03
dot-tobiashi everyone09:13
zygajamesh, 9530 tested locally09:19
zygano tests or anything09:19
mupPR snapd#9530 opened: interfaces: x11 shares hosts /tmp/.X11-unix/ <Created by zyga> <https://github.com/snapcore/snapd/pull/9530>09:23
mupPR snapd#9531 opened: tests: add a unit test for UpdateMany where a single snap fails <Created by stolowski> <https://github.com/snapcore/snapd/pull/9531>09:28
zygajamesh, asked amurray for review09:29
pedronispstolowski: comment in 9531, thanks for it09:35
pstolowskipedronis: sure, thanks for the comment09:38
jameshzyga: I've left some initial comments.09:40
zygajamesh, yeah, I agree with all that you said09:42
zygajamesh, note that the mount point cannot be removed or renamed so at least that part should be safe09:42
jameshzyga: hmm.  I thought I remembered being able to move a bind mountpoint in the past09:42
dot-tobiasIs snapcraft's “build” parameter currently unsupported with the multipass build provider? When I shell into the VM and run `snapcraft build my-part` it works; the same command from the macOS host results in a complete build.09:44
zygajamesh, I think you can move with MS_MOVE but not otherwise09:55
pstolowskimvo: do you think any of the helpers from https://github.com/snapcore/snapd/pull/9457 makessense? if not, i'll close it. they are a bit heavy09:57
mupPR #9457: [RFC] o/snapshotstate: test for roundtrip with corrupted zip file inside exported snapshot <Created by stolowski> <https://github.com/snapcore/snapd/pull/9457>09:57
jameshzyga: ah.  It's the source directory you're free to move10:00
jameshzyga: One more question on the PR, about what happens when the slot snap's private tmp directory doesn't exist10:11
zygajamesh, snap-update-ns will create it10:12
jameshzyga: sure, but will it create it correctly?10:12
zygajamesh, there's some logic around this but it can be done10:12
zygathere are differences between source/destination10:13
zyga(for good reason)10:13
zygabut it can be done10:13
zygajamesh, the only gotcha is https://github.com/snapcore/snapd/blob/master/cmd/snap-update-ns/change.go#L20910:16
zygathis needs adjusting10:17
zygato take Assumptions into account10:17
zygaso that if we can write to a location, we can just do it10:17
jameshzyga: one last horrible case: what if an x11 plug is connected to an x11 slot of the same snap?10:18
zygajamesh, that's also ok10:18
zygajamesh, it will mount /tmp/.X11-unix over itself10:18
zygajamesh, createPath used there takes assumptions alreadyu10:18
amurrayzyga: how urgent is 9530?10:18
jameshzyga: and maybe make it read only10:19
zygajamesh, and /tmp is whitelisted10:19
zygaamurray, I defer to jamesh10:19
amurrayI realise X11 snaps are broken on wayland on groovy so I am guessing urgent-ish but since this is now a 0day SRU for snapd can it wait till next week?10:19
zygaamurray, I think so10:20
zygajamesh: https://github.com/snapcore/snapd/blob/master/cmd/snap-update-ns/change.go#L112 is the relevant point10:20
zygawe use assumptions object to compute the restrictions for the path we are about to create (/tmp/.X11-unix)10:20
zygaand then pass the restrictions to MkdirAll10:20
amurrayok let me know if it gets more urgent otherwise I'll take a look on Monday (or perhaps we'll be lucky and I'll get some time tomorrow)10:21
zygaamurray, +110:21
zygaamurray, it's not for this release10:21
jameshamurray: I've got an upstream PR to fix Mutter 3.38.  If that patch is accepted and pushed out to existing distros with Gnome 3.38.x (currently Ubuntu 20.10 and beta Fedora?), then it is "in the next 6 months" priority.  If we can't get the patch rolled out, then fairly soon10:21
amurrayjamesh: yeah I saw that (and it seems upstream is not super motivated?)10:21
zygajamesh, finally restrictions get passed to MpPrefix and MkDir in which both check if creating the directory is allowed (e.g. https://github.com/snapcore/snapd/blob/b2e238d229b8f4a686122ec6543842c97b8b25c3/cmd/snap-update-ns/utils.go#L175)10:22
jameshamurray: I think there's a very good chance that it'll make it into the 3.38.x branch10:22
amurrayoh nice10:22
jameshamurray: there's some people who'd prefer the abstract sockets didn't exist period, but it hasn't just broken snaps10:22
jameshamurray: I think they'll consider removing them as a conscious choice in Gnome 4.010:24
* pstolowski lunch10:55
mupPR snapcraft#3331 closed: spread tests: move package-repositories test snaps into own dir <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3331>11:00
mupPR snapcraft#3332 opened: storeapi: remove bindings for history <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3332>11:01
mvopstolowski: was in various meeting, I have a look later today/tomorrow11:14
pedronisijohnson: I reviewed 9489, the last small changes seem a bit off to me, also seems tests never started11:21
ijohnsonpedronis: I'll have a look after our meeting, /me is still having breakfast11:45
pedronispstolowski: did a pas on #9527, some questions there11:54
mupPR #9527: o/snapstate: implement undo handler for unlink-snap <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9527>11:54
mupPR snapd#9532 opened: tests: clean systems.sh helper and migrate last set of tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9532>11:59
pstolowskipedronis: thanks12:07
zygamvo_, I've updated https://github.com/snapcore/snapd/pull/9446 with lots of tests12:56
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>12:56
zygamvo_, I think it needs a second review now12:57
zygamvo_, and I can follow-up with removal of warnings12:57
zygamvo_, I'd also like to add very basic persistency12:58
zygamvo_, so that old message, for a given snap, is updated instead of appended12:59
zygamvo_, that will work fine for as long as you don't log out12:59
mupPR snapd#9533 opened: tests: new systemd-state tool <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9533>12:59
zygaand notifications are not persistent across logout, so that seems perfect to me12:59
zygamvo_, we can also discard the notification when the snap does refresh12:59
mupPR snapcraft#3321 closed: meta: add error check for "command not found" <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3321>13:06
mupPR snapcraft#3333 opened: specifications: finalization of package repositories spec <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3333>13:16
mborzeckierrands time13:59
cachiozyga, hey, could you please take a quick look to #941414:12
mupPR #9414: tests: new nested tool <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9414>14:12
cachioI update based on your comments14:12
zygaback from lunch14:40
zygacachio, sure14:40
cachiozyga, tx14:40
zygasmall errand, need to order some lights14:44
zygathen back to reviews14:44
zygacachio, https://github.com/snapcore/snapd/pull/9414#pullrequestreview-51481475514:51
mupPR #9414: tests: new nested tool <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9414>14:51
zygamvo, I have two follow-up branches that remove warnings on inhibited refreshes15:30
mvozyga: \o/15:31
zygamvo, and re-factor inhibitRefresh itself, to remove some duplication and explain the flow better15:31
mvozyga: I guess you just need a second review for the initial one15:31
zygahttps://github.com/snapcore/snapd/pull/9446 needs the 2nd review15:31
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>15:31
zygaexactly so15:31
zygaperhaps jamesh could do a review of that branch?15:32
zygaor ian, not sure if anyone has time15:33
* zyga EODs15:39
pedronisI think jamesh reviewing #9446 if he can would be great15:40
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>15:40
zygadefinitely the best person with the right insight15:40
ijohnsonzyga: you can request a review from me, I need to be doing more reviews really :-)15:44
ijohnsonpedronis: I updated #9489 is ready for a re-review15:44
mupPR #9489: daemon,client: write and read a maintenance.json file for when snapd is shut down <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9489>15:44
ijohnsonstill no idea why the tests never started there but they are running now so /shrugs15:44
ijohnsonpedronis: also is this TODO:UC20: 1.0 material ? https://github.com/snapcore/snapd/blob/master/cmd/snap-bootstrap/cmd_initramfs_mounts.go#L49715:48
ijohnsonor is that todo immaterial now that we seal against the model ?15:48
pedronisbecause we measure the model is indeed not super relevant15:51
pedroniswith ARM we'll need to do something about that though but probably before we get there anyway15:51
ijohnsonpedronis: so not for 1.0 then ?15:54
ijohnsonthanks for confirming15:54
pedronisijohnson: I re-reviewed #9489, thanks for the fixes there16:00
mupPR #9489: daemon,client: write and read a maintenance.json file for when snapd is shut down <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9489>16:00
pedronissome small things16:00
ijohnsonthanks I'll take a look in a second, working on 9418 right now16:00
Copenhagen_BramFor some reason, `snap-store` isn't creating a window16:05
Copenhagen_BramWhen I installed it, I got: INFO snap "snap-store" has bad plugs or slots: appstream-metadata (unknown interface "appstream-metadata"); packagekit-control (unknown interface "packagekit-control")16:07
ograwhats the full output of "snap version" ?16:07
Copenhagen_Bramsnap 2.45, snapd 2.45, series 16, debian 10, kernel 4.19.0-10-amd6416:08
Copenhagen_Bramwait, i ran that command in an ssh16:09
Copenhagen_Bramon this laptop snap and snapd are 2.37.4-1+b116:09
Copenhagen_Bramoh and i just got a gui from snap-store16:09
Copenhagen_Bramlike, 15 minutes to half an hour after i started it16:09
ograi think it pulls all metadata from some remote location on first run or some such16:10
ogra2.37 is rather old, is that also debian ?16:10
Copenhagen_Bramyeah, i'll do a sudo apt upgrade16:11
Copenhagen_Bramso the whole point of me installing snap-store was I was hoping there'd be some permission sliders16:11
Copenhagen_Brambut i'm not seeing any for solarus16:11
ogra(it is likely correct that these interfaces do not exist in that old snapd, that probably also has some effect on the startup speed)16:11
Copenhagen_Brami want to enable permissions for joystick detection for the package solarus16:12
ograsnap connections solarus16:12
ograthat should output all interaes that snap has enabled16:12
ograand show if they are connected16:12
Copenhagen_Brami did, nothing's connected16:12
ograso use "snap connect sloarus:<interface name>" to connect it16:13
ograi.e.: snap connect solarus:joystick16:13
Copenhagen_Bramerror: cannot resolve connection, slot snap name is empty16:13
ograhmm, you shouldnt need to define a slot name for jyostick normally16:14
Copenhagen_Bramis it possible to update snap with snap?16:15
ograi just quickly installed solarus here and the above command definitely works for me16:15
ogra$ snap connect solarus:joystick16:16
Copenhagen_Bramthis is interesting, on my other laptop where snap version says 2.45, I have snap 2.37 installed with apt16:16
ogra$ snap connections solarus|grep joy16:16
ograjoystick            solarus:joystick        :joystick        manual16:16
ograand it shows as manually connected16:16
ograyeah, snapd can update itself from the snapd snap16:16
ogra(and will re-execute itself into the snap version on startup)16:17
Copenhagen_Bramerror: snap "snap" not found16:17
ograwhat did you try ß16:18
Copenhagen_Bramoh snapd16:18
Copenhagen_Bramnot snap16:18
Copenhagen_Bramerror: cannot install "snapd": cannot install snapd snap on a model without a base snap yet16:19
ogratry: snap install core18 snapd16:20
ogra(core18, core and cor20 are base snaps)16:21
Copenhagen_Bramsnap list shoes core18 is already installed16:21
ograoh, then i dont know16:21
Copenhagen_Bramwhat if i install core instead of core18?16:22
* ogra is a spoiled ubuntu user ... doesnt have to jump through such hoops here 🙂16:22
ogratry it, yeah16:22
Copenhagen_Bramare there snap repos other than canonical's repo?16:23
Copenhagen_Bramso flatpak is more decentralized?16:23
ogradunno, i'd call it fragmented 🙂16:24
Copenhagen_Bramwell it's fine until canonical starts pushing developers around by threatening to take apps of the snap repo16:25
Copenhagen_Bramthat's what apple does16:25
ograwell, apple has a business model around selling single apps ... canonical doesnt16:26
ogra(canonical sells sub-stores to business customers ... i doubt the apple model will ever be interesting for the global store)16:27
ograthough there is https://forum.snapcraft.io/t/apps-that-promote-hate-speech-and-violence-dissenter-browser/19537 ...16:28
ograin which case i think it is a really good thing that there is a central store to avoid spreading of such software16:29
Copenhagen_BramWhat does "Waiting for server to restart" mean? Do I have to restart my computer now?16:42
Copenhagen_Bramoh nvm16:43
Copenhagen_BramAlright, let's see if my xbox controller will work on zelda mystery of solarus now16:45
Copenhagen_BramIt works!!!16:47
ograCopenhagen_Bram, congrats17:16
zygaijohnson: if you want to then https://github.com/snapcore/snapd/pull/9446 is ready, but I think we would still like a review fro jamesh for the desktop elements17:29
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>17:29
ijohnsonzyga: ack maybe I will look then tomorrow17:45
ijohnsonah that's the one I've looked at already17:45
mupPR snapcraft#3332 closed: storeapi: remove bindings for history <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3332>19:12
mupPR snapcraft#3334 opened: package repositories: improve error handling <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3334>19:22
* ijohnson EODs21:11
Copenhagen_BramDoes the latest version of snappy resume downloads if interrupted?21:39
Copenhagen_BramI have slow internet right now, and I had to run `until sudo snap install solarus; do sleep 1; done` to get solarus installed. It still filled my screen with many 'connection reset by peer' errors, until it finally was lucky enough to finish the download without an error21:40
Copenhagen_BramI wish developers wouldn't assume everybody has at least 1MB/s speed21:41
ijohnsonCopenhagen_Bram: snapd should auto-retry refreshes, I don't know if we have the same logic for installs, could file a bug on launchpad ?22:04

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!