[06:15] <mborzecki> morning
[06:30] <mborzecki> mvo: hey
[06:30] <mvo> good morning mborzecki !
[07:06] <zyga> o/
[07:06] <zyga> good morning
[07:08]  * zyga starts the day with https://github.com/snapcore/snapd/pull/9446
[07:08] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[07:13] <pstolowski> mornings
[07:15] <zyga> :-)
[07:20] <mborzecki> zyga: pstolowski: hey
[07:21] <pstolowski> o/
[07:39] <mborzecki> pedronis: hi, shall we have a chat at 10?
[07:39] <pedronis> mborzecki: I have the desktop meeting at 10
[07:39] <mborzecki> pedronis: i can do now if you're not busy :)
[07:39] <pedronis> I can I suppose
[07:39] <mborzecki> ok, heading to standup HO
[08:38] <zyga> mvo, https://forum.snapcraft.io/t/snapd-localisation/20696 (via jamesh)
[08:42] <mvo> zyga: thank you! yeah, we should totally tackle this one
[08:42] <mvo> zyga: and when I say we I should probably say I
[08:42] <mvo> zyga: added to trello, have some things now but will look at it soon
[08:51] <zyga> jamesh, building now, I'll just test it quickly on my system
[08:55] <jamesh> zyga: awesome!
[09:03] <zyga> very tentative https://github.com/snapcore/snapd/compare/master...zyga:feature/share-x11-sockets?expand=1
[09:13] <dot-tobias> hi everyone
[09:19] <zyga> jamesh, 9530 tested locally
[09:19] <zyga> no tests or anything
[09:23] <mup> PR snapd#9530 opened: interfaces: x11 shares hosts /tmp/.X11-unix/ <Created by zyga> <https://github.com/snapcore/snapd/pull/9530>
[09:28] <mup> PR snapd#9531 opened: tests: add a unit test for UpdateMany where a single snap fails <Created by stolowski> <https://github.com/snapcore/snapd/pull/9531>
[09:29] <zyga> jamesh, asked amurray for review
[09:35] <pedronis> pstolowski: comment in 9531, thanks for it
[09:38] <pstolowski> pedronis: sure, thanks for the comment
[09:40] <jamesh> zyga: I've left some initial comments.
[09:41] <zyga> thx
[09:42] <zyga> jamesh, yeah, I agree with all that you said
[09:42] <zyga> jamesh, note that the mount point cannot be removed or renamed so at least that part should be safe
[09:42] <jamesh> zyga: hmm.  I thought I remembered being able to move a bind mountpoint in the past
[09:44] <dot-tobias> Is snapcraft's “build” parameter currently unsupported with the multipass build provider? When I shell into the VM and run `snapcraft build my-part` it works; the same command from the macOS host results in a complete build.
[09:55] <zyga> jamesh, I think you can move with MS_MOVE but not otherwise
[09:57] <pstolowski> mvo: do you think any of the helpers from https://github.com/snapcore/snapd/pull/9457 makessense? if not, i'll close it. they are a bit heavy
[09:57] <mup> PR #9457: [RFC] o/snapshotstate: test for roundtrip with corrupted zip file inside exported snapshot <Created by stolowski> <https://github.com/snapcore/snapd/pull/9457>
[10:00] <jamesh> zyga: ah.  It's the source directory you're free to move
[10:11] <jamesh> zyga: One more question on the PR, about what happens when the slot snap's private tmp directory doesn't exist
[10:12] <zyga> jamesh, snap-update-ns will create it
[10:12] <jamesh> zyga: sure, but will it create it correctly?
[10:12] <zyga> jamesh, there's some logic around this but it can be done
[10:13] <zyga> there are differences between source/destination
[10:13] <zyga> (for good reason)
[10:13] <zyga> but it can be done
[10:16] <zyga> jamesh, the only gotcha is https://github.com/snapcore/snapd/blob/master/cmd/snap-update-ns/change.go#L209
[10:17] <zyga> this needs adjusting
[10:17] <zyga> to take Assumptions into account
[10:17] <zyga> so that if we can write to a location, we can just do it
[10:18] <jamesh> zyga: one last horrible case: what if an x11 plug is connected to an x11 slot of the same snap?
[10:18] <zyga> jamesh, that's also ok
[10:18] <zyga> jamesh, it will mount /tmp/.X11-unix over itself
[10:18] <zyga> jamesh, createPath used there takes assumptions alreadyu
[10:18] <amurray> zyga: how urgent is 9530?
[10:19] <jamesh> zyga: and maybe make it read only
[10:19] <zyga> jamesh, and /tmp is whitelisted
[10:19] <zyga> amurray, I defer to jamesh
[10:19] <amurray> I realise X11 snaps are broken on wayland on groovy so I am guessing urgent-ish but since this is now a 0day SRU for snapd can it wait till next week?
[10:20] <zyga> amurray, I think so
[10:20] <zyga> jamesh: https://github.com/snapcore/snapd/blob/master/cmd/snap-update-ns/change.go#L112 is the relevant point
[10:20] <zyga> we use assumptions object to compute the restrictions for the path we are about to create (/tmp/.X11-unix)
[10:20] <zyga> and then pass the restrictions to MkdirAll
[10:21] <amurray> ok let me know if it gets more urgent otherwise I'll take a look on Monday (or perhaps we'll be lucky and I'll get some time tomorrow)
[10:21] <zyga> amurray, +1
[10:21] <zyga> amurray, it's not for this release
[10:21] <jamesh> amurray: I've got an upstream PR to fix Mutter 3.38.  If that patch is accepted and pushed out to existing distros with Gnome 3.38.x (currently Ubuntu 20.10 and beta Fedora?), then it is "in the next 6 months" priority.  If we can't get the patch rolled out, then fairly soon
[10:21] <amurray> jamesh: yeah I saw that (and it seems upstream is not super motivated?)
[10:22] <zyga> jamesh, finally restrictions get passed to MpPrefix and MkDir in which both check if creating the directory is allowed (e.g. https://github.com/snapcore/snapd/blob/b2e238d229b8f4a686122ec6543842c97b8b25c3/cmd/snap-update-ns/utils.go#L175)
[10:22] <jamesh> amurray: I think there's a very good chance that it'll make it into the 3.38.x branch
[10:22] <amurray> oh nice
[10:22] <jamesh> amurray: there's some people who'd prefer the abstract sockets didn't exist period, but it hasn't just broken snaps
[10:24] <jamesh> amurray: I think they'll consider removing them as a conscious choice in Gnome 4.0
[10:55]  * pstolowski lunch
[11:00] <zyga> brb
[11:00] <mup> PR snapcraft#3331 closed: spread tests: move package-repositories test snaps into own dir <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3331>
[11:01] <mup> PR snapcraft#3332 opened: storeapi: remove bindings for history <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3332>
[11:14] <mvo> pstolowski: was in various meeting, I have a look later today/tomorrow
[11:21] <pedronis> ijohnson: I reviewed 9489, the last small changes seem a bit off to me, also seems tests never started
[11:23] <zyga> re
[11:45] <ijohnson> pedronis: I'll have a look after our meeting, /me is still having breakfast
[11:54] <pedronis> pstolowski: did a pas on #9527, some questions there
[11:54] <mup> PR #9527: o/snapstate: implement undo handler for unlink-snap <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9527>
[11:59] <mup> PR snapd#9532 opened: tests: clean systems.sh helper and migrate last set of tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9532>
[12:07] <pstolowski> pedronis: thanks
[12:56] <zyga> mvo_, I've updated https://github.com/snapcore/snapd/pull/9446 with lots of tests
[12:56] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[12:57] <zyga> mvo_, I think it needs a second review now
[12:57] <zyga> mvo_, and I can follow-up with removal of warnings
[12:58] <zyga> mvo_, I'd also like to add very basic persistency
[12:59] <zyga> mvo_, so that old message, for a given snap, is updated instead of appended
[12:59] <zyga> mvo_, that will work fine for as long as you don't log out
[12:59] <mup> PR snapd#9533 opened: tests: new systemd-state tool <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9533>
[12:59] <zyga> and notifications are not persistent across logout, so that seems perfect to me
[12:59] <zyga> mvo_, we can also discard the notification when the snap does refresh
[13:06] <mup> PR snapcraft#3321 closed: meta: add error check for "command not found" <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3321>
[13:16] <mup> PR snapcraft#3333 opened: specifications: finalization of package repositories spec <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3333>
[13:59] <mborzecki> errands time
[14:12] <cachio> zyga, hey, could you please take a quick look to #9414
[14:12] <mup> PR #9414: tests: new nested tool <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9414>
[14:12] <cachio> I update based on your comments
[14:40] <zyga> back from lunch
[14:40] <zyga> cachio, sure
[14:40] <cachio> zyga, tx
[14:44] <zyga> small errand, need to order some lights
[14:44] <zyga> then back to reviews
[14:51] <zyga> cachio, https://github.com/snapcore/snapd/pull/9414#pullrequestreview-514814755
[14:51] <mup> PR #9414: tests: new nested tool <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9414>
[15:30] <zyga> mvo, I have two follow-up branches that remove warnings on inhibited refreshes
[15:31] <mvo> zyga: \o/
[15:31] <zyga> mvo, and re-factor inhibitRefresh itself, to remove some duplication and explain the flow better
[15:31] <mvo> zyga: I guess you just need a second review for the initial one
[15:31] <zyga> https://github.com/snapcore/snapd/pull/9446 needs the 2nd review
[15:31] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[15:31] <zyga> exactly so
[15:32] <zyga> perhaps jamesh could do a review of that branch?
[15:33] <zyga> or ian, not sure if anyone has time
[15:39]  * zyga EODs
[15:40] <pedronis> I think jamesh reviewing #9446 if he can would be great
[15:40] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[15:40] <zyga> yeah
[15:40] <zyga> definitely the best person with the right insight
[15:44] <ijohnson> zyga: you can request a review from me, I need to be doing more reviews really :-)
[15:44] <ijohnson> pedronis: I updated #9489 is ready for a re-review
[15:44] <mup> PR #9489: daemon,client: write and read a maintenance.json file for when snapd is shut down <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9489>
[15:44] <ijohnson> still no idea why the tests never started there but they are running now so /shrugs
[15:48] <ijohnson> pedronis: also is this TODO:UC20: 1.0 material ? https://github.com/snapcore/snapd/blob/master/cmd/snap-bootstrap/cmd_initramfs_mounts.go#L497
[15:48] <ijohnson> or is that todo immaterial now that we seal against the model ?
[15:51] <pedronis> because we measure the model is indeed not super relevant
[15:51] <pedronis> with ARM we'll need to do something about that though but probably before we get there anyway
[15:54] <ijohnson> pedronis: so not for 1.0 then ?
[15:54] <pedronis> indeed
[15:54] <ijohnson> ok
[15:54] <ijohnson> thanks for confirming
[16:00] <pedronis> ijohnson: I re-reviewed #9489, thanks for the fixes there
[16:00] <mup> PR #9489: daemon,client: write and read a maintenance.json file for when snapd is shut down <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9489>
[16:00] <pedronis> some small things
[16:00] <ijohnson> thanks I'll take a look in a second, working on 9418 right now
[16:01] <pedronis> thx
[16:05] <Copenhagen_Bram> Hello!
[16:05] <Copenhagen_Bram> For some reason, `snap-store` isn't creating a window
[16:07] <Copenhagen_Bram> When I installed it, I got: INFO snap "snap-store" has bad plugs or slots: appstream-metadata (unknown interface "appstream-metadata"); packagekit-control (unknown interface "packagekit-control")
[16:07] <ogra> whats the full output of "snap version" ?
[16:08] <Copenhagen_Bram> snap 2.45, snapd 2.45, series 16, debian 10, kernel 4.19.0-10-amd64
[16:09] <Copenhagen_Bram> wait, i ran that command in an ssh
[16:09] <Copenhagen_Bram> on this laptop snap and snapd are 2.37.4-1+b1
[16:09] <Copenhagen_Bram> oh and i just got a gui from snap-store
[16:09] <Copenhagen_Bram> like, 15 minutes to half an hour after i started it
[16:10] <ogra> i think it pulls all metadata from some remote location on first run or some such
[16:10] <Copenhagen_Bram> okay
[16:10] <ogra> 2.37 is rather old, is that also debian ?
[16:11] <Copenhagen_Bram> yeah, i'll do a sudo apt upgrade
[16:11] <Copenhagen_Bram> so the whole point of me installing snap-store was I was hoping there'd be some permission sliders
[16:11] <Copenhagen_Bram> but i'm not seeing any for solarus
[16:11] <ogra> (it is likely correct that these interfaces do not exist in that old snapd, that probably also has some effect on the startup speed)
[16:12] <Copenhagen_Bram> i want to enable permissions for joystick detection for the package solarus
[16:12] <ogra> snap connections solarus
[16:12] <ogra> that should output all interaes that snap has enabled
[16:12] <ogra> and show if they are connected
[16:12] <Copenhagen_Bram> i did, nothing's connected
[16:12] <ogra> *interfaces
[16:13] <ogra> so use "snap connect sloarus:<interface name>" to connect it
[16:13] <ogra> i.e.: snap connect solarus:joystick
[16:13] <Copenhagen_Bram> error: cannot resolve connection, slot snap name is empty
[16:14] <ogra> hmm, you shouldnt need to define a slot name for jyostick normally
[16:15] <Copenhagen_Bram> is it possible to update snap with snap?
[16:15] <ogra> i just quickly installed solarus here and the above command definitely works for me
[16:16] <ogra> $ snap connect solarus:joystick
[16:16] <ogra> $
[16:16] <Copenhagen_Bram> this is interesting, on my other laptop where snap version says 2.45, I have snap 2.37 installed with apt
[16:16] <ogra> $ snap connections solarus|grep joy
[16:16] <ogra> joystick            solarus:joystick        :joystick        manual
[16:16] <ogra> and it shows as manually connected
[16:16] <ogra> yeah, snapd can update itself from the snapd snap
[16:17] <ogra> (and will re-execute itself into the snap version on startup)
[16:17] <Copenhagen_Bram> error: snap "snap" not found
[16:18] <ogra> what did you try ß
[16:18] <ogra> ?
[16:18] <Copenhagen_Bram> oh snapd
[16:18] <Copenhagen_Bram> not snap
[16:18] <ogra> yeah
[16:19] <Copenhagen_Bram> error: cannot install "snapd": cannot install snapd snap on a model without a base snap yet
[16:20] <ogra> try: snap install core18 snapd
[16:21] <ogra> (core18, core and cor20 are base snaps)
[16:21] <Copenhagen_Bram> snap list shoes core18 is already installed
[16:21] <ogra> oh, then i dont know
[16:22] <Copenhagen_Bram> what if i install core instead of core18?
[16:22]  * ogra is a spoiled ubuntu user ... doesnt have to jump through such hoops here 🙂
[16:22] <ogra> try it, yeah
[16:23] <Copenhagen_Bram> are there snap repos other than canonical's repo?
[16:23] <ogra> nope
[16:23] <Copenhagen_Bram> so flatpak is more decentralized?
[16:24] <ogra> dunno, i'd call it fragmented 🙂
[16:25] <Copenhagen_Bram> well it's fine until canonical starts pushing developers around by threatening to take apps of the snap repo
[16:25] <Copenhagen_Bram> that's what apple does
[16:26] <ogra> well, apple has a business model around selling single apps ... canonical doesnt
[16:27] <ogra> (canonical sells sub-stores to business customers ... i doubt the apple model will ever be interesting for the global store)
[16:28] <ogra> though there is https://forum.snapcraft.io/t/apps-that-promote-hate-speech-and-violence-dissenter-browser/19537 ...
[16:29] <ogra> in which case i think it is a really good thing that there is a central store to avoid spreading of such software
[16:42] <Copenhagen_Bram> What does "Waiting for server to restart" mean? Do I have to restart my computer now?
[16:43] <Copenhagen_Bram> oh nvm
[16:45] <Copenhagen_Bram> Alright, let's see if my xbox controller will work on zelda mystery of solarus now
[16:47] <Copenhagen_Bram> It works!!!
[17:16] <ogra> Copenhagen_Bram, congrats
[17:28] <zyga> re\
[17:29] <zyga> ijohnson: if you want to then https://github.com/snapcore/snapd/pull/9446 is ready, but I think we would still like a review fro jamesh for the desktop elements
[17:29] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[17:45] <ijohnson> zyga: ack maybe I will look then tomorrow
[17:45] <ijohnson> ah that's the one I've looked at already
[19:12] <mup> PR snapcraft#3332 closed: storeapi: remove bindings for history <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3332>
[19:22] <mup> PR snapcraft#3334 opened: package repositories: improve error handling <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3334>
[21:11]  * ijohnson EODs
[21:39] <Copenhagen_Bram> Does the latest version of snappy resume downloads if interrupted?
[21:40] <Copenhagen_Bram> I have slow internet right now, and I had to run `until sudo snap install solarus; do sleep 1; done` to get solarus installed. It still filled my screen with many 'connection reset by peer' errors, until it finally was lucky enough to finish the download without an error
[21:41] <Copenhagen_Bram> I wish developers wouldn't assume everybody has at least 1MB/s speed
[22:04] <ijohnson> Copenhagen_Bram: snapd should auto-retry refreshes, I don't know if we have the same logic for installs, could file a bug on launchpad ?