mupPR snapd#9534 opened: many: update to secboot v1 <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9534>00:12
RingtailedFoxhiya... is there a way to compile snapd from source since snap isn't available for my distro?02:18
mupPR core20#91 opened: hooks: add /var/lib/snapd/save <Created by bboozzoo> <https://github.com/snapcore/core20/pull/91>05:57
zygagood morning06:29
zygajamesh, o/ do you think you could look at the notifications we send in https://github.com/snapcore/snapd/pull/944606:30
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>06:30
jameshzyga: okay06:31
zygajamesh, the interesting code is in rest_api.go06:31
zygajamesh, there we construct and make the dbus calls06:32
zygahere: https://github.com/snapcore/snapd/pull/9446/files#diff-fb842538ad8c6ce2555e74f75a07eadadc9f318b2ddd5106b18e83f285be17b5R21506:32
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>06:32
zygameanwhile I will iterate on https://github.com/snapcore/snapd/pull/953006:33
mupPR #9530: interfaces: x11 shares hosts /tmp/.X11-unix/ <Needs security review> <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/9530>06:33
zygahey mvo06:46
zygamvo, I've picked up the x11 socket PR from yesterday as you've marked it as critical06:47
zygamvo, once done I will go back to boot protocol06:47
mvogood morning zyga06:50
mvozyga: did security react?06:50
zygamvo, about x11?06:51
zygamvo, yes, yesterday, there will be a review next week06:51
mvozyga: ok06:51
zygaI'm working on comments from jamesh - mainly to cover non-implicit slots and self-connections06:52
mborzeckimvo: hi, can you take a look at https://github.com/snapcore/core20/pull/91 ?06:54
mupPR core20#91: hooks: add /var/lib/snapd/save <Created by bboozzoo> <https://github.com/snapcore/core20/pull/91>06:54
mvomborzecki: sure06:56
mvomborzecki: fwiw, I think it's fine if snapd auto-creates this dir if it's missing in it's code06:57
mborzeckimvo: also, if we add an entry to fstab systemd-mount should create destination directory as well06:58
mvomborzecki: snap-bootstrap will do the mounting, yes? then that could also create the dir if missing. I mean, adding in core20 is totally fine06:59
mborzeckimvo: snap-bootstrap will do a mount under /run/mnt/ubuntu-save for now07:02
mvomborzecki: aha, yes, make sense07:06
zygajamesh, do you think we can use a read-only bind mount for .X11-unix?07:07
jameshzyga: I think so.  There's zero reason for clients to modify that directory, and the socket should still work07:08
zygaI'll code it as such and give it a try07:08
jameshand we definitely don't want snaps to go and delete those sockets from the host system07:09
zygayeah, that's a good point07:09
zygajamesh, could you look at the general idea I've added to https://github.com/snapcore/snapd/pull/9530/files again please07:34
mupPR #9530: interfaces: x11 shares hosts /tmp/.X11-unix/ <Needs security review> <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/9530>07:34
zygajamesh, it lacks tests and I did not verify it to work correctly yet07:34
zygajamesh, but I want to see if we are aligned on the direction07:35
* jamesh looks07:35
* zyga goes for quick breakfast07:37
mupPR snapd#9532 closed: tests: clean systems.sh helper and migrate last set of tests <Simple πŸ˜ƒ> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9532>07:44
pedroniszyga: hi, should we chat about splitting the export manager PR?08:03
zygapedronis, yes08:03
zygapedronis, I had several ideas08:03
zygapedronis, a lot of the noise is related to the addition of the new tasks08:03
zygapedronis, so we could split the export manager so that new tasks are not used yet08:04
zygapedronis, and only later on add them08:04
zygapedronis, the spread test is another natural boundary08:04
zygapedronis, what do you think?08:04
pedronisso manager + tasks but not used,  use of tasks and rest but, last snap-confine changes + spread tests ?08:06
zygapedronis, oh right, snap-confine is another natural chunk08:06
zygayeah, that is very doable, there will be still some large patches but definitely smaller than now08:07
zygajamesh, I have an idea about the permissions08:08
zygajamesh, I'll work on that today, let's sync on Monday08:08
zygajamesh, I'm sure this will work08:08
jameshzyga: fair enough08:08
zygajamesh, the idea is to give snap-update-ns knowledge about implicit permissions08:09
zygajamesh, so it can create those segment by segment08:09
zygajamesh, and use values matching some patterns unless explicit mode is provided08:09
jameshzyga: also, a regular user running in the slot snap's sandbox should be able to write to /tmp/.X11-unix08:09
zygait'd be all in snap-update-ns08:09
pedroniszyga: I expect the first one to be fairly large, at least it will all be new code08:09
jameshthat seems reasonable08:09
pedroniszyga: in one place08:09
zygapedronis, yes, it's all of the export manager08:10
zygapedronis, we may need to register the link participant along with the new tasks but I think it will be manageable08:10
pedronisgithub doesn't seem very responsive here, stalling opening comments08:12
zygagithub status is all green, hopefully just local routing problems08:14
pedronisyea, weird, is not all comments08:20
mborzeckipedronis: hi, can you take a look at this bit later on https://github.com/snapcore/secboot/pull/124 ?08:31
mupPR secboot#124: Support setting LUKS2 metadata and keyslots area sizes when creating containers <Created by bboozzoo> <https://github.com/snapcore/secboot/pull/124>08:31
pstolowskimvo, pedronis could you grab a few old snapd snaps (I think >=2.42, which was aroud Oct 2019) for the tests we talked about?08:38
pstolowskiand corresponding core18s I suppose08:39
dot-tobiasgood morning08:44
zygao/ dot-tobias08:44
pedronispstolowski: 5760 would be 2.42.5 for amd64, does that work?08:46
pstolowskipedronis: yes that should be fine, it's Dec 2019, old enough but no too old08:48
dot-tobias\o zyga 😊 I revisited the `layout` section in one of my snaps, that wouldn't have been possible without all your work on layouts. Still grateful that I started the snap around that time πŸ˜„08:49
zygadot-tobias, that's so nice to hear, thank you :)08:50
pedronispstolowski: core18 is messier, its version don't tell easily if something is a stable release or not08:52
zygapedronis, we could take core18 from CD images perhaps08:54
zygabut yeah, it would be good to have release history08:54
pstolowskipedronis: Roger's pi3 has core18 20190723 rev 1076, but I guess it's not easy to remap to amd6408:55
pedronisno, that is fine08:55
pedronisbut that is much older than the snapd we are taking08:55
zygapstolowski, btw, once gadget assets from kernel are done, we could update roger's pi08:56
pstolowskipedronis: right. we could go back to 2.39.x (which was Mar-Jun 2019). auto-connect was way older, from 201809:00
pedronispstolowski: need to do something else, will come back to this09:01
zygajamesh, if you are still around, I pushed my idea for making the permissions right09:16
jameshzyga: okay.  In a meeting right now, but will look afterwards09:16
mvopstolowski: I'm back, I can also help with downloading09:18
zygathanks, I'll adjust the remaining comment and work towards having proper end-to-end tests as well09:18
zygabut first, tea, it's cold, raining and warm tea is cheaper than heating09:18
pstolowskimvo: ty!09:27
mvopstolowski: do you want a released version or is 2.38+git831.g9ac7e3e okay? or should it be 2.39?09:28
pstolowskimvo: no strong opinion, but i'd stick to released versions09:30
mvopstolowski: sure, let me try to find the right revisions for this09:31
mvopstolowski: it looks like the store api makes it hard to find things :(09:31
mvopstolowski: old things09:32
dot-tobiasDo launchpad builders still get their internet connection cut after 2 hours? I have four parts that I need to build in sequence; the third part takes > 2h to build on ARM. If the connection is cut, snapcraft won't be able to download the sources for part 4.09:32
zygadot-tobias, interesting, I guess that's a question for the launchpad team, I was not aware of that limitation09:32
mvopstolowski: shared the .git version of 2.38 with you need to figure out how to get the store to filter the history by branch, then I can see the revisions for released versions09:33
dot-tobiaszyga: Yeah, last time I ran into this was > 1 year ago, so I thought I'd re-check. Who might I ping about this, as it cjp256 is probably09:34
dot-tobias(that sentence should've continued) … not up yet09:35
pstolowskimvo: thanks, maybe put it on gdrive and share with cachio as well, we will want those files in gcloud storage09:35
pedronispstolowski: I found a stable core18 from 2019-12-04, does that work ?09:36
pedronismvo: I'm working on findind snaps for pstolowski09:36
pstolowskipedronis: yes, that should be fine with 2.42.509:37
mvopedronis: ok09:38
pedronispstolowski: https://people.canonical.com/~pedronis/old-snapd/  let me know if you need something older instead09:44
pstolowskipedronis: thanks09:44
jameshzyga: left some comments on https://github.com/snapcore/snapd/pull/9446#pullrequestreview-515450485.  Looking over the x11 PR again next10:19
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>10:19
zygajamesh, thanks10:21
zygaI've started testing it, fixed apparmor permissions10:21
zygajamesh, thank you for the review!10:26
zygasome apparmor woes10:33
zygagot that to work10:37
zygajamesh, if you are looking10:39
zygajamesh, I've pushed a fix for apparmor permissions to x1110:39
zygamvo, I'll park https://github.com/snapcore/snapd/pull/9530 for now and get back to notifications10:45
mupPR #9530: interfaces: x11 shares hosts /tmp/.X11-unix/ <Needs security review> <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/9530>10:45
mvozyga: ok10:46
zygaafk / walk11:01
mupPR snapd#9535 opened: o/snapstate: generate snapd snap wrappers again after restart on refresh <Bug> <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9535>11:14
zygabut okay11:35
zygajamesh, thank you for the reviews!11:46
pedronisjamesh: thanks for the review indeed11:51
zygajamesh, I've updated https://github.com/snapcore/snapd/pull/9446 based on your comments12:04
mupPR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>12:04
zyga(it's late so I don't expect you to review it today)12:05
zygawe need one more review anyway12:05
mborzeckidegville: hi, the gdb docs look great, i've left some tips that may be worth adding at the bottom https://forum.snapcraft.io/t/using-gdb-and-gdbserver/2071812:12
degvillemborzecki: brilliant, thank you! I'll add them!12:13
cmatsuokacachio: have you seen this error before? https://pipelines.actions.githubusercontent.com/xS8oSnypZkPEQZqiZgDaRp2kdvQJKbOY08TesHp7E8vn7g4hYR/_apis/pipelines/1/runs/15660/signedlogcontent/85?urlExpires=2020-10-23T12%3A23%3A33.6075691Z&urlSigningMethod=HMACV1&urlSignature=6j4OihznEJx3htX02RAWE1Po54U1GfsTOZ9dYr6a5Po%3D (look for "certificate")12:23
cachiocmatsuoka, checking12:24
cachiouri expired12:24
cachiocmatsuoka, dou you have a pr number?12:25
cmatsuokait's #953412:25
mupPR #9534: many: update to secboot v1 <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9534>12:25
cachiocmatsuoka, which syste?12:27
cmatsuokaand others12:28
pstolowskicachio: hey, could you upload https://people.canonical.com/~pedronis/old-snapd/ to GC so I can use it in spread test?12:31
cachiopstolowski, sure12:31
cachiocmatsuoka, first time I see that error12:32
cachioperhaps a repo issue at maze-io12:33
cachiopstolowski, both core18 and snpad snapsΒ‘12:34
cmatsuokacachio: it seems so, I 'll investigate12:35
pstolowskicachio: yes12:35
zygamborzecki, can you open bootstate16.go on line 102 please: is word "threading" there a mistake?12:38
mborzeckizyga: maybe it was meant to be treading (as in steppin over?)12:39
zygamakes sense, thanks12:40
mborzeckimhm, yeah, most likely, better if one of the native speakers confirms :P12:40
zygaI'll correct that12:40
pedronismborzecki: zyga: I wrote that12:41
zygapedronis, should it say "treading"?12:42
pedronisif you want to make it less, obscure s/threading/passing/12:42
zygaso what does it mean, right now it doesn't read right12:42
zygayeah, I think that's better12:43
zygathreads != treads12:43
mborzeckiheh languages are fun, not just the programming ones :P12:43
pedronisto be clear I think the verb is fine (it's used like that in other programming contexts) but it's probably obscure12:45
zygathreading as in providing?12:45
pedronisthreading as in passing something around that also ties things together12:46
pedroniszyga: it's probably more common in the compiler/functional world, but if you google for "threading state around" you'll find some computer science text using that expression12:49
zygaI see, I didn't know that12:50
zygabut probably a bit confusing to be honest, given that threading has such a strong semantic in computing now12:50
zygaoh my, almost standup time12:51
mupPR snapd#9536 opened: RFC: bootloader ping/pong protocol <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9536>13:05
zygamvo, pedronis: something I'd love to discuss if you have a few minutes after the standup %13:06
mvozyga: we have a secboot thing after but we can squeeze you in probably somehow13:06
zygaI just read that mvo said "boot"13:07
zygamust be yes ;)13:07
=== probono9 is now known as probono
zygare (back with coffee)13:48
zygaI'll chop export manager now13:48
mvozyga: \o/ thank you!13:57
mvoijohnson: what was the url for the enumerating disk work you need review/feedback for from foundatoins?14:00
mvoijohnson: I will put it on the agenda for todays meeting14:00
mvopstolowski: current meeting overruning, we may be late for tgif (cc ijohnson )14:00
ijohnsonmvo: it's a lp bug let me grab it14:00
mvoijohnson: ta!14:01
pstolowskimvo: ack14:01
ijohnsonmvo: last comment on https://bugs.launchpad.net/snapd/+bug/190084214:01
mupBug #1900842: partitions can have different major numbers <core20> <snapd:In Progress by anonymouse67> <https://launchpad.net/bugs/1900842>14:01
mvoijohnson: ta14:04
mborzeckizyga: btw. i have govendor sync && rm vendor dirs in a loop on a tw system in gcp, it's been running for 1h+ now14:31
zygamborzecki, I really wonder what's the magic that breaks there14:32
mborzeckimaybe it's something with the hosts14:32
zygaijohnson, btw, speaking of politics, what's up witch McConnell?14:32
ijohnsonhaha what's not up with McConnell14:33
zygahe could play in a harry potter zombie movie now14:33
ijohnsonhe could play any villain in any movie ever probably14:35
zyga"ONE MILLION DOLLARS" in evil voice14:36
ijohnsonoh wow actually there is something up with him he's all different colors now14:36
zygayeah, that's what I meant14:36
mupPR snapd#9527 closed: o/snapstate: implement undo handler for unlink-snap <Needs Samuele review> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9527>14:40
* zyga -> lunch14:42
mupPR snapd#9537 opened: tests: also check snapst.Current in undo-unlink tests <Simple πŸ˜ƒ> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9537>14:45
* cachio lunch15:05
* zyga EODs16:05
mupPR snapd#9538 opened: o/snapstate/catalogrefresh.go: don't refresh catalog in install mode uc20 <Simple πŸ˜ƒ> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9538>16:06
cachiozyga, do you have the tumbleweed links?16:10
mupPR snapd#9414 closed: tests: new nested tool <Run nested> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9414>16:16
mupPR snapd#9373 closed: snap: add new `snap recovery --show-recovery-key` option <Needs Samuele review> <Run nested> <Squash-merge> <UC20> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9373>16:36
mupPR snapd#9539 opened: many: add /v2/system-recovery-key API and client <Created by mvo5> <https://github.com/snapcore/snapd/pull/9539>16:36
* cachio afk errands16:42
mupPR snapd#9540 opened: snap: add new `snap recovery --show-recovery-key` optio <Created by mvo5> <https://github.com/snapcore/snapd/pull/9540>16:51
=== ubott2 is now known as ubottu
=== seyeongkim_ is now known as seyeongkim
=== Wimpress_ is now known as Wimpress
=== lfaraone_ is now known as lfaraone
=== philroche_ is now known as philroche
=== marosg_ is now known as marosg
mupPR snapcraft#3325 closed: snapcraftctl: add checks for empty string for set-version & set-grade <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3325>18:04
mupPR snapcraft#3333 closed: specifications: finalization of package repositories spec <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3333>18:04
mupPR snapcraft#3334 closed: package repositories: improve error handling <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3334>18:04
mupPR snapcraft#3335 opened: cli: remove spaces from progressive metrics <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3335>20:19
mupPR snapd#9541 opened: osutil/disks: re-implement partition searching for disk w/ non-adjacent parts <Bug> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9541>21:12
* ijohnson EOWs22:41
mupBug #1901262 opened: Unable to mount NTFS drives with write support <ntfs> <ntfs-3g> <Snappy:New> <https://launchpad.net/bugs/1901262>23:32

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!