[00:12] <mup> PR snapd#9534 opened: many: update to secboot v1 <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9534>
[02:18] <RingtailedFox> hiya... is there a way to compile snapd from source since snap isn't available for my distro?
[05:36] <mborzecki> morning
[05:57] <mup> PR core20#91 opened: hooks: add /var/lib/snapd/save <Created by bboozzoo> <https://github.com/snapcore/core20/pull/91>
[06:29] <zyga> good morning
[06:30] <zyga> jamesh, o/ do you think you could look at the notifications we send in https://github.com/snapcore/snapd/pull/9446
[06:30] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[06:31] <jamesh> zyga: okay
[06:31] <zyga> jamesh, the interesting code is in rest_api.go
[06:32] <zyga> jamesh, there we construct and make the dbus calls
[06:32] <zyga> here: https://github.com/snapcore/snapd/pull/9446/files#diff-fb842538ad8c6ce2555e74f75a07eadadc9f318b2ddd5106b18e83f285be17b5R215
[06:32] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[06:33] <zyga> meanwhile I will iterate on https://github.com/snapcore/snapd/pull/9530
[06:33] <mup> PR #9530: interfaces: x11 shares hosts /tmp/.X11-unix/ <Needs security review> <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/9530>
[06:46] <zyga> hey mvo
[06:47] <zyga> mvo, I've picked up the x11 socket PR from yesterday as you've marked it as critical
[06:47] <zyga> mvo, once done I will go back to boot protocol
[06:50] <mvo> good morning zyga
[06:50] <mvo> zyga: did security react?
[06:51] <zyga> mvo, about x11?
[06:51] <zyga> mvo, yes, yesterday, there will be a review next week
[06:51] <mvo> zyga: ok
[06:52] <zyga> I'm working on comments from jamesh - mainly to cover non-implicit slots and self-connections
[06:52] <mvo> ta
[06:54] <mborzecki> mvo: hi, can you take a look at https://github.com/snapcore/core20/pull/91 ?
[06:54] <mup> PR core20#91: hooks: add /var/lib/snapd/save <Created by bboozzoo> <https://github.com/snapcore/core20/pull/91>
[06:56] <mvo> mborzecki: sure
[06:57] <mvo> mborzecki: fwiw, I think it's fine if snapd auto-creates this dir if it's missing in it's code
[06:58] <mborzecki> mvo: also, if we add an entry to fstab systemd-mount should create destination directory as well
[06:59] <mvo> mborzecki: snap-bootstrap will do the mounting, yes? then that could also create the dir if missing. I mean, adding in core20 is totally fine
[07:02] <mborzecki> mvo: snap-bootstrap will do a mount under /run/mnt/ubuntu-save for now
[07:06] <mvo> mborzecki: aha, yes, make sense
[07:07] <zyga> jamesh, do you think we can use a read-only bind mount for .X11-unix?
[07:07] <pstolowski> morning
[07:08] <jamesh> zyga: I think so.  There's zero reason for clients to modify that directory, and the socket should still work
[07:08] <zyga> I'll code it as such and give it a try
[07:09] <jamesh> and we definitely don't want snaps to go and delete those sockets from the host system
[07:09] <zyga> yeah, that's a good point
[07:34] <zyga> jamesh, could you look at the general idea I've added to https://github.com/snapcore/snapd/pull/9530/files again please
[07:34] <mup> PR #9530: interfaces: x11 shares hosts /tmp/.X11-unix/ <Needs security review> <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/9530>
[07:34] <zyga> jamesh, it lacks tests and I did not verify it to work correctly yet
[07:35] <zyga> jamesh, but I want to see if we are aligned on the direction
[07:35]  * jamesh looks
[07:37]  * zyga goes for quick breakfast
[07:44] <mup> PR snapd#9532 closed: tests: clean systems.sh helper and migrate last set of tests <Simple 😃> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9532>
[08:01] <zyga> re
[08:03] <pedronis> zyga: hi, should we chat about splitting the export manager PR?
[08:03] <zyga> pedronis, yes
[08:03] <zyga> pedronis, I had several ideas
[08:03] <zyga> pedronis, a lot of the noise is related to the addition of the new tasks
[08:04] <zyga> pedronis, so we could split the export manager so that new tasks are not used yet
[08:04] <zyga> pedronis, and only later on add them
[08:04] <zyga> pedronis, the spread test is another natural boundary
[08:04] <zyga> pedronis, what do you think?
[08:06] <pedronis> so manager + tasks but not used,  use of tasks and rest but, last snap-confine changes + spread tests ?
[08:06] <zyga> pedronis, oh right, snap-confine is another natural chunk
[08:07] <zyga> yeah, that is very doable, there will be still some large patches but definitely smaller than now
[08:08] <zyga> jamesh, I have an idea about the permissions
[08:08] <zyga> jamesh, I'll work on that today, let's sync on Monday
[08:08] <zyga> jamesh, I'm sure this will work
[08:08] <jamesh> zyga: fair enough
[08:09] <zyga> jamesh, the idea is to give snap-update-ns knowledge about implicit permissions
[08:09] <zyga> jamesh, so it can create those segment by segment
[08:09] <zyga> jamesh, and use values matching some patterns unless explicit mode is provided
[08:09] <jamesh> zyga: also, a regular user running in the slot snap's sandbox should be able to write to /tmp/.X11-unix
[08:09] <zyga> it'd be all in snap-update-ns
[08:09] <pedronis> zyga: I expect the first one to be fairly large, at least it will all be new code
[08:09] <jamesh> that seems reasonable
[08:09] <pedronis> zyga: in one place
[08:10] <zyga> pedronis, yes, it's all of the export manager
[08:10] <zyga> pedronis, we may need to register the link participant along with the new tasks but I think it will be manageable
[08:12] <pedronis> github doesn't seem very responsive here, stalling opening comments
[08:14] <zyga> github status is all green, hopefully just local routing problems
[08:20] <pedronis> yea, weird, is not all comments
[08:31] <mborzecki> pedronis: hi, can you take a look at this bit later on https://github.com/snapcore/secboot/pull/124 ?
[08:31] <mup> PR secboot#124: Support setting LUKS2 metadata and keyslots area sizes when creating containers <Created by bboozzoo> <https://github.com/snapcore/secboot/pull/124>
[08:32] <pedronis> yes
[08:38] <pstolowski> mvo, pedronis could you grab a few old snapd snaps (I think >=2.42, which was aroud Oct 2019) for the tests we talked about?
[08:39] <pstolowski> and corresponding core18s I suppose
[08:44] <dot-tobias> good morning
[08:44] <zyga> o/ dot-tobias
[08:46] <pedronis> pstolowski: 5760 would be 2.42.5 for amd64, does that work?
[08:48] <pstolowski> pedronis: yes that should be fine, it's Dec 2019, old enough but no too old
[08:49] <dot-tobias> \o zyga 😊 I revisited the `layout` section in one of my snaps, that wouldn't have been possible without all your work on layouts. Still grateful that I started the snap around that time 😄
[08:50] <zyga> dot-tobias, that's so nice to hear, thank you :)
[08:52] <pedronis> pstolowski: core18 is messier, its version don't tell easily if something is a stable release or not
[08:54] <zyga> pedronis, we could take core18 from CD images perhaps
[08:54] <zyga> but yeah, it would be good to have release history
[08:55] <pstolowski> pedronis: Roger's pi3 has core18 20190723 rev 1076, but I guess it's not easy to remap to amd64
[08:55] <pedronis> no, that is fine
[08:55] <pedronis> but that is much older than the snapd we are taking
[08:56] <zyga> pstolowski, btw, once gadget assets from kernel are done, we could update roger's pi
[09:00] <pstolowski> pedronis: right. we could go back to 2.39.x (which was Mar-Jun 2019). auto-connect was way older, from 2018
[09:01] <pedronis> pstolowski: need to do something else, will come back to this
[09:01] <pstolowski> np
[09:16] <zyga> jamesh, if you are still around, I pushed my idea for making the permissions right
[09:16] <jamesh> zyga: okay.  In a meeting right now, but will look afterwards
[09:18] <mvo> pstolowski: I'm back, I can also help with downloading
[09:18] <zyga> thanks, I'll adjust the remaining comment and work towards having proper end-to-end tests as well
[09:18] <zyga> but first, tea, it's cold, raining and warm tea is cheaper than heating
[09:27] <pstolowski> mvo: ty!
[09:28] <mvo> pstolowski: do you want a released version or is 2.38+git831.g9ac7e3e okay? or should it be 2.39?
[09:30] <pstolowski> mvo: no strong opinion, but i'd stick to released versions
[09:31] <mvo> pstolowski: sure, let me try to find the right revisions for this
[09:31] <mvo> pstolowski: it looks like the store api makes it hard to find things :(
[09:32] <mvo> pstolowski: old things
[09:32] <dot-tobias> Do launchpad builders still get their internet connection cut after 2 hours? I have four parts that I need to build in sequence; the third part takes > 2h to build on ARM. If the connection is cut, snapcraft won't be able to download the sources for part 4.
[09:32] <zyga> dot-tobias, interesting, I guess that's a question for the launchpad team, I was not aware of that limitation
[09:33] <mvo> pstolowski: shared the .git version of 2.38 with you need to figure out how to get the store to filter the history by branch, then I can see the revisions for released versions
[09:34] <dot-tobias> zyga: Yeah, last time I ran into this was > 1 year ago, so I thought I'd re-check. Who might I ping about this, as it cjp256 is probably
[09:35] <dot-tobias> (that sentence should've continued) … not up yet
[09:35] <pstolowski> mvo: thanks, maybe put it on gdrive and share with cachio as well, we will want those files in gcloud storage
[09:36] <pedronis> pstolowski: I found a stable core18 from 2019-12-04, does that work ?
[09:36] <pedronis> mvo: I'm working on findind snaps for pstolowski
[09:37] <pstolowski> pedronis: yes, that should be fine with 2.42.5
[09:38] <mvo> pedronis: ok
[09:44] <pedronis> pstolowski: https://people.canonical.com/~pedronis/old-snapd/  let me know if you need something older instead
[09:44] <pstolowski> pedronis: thanks
[10:19] <jamesh> zyga: left some comments on https://github.com/snapcore/snapd/pull/9446#pullrequestreview-515450485.  Looking over the x11 PR again next
[10:19] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[10:21] <zyga> jamesh, thanks
[10:21] <zyga> I've started testing it, fixed apparmor permissions
[10:26] <zyga> jamesh, thank you for the review!
[10:32] <zyga> sigh
[10:33] <zyga> some apparmor woes
[10:37] <zyga> woot
[10:37] <zyga> got that to work
[10:39] <zyga> jamesh, if you are looking
[10:39] <zyga> jamesh, I've pushed a fix for apparmor permissions to x11
[10:45] <zyga> mvo, I'll park https://github.com/snapcore/snapd/pull/9530 for now and get back to notifications
[10:45] <mup> PR #9530: interfaces: x11 shares hosts /tmp/.X11-unix/ <Needs security review> <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/9530>
[10:46] <mvo> zyga: ok
[11:01] <zyga> afk / walk
[11:14] <mup> PR snapd#9535 opened: o/snapstate: generate snapd snap wrappers again after restart on refresh <Bug> <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9535>
[11:35] <zyga> back
[11:35] <zyga> WET
[11:35] <zyga> but okay
[11:46] <zyga> jamesh, thank you for the reviews!
[11:51] <pedronis> jamesh: thanks for the review indeed
[12:04] <zyga> jamesh, I've updated https://github.com/snapcore/snapd/pull/9446 based on your comments
[12:04] <mup> PR #9446: overlord,usersession: initial notifications of pending refreshes <Created by zyga> <https://github.com/snapcore/snapd/pull/9446>
[12:05] <zyga> (it's late so I don't expect you to review it today)
[12:05] <zyga> we need one more review anyway
[12:12] <mborzecki> degville: hi, the gdb docs look great, i've left some tips that may be worth adding at the bottom https://forum.snapcraft.io/t/using-gdb-and-gdbserver/20718
[12:13] <degville> mborzecki: brilliant, thank you! I'll add them!
[12:23] <cmatsuoka> cachio: have you seen this error before? https://pipelines.actions.githubusercontent.com/xS8oSnypZkPEQZqiZgDaRp2kdvQJKbOY08TesHp7E8vn7g4hYR/_apis/pipelines/1/runs/15660/signedlogcontent/85?urlExpires=2020-10-23T12%3A23%3A33.6075691Z&urlSigningMethod=HMACV1&urlSignature=6j4OihznEJx3htX02RAWE1Po54U1GfsTOZ9dYr6a5Po%3D (look for "certificate")
[12:24] <cachio> cmatsuoka, checking
[12:24] <cachio> uri expired
[12:25] <cachio> cmatsuoka, dou you have a pr number?
[12:25] <cmatsuoka> it's #9534
[12:25] <mup> PR #9534: many: update to secboot v1 <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/9534>
[12:27] <cachio> cmatsuoka, which syste?
[12:27] <cachio> m
[12:28] <cmatsuoka> ubuntu-20.04-64
[12:28] <cmatsuoka> and others
[12:31] <pstolowski> cachio: hey, could you upload https://people.canonical.com/~pedronis/old-snapd/ to GC so I can use it in spread test?
[12:31] <cachio> pstolowski, sure
[12:32] <cachio> cmatsuoka, first time I see that error
[12:33] <cachio> perhaps a repo issue at maze-io
[12:34] <cachio> pstolowski, both core18 and snpad snaps¡
[12:35] <cachio> ?
[12:35] <cmatsuoka> cachio: it seems so, I 'll investigate
[12:35] <pstolowski> cachio: yes
[12:38] <zyga> mborzecki, can you open bootstate16.go on line 102 please: is word "threading" there a mistake?
[12:39] <mborzecki> zyga: maybe it was meant to be treading (as in steppin over?)
[12:40] <zyga> mmm
[12:40] <zyga> yeah
[12:40] <zyga> makes sense, thanks
[12:40] <mborzecki> mhm, yeah, most likely, better if one of the native speakers confirms :P
[12:40] <zyga> I'll correct that
[12:41] <pedronis> mborzecki: zyga: I wrote that
[12:42] <zyga> pedronis, should it say "treading"?
[12:42] <pedronis> no
[12:42] <pedronis> if you want to make it less, obscure s/threading/passing/
[12:42] <zyga> so what does it mean, right now it doesn't read right
[12:42] <zyga> ah
[12:43] <zyga> yeah, I think that's better
[12:43] <zyga> threads != treads
[12:43] <mborzecki> heh languages are fun, not just the programming ones :P
[12:45] <pedronis> to be clear I think the verb is fine (it's used like that in other programming contexts) but it's probably obscure
[12:45] <zyga> threading as in providing?
[12:46] <pedronis> threading as in passing something around that also ties things together
[12:49] <pedronis> zyga: it's probably more common in the compiler/functional world, but if you google for "threading state around" you'll find some computer science text using that expression
[12:50] <zyga> I see, I didn't know that
[12:50] <zyga> but probably a bit confusing to be honest, given that threading has such a strong semantic in computing now
[12:51] <zyga> oh my, almost standup time
[13:05] <mup> PR snapd#9536 opened: RFC: bootloader ping/pong protocol <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/9536>
[13:06] <zyga> mvo, pedronis: something I'd love to discuss if you have a few minutes after the standup %
[13:06] <zyga> ^
[13:06] <mvo> zyga: we have a secboot thing after but we can squeeze you in probably somehow
[13:07] <zyga> I just read that mvo said "boot"
[13:07] <zyga> must be yes ;)
[13:48] <zyga> re (back with coffee)
[13:48] <zyga> I'll chop export manager now
[13:57] <mvo> zyga: \o/ thank you!
[14:00] <mvo> ijohnson: what was the url for the enumerating disk work you need review/feedback for from foundatoins?
[14:00] <mvo> ijohnson: I will put it on the agenda for todays meeting
[14:00] <mvo> pstolowski: current meeting overruning, we may be late for tgif (cc ijohnson )
[14:00] <ijohnson> mvo: it's a lp bug let me grab it
[14:01] <mvo> ijohnson: ta!
[14:01] <pstolowski> mvo: ack
[14:01] <ijohnson> mvo: last comment on https://bugs.launchpad.net/snapd/+bug/1900842
[14:01] <mup> Bug #1900842: partitions can have different major numbers <core20> <snapd:In Progress by anonymouse67> <https://launchpad.net/bugs/1900842>
[14:04] <mvo> ijohnson: ta
[14:31] <mborzecki> zyga: btw. i have govendor sync && rm vendor dirs in a loop on a tw system in gcp, it's been running for 1h+ now
[14:32] <zyga> mborzecki, I really wonder what's the magic that breaks there
[14:32] <mborzecki> maybe it's something with the hosts
[14:32] <zyga> ijohnson, btw, speaking of politics, what's up witch McConnell?
[14:33] <ijohnson> haha what's not up with McConnell
[14:33] <zyga> he could play in a harry potter zombie movie now
[14:35] <ijohnson> he could play any villain in any movie ever probably
[14:36] <zyga> "ONE MILLION DOLLARS" in evil voice
[14:36] <ijohnson> oh wow actually there is something up with him he's all different colors now
[14:36] <zyga> yeah, that's what I meant
[14:40] <mup> PR snapd#9527 closed: o/snapstate: implement undo handler for unlink-snap <Needs Samuele review> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9527>
[14:42]  * zyga -> lunch
[14:45] <mup> PR snapd#9537 opened: tests: also check snapst.Current in undo-unlink tests <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9537>
[15:05]  * cachio lunch
[15:12] <zyga> back
[16:05]  * zyga EODs
[16:06] <mup> PR snapd#9538 opened: o/snapstate/catalogrefresh.go: don't refresh catalog in install mode uc20 <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9538>
[16:10] <cachio> zyga, do you have the tumbleweed links?
[16:16] <mup> PR snapd#9414 closed: tests: new nested tool <Run nested> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9414>
[16:36] <mup> PR snapd#9373 closed: snap: add new `snap recovery --show-recovery-key` option <Needs Samuele review> <Run nested> <Squash-merge> <UC20> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9373>
[16:36] <mup> PR snapd#9539 opened: many: add /v2/system-recovery-key API and client <Created by mvo5> <https://github.com/snapcore/snapd/pull/9539>
[16:42]  * cachio afk errands
[16:51] <mup> PR snapd#9540 opened: snap: add new `snap recovery --show-recovery-key` optio <Created by mvo5> <https://github.com/snapcore/snapd/pull/9540>
[18:04] <mup> PR snapcraft#3325 closed: snapcraftctl: add checks for empty string for set-version & set-grade <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3325>
[18:04] <mup> PR snapcraft#3333 closed: specifications: finalization of package repositories spec <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3333>
[18:04] <mup> PR snapcraft#3334 closed: package repositories: improve error handling <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3334>
[20:19] <mup> PR snapcraft#3335 opened: cli: remove spaces from progressive metrics <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3335>
[21:12] <mup> PR snapd#9541 opened: osutil/disks: re-implement partition searching for disk w/ non-adjacent parts <Bug> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9541>
[22:41]  * ijohnson EOWs
[23:32] <mup> Bug #1901262 opened: Unable to mount NTFS drives with write support <ntfs> <ntfs-3g> <Snappy:New> <https://launchpad.net/bugs/1901262>