wallyworldhpidcock: trivial PR https://github.com/juju/juju/pull/1219104:54
wallyworldor kelvinliu ^^^^04:59
hpidcockwallyworld: should it not be ?= not := ?05:02
hpidcockmy gnumake is rusty05:02
wallyworld?= only sets it if not set, and it is set above05:02
wallyworld:= will take an override05:02
wallyworldi tested it to be sure05:03
wallyworldhappy for a double check05:03
kelvinliuwallyworld: ru looking on the unittests timeout issue?05:04
wallyworldfor now, just providing a job parameter for the unit test jobs to allow the timeouts to be adjusted within jenkins05:04
wallyworldit may be if jenkins gets busy we need to increase the timeout; but we need a parameter and juju makefile change to allow that05:05
wallyworldi just ran a unittest run now, and it passed fine with nothing much else running on jenkin05:06
wallyworldhpidcock: the forward port https://github.com/juju/juju/pull/1219205:23
hpidcockwallyworld: looking05:23
hpidcockwallyworld: looks great.05:23
=== mup_ is now known as mup
hpidcockwallyworld: PTAL https://github.com/juju/juju/pull/1219306:39
wallyworldhpidcock: sure, looking07:15
wallyworldhpidcock: lgtm ty07:32
eloxoscar 0: THanx for writing this up https://discourse.juju.is/t/custom-os-images-when-using-juju-with-vmware/372009:26
=== gsamfira_ is now known as gsamfira
hmlpetevg[m]: review please: https://github.com/juju/juju/pull/1219819:15

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!