[04:54] <wallyworld> hpidcock: trivial PR https://github.com/juju/juju/pull/12191
[04:59] <wallyworld> or kelvinliu ^^^^
[05:00] <hpidcock> looking
[05:02] <hpidcock> wallyworld: should it not be ?= not := ?
[05:02] <hpidcock> my gnumake is rusty
[05:02] <wallyworld> ?= only sets it if not set, and it is set above
[05:02] <wallyworld> := will take an override
[05:03] <wallyworld> i tested it to be sure
[05:03] <wallyworld> happy for a double check
[05:04] <kelvinliu> wallyworld: ru looking on the unittests timeout issue?
[05:04] <wallyworld> for now, just providing a job parameter for the unit test jobs to allow the timeouts to be adjusted within jenkins
[05:05] <kelvinliu> ok
[05:05] <wallyworld> it may be if jenkins gets busy we need to increase the timeout; but we need a parameter and juju makefile change to allow that
[05:06] <wallyworld> i just ran a unittest run now, and it passed fine with nothing much else running on jenkin
[05:19] <hpidcock> 👍
[05:20] <wallyworld> ty
[05:23] <wallyworld> hpidcock: the forward port https://github.com/juju/juju/pull/12192
[05:23] <hpidcock> wallyworld: looking
[05:23] <hpidcock> wallyworld: looks great.
[05:24] <wallyworld> ta
=== mup_ is now known as mup
[06:39] <hpidcock> wallyworld: PTAL https://github.com/juju/juju/pull/12193
[07:15] <wallyworld> hpidcock: sure, looking
[07:32] <wallyworld> hpidcock: lgtm ty
[09:26] <elox> oscar 0: THanx for writing this up https://discourse.juju.is/t/custom-os-images-when-using-juju-with-vmware/3720
=== gsamfira_ is now known as gsamfira
[19:15] <hml> petevg[m]: review please: https://github.com/juju/juju/pull/12198