| smoser | https://github.com/canonical/cloud-init/pull/622 'd be nice if someone took a look. | 02:58 |
|---|---|---|
| AscII | Odd_Bloke: Re: PR: 629 - I just don't have the option to allow edits. That checkbox simply does not exist for me | 06:14 |
| === cpaelzer__ is now known as cpaelzer | ||
| AscII | smoser: thanks for the review | 12:56 |
| Odd_Bloke | AscII: Oh, interesting; I guess it must be controlled by an organisation setting in that case? I've landed #629 just now. | 13:12 |
| Odd_Bloke | johnsonshi: Thank you, and thanks for the update! | 13:12 |
| AscII | thanks | 13:13 |
| amansi26 | blackboxsw: One of my UT is failing because in the UT I am using assert_called which got introduced in python3.6 . I am wondering why is that only job pointing to python3.5 . CI: https://github.com/canonical/cloud-init/runs/1320196999 PR: https://github.com/canonical/cloud-init/pull/584 | 13:18 |
| Odd_Bloke | amansi26: cloud-init supports Python 3.4+; Python 3.5 is the earliest easy version for us to test, so that's what's in Travis. | 13:21 |
| amansi26 | Odd_Bloke: Thanks. as you said python3.5 is there on travis. one doubt is why is only 1 job is pointing to 3.5 rest all to 3.6 ? | 13:24 |
| Odd_Bloke | amansi26: We want to cover more than a single Python version: we really should cover _more_ versions than just 3.5 and 3.6, but that's where we're at ATM. | 13:29 |
| Odd_Bloke | When we were first writing the Travis integration, Python 3.6 was the version in the most recent Ubuntu LTS, so I suspect that's why we pinned on that one. | 13:29 |
| amansi26 | So we can't use something introduced in python3.6 in our UTs. | 13:36 |
| AscII | smoser: is PR #630 now okay from your side? | 13:40 |
| Odd_Bloke | amansi26: Yep, that's correct. :) | 13:44 |
| meena | AscII: flake8 is still failing | 14:05 |
| rharper | amansi26: for assert_called, we typically use call_count ; self.assertEqual(1, mock_obj.call_count); or whatever you need; | 14:09 |
| dikonoor | rharper:Odd_Bloke: On the PR that amansi26 is working on, for which the LP bug was opened by me (we are new to cloudinit community), for acceptance into the community, do more than one maintainer have to approve it? > https://github.com/canonical/cloud-init/pull/584 | 14:12 |
| dikonoor | smoser has been very helpful with the reviews; however want to know if we should be explicitly adding anyone else into this PR for review. | 14:13 |
| dikonoor | rharper:Odd_Bloke: We are waiting for this to be accepted into the community to use this module downstream. So, anyone else from the community should be taking a look at the PR, it will be great if you could let us know. | 14:15 |
| dikonoor | That would help address the review comments faster(hoping we are almost there with the changes amansi26 has pushed) | 14:17 |
| rharper | dikonoor: one is enough for approval; | 14:17 |
| dikonoor | rharper: ok. Wasn't aware of that. We typically work with OpenStack that needs approval from two cores. | 14:18 |
| rharper | we're not so big | 14:20 |
| rharper | organizationally (community) | 14:20 |
| dikonoor | rharper:sure. So I believe as soon as smosers comments are addressed, we should be good. | 14:24 |
| AscII | meena: weird, mine says everythings good | 14:29 |
| AscII | ah, found it | 14:31 |
| zamba | anyone alive in here? | 14:35 |
| meena | zamba: eh. | 14:37 |
| meena | barely | 14:37 |
| dikonoor | smoser: Thanks for your review on https://github.com/canonical/cloud-init/pull/584. Appreciate all the comments and help you have been providing. We are waiting for the changes to be upstreamed, so that we can pull this downstream and are under bit of a short deadline. Apart from the current open comment (And the UT that amansi26 is fixing), if there is anything else that we should be taking care of, it will be great if you can let us know. | 14:38 |
| smoser | dikonoor: well right now it doesn't pass c-i | 14:40 |
| smoser | so... show stoppers: | 14:40 |
| smoser | a.) doesnt pass c-i | 14:40 |
| smoser | the easiest thing to do there might be just to drop test_handler_reset_rmc.py entirely, as it doesn't actually test anything. | 14:41 |
| smoser | b.) i woudl suggest you squash and rebase. | 14:42 |
| dikonoor | smoser:Thanks. anything else? | 14:42 |
| smoser | https://github.com/canonical/cloud-init/pull/584#discussion_r512729238 | 14:44 |
| zamba | i'm attempting to deploy and customize an ova directly to a standadlone esxi host.. under options i can tweak certain options.. like ssh public keys, default user's password, a unique instance id for this instance and so on | 14:44 |
| smoser | dikonoor: fix that too. (drop print() statements in trests) | 14:45 |
| zamba | but the problem is that it doesn't seem like these options stick when deploying and booting the virtual machine | 14:45 |
| dikonoor | smoser: Sure. amansi26 is pushing a commit with these changes.Will ping once he is done and the ci goes through | 14:47 |
| smoser | i hope i've not come off to amansi26 as hard to deal with. | 14:54 |
| amansi26 | smoser: I am thankful for all the review comments you had. I am learning the way to contribute to the community. | 14:58 |
| amansi26 | smoser: On your suggestion to squash and rebase. Usually I get an option from UI to squash the commit, but in this case I am not seeing the option. Is there any other way to squash and rebase the commits? | 15:01 |
| amansi26 | smoser: All the Travis checks are passed now https://github.com/canonical/cloud-init/pull/584 | 15:05 |
| amansi26 | rharper: Thanks for suggesting an alternative way to handle it | 15:06 |
| rharper | sure | 15:11 |
| smoser | amansi26: i hit a buttom 'update branch'... (much of github workflow is new to me). | 15:15 |
| smoser | it i think merged with master, and then made that commit... and then ambe when taht passees i can hit 'squash and merge' | 15:15 |
| faa | hello bug tracker launchpad now? | 15:17 |
| amansi26 | smoser: I think, when you try to merge, there you will get an option to squash and merge. I don't have the write | 15:17 |
| amansi26 | smoser: I think, when you try to merge, there you will get an option to squash and merge. I don't have the write permission. | 15:18 |
| smoser | amansi26: fwiw, 'git rebase -i' is what i use to squash and rebase. | 15:19 |
| smoser | ok. 2 other things... i'm really sorry. | 15:23 |
| smoser | a.) rite a commit cohesive commit message. your PR summary is a good start, but you don't need thing slike "there are couple of cloud-init config modules that we have been maintaining downstream." . | 15:24 |
| smoser | add a '#commit message' section to that with something you think is sane. | 15:25 |
| smoser | b.) Odd_Bloke or blackboxsw or @someone-at-canonical ... do we need to add the modules to config/cloud.cfg.tmpl | 15:25 |
| smoser | i think that all other modules are present there. | 15:26 |
| smoser | for 'a', i gave you a start. | 15:28 |
| smoser | amansi26, dikonoor ^ | 15:32 |
| amansi26 | smoser: I am trying to rebase with the command you suggested | 15:34 |
| smoser | amansi26: dont worry about rebase now. | 15:35 |
| smoser | with all your merge back and forth... it is hard to squash. | 15:35 |
| meena | now with FreeBSD 12.2 released, i should patch up cc_ca_certs to work with https://www.freebsd.org/cgi/man.cgi?query=certctl !! | 15:36 |
| smoser | the easiest thing to do really is just something like | 15:36 |
| smoser | git checkout your-branch | 15:36 |
| smoser | git diff --no-prefix $(git merge-base origin/master HEAD) > out.diff | 15:37 |
| smoser | git reset --hard origin/master | 15:37 |
| smoser | patch -p1 < out.diff | 15:37 |
| smoser | git add files/in/your/diff | 15:37 |
| smoser | git commit | 15:37 |
| smoser | the just p ush force over the top | 15:37 |
| smoser | but as i said... dont worry about it. | 15:37 |
| smoser | github seems like it will do that stuff in squash and merge button | 15:38 |
| smoser | do 'a' and 'b' above. | 15:38 |
| smoser | well.. i need Odd_Bloke for b. this is really policy decisioin. | 15:38 |
| smoser | my feeling is all config moduels should be present and enabled. | 15:39 |
| dikonoor | smoser: Does adding these entries into config/cloud.cfg.tmpl mean that these will be automatically added /enabled as part of cloud.cfg. These two new modules work only on PowerVM based VMs. | 15:41 |
| faa | https://bugs.freebsd.org/bugzilla/attachment.cgi?id=218934&action=diff freebsd require small patches, and now a found brocken growfs if trim option enable :( | 15:41 |
| smoser | dikonoor: but they do the right thing. and do nothing. | 15:41 |
| dikonoor | smoser: so the default cloud.cfg currently has all the modules listed and enabled. I was under the impression that only the common ones are enabled. | 15:43 |
| smoser | faa: yes, file bugs on launchpad. | 15:43 |
| smoser | dikonoor: https://paste.ubuntu.com/p/TfY8X5fgVP/ | 15:47 |
| smoser | so the only ones not enabled are 'foo' (which is just an exmample) and rh_subscription, which I think is probably just oversite | 15:49 |
| dikonoor | smoser: ok. Got it | 15:50 |
| smoser | so *I* think it should be present in config_modules section (i'd just add it to the end). but i'm willing to not amke that a sticking point if some other developer says "smoser that is silly". | 15:52 |
| paride | hey Odd_Bloke, this is the packaging for the cloud-utils upload https://github.com/canonical/cloud-utils/pull/21 | 15:58 |
| dikonoor | smoser: I would recommend that cc_refresh_rmc_and_interface.py not be enabled by default as it has a step where the ipv6 interface is explicitly set to nm_controlled=no..which applies only to PowerVM based VMs . | 15:58 |
| dikonoor | We might not want this change to be applied on any RHEL system that is booting up | 15:58 |
| paride | the packaging itself it a bit outdated and lintian complains of a few things, I will fix for the new release | 15:58 |
| paride | I mean, after this one :) | 15:58 |
| smoser | dikonoor: but they quietly do nothing when unless they are on that system. | 16:01 |
| smoser | (as indicated by presense of rmcctrl) | 16:02 |
| dikonoor | smoser: you are right | 16:02 |
| smoser | we can make that check better... we can also check uname is ppc64el and anything else uyou want to add. | 16:02 |
| dikonoor | the first few lines have check | 16:02 |
| dikonoor | I missed that | 16:02 |
| smoser | (we probably should add the ppc64 check) | 16:02 |
| smoser | and should probably make the check consistent between the two things. | 16:03 |
| dikonoor | smoser: The existing check is enough | 16:03 |
| dikonoor | You are right. It will do nothing | 16:03 |
| smoser | in one case we check for RSCT_PATH and in the other we check for rmcctrl | 16:03 |
| dikonoor | if not subp.which(RMCCTRL): | 16:03 |
| dikonoor | return | 16:03 |
| dikonoor | smoser: Agree with you :) | 16:04 |
| amansi26 | smoser: I squash and rebase the changes, the checks passed and updated the PR description you suggested. | 16:10 |
| amansi26 | I believe that fixes the point a. Correct me if I am wrong? | 16:12 |
| dikonoor | smoser: Will the changes get merged into the community automatically or is there anything that needs to be done? | 16:12 |
| ananke | I'm wondering if content of debconf_selections specified in cloud-init get shown in its logs. This is my first time trying that module and the value I specified doesn't seem to be present (and it doesn't show up in the logs either) | 16:15 |
| ananke | I used this syntax in the config file: | 16:16 |
| ananke | https://dpaste.com/HZ6AR4V9T | 16:17 |
| ananke | but the logs don't seem to show it, and the resulting debconf selections has a default value (not what I was trying to set) https://dpaste.com/2TVS26NCP | 16:19 |
| smoser | dikonoor, amansi26 i put one more review on github. please address those three things. | 16:24 |
| otubo | I think I found a bug on the openstack helper. Everything breaks (stack trace and all) if you specify static or static6 on the network_data.json file. cloudinit/sources/helpers/openstack.py does not handle those subnet type. | 16:54 |
| otubo | I found that because I'm writing support for IPV6_FORCE_ACCEPT_RA and IPV6_AUTOCONF on the sysconfig renderer while using subnet static6, and all of a sudden everything broke :-D | 17:00 |
| amansi26 | smoser: Addressed the changes you asked. Added the modules at the end of final section. We wanted the operation to be done at the very end. | 17:01 |
| amansi26 | smoser: What should be the next step? | 17:13 |
| smoser | did you update the commit message ? and i gave feedback on the location of the modules. | 17:17 |
| dikonoor | amansi26: this comment needs to be addressed > https://github.com/canonical/cloud-init/pull/584/files#r513623252 | 17:21 |
| amansi26 | ok | 17:23 |
| dikonoor | amansi26: Also it looks like the commit message has not been updated yet. | 17:27 |
| dikonoor | smoser: Did you mean to say that the "commit message" has to be replaced with a an appropriate title? | 17:27 |
| amansi26 | dikonoor: Commit message is updated. https://github.com/canonical/cloud-init/pull/584/commits/df62d3b2d968ca9fec6bb4af523ee9770d7960ee | 17:28 |
| dikonoor | amansi26: IF so, then only the location os the modules need to be fixed | 17:29 |
| amansi26 | smoser: dikonoor: committed a new PR for that https://github.com/canonical/cloud-init/pull/584/files | 17:30 |
| amansi26 | smoser: dikonoor: I addressed all the recent comments, squashed and rebase all the recent changes . | 17:55 |
| smoser | oh fudge. | 18:06 |
| smoser | i merged... one thing i didn't realize. | 18:06 |
| smoser | youhae your name set to man306 <45781773+Aman306@users.noreply.github.com> | 18:07 |
| smoser | i didn't notice that. so you don't get proper credit :-( | 18:07 |
| smoser | nor does ibm | 18:07 |
| amansi26 | smoser: thanks for merging it. thanks for all your guidance | 18:10 |
| dikonoor | smoser: Thanks for all your time and help getting https://github.com/canonical/cloud-init/pull/584/files merged ! | 18:38 |
| meena | AscII: i'm working on it! okay!!? https://github.com/canonical/cloud-init/pulls?q=is%3Apr+author%3Aigalic | 19:55 |
| AscII | ;-) | 19:55 |
| meena | oh, and this one's new, https://bugs.launchpad.net/cloud-init/+bug/1901915 | 19:57 |
| ubot5 | Ubuntu bug 1901915 in cloud-init "FreeBSD: Add certctl support to cc_ca_certs" [Undecided,New] | 19:57 |
| meena | but i'll wait until https://github.com/canonical/cloud-init/pull/633 lands | 19:57 |
| AscII | I see. We had evaluated if we could add a FreeBSD image to our platform, but kind of got stuck at some point. And we didn't want to add an alternate method via ConfigDrive | 19:58 |
| AscII | If you need are developing on our platform, please reach out via ticket, so we can set up some credit for you | 20:00 |
| meena | AscII: i have been primarily targeting Hetzner (and lately NoCloud on my own laptop) | 20:06 |
| AscII | \o/ | 20:06 |
| meena | AscII: i have previously mentioned that in tickets, but no one's thought of crediting me? | 20:06 |
| meena | i don't need credit… but maybe credits :P | 20:06 |
| AscII | really... oh well, what a shame | 20:07 |
| meena | eh | 20:07 |
| meena | i don't do FOSS for fame | 20:07 |
| meena | but i do love creating tickets based on Tweets and IRC conversations | 20:08 |
| AscII | ;-) | 20:08 |
| AscII | if you have an existing ticket ID for me, that works for me, too | 20:09 |
| meena | nah, only https://twitter.com/hirojin/status/1321412377649336322 so far | 20:10 |
| AscII | I am working on it, okay!!? ;-) | 20:11 |
| meena | AscII: but, yeah, i have a projects where i test my patches against Hetzner, currently my patches are stuck on my lack of Python Testing skills | 20:13 |
| meena | or, put more bluntly: my lack of Software Engineering Skills | 20:14 |
| AscII | Well, I got you the 12.2 bootonly ISO ready | 20:15 |
| meena | AscII: 💜 | 20:16 |
| meena | smoser: added a test case for ds-identify | 20:48 |
| smoser | meena: expect your invitation to the 3l337 h@CK3R group | 20:49 |
| smoser | shell unit(or system) testing in python \o/ | 20:50 |
| meena | sorry i was so dense; i thought the dict is tested as a hole; not entry by entry | 20:50 |
| smoser | meena: that would make sense | 21:04 |
| meena | smoser: different people have different measures of what makes sense 🤪️ | 21:13 |
| meena | the amount of shit i need to mock away for testing generate_fallback_config is… flabbergasting | 21:18 |
| meena | and i can't use generic_networking_cls | 21:21 |
| smoser | yeah, who wroteo this stufff! | 21:21 |
| smoser | i honestly don't know how that 2010 smoser got a job. | 21:21 |
| meena | smoser: https://github.com/canonical/cloud-init/pull/588 ← i deleted the tests from tests/unittests/test_net.py and now i need to add them back to cloudinit/distros/tests/test_networking.py and it's just… a mountain of work | 21:23 |
| meena | Odd_Bloke: first attept at a test, https://github.com/canonical/cloud-init/pull/588/commits/92816acdf02e9cb7d5a2200b29c570d49bd2b16a (it's failing) and i need sleep | 21:41 |
| Odd_Bloke | meena: Same (I am failing and I need sleep ;). | 21:43 |
| Odd_Bloke | I'll take a look tomorrow! | 21:43 |
| blackboxsw | meena: m_find_fallback_nic.side_effect = 'eth0' -> m_find_fallback_nic.return_value = 'eth0' thugh there are more errors afterward | 21:44 |
| blackboxsw | side_effect is more for callables/functions/Exceptions etc. | 21:44 |
| blackboxsw | return_value mocks the return of the function in this case | 21:45 |
| otubo | (I see you guys online so I'll just poke) | 21:45 |
| otubo | smoser: Odd_Bloke blackboxsw just filed this cute PR https://github.com/canonical/cloud-init/pull/634 if you would like to take a look, that would be really awesome. | 21:46 |
| meena | blackboxsw: aye, the netcfg i'm using is wrong… i should revert those changesets | 21:47 |
| otubo | This is on the same time pressure package of the PowerVM stuff smoser was helping earlier today. Scott I'll pay you a beverage of your choice next time we meet if you take a look at that :-D | 21:48 |
| otubo | Also, it's almost 23h and I need some sleep. I'll check the messages tomorrow. Thanks guys! :) | 21:49 |
| meena | blackboxsw: okay, thanks for your help… i think that got the ball rolling. I'll try to replace the tests i deleted over the following days | 21:52 |
| meena | but somebody needs to help me fix that myserty failing test. | 21:52 |
| meena | tests/unittests/test_datasource/test_azure.py::TestAzureDataSource::test_imds_network_config FAILED ← this one. in https://travis-ci.com/github/canonical/cloud-init/jobs/416919478 | 21:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!