manadartstickupkid: Trivial one: https://github.com/juju/juju/pull/1221409:41
stickupkidmanadart, https://github.com/juju/juju/pull/1221511:59
stickupkidhml, https://github.com/juju/os/pull/2713:02
hmlstickupkid: one question before it’s approved, in the pr13:07
stickupkidhml, i've got other issues first haha13:07
stickupkidmanadart, https://github.com/juju/juju/pull/1221715:10
stickupkidmanadart, also responded to your comment15:11
stickupkidhml, fixed the issue with juju/os PR https://github.com/juju/os/pull/2715:26
hmlstickupkid: approved15:27
stickupkidmanadart, hml CR, want to get this one in before 2.9-rc116:05
hmlstickupkid: looking16:05
hmlstickupkid: should main.sh run all the tests?16:27
hmlstickupkid: what was failing to require the change?16:28
stickupkidhml, so schema.List(schema.String()) requires [] brackets around the mode i.e. `[strict]`16:29
stickupkidhml, or `[strict,testing]`16:29
stickupkidhml, but I originally coded it like `strict,testing` and then we decided to use the right schema, which then caused the massive change, but I forgot to update the integration test16:30
hmlstickupkid: running the model test now.  added 2 comments16:43
hmlif those are resolved i can merge the pr for you, provided good qa16:43
stickupkidhml another one https://github.com/juju/juju/pull/1221916:46
stickupkidsorry I'm fixing loads of crap atm16:47
hmlstickupkid: i’ll put 12219 in the queu16:48
stickupkidhml, I've updated PR 1221716:53
hmlstickupkid: got it.16:56
hmlstickupkid: 12117 is approved16:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!