[09:41] <manadart> stickupkid: Trivial one: https://github.com/juju/juju/pull/12214
[11:59] <stickupkid> manadart, https://github.com/juju/juju/pull/12215
[13:02] <stickupkid> hml, https://github.com/juju/os/pull/27
[13:07] <hml> stickupkid: one question before it’s approved, in the pr
[13:07] <stickupkid> hml, i've got other issues first haha
[15:10] <stickupkid> manadart, https://github.com/juju/juju/pull/12217
[15:11] <stickupkid> manadart, also responded to your comment
[15:26] <stickupkid> hml, fixed the issue with juju/os PR https://github.com/juju/os/pull/27
[15:27] <hml> stickupkid: approved
[16:05] <stickupkid> manadart, hml CR, want to get this one in before 2.9-rc1
[16:05] <stickupkid> https://github.com/juju/juju/pull/12217
[16:05] <hml> stickupkid: looking
[16:27] <hml> stickupkid: should main.sh run all the tests?
[16:28] <hml> stickupkid: what was failing to require the change?
[16:29] <stickupkid> hml, so schema.List(schema.String()) requires [] brackets around the mode i.e. `[strict]`
[16:29] <stickupkid> hml, or `[strict,testing]`
[16:30] <stickupkid> hml, but I originally coded it like `strict,testing` and then we decided to use the right schema, which then caused the massive change, but I forgot to update the integration test
[16:43] <hml> stickupkid: running the model test now.  added 2 comments
[16:43] <hml> if those are resolved i can merge the pr for you, provided good qa
[16:46] <stickupkid> hml another one https://github.com/juju/juju/pull/12219
[16:47] <stickupkid> sorry I'm fixing loads of crap atm
[16:48] <hml> stickupkid: i’ll put 12219 in the queu
[16:53] <stickupkid> hml, I've updated PR 12217
[16:56] <hml> stickupkid: got it.
[16:57] <hml> stickupkid: 12117 is approved