bthomasmoo-ning :-)08:33
bthomasChipaca: would a 1:1 around 12:30 be fine with you . If so I can add it to your calendar ?09:12
Chipacabthomas: go for it09:21
Chipacamy day just got 78% better \o/ (a 1h meeting was canceled)09:36
facubatista¡Muy buenos días a todos!10:36
bthomasनमस्ते facubatista10:36
facubatistahola bthomas10:37
mupPR operator#435 closed: Only set sys.breakpointhook in Framework.__init__ if env is set <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/pull/435>10:47
Chipacafacubatista: gooooooooooooooooooooooooooooooooooooooooooood  morning!10:48
Chipacafacubatista: should i merge my suggestions into #432 and land it?10:49
mupPR #432: More docstrings (and some improved a little) <Created by facundobatista> <https://github.com/canonical/operator/pull/432>10:49
facubatistaChipaca, please10:49
facubatistaChipaca, I'll work on other docstrings, unless you're on them10:49
Chipacafacubatista: i'm on the fix for #42110:50
mupIssue #421: breakpoint handlers unconditionally installed on framework initialization <Created by stub42> <https://github.com/canonical/operator/issues/421>10:50
facubatistafacubatista, let me know when you landed 432, thanks10:53
mupPR operator#432 closed: More docstrings (and some improved a little) <Created by facundobatista> <Merged by chipaca> <https://github.com/canonical/operator/pull/432>11:58
Chipacafacubatista: ^11:58
Chipacacheated a little because windows was taking ages11:58
facubatistaChipaca, in what sense you cheated?12:11
Chipacafacubatista: ☐ Use your administrator privileges to merge this pull request.12:11
facubatistaChipaca, ah, it's fine12:12
* bthomas pings Chipaca12:31
Chipaca1 sec12:31
* bthomas thanks Chipaca12:58
Chipacade nada 🙂12:58
facubatistaChipaca, bueno, 424 should be green, and I +1ed 43613:05
facubatistathat's all you should need for today from my side in the OF13:05
facubatistaI'll start the charmcraft release process in 5' or so13:05
Chipacafacubatista: there'll be one more for OF, i'll ping you13:11
Chipacabthomas: please review #436 if you can13:11
mupPR #436: Give ObjectEvents a useful __repr__ <Created by chipaca> <https://github.com/canonical/operator/pull/436>13:11
bthomaswill do13:12
facubatistaChipaca, sure13:19
mthaddonbthomas: I've created a few PRs against the prometheus operator, fwiw - https://github.com/canonical/prometheus-operator/pulls14:10
bthomas mthaddon: will review thank you14:10
mthaddonthx - no hurry obviously14:10
* Chipaca pokes travis14:13
justinclarkGood morning o/14:16
facubatistahola justinclark14:17
justinclarkbthomas - just reviewed the Prometheus PRs and they should be good to merge.14:24
bthomas:-) I was just going to request that from you.14:24
bthomaswill merge now14:24
bthomasI liked the use of assertLogs I think I am going to stick with them in the future14:25
justinclarkAgreed ^ I'm going to refactor some of the Grafana tests to use it14:33
JoseMassongood morning justinclark14:35
bthomasmonin JoseMasson14:36
justinclarkI enjoy the friendliness in the morning over here on IRC14:37
* bthomas wonders why justinclark does not enjoy friendliness at 2AM EST14:37
* bthomas takes a coffee break14:38
* justinclark wishes he enjoyed waking up at 2AM but, alas, does not for some strange reason14:40
* bthomas back14:46
* facubatista lunches while snap remote building works15:16
mupIssue operator#438 closed: defered events never re-emitted when using juju storage backend <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/issues/438>15:45
mupPR operator#439 closed: Make JujuStorage.notices respect the api :-) <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/439>15:45
Chipacafacubatista: does the charmcraft snap include ops? and if so, wouldn't it make sense to release it after we release ops?15:46
* Chipaca wonders if travis is somehow immunte to being stared at16:01
facubatistaChipaca, oh, maybe16:11
facubatistaChipaca, so, I aborted the remote build, I will re-trigger it when you're done16:15
Chipacafacubatista: travis is taking very long today16:16
Chipacafacubatista: i've got one more pr to push (the rework of the breakpoint init) but i'll push it once the current one is in to minimise builds16:16
Chipacait's straightforward, but i'm not sure it'll make it in before my EOD16:16
facubatistaChipaca, we can release tomorrow16:17
Chipacathat's what _she_ said!16:18
Chipaca(my dog)16:18
justinclarkBefore I spend too many brain cycles rearranging charm logic, is there some way in OF to get the current application ingress-address without having a peer relation?17:22
justinclarkI believe it's exposed by Juju (it's also an environmental variable in the application pod) but I haven't been able to figure out how to get it through the charm.17:26
Chipacajustinclark: would that be part of the juju-info implicit peer relation?17:32
bthomasjustinclark: hopefully jam Chipaca or facubatista would be able to help you with your Q. I would be interested to know too. What I was trying to say was this : updating of minimum master nodes is only done in response to a peer relation joined event. Hence by the time you need to update it you may already have a relation to get the ingress address from. Besides operator framework does allow you to check if you have a relation or not and17:36
bthomasalso the number of units in the relation. This leads me to believe it may be possible to find an implementation that works even if at present there is no way to get the ingress address without a realtion. Having said so I may in all possiblity be wrong and would gladly stand corrected, if so.17:36
justinclarkChipaca, I will look into juju-info. Is this still how it is used in OF? https://github.com/juju-solutions/interface-juju-info17:42
Chipacajustinclark: maybe https://github.com/canonical/operator/issues/395 is a better place to start?17:42
justinclarkThank you Chipaca17:43
justinclarkbthomas, I think you're right - we can do this without needing ingress-address.18:03
justinclarkI still do want to make sure we have a good solution if there's ever a case where we need to set dynamic settings before a peer joins. But I think this can wait.18:04
* bthomas is craving a five guys veggie burger and fries18:19
* bthomas goes18:19
=== dylan is now known as Guest95360
dstathisI am having an issue with the test framework19:19
dstathisnever mind the issue is not what I thought it was19:21
dstathisOkay so I am still having an issue19:52
dstathisupdate_relation_data does not seem to be doing its job19:53
dstathis(or I don't understand it)19:53
dstathisI am making that call and seeing19:54
dstathislol I see the bug. - not _19:56
dstathisokay new issue19:56
dstathisthe charm reads both the unit and app relation data on relation_changed19:57
dstathisbut I can only set one of those at once19:57
dstathisso whichever I set first, I will get a failure saying the other wasn't set19:58
dstathissolved that too19:59
mupIssue operator#416 closed: Introspection for events <Created by balbirthomas> <Closed by chipaca> <https://github.com/canonical/operator/issues/416>20:09
mupPR operator#436 closed: Give ObjectEvents a useful __repr__ <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/436>20:09
mupPR operator#440 opened: Set sys.breakpointhook in main instead of Framework.__init__ <Created by chipaca> <https://github.com/canonical/operator/pull/440>20:14
Chipacafacubatista: ^ 440 if you're still here20:15
facubatistadstathis, that was fun :)21:26
facubatistaChipaca, will review21:27

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!