| bthomas | moo-ning :-) | 08:33 |
|---|---|---|
| Chipaca | mo'in | 09:07 |
| bthomas | Chipaca: would a 1:1 around 12:30 be fine with you . If so I can add it to your calendar ? | 09:12 |
| Chipaca | bthomas: go for it | 09:21 |
| bthomas | thanks | 09:21 |
| Chipaca | my day just got 78% better \o/ (a 1h meeting was canceled) | 09:36 |
| bthomas | :-) | 09:53 |
| facubatista | ¡Muy buenos días a todos! | 10:36 |
| bthomas | नमस्ते facubatista | 10:36 |
| facubatista | hola bthomas | 10:37 |
| mup | PR operator#435 closed: Only set sys.breakpointhook in Framework.__init__ if env is set <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/pull/435> | 10:47 |
| Chipaca | facubatista: ｇｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｏｄ ｍｏｒｎｉｎｇ！ | 10:48 |
| Chipaca | facubatista: should i merge my suggestions into #432 and land it? | 10:49 |
| mup | PR #432: More docstrings (and some improved a little) <Created by facundobatista> <https://github.com/canonical/operator/pull/432> | 10:49 |
| facubatista | Chipaca, please | 10:49 |
| facubatista | Chipaca, I'll work on other docstrings, unless you're on them | 10:49 |
| Chipaca | facubatista: i'm on the fix for #421 | 10:50 |
| mup | Issue #421: breakpoint handlers unconditionally installed on framework initialization <Created by stub42> <https://github.com/canonical/operator/issues/421> | 10:50 |
| facubatista | ack | 10:52 |
| facubatista | facubatista, let me know when you landed 432, thanks | 10:53 |
| mup | PR operator#432 closed: More docstrings (and some improved a little) <Created by facundobatista> <Merged by chipaca> <https://github.com/canonical/operator/pull/432> | 11:58 |
| Chipaca | facubatista: ^ | 11:58 |
| Chipaca | cheated a little because windows was taking ages | 11:58 |
| facubatista | Chipaca, in what sense you cheated? | 12:11 |
| Chipaca | facubatista: ☐ Use your administrator privileges to merge this pull request. | 12:11 |
| facubatista | Chipaca, ah, it's fine | 12:12 |
| Chipaca | yup | 12:12 |
| * bthomas pings Chipaca | 12:31 | |
| Chipaca | whoops | 12:31 |
| Chipaca | 1 sec | 12:31 |
| * bthomas thanks Chipaca | 12:58 | |
| Chipaca | de nada 🙂 | 12:58 |
| facubatista | Chipaca, bueno, 424 should be green, and I +1ed 436 | 13:05 |
| facubatista | that's all you should need for today from my side in the OF | 13:05 |
| facubatista | I'll start the charmcraft release process in 5' or so | 13:05 |
| Chipaca | facubatista: there'll be one more for OF, i'll ping you | 13:11 |
| Chipaca | bthomas: please review #436 if you can | 13:11 |
| mup | PR #436: Give ObjectEvents a useful __repr__ <Created by chipaca> <https://github.com/canonical/operator/pull/436> | 13:11 |
| bthomas | will do | 13:12 |
| facubatista | Chipaca, sure | 13:19 |
| mthaddon | bthomas: I've created a few PRs against the prometheus operator, fwiw - https://github.com/canonical/prometheus-operator/pulls | 14:10 |
| bthomas | mthaddon: will review thank you | 14:10 |
| mthaddon | thx - no hurry obviously | 14:10 |
| * Chipaca pokes travis | 14:13 | |
| justinclark | Good morning o/ | 14:16 |
| facubatista | hola justinclark | 14:17 |
| justinclark | bthomas - just reviewed the Prometheus PRs and they should be good to merge. | 14:24 |
| bthomas | :-) I was just going to request that from you. | 14:24 |
| bthomas | will merge now | 14:24 |
| bthomas | thanks | 14:24 |
| bthomas | I liked the use of assertLogs I think I am going to stick with them in the future | 14:25 |
| justinclark | Agreed ^ I'm going to refactor some of the Grafana tests to use it | 14:33 |
| JoseMasson | good morning justinclark | 14:35 |
| bthomas | monin JoseMasson | 14:36 |
| bthomas | :-) | 14:36 |
| JoseMasson | :-) | 14:36 |
| justinclark | I enjoy the friendliness in the morning over here on IRC | 14:37 |
| * bthomas wonders why justinclark does not enjoy friendliness at 2AM EST | 14:37 | |
| * bthomas takes a coffee break | 14:38 | |
| * justinclark wishes he enjoyed waking up at 2AM but, alas, does not for some strange reason | 14:40 | |
| * bthomas back | 14:46 | |
| * facubatista lunches while snap remote building works | 15:16 | |
| mup | Issue operator#438 closed: defered events never re-emitted when using juju storage backend <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/issues/438> | 15:45 |
| mup | PR operator#439 closed: Make JujuStorage.notices respect the api :-) <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/439> | 15:45 |
| Chipaca | facubatista: does the charmcraft snap include ops? and if so, wouldn't it make sense to release it after we release ops? | 15:46 |
| * Chipaca wonders if travis is somehow immunte to being stared at | 16:01 | |
| Chipaca | immune* | 16:01 |
| facubatista | Chipaca, oh, maybe | 16:11 |
| facubatista | Chipaca, so, I aborted the remote build, I will re-trigger it when you're done | 16:15 |
| Chipaca | facubatista: travis is taking very long today | 16:16 |
| Chipaca | facubatista: i've got one more pr to push (the rework of the breakpoint init) but i'll push it once the current one is in to minimise builds | 16:16 |
| Chipaca | it's straightforward, but i'm not sure it'll make it in before my EOD | 16:16 |
| facubatista | Chipaca, we can release tomorrow | 16:17 |
| Chipaca | that's what _she_ said! | 16:18 |
| Chipaca | (my dog) | 16:18 |
| justinclark | Before I spend too many brain cycles rearranging charm logic, is there some way in OF to get the current application ingress-address without having a peer relation? | 17:22 |
| justinclark | I believe it's exposed by Juju (it's also an environmental variable in the application pod) but I haven't been able to figure out how to get it through the charm. | 17:26 |
| Chipaca | justinclark: would that be part of the juju-info implicit peer relation? | 17:32 |
| bthomas | justinclark: hopefully jam Chipaca or facubatista would be able to help you with your Q. I would be interested to know too. What I was trying to say was this : updating of minimum master nodes is only done in response to a peer relation joined event. Hence by the time you need to update it you may already have a relation to get the ingress address from. Besides operator framework does allow you to check if you have a relation or not and | 17:36 |
| bthomas | also the number of units in the relation. This leads me to believe it may be possible to find an implementation that works even if at present there is no way to get the ingress address without a realtion. Having said so I may in all possiblity be wrong and would gladly stand corrected, if so. | 17:36 |
| justinclark | Chipaca, I will look into juju-info. Is this still how it is used in OF? https://github.com/juju-solutions/interface-juju-info | 17:42 |
| Chipaca | justinclark: maybe https://github.com/canonical/operator/issues/395 is a better place to start? | 17:42 |
| justinclark | Thank you Chipaca | 17:43 |
| justinclark | bthomas, I think you're right - we can do this without needing ingress-address. | 18:03 |
| justinclark | I still do want to make sure we have a good solution if there's ever a case where we need to set dynamic settings before a peer joins. But I think this can wait. | 18:04 |
| * bthomas is craving a five guys veggie burger and fries | 18:19 | |
| * bthomas goes | 18:19 | |
| === dylan is now known as Guest95360 | ||
| dstathis | I am having an issue with the test framework | 19:19 |
| dstathis | never mind the issue is not what I thought it was | 19:21 |
| dstathis | Okay so I am still having an issue | 19:52 |
| dstathis | update_relation_data does not seem to be doing its job | 19:53 |
| dstathis | (or I don't understand it) | 19:53 |
| dstathis | https://paste.ubuntu.com/p/7CGKZGmTBc/ | 19:54 |
| dstathis | I am making that call and seeing | 19:54 |
| dstathis | https://paste.ubuntu.com/p/CYzTXVpxCW/ | 19:55 |
| dstathis | lol I see the bug. - not _ | 19:56 |
| dstathis | okay new issue | 19:56 |
| dstathis | the charm reads both the unit and app relation data on relation_changed | 19:57 |
| dstathis | but I can only set one of those at once | 19:57 |
| dstathis | so whichever I set first, I will get a failure saying the other wasn't set | 19:58 |
| dstathis | solved that too | 19:59 |
| mup | Issue operator#416 closed: Introspection for events <Created by balbirthomas> <Closed by chipaca> <https://github.com/canonical/operator/issues/416> | 20:09 |
| mup | PR operator#436 closed: Give ObjectEvents a useful __repr__ <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/436> | 20:09 |
| mup | PR operator#440 opened: Set sys.breakpointhook in main instead of Framework.__init__ <Created by chipaca> <https://github.com/canonical/operator/pull/440> | 20:14 |
| Chipaca | facubatista: ^ 440 if you're still here | 20:15 |
| facubatista | dstathis, that was fun :) | 21:26 |
| facubatista | Chipaca, will review | 21:27 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!