* Chipaca decides it's time for more coffee10:50
* bthomas resisting the urge to caffinate10:50
* Chipaca laughs10:51
Chipacathere's 75mg of caffeine in my _hydration_ tablets10:51
bthomaswow. coffee and tea are dehydrating though10:52
Chipacaon the other hand, there's 0mg of caffeine in beer10:52
Chipaca*most beer10:53
bthomaswho needs caffeine when you have beer. algthough I prefer some good port wine.10:53
* Chipaca wonders about starboard wine10:53
bthomasCockburns fine tawny is very soomth10:53
* bthomas googles starboard wine10:54
* Chipaca ⇝ coffee10:55
facubatista¡Muy buenos días a todos!11:12
facubatistaChipaca, is travis your friend today?11:13
Chipacafacubatista: travis is an enemy with benefits11:13
bthomasनमस्ते facubatista11:14
facubatistahola bthomas11:14
Chipacafacubatista: hoping for a review from jаm and then we're done11:14
* Chipaca points out 'jаm' is using a homoglyph because it's early11:15
ChipacaJoseMasson: buen día!12:13
JoseMassonBuen día!12:13
ChipacaI think I'm going to step out and get lunch12:36
bthomashttp://ops.rtfd.io/ is returning 503 service unavailable13:57
bthomasChipaca: facubatista Have you tried using your IDE to access operator framework documentation. I use Emacs with Elpy. When I try to access the documentation (C-c C-d) I get a nearly blank page. I think this may be because we are not tying in the class and module level docs correctly into the package level but I am not sure. Any way I will just create a ticket for this now as I am still busy with the refactoring.13:59
facubatistabthomas, regarding RTFD, it looks a problem on their side?14:02
facubatistabthomas, regarding proper docs building/packaging/something, thanks for the issue14:03
facubatistaChipaca, how are we coming regarding rollout?14:04
Chipacafacubatista: waiting for a review on #44014:04
mupPR #440: Set sys.breakpointhook in main instead of Framework.__init__ <Created by chipaca> <https://github.com/canonical/operator/pull/440>14:04
Chipacafacubatista: hopefully from jam 🙂14:04
mupIssue operator#441 opened: Link docstrings to package level <Created by balbirthomas> <https://github.com/canonical/operator/issues/441>14:05
* bthomas needs that coffee now14:06
Chipacaabout 'ops' being almost blank: imho, we should make it so that 'ops' is all you need to import for making a 'basic' charm14:09
Chipacai.e. everything we think is needed for just a charm (as opposed to a reusable component or extension of ops) should be doable by doing 'import ops' (or more likely 'from ops import x')14:10
Chipacaie CharmBase, and main, and the statuses, and … etc14:10
Chipacaso people don't have to guess where inside ops the thing is defined14:10
Chipaca(which would also be nice to refactor at some point)14:10
bthomasChipaca: I like that ^ idea14:18
* bthomas is jittery will at that coffee14:19
Chipacabthomas: rtfd is back14:27
bthomasJust to be clear ops documentation is accessible if you look at any particular function or class but not if you look at the whole package.14:28
Chipacabthomas: and if you look at a module?14:30
Chipacabthomas: e.g. ops.testing14:30
bthomasChipaca: still blank : both import ops.framework and from ops import framework14:31
Chipacabthomas: not even "The Operator Framework infrastructure."?14:31
bthomasChipaca: only that14:32
bthomasI mean that is the only thing that is shown14:32
Chipacabthomas: can you show me an example of something that shows more than just the toplevel docstring?14:32
bthomasChipaca: on the line from ops.charm import CharmBase , if i put the point on CharmBase and C-c C-d then I do get the docstring for CharmBase14:33
Chipacabthomas: FWIW it sounds to me like C-c C-d is less helpful than python's builtin help() which i didn't think was a low bar14:50
bthomasChipaca: indeed just tried python's help(ops), and it does give more, in particular a list of modules. For comparison I also did import json and help(json) and C-c C-d on json, both give the same output.14:53
Chipacaright, that's a good docstring there14:53
Chipacagood one14:53
Chipacaotoh, json doesn't have submodules14:53
bthomaswe should look at some other stdlib14:54
Chipacapicking multiprocessing at random14:54
bthomasurllib package level is quite sparse14:54
bthomasmultiprocessing is quite extensive14:55
Chipacabthomas: in C-c C-d?14:55
bthomasChipaca: C-c C-d is extensive for multiprocessing14:56
Chipacavery strange14:56
Chipacawhat is it doing?14:56
Chipacabecause the docstring itself is empty14:56
Chipacai installed elpy here to look into this also14:56
bthomasnice, what are you using otherwise if not elpy, python-mode ?14:57
Chipacaoooh, looks like it uses pydoc.docmodule14:57
bthomasChipaca: I wonder if __all__ needs to be in ops/__init__.py and that will make it pickup and collate module level docstrings.15:02
Chipacaso there's inspect.getdoc15:15
Chipacathat, if the module has *no docstring*, calls inspect._finddoc15:15
bthomasinteresting was not familiar with inspect.getdoc15:15
Chipacabah, no, for modules _finddoc does nothing15:17
bthomasJust to emphasise for multiprocessing both python help() and C-c C-d produce the same result15:17
bthomasThe only difference I can see between help() and C-c C-d is help() in some cases just lists the modules (without any module or lower level docs collated) where as in those case C-c C-d shows nothing.15:19
Chipacabthomas: look what happens to C-c C-d if you delete the module-level docstring entirely15:20
Chipacabthomas: i.e. if you edit __init__.py and delete the docstring15:20
bthomasChipaca: Indeed after deleting the one line docstring from ops/__init__.py I do see the list of modules (as shown by help()) and the license (placed under "DESCRIPTION" !) .15:23
bthomasusing C-c C-d15:23
justinclarkbthomas, here's the busy loop replacement PR: https://github.com/canonical/elasticsearch-operator/pull/2315:43
justinclarkReview much appreciated :)15:43
bthomashaving a look15:56
Chipacaah, dang, jam is away today16:00
Chipacajustinclark: care to review #440 ?16:00
mupPR #440: Set sys.breakpointhook in main instead of Framework.__init__ <Created by chipaca> <https://github.com/canonical/operator/pull/440>16:00
justinclarkChipaca, Yep - I'll look now.16:01
* Chipaca takes a short break16:01
justinclarkChipaca - just approved #440. Though I fear I'm not as opinionated as jam would be on this.16:59
mupPR #440: Set sys.breakpointhook in main instead of Framework.__init__ <Created by chipaca> <https://github.com/canonical/operator/pull/440>16:59
Chipacajustinclark: we can always fix it in post :-p16:59
mupIssue operator#421 closed: breakpoint handlers unconditionally installed on framework initialization <Created by stub42> <Closed by chipaca> <https://github.com/canonical/operator/issues/421>17:00
mupPR operator#440 closed: Set sys.breakpointhook in main instead of Framework.__init__ <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/440>17:00
Chipacaoh drat i forgot about #42417:01
mupPR #424: Added docstrings checks <Created by facundobatista> <https://github.com/canonical/operator/pull/424>17:01
* Chipaca hugs facubatista 17:01
Chipacayeah, i'm running tests locally and going to merge that by hand because travis is stupid slow again17:07
mupPR operator#424 closed: Added docstrings checks <Created by facundobatista> <Merged by chipaca> <https://github.com/canonical/operator/pull/424>17:08
=== ChanServ changed the topic of #smooth-operator to: general discussion of the operator framework || github.com/canonical/operator || ops 1.0.0 || charmcraft 0.5.0
Chipacafacubatista: ^17:32
facubatistaChipaca, rocanrol17:51
facubatistaChipaca, remote building now17:52
ChipacaEOW for me18:00
Chipacahave a great weekend all!18:00
Chipacadon't party _too_ hard18:00
bthomasjustinclark: I am not going to be able to finish your PR review today. I will leave only one half backed possibliy poorly thoughtout comment for you to mull over the weekend. But I will pick it up on monday along with review changes for Prometheus. Hope this is ok ?18:03
* bthomas is hungry18:03
justinclarkbthomas, sounds good. No problem at all.18:05
* facubatista eods and eows, will surely release on Monday...21:41

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!