| meena | smoser: can you take a look at my failing dmi / kenv test? | 14:36 |
|---|---|---|
| smoser | meena: link ? | 14:42 |
| meena | smoser: https://github.com/canonical/cloud-init/pull/625 | 15:18 |
| meena | wrong one, actually | 15:18 |
| meena | but that one could use your approval now | 15:19 |
| meena | smoser: this is the one with the failing test https://github.com/canonical/cloud-init/pull/621 | 15:20 |
| meena | @smoser, but that one's far away from mergable, it also needs to touch ds-identify | 15:21 |
| smoser | meena: i dont know. i looked, dont' see anything obvious. that test class is interesting. | 17:01 |
| smoser | squash-and-merge is a royal pain. | 17:03 |
| smoser | way to many things for me to do right. | 17:03 |
| smoser | for instance, i went to squash #625 and failed. | 17:04 |
| smoser | meena: would you squash taht all ? and get the commit message that you want. so that it is easier. | 17:04 |
| smoser | and i have to run | 17:04 |
| meena | smoser: ill squash 625 myself | 17:12 |
| meena | as, for 621, we can ask our local testing guru, Odd_Bloke | 17:13 |
| meena | https://github.com/canonical/cloud-init/pull/625 ← is rebased, squashed and i've updated the commit message, and would you look at that commit message?!! | 17:48 |
| === ijohnson is now known as ijohnson|lunch | ||
| Odd_Bloke | smoser: I've updated https://github.com/canonical/cloud-init/pull/642 to be 70 characters in the summary line. | 19:05 |
| meena | there exist zero tests for cloudinit/config/cc_resizefs.py … just like for cc_growpart.py… | 19:19 |
| meena | rick_h: ^ i'm not sure i want to be the first to start adding tests for these things, given that i'm only just learning how to do testing. | 19:19 |
| meena | goodness grief! it's like… `gh pr status` is actually extremely useful! | 19:21 |
| === ijohnson|lunch is now known as ijohnson | ||
| meena | https://github.com/canonical/cloud-init/pull/636 ← updated this one to… be correcter… the original patch from FreeBSD's net/cloud-init maintainer wasn't actually correct… | 20:05 |
| meena | okay, so, the reason why we have this big long function that checks if we need to resize a UFS partition is this error: | 21:21 |
| meena | growfs: requested size 6.0GB is not larger than the current filesystem size 6.0GB | 21:21 |
| meena | i have proposed a path forward, that removes a ton of code. | 21:56 |
| meena | among other things, there's no longer an `import re`; and any day you can remove `import re` is a good day. | 21:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!