[00:51] <wallyworld> kelvinliu_: no rush, off to get food, but here'sthat labels PR https://github.com/juju/juju/pull/12294
[00:53] <jam> kelvinliu_: poke
[00:54] <kelvinliu_> looking wallyworld
[01:17] <kelvinliu_> wallyworld: lgtm ty
[05:46] <wallyworld> hpidcock: i'm hoping this will solve ken's issue with rebooting microk8s and having it come up with a different ip https://github.com/juju/juju/pull/12297
[05:47] <hpidcock> wallyworld: looking
[05:55] <hpidcock> wallyworld: just one suggestion
[05:55] <wallyworld> righto, thanks
[05:55] <wallyworld> hpidcock: my troll worked :-D
[05:59] <hpidcock> wallyworld: what I'd like to see in the future for CAAS is a controller service per namespace. Then the controller publishes it's addresses into it
[05:59] <hpidcock> that way it works for microk8s clustered
[05:59] <wallyworld> yeah, the layering is wrong right now, but a fairly significant bit of work is needed to fix it
[05:59] <wallyworld> and state can't import provider or environ code so we're stuck with it for now
[06:00] <wallyworld> with having the string literal in state
[06:00] <hpidcock> state already imports provider/constants
[06:00] <wallyworld> i'd love to rework this for v3.0
[06:00] <wallyworld> sigh, ok
[06:01] <hpidcock> yeah infact state already imports caas/kubernetes/provider
[06:01] <wallyworld> double sigh
[06:01] <hpidcock> I was trying to move it to just the constants package when I did this work
[06:01] <hpidcock> hence why constants package exists now
[06:01] <wallyworld> let's fix it for 3
[06:01] <hpidcock> agreed
[07:11] <wallyworld> hpidcock: sorry, one more https://github.com/juju/juju/pull/12298
[07:24] <hpidcock> no problemo
[07:26] <hpidcock> getting close to PR #12345
[07:26] <mup> Bug #12345: isdn does not work, fritz avm (pnp?) <isdnutils (Ubuntu):Fix Released by doko> <https://launchpad.net/bugs/12345>
[10:18] <stickupkid> manadart, https://github.com/juju/juju/pull/12299
[10:23] <manadart> stickupkid: Looking.
[10:46] <stickupkid> manadart, also https://github.com/juju/juju/pull/12291