=== vrubiolo1 is now known as vrubiolo
[14:41] <smoser> otubo: are you around ?
[14:42] <smoser> How would I go about requesting or PR to do this in redhat/fedora ? (asking how i get the spec file ammended... or have someone tell me i'm ignorant)
[14:42] <smoser> https://github.com/canonical/cloud-init/blob/db2ff11dea5d884093e4e29393eeac70d3315bbb/packages/redhat/cloud-init.spec.in#L115
[14:42] <smoser> and i guess robjo , same question to you (if it isn't already present)
[14:44] <smoser> ubuntu modifies upstream to have that change, so that 'cloud-init --version' shows the packaged version (complete with whatever 'dpkg' has)
[14:44] <smoser> root@f1:~# cloud-init --version
[14:44] <smoser> /usr/bin/cloud-init 20.3-2-g371b392c-0ubuntu1~20.04.1
[14:44] <smoser> rather than just the upstream version (20.3)
[14:47] <robjo> that is build service magic I am not even sure the counters are available at the time when the spec file is processed
[14:48] <smoser> surely they are... thats an rpm spec there.
[14:48] <smoser> %{version}-%{release}
[14:48] <smoser> those should be available
[14:48] <smoser> as rpm macros, right?
[14:50] <smoser> (and thank you for responding)
[14:53] <robjo> Well version is set in the spec file to the upstream version and release is one of the counters yes, but there is a chance I am over thinking this and it is handled transparently. I'll test it, let's see what happens, easy enough to do
[14:58] <robjo> building....
[15:09] <smoser> and otubo , if you do come around, i have a question about
[15:09] <smoser>  https://git.centos.org/rpms/cloud-init/blame/SOURCES/0007-Remove-race-condition-between-cloud-init-and-Network.patch?identifier=c8
[16:27] <smoser> otubo: filed https://bugzilla.redhat.com/show_bug.cgi?id=1897616
[16:28] <ubot5`> bugzilla.redhat.com bug 1897616 in cloud-init "cloud-final.service fails if NetworkManager not installed." [Medium,New]
[16:31] <smoser> nice job ubot5`
[19:43] <robjo> smoser: # cloud-init --version
[19:43] <robjo> /usr/bin/cloud-init 20.2-4.1
[19:44] <smoser> robjo: \o/ . thank you.
[19:44] <smoser> that'll show in the logs too, which is just more helpful
[19:45] <robjo> I decided this is part of prep: https://build.opensuse.org/package/view_file/Cloud:Tools/cloud-init/cloud-init.spec?expand=1  line 138
[19:46] <robjo> Will eventually make it's way into SLE as well
[20:23] <Odd_Bloke> Nice!
[21:53] <Odd_Bloke> smoser: Your review of https://github.com/canonical/cloud-init/pull/665 would be appreciated, as it's touching (very lightly) on some fairly involved (generated) shell code that I don't fully understand. :)
[22:05] <meena> i mean, what there is hard to understand?!
[22:35] <Odd_Bloke> smoser: Thanks for the review!