| === _thumper_ is now known as thumper | ||
| stickupkid | achilleasa, bundle diff and charmhub charms https://github.com/juju/juju/pull/12318 | 12:40 |
|---|---|---|
| achilleasa | stickupkid: so the charmAdaptor is in fact a BundleResolverFactoryFactoryInvoker ;-) | 12:58 |
| stickupkid | yeah, I think that charmAdaptor can die soon'ish | 12:58 |
| stickupkid | i'd rather model dependencies closer to where they're run, but it is what it is | 12:59 |
| achilleasa | stickupkid: got some comments on ^^ | 13:18 |
| stickupkid | achilleasa, done | 14:11 |
| achilleasa | stickupkid: I am looking into store/charmadapter.go. Would it be possible to have two adaptors (one for V3+ and one for older API versions) and instantiate the appropriate one from the diff code where you already check the Charm API version? | 14:16 |
| stickupkid | ho? | 14:16 |
| achilleasa | sure | 14:16 |
| stickupkid | achilleasa, https://github.com/juju/juju/pull/12318 <-- updated | 16:22 |
| stickupkid | that was fun... | 16:22 |
| achilleasa | stickupkid: got 2 meetings back to back, can look again in ~1h | 16:27 |
| stickupkid | achilleasa, maybe | 16:27 |
| stickupkid | achilleasa, of course, i'll pick it up tomorrow morning | 16:27 |
| stickupkid | :p | 16:27 |
| === gsamfira_ is now known as gsamfira | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!