=== _thumper_ is now known as thumper [12:40] achilleasa, bundle diff and charmhub charms https://github.com/juju/juju/pull/12318 [12:58] stickupkid: so the charmAdaptor is in fact a BundleResolverFactoryFactoryInvoker ;-) [12:58] yeah, I think that charmAdaptor can die soon'ish [12:59] i'd rather model dependencies closer to where they're run, but it is what it is [13:18] stickupkid: got some comments on ^^ [14:11] achilleasa, done [14:16] stickupkid: I am looking into store/charmadapter.go. Would it be possible to have two adaptors (one for V3+ and one for older API versions) and instantiate the appropriate one from the diff code where you already check the Charm API version? [14:16] ho? [14:16] sure [16:22] achilleasa, https://github.com/juju/juju/pull/12318 <-- updated [16:22] that was fun... [16:27] stickupkid: got 2 meetings back to back, can look again in ~1h [16:27] achilleasa, maybe [16:27] achilleasa, of course, i'll pick it up tomorrow morning [16:27] :p === gsamfira_ is now known as gsamfira