| mup | Issue operator#450 opened: is_doomed() <Created by stub42> <https://github.com/canonical/operator/issues/450> | 03:05 |
|---|---|---|
| bthomas | morning | 09:08 |
| facubatista | ¡Muy buenos días a todos! | 11:13 |
| bthomas | Morning facubatista | 11:14 |
| facubatista | hola bthomas | 11:14 |
| mup | PR operator#451 opened: protect calls to juju-log from messages starting with dashes <Created by chipaca> <https://github.com/canonical/operator/pull/451> | 11:31 |
| * Chipaca takes a break | 14:15 | |
| * facubatista -> lunch | 15:48 | |
| * Chipaca refrains from setting things on fire | 16:16 | |
| * Chipaca instead gets a cuppa | 16:17 | |
| Chipaca | facubatista: charmcraft init --add-missing ? | 16:49 |
| facubatista | Chipaca, --add-missing? what for? | 16:50 |
| Chipaca | facubatista: so it adds files that are missing but doesn't overwrite existing ones | 16:52 |
| facubatista | Chipaca, with a log in warning like "not creating/writing foo because it's already there"? | 16:59 |
| facubatista | Chipaca, I'm +1 to the idea, anyway | 16:59 |
| * facubatista -> bank | 16:59 | |
| Chipaca | facubatista: sgtm | 16:59 |
| * Chipaca ⇝ not a bank | 16:59 | |
| Chipaca | :-p | 16:59 |
| bthomas | Heck. No easy way to change "forked from" on github. So I have to delete my github mongodb repo and re-create it. justinclark JoseMasson please note ^ service disruption for the next 5-10 mins. | 17:16 |
| bthomas | justinclark: done https://github.com/canonical/mongodb-operator/pull/1 | 17:21 |
| mup | PR mongodb-operator#1: Refactor <Created by balbirthomas> <https://github.com/canonical/mongodb-operator/pull/1> | 17:21 |
| * bthomas takes a tea break | 17:22 | |
| justinclark | Thanks bthomas. Taking a look now. | 17:34 |
| * bthomas is back | 17:35 | |
| bthomas | justinclark: please keep in mind there is still small bits of work to be done like adding tests, socstrings, cleaning up comments, messages etc. Somethings I can do part of the review but for tests I will create a separate pull request. | 17:36 |
| JoseMasson | bthomas: I added some comments about fstrings | 17:40 |
| bthomas | thanks JoseMasson will gladly make all changes to keep you happy :-) | 17:40 |
| justinclark | bthomas, noted. I think the most important thing is that there's a working charm that can be used by KubeCon people. Those other things can come later. | 17:41 |
| JoseMasson | Nooo I love fstring, but Xenia don't :P | 17:41 |
| bthomas | he, he | 17:41 |
| bthomas | I like fstrings too. Sorry that slipped by. I wasn't focused on these things during the refactor. | 17:42 |
| bthomas | thanks for pointing it out. | 17:42 |
| JoseMasson | bthomas: If you want, you can copy this file to mongodb-operator repo in order to have CI in every PR and commit: https://github.com/canonical/graylog-operator/blob/main/.github/workflows/python-package.yml | 17:43 |
| bthomas | JoseMasson: We should add you to charmcraft team so we can add you to reviews through github. Not sure how to go about it though. Perhaps ping jldev. Thanks for CI link. Will add it. If you don't mind please put it in a review comment so I can address all review comments together. | 17:44 |
| JoseMasson | ack | 17:45 |
| JoseMasson | JoseMasson: Lunch time! I'll be back in some minutes | 17:46 |
| Chipaca | ok peeps i'm stepping out | 18:03 |
| Chipaca | facubatista: @ me on mattermost for those reviews, if and when | 18:03 |
| Chipaca | if it's later than my 2300 i'll get to them tomorrow morning 🙂 | 18:03 |
| * bthomas presses his "off" button | 18:04 | |
| * facubatista is back | 18:27 | |
| mup | Issue operator#452 opened: event.unit is None when using update_relation_data <Created by dstathis> <https://github.com/canonical/operator/issues/452> | 21:25 |
| dstathis | Just made a PR for charmcraft force option. Feedback welcome | 22:17 |
| === facubatista changed the topic of #smooth-operator to: general discussion of the operator framework || github.com/canonical/operator || ops 1.0.1 || charmcraft 0.6.1 | ||
| * facubatista eods now | 23:13 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!