[00:17] <mup> PR snapd#9653 opened: strutil/shlex,osutil/udev/netlink: minimally import go-check <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9653>
[00:27] <mup> PR snapd#9654 opened: boot/makebootable.go: set snapd_recovery_mode=install at image-build time <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9654>
[07:32] <zyga-x240> good morning :)
[07:43] <zyga-x240> hey mvo
[07:43] <zyga-x240> gooood morning :)
[07:43] <zyga-x240> (Some sunshine in the morning, not just clouds here)
[07:43] <mvo> goooood morning zyga-x240 !
[08:06] <pstolowski> morning
[08:06] <zyga-x240> good morning pstolowski
[08:07] <mvo> good morning pstolowski
[08:07] <pstolowski> o/
[09:04] <mup> PR snapd#9488 closed: boot/fdehelper: add initrd fdehelper support <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9488>
[10:09] <mup> PR core20#95 closed: Rpi kernel names <Created by xnox> <Merged by xnox> <https://github.com/snapcore/core20/pull/95>
[13:35] <pstolowski> could use a 2nd review for #9652 as it tends to fail in master
[13:35] <mup> PR #9652: o/servicestate: unlock state before calling wrappers in doServiceControl <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9652>
[13:40] <mup> PR snapd#9555 closed: asserts: implement "storage-safety" in uc20 model assertion <Needs Samuele review> <Skip spread> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9555>
[13:42] <mvo> pstolowski: I have a look, can I squash merge it? looks like something worthwhile to pull into 2.48?
[13:43] <mvo> pstolowski: oh, nevermind, this is new in 2.49, yes?
[13:45] <mvo> pstolowski: or not? anyway, just tell me async or at the standup :)
[14:00] <mup> PR snapd#9611 closed: tests: migrate test from boot.sh helper to boot-state tool <Squash-merge> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9611>
[14:00] <mup> PR snapd#9655 opened: tests: fix fsck on boot on arm devices <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9655>
[14:09] <mborzecki> hellos
[14:34] <mup> PR snapcraft#3379 opened: cli: warn when running snapcraft inside assets directory <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3379>
[14:34] <ijohnson> hey mborzecki
[14:55] <mvo> thanks for your reviews pstolowski !
[14:55] <pstolowski> yw
[15:18] <mborzecki> ijohnson: hey
[15:22] <zyga-x240> hey ijohnson :-)
[15:29]  * cachio lunch
[15:30] <pedronis> ijohnson: should we chat quickly now in SU about the "install" vs "" ?
[15:30] <ijohnson> pedronis: yes I am free now if you would like to talk
[15:30] <ijohnson> let me join the SU
[16:16] <mup> PR snapd#9656 opened: devicestate: support "storage-safety" defaults during install <Run nested> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9656>
[16:32] <pedronis> mvo: pstolowski: question and comments in #8929
[16:32] <mup> PR #8929: many: add new "install-mode: disable" option <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8929>
[16:35] <mvo> pedronis: thank you!
[17:01] <pedronis> pstolowski: I did a first on #9409, let me know if you have questions
[17:01] <mup> PR #9409: cmd/snap: implement 'snap validate' command <validation-sets :white_check_mark:> <⛔ Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9409>
[17:01] <pstolowski> pedronis: thank you!
[18:31]  * mvo hugs pedronis for the review in 9642
[18:38] <cachio> ijohnson, hi, thanks for the review on #9655
[18:38] <mup> PR #9655: tests: fix fsck on boot on arm devices <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9655>
[18:38] <cachio> I already updated that
[18:39] <ijohnson> cachio: yaw
[19:17] <mup> PR snapd#9657 opened: snap: use the boot-base for kernel hooks <Needs Samuele review> <Squash-merge> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9657>
[19:44] <mvo> ijohnson|lunch: could you please open 9654 for 2.48? it seems like it is conflicting so I can't do a straight cherry-pick. maybe easier if you just use 2.48 as the base and cherry-pick whatever is needed so that things don't conflict (if that's easier)
[19:46] <ijohnson|lunch> mvo: sure
[19:46] <ijohnson|lunch> I'll do that now
[19:47] <mup> PR snapd#9654 closed: boot/makebootable.go: set snapd_recovery_mode=install at image-build time <Simple 😃> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9654>
[19:48] <ijohnson|lunch> ah the conflicts were from a pr maciej landed to master recently
[19:51] <ijohnson|lunch> mvo: for reference, #9643 is the pr that was landed to master which made my 9654 have conflicts
[19:51] <mup> PR #9643:  bootloader: use ForGadget when installing boot config  <Run nested> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9643>
[19:56] <ijohnson> mvo: I think it's fine that we don't backport 9643 to 2.48 fwiw, so we can just go with my backport #9658 to 2.48, but note that if we change our mind it will be awkward to backport 9643 now if we do merge 9658
[19:56] <mup> PR #9658: boot/makebootable.go: set snapd_recovery_mode=install at image-build time <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9658>
[19:57] <ijohnson> the alternative would be to first backport 9643, then backport my pr via cherry-pick
[19:57] <mup> PR snapd#9658 opened: boot/makebootable.go: set snapd_recovery_mode=install at image-build time <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9658>
[19:57] <mvo> ijohnson: ok
[19:58] <ijohnson> up to you
[19:58] <ijohnson> I'm happy to open a backport of maciej's pr too if you'd rather do that, I don't think it necessarily fixes any bugs though it's just more a nicety
[19:59] <mvo> ijohnson: hm, 9643+cherry pick of your PR sounds good to me, I think it's worth having to make future cherry-picks easier
[20:00] <mvo> ijohnson: i.e. right now I think it's best if we stay close
[20:00] <ijohnson> mvo: ack let me quickly check for you if 9643 cleanly applies, I think it should
[20:00] <mvo> ijohnson: \o/
[20:04] <ijohnson> mvo: yeah you can just straight cherry pick all the commits from maciej's branch and then mine cleanly onto 2.48
[20:05] <ijohnson> mvo: I did this:
[20:05] <ijohnson> https://www.irccloud.com/pastebin/fxNX4rOI/
[20:11] <mvo> ijohnson: cool! ideally we would open maciejs PR just for 2.48 because the auto-changelog generator uses merge commits
[20:11] <ijohnson> mvo: ok, I can do that for you too
[20:11] <ijohnson> give me a moment then
[20:11] <mvo> ijohnson: \o/ thanks a lot
[20:11] <mvo> ijohnson: no rush, I will just do that in my morning
[20:12] <ijohnson> ah okay then
[20:16]  * zyga is happy to see mvo EOD at reasonable times
[20:16] <ijohnson> haha indeed
[20:32] <mup> PR snapd#9659 opened: strutil/cmdline.go: add GetKernelCommandLineKeyValue <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9659>
[22:18] <mup> PR snapd#9660 opened: gadget/gadget.go: allow system-recovery-{image,select} as roles in gadget.yaml <Needs Samuele review> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9660>
[22:23] <mup> PR snapd#9658 closed: boot/makebootable.go: set snapd_recovery_mode=install at image-build time <UC20> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/9658>