| blackboxsw | approved integration test updates https://github.com/canonical/cloud-init/pull/672 | 00:01 |
|---|---|---|
| user217_ | blackboxsw, thnks for help | 00:02 |
| === dionysus70 is now known as dionysus69 | ||
| otubo | blackboxsw: thanks for the update on the release! I'll work on the rebase for Fedora once it's out. :) | 10:33 |
| johnsonshi | Odd_Bloke and blackboxsw: Thank you so much for reviewing #594 (Azure report failure functionality) and #619 (Azure endpoint increased HTTP retries). I've just addressed the final set of minor comments and NITs in both PRs, so they should be mergeable. Given that #594 (Azure report failure functionality) is more complicated than #619 (increased http retries), let's merge #594/Azure-report-failure first. | 10:57 |
| johnsonshi | If we merge #594 (https://github.com/canonical/cloud-init/pull/594) first, if there are any merge conflicts, the conflicts should be easier to resolve in #619 (https://github.com/canonical/cloud-init/pull/619). | 10:58 |
| vijayendra | rharper, updated as per your review comments. https://github.com/canonical/cloud-init/pull/647# | 11:03 |
| Odd_Bloke | johnsonshi: Ack, thanks for the update; #594 is top of my list for today. :) | 14:25 |
| Odd_Bloke | blackboxsw: Extremely simple follow-up to #673: https://github.com/canonical/cloud-init/pull/674 | 14:54 |
| Odd_Bloke | I'm investigating the build failures in master, BTW. | 15:41 |
| Odd_Bloke | (That's going to block landing anything we review, so it's the priority.) | 15:41 |
| Odd_Bloke | First thing I've tried is removing the Travis cache; that will force a re-debootstrap which may address the issue. | 15:46 |
| Odd_Bloke | That looks like it's fixed it, it's past the point of failure on this next build. | 15:50 |
| Odd_Bloke | I'm going to clear out all the rest of the caches in Travis, to be sure we won't hit that issue on existing branches/PRs. | 15:52 |
| Odd_Bloke | It's not letting me clear out some of the pushed branches' caches, for some reason. Specifically: cryptography-3.2, groovy, xenial, devel. Given that we don't run the package builds in the packaging branches, I think that should be fine. | 15:55 |
| Odd_Bloke | But FYI in case folks see failures because apt-transport-https isn't installed during package build (which it shouldn't need to be). | 15:56 |
| blackboxsw | Odd_Bloke: thanks for review on johnsonshi's #594, I just merged https://github.com/canonical/cloud-init/pull/619 too | 18:04 |
| * blackboxsw checks 647 | 18:04 | |
| blackboxsw | 675 | 18:04 |
| blackboxsw | hah | 18:04 |
| blackboxsw | ahh already landed right | 18:04 |
| meena | blackboxsw, if you lookin for work, https://github.com/canonical/cloud-init/pull/655 needs a review from someone who can make green ✅ | 18:11 |
| johnsonshi | Odd_Bloke blackboxsw: Thanks for merging both PRs! | 18:12 |
| === ijohnson is now known as ijohnson|lunch | ||
| AnhVoMSFT | @blackboxsw Thanks for the suggestions on unit tests for https://github.com/canonical/cloud-init/pull/670. I have updated it with the requested unit tests | 18:19 |
| === hjensas__ is now known as hjensas | ||
| asakkurr | Hi Odd_Bloke, I addressed your comments in #613 and sent a new update. Apologies for the delay here, I was out last week. Please do let me know if you have any more suggestions, I'll get to them asap this time. https://github.com/canonical/cloud-init/pull/613 | 19:09 |
| Odd_Bloke | asakkurr: No worries, thanks for making the changes! That's next on my list of reviews to revisit. :) | 19:18 |
| === ijohnson|lunch is now known as ijohnson | ||
| shurdeek | hello. I was wondering if there is something similar to cloud-init for macOS | 20:25 |
| Odd_Bloke | shurdeek: Not to my knowledge, no. | 20:38 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!