[00:53] <mup> PR snapd#9661 opened: osutil/disks: add DiskFromName to get a disk using a udev name <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9661>
[02:04] <mup> PR snapd#9662 opened: bootloader/many: return error from ConfigFile and new* functions <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9662>
[02:19] <mup> PR snapd#9663 opened: tests/main/lxd/prep-snapd-in-lxd.sh: wait for archive DNS before apt things <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9663>
[06:55] <mup> PR snapd#9646 closed: tests/many: enable some uc20 tests, delete old unneeded tests or TODOs <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9646>
[06:59] <mborzecki> morning
[07:23] <zyga-x240> good morning guy
[07:23] <zyga-x240> *guys
[07:23] <zyga-x240> my s key is still broken here ;D
[07:26] <mborzecki> zyga-x240: heya
[07:45] <mup> PR snapd#9649 closed: seed: make a shared seed system label validation helper <Simple 😃> <Squash-merge> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9649>
[08:01] <pstolowski> morning
[08:08] <mborzecki> pstolowski: hey
[08:08] <mborzecki> weird, our 18.04 images have systemd-resolved running, resolv.conf points to 127.0.0.1:53 (so resolved), but there's no resolvectl in $PATH
[08:12] <mborzecki> wth there's no resolvectl in 18.04?
[08:15] <mborzecki> heh in systemd 239 they did s/systemd-resolve/resolvectl/
[08:17] <mborzecki> mvo: hey
[08:17] <mvo> hey mborzecki and pstolowski
[08:24] <mborzecki> mvo: squash merged https://github.com/snapcore/snapd/pull/9649 can you cherry pick?
[08:24] <mup> PR #9649: seed: make a shared seed system label validation helper <Simple 😃> <Squash-merge> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9649>
[08:25] <mvo> mborzecki: correct
[08:27] <mvo> mborzecki: is that an issue?
[08:28] <mborzecki> mvo: hm not a big one, but one of the tweaks was to allow only lowercase letters in system label so that we don't end up in a silly state when seed is on FAT
[08:31] <mvo> mborzecki: oh and you would like to have cherry picked this tweak elesewhere too?
[08:32] <mvo> mborzecki: oh, sorry, I think I misunderstood, I want to cherry pick this, yes :)
[08:33] <mvo> mborzecki: and done
[08:35] <zyga-x240> hey mvo :)
[08:35] <mborzecki> mvo: thanks!
[08:35] <mvo> good morning zyga-x240 !
[08:36] <mborzecki> mvo: idk if i mentioned this, but it looks like the fonts issue may have been fixed in snapcraft https://forum.snapcraft.io/t/snapped-app-not-loading-fonts-on-fedora-and-arch/12484/79 i found a PR https://github.com/snapcore/snapcraft/pull/3299 but it's 4.4+
[08:36] <mup> PR snapcraft#3299: extensions: configure hook for fonts <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3299>
[08:40] <mvo> mborzecki: oh, that is amazing
[08:40] <mvo> mborzecki: I had hoped this would happen, really cool that it actually did
[08:41] <mborzecki> mvo: mhm, one nitpick, one needs to rebuild the snap using snapcraft 4.4
[08:53] <mvo> mborzecki: meh, right
[08:54] <mvo> did you guys also see "fsck-on-boot" failing on ubuntu-core-20 ?
[08:54] <mvo> it seems like a new thing
[08:54] <mborzecki> mvo:  did you build the image today?
[08:55] <mborzecki> mvo: and is the system encrypted?
[08:56] <mup> PR snapd#9651 closed: tests: fix basic20 test on arm devices <Simple 😃> <Squash-merge> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9651>
[09:03] <pedronis> mvo: Ian mentioned it in the SU notes
[09:04] <mvo> pedronis: thank you!
[09:05] <mvo> pedronis: in 9659 you suggest to move KenrelCommandLineSplit, what pkg do you have in mind? boot?
[09:05] <mvo> pedronis: or soemthing like boot/{k,}cmdline?
[09:06] <pedronis> mvo: osutil seems also fine
[09:06] <mvo> pedronis: cool, I have a look
[09:14] <mvo> pedronis: updated 9659
[09:14] <mborzecki> mvo: are you looking into fsck-on-boot test?
[09:14] <mvo> mborzecki: I was just booting a qemu to poke around
[09:15] <mvo> mborzecki: not sure how far I get, I let you know if I need to give up
[09:16] <pedronis> mvo: I put it back into my queue
[09:18] <mvo> ta
[09:41] <mborzecki> duh, wth? `Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 16829 (unattended-upgr)`
[09:41] <mvo> mborzecki: where do you see that?
[09:41] <mvo> mborzecki: fwiw, we should probably disable u-u
[09:42] <mvo> mborzecki: fwiw^2 - modern apt will retry locking but iirc only when used interactively :/
[09:48] <mborzecki> mvo: 20.04
[09:48] <mborzecki> mvo: yeah, unattended-upgrades service is running in a 20.04 image we use
[09:55] <pedronis> zyga-x240: I did a pass now on #9546, I can likely take care of some of my own comments when I have a moment  but one is a question
[09:55] <mup> PR #9546: overlord: add inert export manager <Created by zyga> <https://github.com/snapcore/snapd/pull/9546>
[09:55] <zyga-x240> pedronis: woot, thank you
[09:55] <zyga-x240> I will look at the comment shortly
[09:55] <pedronis> thx
[09:57] <mborzecki> mvo: huh, unattended-upgrades is running in 18.04 images too
[10:11] <mup> PR snapd#9653 closed: strutil/shlex,osutil/udev/netlink: minimally import go-check <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9653>
[10:11] <mup> PR snapd#9664 opened: spread: disable unattended-upgrades on ubuntu <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9664>
[10:16] <niemeyer> Morning all
[10:16] <niemeyer> Would anyone recall if we have any task/change in snapd that is transient, in the sense it's supposed to run only during the lifetime of the current snapd execution?
[10:17] <niemeyer> I'm guessing the answer is no, since tasks precisely overcome the fact that we want the task to be accomplished no matter how many times we restart, but checking just in case
[10:19] <zyga-x240> niemeyer: I don't think we have that
[10:20] <pedronis> niemeyer: no, indeed not so far, the closest would be some of the hot plug tasks, but they are stil persistent and it's useful but we need to be a bit careful with them
[10:20] <niemeyer> Ah, interesting.. careful in what sense?
[10:21] <pedronis> we need to make sure that we run them in order, even if they are in different changes. that is very unusual, for most other tasks the conflict logic avoid that kind of issue at all
[10:21] <niemeyer> Interesting indeed
[10:22] <pedronis> otherwise you might end up trying to add and remove a slot at the same time
[10:22] <niemeyer> I see, thanks for the details
[10:34] <mvo> mborzecki: fwiw, no progress on "fsck-on-boot" not running but core20 was stuck in manual recore
[10:34] <mvo> mborzecki: manual review, I unblocked it and will run again once the store has published it
[10:35] <mvo> mborzecki: it looks legit though, there is really no fsck happening now
[10:35] <mvo> mborzecki: but the fsck.vfat binary is still there
[10:35] <mborzecki> mvo: maybe there is but not clearing the dirty bit?
[10:40] <pedronis> zyga-x240: I commented on my comment, not sure what I'm saying there makes sense though
[10:53] <mborzecki> pstolowski: can you take a look at https://github.com/snapcore/snapd/pull/9556 ?
[10:53] <mup> PR #9556: tests: testing new fedora 33 image <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9556>
[10:53] <pstolowski> sure
[11:00] <pedronis> mvo: mborzecki: I commeted again on #9659
[11:00] <mup> PR #9659: strutil/cmdline.go: add GetKernelCommandLineKeyValue <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9659>
[11:00] <pedronis> *commented
[11:01] <mvo> pedronis: looking
[11:08] <pstolowski> mborzecki: shouldn't we drop fedora-31-64 from spread.yaml per my existing comment?
[11:09] <niemeyer> Another trivial: in hookstate, this comment is bogus:
[11:09] <niemeyer>  // check if we're a hook task, probably not needed but let's take extra care
[11:10] <niemeyer> It necessarily must check if it's a run-hook task, otherwise it'd be evaluating an unknown task
[11:10] <niemeyer> (the predicate runs for all tasks)
[11:12] <mborzecki> pstolowski: it's not EOL yet
[11:13] <mborzecki> hm let me double check actually
[11:13] <mborzecki> pstolowski: mhm, it'll eol in a couple of feeks
[11:14] <pstolowski> mborzecki: i misread Sergio's PR desc, it says 'Also fedora 31 is not executed anymore, it remains manual' i
[11:14] <pstolowski> mborzecki:  makes sense to keep it for a while then
[11:14] <mborzecki> yup
[11:16] <pstolowski> mborzecki: but.. i confused about all the dropping for -fedora-31-* in this PR
[11:16] <pstolowski> *i'm*
[11:17] <mvo> mborzecki: so we got a new kernel yesterday with new initrd, I wonder if that could have broken the fsck, I see no systemd-fsck message for ubuntu-seed in journalctl
[11:19] <mvo> mborzecki: ohhh, I think it might be PR#8 from core-initrd ... we now bind mount /run/mnt/ubuntu-seed so *maybe* this triggers it
[11:20]  * mvo looks a bit deeper
[11:29] <mborzecki> pstolowski: otoh, f31 is eol on 24.11, so maybe we should just drop it now
[11:31] <pstolowski> mborzecki: +1,
[11:51] <mup> PR snapd#9665 opened: tests: unmount /boot/efi in fsck-on-boot test <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9665>
[11:55] <pstolowski> mborzecki: are you updating that PR?
[11:56] <mborzecki> pstolowski: yeah, i pushed an update
[12:05] <pedronis> niemeyer: thx, I took note of that
[12:08] <mborzecki> mvo: hm i see that the bit is set in a vm too
[12:08] <mborzecki> mvo: so the question is, are we even looking at the right bit?
[12:08] <mvo> mborzecki: maybe not, not sure, but my PR above fixes the issue
[12:09] <mvo> mborzecki: how did you test it in the vm? spread with qemu cannot run core20 currently :/ ?
[12:09] <mborzecki> mvo: i built the image myself and booted it
[12:13] <mvo> ok
[12:16] <mup> PR snapd#9642 closed: boot: add scaffolding for "fde-setup" hook support for sealing <Squash-merge> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9642>
[12:46] <niemeyer> pedronis: Thanks! No big deal obviously..
[12:47] <niemeyer> It just got my attention because I went looking into the predicates to see if something else might be filtering them up
[12:51] <pstolowski> mvo: #9627 has +1 from Alex; i can prepare followup for other interfaces that need access to tty
[12:51] <mup> PR #9627: interfaces/raw_usb: allow read access to /proc/tty/drivers (LP: #1890365) <Needs security review> <Created by oSoMoN> <https://github.com/snapcore/snapd/pull/9627>
[13:05] <cachio> mbeierl, hey
[13:05] <cachio> mborzecki, hey
[13:06] <mborzecki> cachio: hey, what's up?
[13:06] <cachio> I see this error in open suse
[13:06] <cachio> + su -c 'SNAPPY_USE_STAGING_STORE=0 snap prepare-image --channel edge --snap test-snapd-tools /home/gopath/src/github.com/snapcore/snapd/tests/lib/assertions/developer1-pc.model /tmp/root' test
[13:06] <cachio> error: cannot fetch and check prerequisites for the model assertion: circular assertions are not expected: account (testrootorg)
[13:06] <cachio> preparing image
[13:06] <cachio> did you notice that?
[13:06]  * mbeierl thinks I need a new nick :)  Sorry mborzecki for being a second "mb<tab>"!
[13:06] <cachio> it just fails in opensuse
[13:10] <mborzecki> cachio: no clue, but does not look like anything opensuse related
[13:13] <pedronis> mborzecki: cachio: something broke in the build and we don't include the test key anymore ?
[13:14] <pedronis> that would be something that provokes that
[13:14] <mborzecki> pedronis: hm maybe some option is being ignored and testkeys tags does not get set during build
[13:14] <cachio> systems: [-ubuntu-core-*, -fedora-*, -opensuse-*, -arch-*, -amazon-*, -centos-*]
[13:14] <mborzecki> looks like i should investigate
[13:15] <cachio> the test should not be executed on opensuse
[13:15] <ijohnson> morning folks
[13:15] <cachio> good morning
[13:15] <ijohnson> hey cachio
[13:17] <cachio> mborzecki, foud the problem
[13:17] <ijohnson> anybody look into the core/fsck-on-boot spread test yet ?
[13:17] <ijohnson> ah I see mvo found the issue in 9665
[13:19] <cachio> ijohnson, you mean #9655 right?
[13:19] <mup> PR #9655: tests: fix fsck on boot on arm devices <Squash-merge> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9655>
[13:20] <ijohnson> cachio: no core/fsck-on-boot started failing all the time yesterday
[13:20] <ijohnson> mvo fixed the issue in #9665 it seems
[13:20] <mup> PR #9665: tests: unmount /boot/efi in fsck-on-boot test <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9665>
[13:20] <cachio> ijohnson, ahh, It was not me :)
[13:20] <ijohnson> cachio: but also please take a look at that PR, as I think you will want to handle that change in your PR
[13:22] <mup> PR snapd#9665 closed: tests: unmount /boot/efi in fsck-on-boot test <⚠ Critical> <Created by mvo5> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9665>
[13:22] <cachio> ijohnson, yes
[13:22] <cachio> done
[13:24] <ijohnson> thanks cachio
[13:25] <cachio> ijohnson, I think I need to update that for arm because /boot/efi does not exist
[13:25] <ijohnson> cachio: precisely
[13:31] <niemeyer> pedronis: Another nit for an eventual lazy afternoon: the hookstate manager is currently breaking through the overlord abstraction and being manipulated directly by the daemon. Instead, we should extend the StateManager API with something like a Halt early signal, which would replace GracefullyWaitForHooks in a general way
[13:33] <ijohnson> pedronis: I responded to #9662, hopefully it makes sense, if not we should chat today ideally because this will block further prs on supporting lk
[13:33] <mup> PR #9662: bootloader/many: return error from ConfigFile and new* functions <UC20> <⛔ Blocked> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9662>
[13:43] <pedronis> ijohnson: it sounds like we need to chat, because you explained the problem, but is still unclear that the content of the PR is the right path
[13:43] <ijohnson> pedronis: ok sorry I just left another comment
[13:43] <ijohnson> pedronis: when are you free today?
[13:44] <ijohnson> I guess I could chat now before SU
[13:45] <pedronis> ijohnson: let's chat now
[13:45] <ijohnson> k, joining now
[13:51] <mvo> pstolowski: sounds great, thank you
[13:57] <mup> PR snapd#9627 closed: interfaces/raw_usb: allow read access to /proc/tty/drivers (LP: #1890365) <Needs security review> <Created by oSoMoN> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9627>
[14:07] <zyga-x240> pedronis: I eod at 16:00 today, I can send some follow ups then
[14:31] <pedronis> zyga-x240: ok, thx, I pushed a merge fixing conflicts btw
[14:33] <zyga-x240> pedronis: thank you
[14:37] <mup> PR snapd#9666 opened: tests: updated the systems to run prepare-image-grub test <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9666>
[14:41] <pedronis> cachio: mborzecki: ^ but we don't support explicitly building images on those other distros, that was the reason of the skipping
[14:42] <pedronis> ijohnson: ^
[14:42] <cachio> pedronis, ok, so I'll disable them and add a tag
[14:42] <ijohnson> pedronis: yeah I was wondering the same
[14:42] <mup> PR snapd#9667 opened: devicestate: implement boot.HasFDESetupHook <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9667>
[14:42] <ijohnson> pedronis: IMHO if it works let's just run it there anyways
[14:42] <ijohnson> if or when it breaks we can decide whether it's worth it to fix that or not I think
[14:43] <ijohnson> but that's just me
[14:43] <pedronis> ijohnson: well, the issue is that is not an interesting test from tht pov
[14:43] <pedronis> becaused it's only prepare-image
[14:43] <pedronis> not ubuntu-image
[14:43] <ijohnson> I guess I'm just of the opinion if it passes on that system why not let it run there
[14:43] <pedronis> so it passing doesn't mean much full-picture-wise
[14:43] <pedronis> ijohnson: because tests take time
[14:43] <pedronis> and those time adds up
[14:44] <pedronis> and also see othe remark
[14:44] <pedronis> as is it doesn't prove or disproves anything
[14:44] <ijohnson> sure then just disable it for those other systems
[14:44] <ijohnson> I don't feel strongly enough about it to argue otherwise
[14:45]  * ijohnson perhaps has just gotten too used to the fact that tests take ages and are never green anyways to not be worried about additional time for tests to execute
[14:52] <mup> PR snapd#9668 opened: bootloader: use ForGadget when installing boot config (2.48) <Created by mvo5> <https://github.com/snapcore/snapd/pull/9668>
[14:52] <mborzecki> fwiw, i'm using ubuntu-image which runs snap prepare-image on arch, so we get at least some testing on other distros here
[15:15] <cachio> ijohnson, I updated the change
[15:15] <cachio> included 2 other tests
[15:25]  * cachio lunch
[15:26] <ijohnson> cachio: approved
[15:30] <pedronis> mvo: some comments/questions in #9667
[15:30] <mup> PR #9667: devicestate: implement boot.HasFDESetupHook <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9667>
[15:32] <mup> PR snapd#9669 opened: [RFC] interfaces: allow read access to /proc/tty/drivers to modem-manager and ppp <Needs security review> <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9669>
[15:45] <mvo> pedronis: thanks! I will look in a wee bit
[15:49] <zyga> pedronis I'm grabbing coffee and looking at that branch in a moment
[16:01] <pedronis> zyga: ok, about to be in a meeting
[16:01] <zyga> ok
[17:10] <ijohnson> pedronis: is it a strong property that we want to error if snapd_recovery_mode is specified multiple times on the kernel command line we error in the initramfs ? that is the way it currently works with the code originally written by mborzecki in boot/cmdline.go, but if we don't have such strong checking we can simplify the code somewhat with the (imho) reasonable assumption that later values override earlier ones
[17:11] <ijohnson> (and same for snapd_recovery_label)
[17:35] <pedronis> ijohnson: you need to double check but I think that's the kernel behavior as well https://www.kernel.org/doc/html/v4.14/admin-guide/kernel-parameters.html ?
[17:36] <ijohnson> pedronis: which behavior is the same as the kernel ?
[17:36] <pedronis> ijohnson: last wins
[17:36] <ijohnson> pedronis: ah ok good
[17:36] <pedronis> otoh when we measure it, it won't matter much anyway
[17:36] <pedronis> or matter a lot in the sense that it won't both ;)
[17:37] <ijohnson> I mean it's kinda a nice property that if you define it multiple times uc20 freaks out at you for board enablement folks
[17:37] <ijohnson> but it's also cumbersome to code
[17:37] <ijohnson> right yes in the measurement case it doesn't really matter
[17:40] <pedronis> ijohnson: though in my proposal it might be not too hard to code for either behavior, it would need to be a flag though
[17:40] <ijohnson> pedronis: well it seems the kernel is a little different, for known parameters it will invoke callbacks for each parameter, so in the case of duplicated parameters it will call the callback twice, first with the first value and then again with the second value
[17:40] <ijohnson> but for things like snapd_recovery_mode that the kernel doesn't care about, then it essentially doesn't matter
[17:41] <ijohnson> pedronis: yeah I thought maybe to handle it we could return a `map[string][]string` but it makes some other usages more complicated
[17:41] <ijohnson> I think for our purposes since we are not the kernel, it's ok to just let the last one win
[18:08] <mup> PR snapd#9668 closed: bootloader: use ForGadget when installing boot config (2.48) <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9668>
[19:54] <cachio> ijohnson|lunch, is it ok #9650 ?
[19:54] <mup> PR #9650: tests: skip boot state test on arm devices <Simple 😃> <Squash-merge> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9650>
[19:55] <cachio> it is ready for merge
[20:04] <mup> PR snapd#9666 closed: tests: updated the systems to run prepare-image-grub test <Simple 😃> <Squash-merge> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9666>
[20:04] <ijohnson|lunch> cachio approved thanks
[20:04] <cachio> ijohnson|lunch, yaw
[20:09] <mup> PR snapd#9650 closed: tests: skip boot state test on arm devices <Simple 😃> <Squash-merge> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9650>
[20:09] <pedronis> ijohnson|lunch: do you need input on anything right now?
[20:13] <ijohnson> pedronis: no, not really but just to be clear it's okay to not fatally error if there is a duplicated kernel command line parameter for snapd_recovery_{mode,system} ?
[20:14] <pedronis> ijohnson: it's ok (we can always change it again), I think the most affected case would be playing with it and then turning on encryption later, but we don't really support playing with the command line that much for relevant systems atm
[20:14] <ijohnson> right
[20:15] <ijohnson> ok, sounds good that's what I implemented and was about to push up changes for
[22:34] <mup> PR snapcraft#3380 opened: snap packaging: fix broken path check when copying local icon <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3380>
[22:39] <mup> PR snapd#9655 closed: tests: fix fsck on boot on arm devices <Squash-merge> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9655>