[05:55] <mup> PR snapd#9707 opened: update-pot: fix typo in plural keyword spec <Simple 😃> <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/9707>
[06:54] <mborzecki> morning
[07:10] <mup> PR snapd#9706 closed: tests: fix uc20-create-parition-* tests for updated gadget <⚠ Critical> <Created by mvo5> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9706>
[07:22] <zyga> good morning
[07:23] <zyga> final day of cycle scheduling for me, after that I will have time for pushing snapd forward
[07:40] <mborzecki> zyga: hey
[07:44] <zyga> hey :)
[07:44] <zyga> feeling better?
[07:46] <mborzecki> zyga: yeah, much better but still a bit weak
[08:02] <pstolowski> morning
[08:03] <mvo> good morning pstolowski and mborzecki
[08:04] <mborzecki> pstolowski: mvo: hey
[08:04] <pstolowski> mborzecki: how are you? feeling better?
[08:05] <mborzecki> pedronis: yes, feeling better now
[08:12] <mvo> mborzecki: great to hear! take it slowely if you still feel weak
[08:15] <mborzecki> heh i replaced some not MATCH with NOMATCH but it looks like as if it's just spawninng subshells in a loop
[08:16] <zyga> mborzecki, oh
[08:16] <zyga> maybe a bug in the wrapper somewhere
[08:16] <zyga> NOTMATCH was added to the redirect system relatively recently
[08:16] <mborzecki> + NOMATCH /run/mnt/ubuntu-seed
[08:16] <mborzecki> + mount
[08:16] <mborzecki> /bin/bash: warning: shell level (1000) too high, resetting to 1
=== pedronis_ is now known as pedronis
[08:32] <mborzecki> zyga: nvm, my fork of spread was not rebased on top of latest master, that's why NOMATCH was not define as a function in spread
[08:36] <mup> PR snapd#9708 opened: tests/main/uc20-create-partitions: verify ubuntu-save encryption keys, tweak not MATCH <Simple 😃> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9708>
[08:36] <mborzecki> mvo: ^^
[08:40] <mvo> mborzecki: thanks, looking
[08:42] <mvo> mborzecki: https://github.com/snapcore/snapd/pull/9708/commits/e4dd82d0211a81f7f1625abd93174a2feac8ac3b <- description and content do not quite match is thta the right comit?
[08:42] <mup> PR #9708: tests/main/uc20-create-partitions: verify ubuntu-save encryption keys, tweak not MATCH <Simple 😃> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9708>
[08:43] <mvo> mborzecki: I guess it is, I was just confused
[08:43] <mborzecki> mvo: hm the upper hunk is a drive by tweak, i can split it in 2 patches if that's better
[08:43] <mvo> mborzecki: no, it's fine, I was just confused by not expecting this
[08:47] <mborzecki> some unexpected failures after mergeing master:
[08:47] <mborzecki> google:ubuntu-20.04-64:tests/main/lxd:snapd_cgroup_just_outside
[08:47] <mborzecki> google:ubuntu-20.10-64:tests/main/snapd-reexec-snapd-snap (package was updated in the distro?)
[08:47] <mborzecki> google:ubuntu-20.10-64:tests/main/snapd-reexec-snapd-snap (this seems to be quite random)
[08:59] <zyga> mborzecki, ahh, good
[08:59] <zyga> (about nomatch)
[09:39] <mborzecki> mvo: i've udpated #9686, please take a look
[09:39] <mup> PR #9686: tests: remove workarounds that add "ubuntu-save" if missing <Run nested> <⛔ Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9686>
[09:45] <mvo> mborzecki: looking
[09:56] <mup> PR snapd#9526 closed: snapshotstate: add cleanup of abandonded snapshot imports <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9526>
[10:31] <sil2100> Hey guys! So I just went and confirmed if current ubuntu-image properly calculates the image size - and I think it does
[10:31] <sil2100> So I have https://code.launchpad.net/~ubuntu-core-dev/livecd-rootfs/+git/livecd-rootfs/+merge/393247 prepared to drop the --image-size workaround for UC20 images
[10:32] <sil2100> But just in case, could someone here do a quick test: build an UC20 image with ubuntu-image 1.10 (current) and see if the images boot and work correctly, as expected, with the auto-calcualted size?
[10:32] <sil2100> (i.e. without specifying --image-size for amd64)
[10:33] <sil2100> The image sizes per the generated files seem correct, but I'd prefer a live test to see if everything still works
[10:34] <sil2100> This is fixed since a long time, but so far our UC20 cdimage image builds still had the --image-size=8G set, and I'd just want a double-confirmation that we can really safely drop that
[10:36] <mup> PR snapd#9709 opened: snapshotstate: improve handling of multiple errors <Created by mvo5> <https://github.com/snapcore/snapd/pull/9709>
[10:36] <mvo> pedronis: your intuition about the error formating was spot-on, the test I wrote forced me to do some refactoring. sorry that it's a bit more complicated now :/
[10:43] <mvo> sil2100: sure, let me try
[10:44] <sil2100> mvo: thank you!
[10:46] <mup> PR snapd#9675 closed: bootloader/lkenv: add v2 struct + support using it <UC20> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9675>
[10:50] <pedronis> mvo: ok, I added it to my queue, should we chat about fde hook running?
[10:50] <mvo> pedronis: yeah
[10:51] <mvo> pedronis: is now good?
[10:52] <mvo> sil2100: seems to be fine. image is 3g in size and /writable has 540 mb free
[10:54] <pedronis> mvo: now is ok if it's not too long
[10:54] <mborzecki> mvo: can you squash merge https://github.com/snapcore/snapd/pull/9694/ ? looks like the uc20 nested test failed on uc20-create-partitions which is fixed in master, and another spread run does not make sense
[10:54] <mup> PR #9694: o/devicestate,daemon: fix reboot system action to not require a system label <Bug> <Run nested> <Simple 😃> <Squash-merge> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9694>
[10:59] <sil2100> mvo: sweet! Thanks a bunch!
[10:59] <mvo> sil2100: yw, thanks for promoting snapcraft btw
[10:59] <sil2100> mvo: yw, sorry I only did it so late, yesterday was weird
[11:08] <pedronis> there are unit test failures in https://github.com/snapcore/snapd/pull/9695
[11:08] <mup> PR #9695: bootloader/lk: add support for UC20 lk bootloader with V2 lkenv structs <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9695>
[11:13] <mvo> sil2100: no worries
[11:16] <mup> PR snapd#9710 opened: seed/seedwriter: consider modes when checking for deps availability <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9710>
[11:26] <mup> PR snapd#9691 closed: spread: bump delta ref, tweak repacking to make smaller delta archives <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9691>
[12:01] <mup> PR snapd#9711 opened: tests: reset fakestore unit status <Simple 😃> <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9711>
[12:38] <mborzecki> pstolowski: can you take a look at https://github.com/snapcore/snapd/pull/9687 ?
[12:38] <mup> PR #9687: osutil: add helper for getting the kernel command line <Simple 😃> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9687>
[12:38] <pstolowski> sure
[12:40] <mborzecki> pstolowski: thanks
[12:50] <pstolowski> mborzecki: if you have a moment, https://github.com/snapcore/snapd/pull/9609 needs 2nd review
[12:50] <mup> PR #9609: tests: add unit test for auto-refresh with validate-snap failure <Created by stolowski> <https://github.com/snapcore/snapd/pull/9609>
[12:50] <mborzecki> pstolowski: sure
[12:50] <mborzecki> pstolowski: heh, i did the change ian proposed on wednesday, but apaprently did not push the branch :/
[13:10] <pedronis> mvo: I commented on https://github.com/snapcore/snapd/pull/9709, I'm not quite conviced about its current form if the intention is to share it
[13:10] <mup> PR #9709: snapshotstate: improve handling of multiple errors <Created by mvo5> <https://github.com/snapcore/snapd/pull/9709>
[13:52] <mup> PR snapd#9688 closed: boot: add kernel command lines to the modeenv file <Run nested> <Simple 😃> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9688>
[13:52] <mup> PR snapd#9708 closed: tests/main/uc20-create-partitions: verify ubuntu-save encryption keys, tweak not MATCH <Simple 😃> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9708>
[14:27] <mup> PR snapd#9687 closed: osutil: add helper for getting the kernel command line <Simple 😃> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9687>
[14:41] <pstolowski> #9590 needs second review
[14:41] <mup> PR #9590: tests: download timeout spread test <Created by stolowski> <https://github.com/snapcore/snapd/pull/9590>
[15:17] <mup> PR snapd#9712 opened: cmd/snap-repair,store: increase initial retry time intervals, stalling TODOs <Created by pedronis> <https://github.com/snapcore/snapd/pull/9712>
[15:21] <pedronis> pstolowski: ^ what I discussed in the standup, there are also some todos that we might have to consider when we are bit more sure of the work we did for downloads
[15:22] <pstolowski> pedronis: thanks, will take a look
[15:27]  * cachio lunch
[15:37] <mup> PR snapd#9713 opened: tests: sign new nested-18|20* models to allow for generic serials <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9713>
[16:08] <mup> PR snapd#9609 closed: tests: add unit test for auto-refresh with validate-snap failure <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9609>
[16:43] <mup> PR snapd#9714 opened: client: reduce again the /v2/system-info timeout <Created by pedronis> <https://github.com/snapcore/snapd/pull/9714>
[16:55] <mvo> pedronis: I pushed a draft of the EphemeralRunHook with the context, let me know if I captured what you had in mind. it will need more tests but mostly wondering if the shape is allright. but no rush of course!
[16:58] <mup> PR snapd#9715 opened: hookstate: add new HookManager.EphemeralRunHook() <Needs Samuele review> <Squash-merge> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9715>
[18:48] <mup> PR snapd#9716 opened: daemon: split interfacesCmd to api_interfaces.go <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9716>
[18:58] <mup> PR snapd#9686 closed: tests: remove workarounds that add "ubuntu-save" if missing <Run nested> <UC20> <Created by mvo5> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9686>
[19:06] <mvo> waveform: hey, help with https://github.com/snapcore/pi-gadget/issues/60 would be great (no rush but I'm not sure if you monitor GH issues)
[19:13] <mvo> pedronis: thanks so much for your initial thoughts on 9715!
[20:49]  * cachio afk
[20:59] <mup> PR snapcraft#3389 opened: plugins v1: move build base test in v1 plugins to base class <Created by cmatsuoka> <https://github.com/snapcore/snapcraft/pull/3389>