| bthomas | morning | 09:09 |
|---|---|---|
| facubatista | ¡Muy buenos días a todos! | 11:16 |
| bthomas | morning facubatista | 11:17 |
| facubatista | hola bthomas :) | 11:17 |
| bthomas | facubatista: when you are settled in ping me I need a couple of minutes to discuss two PRs. I am going to grab a quick coffee. | 11:18 |
| facubatista | bthomas, ack | 11:18 |
| Chipaca | facubatista: 👋❗ | 11:34 |
| Chipaca | facubatista: welcome back, hope you had a good break | 11:35 |
| facubatista | Chipaca, I had an excelent break, thanks! | 11:35 |
| facubatista | Chipaca, also, what is this, where am I, who are you? | 11:35 |
| Chipaca | facubatista: this is pycamp 2020. You are in a VR pod. I am admin. | 11:36 |
| facubatista | all this virus thing is a lie! game over | 11:37 |
| Chipaca | facubatista: at your earliest convenience, could you review #459? i'd like to merge it into master and push out 1.1 with it | 11:37 |
| mup | PR #459: Treat empty actions.yaml as no actions.yaml <Created by chipaca> <https://github.com/canonical/operator/pull/459> | 11:37 |
| facubatista | yes | 11:37 |
| Chipaca | facubatista: thank you | 11:37 |
| Chipaca | facubatista: also, we are the virus | 11:37 |
| facubatista | https://www.youtube.com/watch?v=9UY8kqV7KgE | 11:39 |
| bthomas | Chipaca: I am looking over ops issues. Is there anyone that you would recommend that needs being done ? | 12:10 |
| Chipaca | bthomas: you want to explore implementing `is_doomed` using the appropriate env var? | 12:11 |
| Chipaca | bthomas: it's going to be quite a trip, but should prove to be fun | 12:12 |
| bthomas | Chipaca: ack will start looking into it. Thank you. I hope I am not doomed. | 12:12 |
| bthomas | will get back to you when I have a plan. | 12:12 |
| Chipaca | bthomas: the issue is #450 but jam tells me that you don't need gaol state for that, because there is an env var that tells you who is leaving | 12:12 |
| mup | Issue #450: is_doomed() <Created by stub42> <https://github.com/canonical/operator/issues/450> | 12:12 |
| Chipaca | but i forget the name of the env var :-/ | 12:12 |
| bthomas | ack will dig | 12:12 |
| Chipaca | phew, finally worked out what was going on WRT https://discourse.charmhub.io/t/test-harness-with-custom-events/3887 | 12:13 |
| Chipaca | DominikF: ^ fwiw | 12:14 |
| JoseMasson | Good morning! | 12:21 |
| bthomas | Morning JoseMasson | 12:23 |
| facubatista | hola JoseMasson | 12:25 |
| JoseMasson | bthomas facubatista have already prepared your morning mate? | 12:27 |
| facubatista | of course | 12:27 |
| bthomas | JoseMasson: Morning coffee for me. | 12:28 |
| * bthomas googles mate | 12:28 | |
| JoseMasson | bthomas: https://en.wikipedia.org/wiki/Mate_(drink) | 12:29 |
| bthomas | yep was just reading that | 12:29 |
| bthomas | never had it. Hope to some day. | 12:29 |
| facubatista | Chipaca, #459 approved, with a comment | 12:49 |
| mup | PR #459: Treat empty actions.yaml as no actions.yaml <Created by chipaca> <https://github.com/canonical/operator/pull/459> | 12:49 |
| Chipaca | facubatista: not sure i understand how i could test what you ask | 13:26 |
| Chipaca | d'oh, i could check .actions | 13:27 |
| facubatista | Chipaca, test/test_charm.py, you added a test | 13:27 |
| facubatista | test_empty_action | 13:27 |
| facubatista | that returns a class, you can grab it and check its attrinute | 13:28 |
| facubatista | attribute, also | 13:28 |
| Chipaca | facubatista: yeah, as i say, check .actions | 13:28 |
| Chipaca | facubatista: pushed, thanks! | 13:30 |
| facubatista | Chipaca, land it | 13:31 |
| Chipaca | facubatista: as soon as it's green | 13:32 |
| Chipaca | and then i'll bless it into 1.1 | 13:32 |
| * bthomas -> lunch | 13:35 | |
| * Chipaca ⇝ run (because travis is being travis) | 13:38 | |
| * Chipaca didn't go | 13:49 | |
| * bthomas -> back | 13:52 | |
| * facubatista -> small errands | 13:57 | |
| * facubatista is back | 14:36 | |
| mup | Issue operator#458 closed: a charm with an empty actions.yaml trips up the framework <bug> <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/issues/458> | 15:45 |
| mup | PR operator#459 closed: Treat empty actions.yaml as no actions.yaml <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/459> | 15:45 |
| === ChanServ changed the topic of #smooth-operator to: general discussion of the operator framework || github.com/canonical/operator || ops 1.1.0 || charmcraft 0.6.1 | ||
| bthomas | ah time to upgrade then | 15:56 |
| Chipaca | :-D | 15:56 |
| bthomas | done | 15:57 |
| Chipaca | facubatista: standup? | 16:31 |
| facubatista | Chipaca, yes, auth and stuff | 16:31 |
| dstathis | How does one scale up to more units in harness? | 21:06 |
| dstathis | I can't seem to find anything | 21:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!