[00:40] <mup> PR snapd#9707 closed: update-pot: fix typo in plural keyword spec <Simple 😃> <Created by jhenstridge> <Merged by jhenstridge> <https://github.com/snapcore/snapd/pull/9707>
[00:45] <mup> PR snapd#9717 opened: update-pot: fix typo in plural keyword spec <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/9717>
[06:07] <mup> PR snapd#9711 closed: tests: reset fakestore unit status <Simple 😃> <Test Robustness> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9711>
[06:17] <mup> PR snapd#9633 closed: github: run nested suite when commit is pushed to release branch <Run nested> <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9633>
[06:17] <mup> PR snapd#9714 closed: client: reduce again the /v2/system-info timeout <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9714>
[06:41] <mvo> hey mborzecki
[06:41] <mborzecki> good morning mvo
[06:48] <mborzecki> mvo: looks like https://github.com/snapcore/snapd/pull/9694 can be squash merged
[06:48] <mup> PR #9694: o/devicestate,daemon: fix reboot system action to not require a system label <Bug> <Run nested> <Simple 😃> <Squash-merge> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9694>
[06:52] <mup> PR snapd#9716 closed: daemon: split interfacesCmd to api_interfaces.go <Cleanup :broom:> <Created by pedronis> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9716>
[07:15] <zyga> good morning guys
[07:15] <zyga> 2 more days and I'll be out of the planning craze
[07:15] <mborzecki> mvo: is https://github.com/snapcore/snapd/pull/9712 something you want for 2.48?
[07:15] <mup> PR #9712: cmd/snap-repair,store: increase initial retry time intervals, stalling TODOs <Created by pedronis> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9712>
[07:15] <mborzecki> zyga: hey
[07:17] <mup> PR snapd#9712 closed: cmd/snap-repair,store: increase initial retry time intervals, stalling TODOs <Created by pedronis> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9712>
[08:00] <pstolowski> morning
[08:05] <mvo> good morning pstolowski
[08:05] <mvo> mborzecki: I was thinkning about 9712, not sure tbh
[08:12] <mup> PR snapd#9694 closed: o/devicestate,daemon: fix reboot system action to not require a system label <Bug> <Run nested> <Simple 😃> <Squash-merge> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9694>
[08:17] <mup> PR snapd#9717 closed: update-pot: fix typo in plural keyword spec <Created by jhenstridge> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9717>
[08:22] <mborzecki> pstolowski: hey
[08:39] <pedronis> mvo: mborzecki: hi, more nested fun, this seems to fail on 18 for real (but not 20): https://github.com/snapcore/snapd/pull/9713
[08:39] <mup> PR #9713: tests: sign new nested-18|20* models to allow for generic serials <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9713>
[08:45] <pedronis> mvo: I commented in https://github.com/snapcore/snapd/pull/9709
[08:45] <mup> PR #9709: snapshotstate: improve handling of multiple errors <Created by mvo5> <https://github.com/snapcore/snapd/pull/9709>
[08:48] <mborzecki> pedronis: hm why are there only cloud init tests failing though?
[08:50] <mvo> pedronis: thank you, looking
[09:07] <pedronis> mborzecki: thanks, I added the comments in https://github.com/snapcore/snapd/pull/9710, slightly tweaked
[09:07] <mup> PR #9710: seed/seedwriter: consider modes when checking for deps availability <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9710>
[09:08] <mborzecki> pedronis: thanks
[09:13] <pstolowski> pedronis: hey, can we talk about validation sets monitoring today?
[09:19] <pedronis> mborzecki: looking at the logs for those 18 nested failures is very strange, it seems we get through all the process, but logging in continues to fail
[09:20] <mborzecki> pedronis: there's cmd_auto_import.go:228: error: cannot mount /dev/sr0: mount: /tmp/snapd-auto-import-mount-409874544: wrong fs type, bad option, bad superblock on /dev/sr0, missing codepage or helper program, or other error.
[09:20] <mborzecki> maybe the isos prepared by the test are bad?
[09:21] <pedronis> mmh,  but how does this relate to the new model
[09:21] <mborzecki> pedronis: anyways, i'm running that test on master right now, i don't think the PR you have would trigger that
[09:21] <pedronis> thx
[09:21] <pedronis> pstolowski: we can chat at 11 ?
[09:24] <pedronis> mborzecki: mmh, I know
[09:26] <pedronis> mborzecki: it's my fault, I think I know how to fix but a bit annoying
[09:26] <pstolowski> pedronis: ok
[09:26] <mborzecki> pedronis: ok
[09:26] <pedronis> mborzecki: I need to sign the system-user assertion
[09:26] <pedronis> we probably need one depenign on who signed the model
[09:38] <sil2100> Hey guys! Can anyone take a look at why snapd FTBFS on bionic arm64? https://launchpad.net/ubuntu/+source/snapd/2.48+18.04/+build/20328505
[09:39] <sil2100> And same for xenial armhf: https://launchpad.net/ubuntu/+source/snapd/2.48/+build/20328512
[09:39] <sil2100> Please be sure to always look at whether the package builds correctly on all series and arches once you submit the SRU!
[09:41] <mborzecki> sil2100: the unit tests failed in both, i'm guessing it's timing/slowness issue
[09:42] <mvo> sil2100: sorry for this!
[09:42] <mup> PR snapd#9718 opened: secboot,devicestate: add scaffoling for "fde-reveal-key" support <Needs Samuele review> <Squash-merge> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9718>
[10:03] <pedronis> pstolowski: I'm in the standup
[10:03] <pstolowski> pedronis: ok coming
[12:03] <mup> PR snapd#9710 closed: seed/seedwriter: consider modes when checking for deps availability <Run nested> <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9710>
=== pedronis_ is now known as pedronis
[13:43] <mup> PR snapd#9719 opened: boot: set kernel command line in modeenv during install  <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9719>
[15:09] <pedronis> now my nested core 18 tests failed in a different way :/
[15:10] <ijohnson> pedronis: what was it that you tried to change to nested.sh with respect to system-user assertions?
[15:10] <ijohnson> I thought I added support for tests to supply their own system-user assertion with some env var for the cloud-init stuff
[15:10] <ijohnson> I forgot to ask you about that after the SU
[15:11] <pedronis> ijohnson: you did but not sure it was the best approach here, I did something slightly different: https://github.com/snapcore/snapd/pull/9713/commits/26a9ebba4b50fceb5765e1e634b60afaab8a8738
[15:11] <mup> PR #9713: tests: sign new nested-18|20* models to allow for generic serials <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9713>
[15:11]  * ijohnson looks
[15:11] <pedronis> anyway the cloud init tests now passed, it's something else that failed
[15:30] <mborzecki> meh 7 files changed, 515 insertions(+), 33 deletions(-)
[16:05] <mvo> pedronis: I updated 9715 based on your suggestion, please let me know if I understood this correctly. if it looks reasonable I will add more unit tests and mark it a non-draft(?)
[16:07] <pedronis> mvo: yes, it looks reasonable, did you find it ok the suggestion?
[16:11] <pstolowski> ijohnson: hey, would you take a look at #9590 when you have a moment?
[16:11] <mup> PR #9590: tests: download timeout spread test <Created by stolowski> <https://github.com/snapcore/snapd/pull/9590>
[16:11] <ijohnson> pstolowski: sure I will add it to my queue
[16:12] <mvo> pedronis: yes, I would love if that area would get some refactor but for now I think it's nice, thanks for the suggestions!
[16:14] <pedronis> mvo: do you have a moment to talk about 9718 ?
[16:15] <mvo> pedronis: sure, is in 5min okay?
[16:17] <pedronis> yes
[16:17] <pedronis> mvo: ping me
[16:18] <mvo> pedronis: ready in the standup ch now
[16:19] <mvo> (but no rush)
[16:34] <pstolowski> ijohnson: thanks
[17:21] <ijohnson> pedronis: got a second to chat about the disks package?
[17:21] <ijohnson> I need to search now by partition label as well as by filesystem label like we are doing today
[17:22] <pedronis> ijohnson: yes
[17:22] <ijohnson> I'm wondering if you would prefer to add another method to the interface to expand FindMatchingPartitionUUID to take a SearchOptions or something which specifies what query to use
[17:22] <ijohnson> what is easiest is to just expand the interface to have 2 interfaces:
[17:22] <ijohnson> FindMatchingPartitionUUIDFromPartitionLabel
[17:23] <ijohnson> FindMatchingPartitionUUIDFromFilesystemLabel
[17:23] <ijohnson> but that's a mouthful
[17:24] <ijohnson> err sorry I guess I phrased my question awkwardly, I think there are two options option 1 which is the easiest is to have 2 methods like I mentioned above, and option 2 is to have 1 Find*() function and then have an SearchOptions or something to specify how to search
[17:24] <pedronis> FindMatchPartitionUUIDFromPartLabel  FindMatchingPartitionFromFSLabel ?
[17:25] <pedronis> option 2 is a bit strange in this context to me
[17:27] <ijohnson> sure option 1 is the simplest I think
[17:27] <ijohnson> ok, I will go with that
[17:27] <ijohnson> FYI in case you didn't see in the UC20 channel, we need this for the lk bootloader work too
[17:27] <ijohnson> since the partitions we need to search for don't have filesystems and thus don't have filesystem labels
=== ijohnson is now known as ijohnson|lunch
=== ijohnson|lunch is now known as ijohnson
[19:15] <mup> PR snapd#9720 opened: many: rename disks.FindMatching... to FindMatching...WithFsLabel and err type <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9720>
[19:30] <mup> PR snapd#9721 opened: osutil/disks: add FindMatchingPartitionUUIDFromPartLabel to Disk iface <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9721>
[21:00] <mup> PR snapd#9722 opened: daemon: split apps and logs endpoints to api_apps.go and tests <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9722>
[21:00] <mup> PR snapd#9723 opened: daemon: move some more api tests from daemon to daemon_test <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9723>