falcojrSounds good. I'll take a look first thing in the morning00:08
otubosmoser: Thanks! I'll probably go with your approach of removing the lvextend part. I'll send a PR soon. :)10:16
eoli3nis late_command a key added by ubuntu autoinstall and not cloud-init dependant ?10:30
eoli3nhow cloud-config differs from cloud-init ?10:30
ubot5Ubuntu bug 1905731 in subiquity "feature request autoinstall: late_command scripts and chroot key" [Undecided,New]10:40
eoli3nis subiquity only manage by mwhudson ?10:40
eoli3nwrong chan10:40
otubohey guys, I'm working on the Fedora rebase (20.4) and I'm seeing some weird stuff on the tests, there's 24 of them failing: https://kojipkgs.fedoraproject.org//work/tasks/5682/56695682/build.log12:46
otuboThis is the result of a vanilla 20.4 + 3 irrelevant patches: https://src.fedoraproject.org/fork/otubo/rpms/cloud-init/tree/190225012:46
otuboThe tests are being called by the spec file as "nosetests-3.9 tests/unittests/". I don't believe the tests are bogus, but probably some misconfiguration on the spec file, some package version, I don't know and I would love another pair of eyes on this matter :-D12:48
otuboDon't know who to ping for this, but I'm gonna give it a try with Odd_Bloke who is always ready to help :)12:48
smosereoli3n: late_command is not part of cloud-init, it is curtin.13:57
smoserso, it runs in the installer environment.13:58
eoli3nsmoser thanks14:14
eoli3ndoes debian supports cloud-config ?14:14
smosercloud-init is available on debian, cloud-init supports cloud-config.14:16
smoserso... dependent upon whether or not cloud-init is installed.14:16
Odd_Blokeotubo: Those are parameterised pytest tests (e.g. https://github.com/canonical/cloud-init/blob/master/tests/unittests/test_util.py#L954).  (As nose doesn't know how to parameterise these tests, the function parameters which would be filled by that parameterisation are instead left unpassed, hence "missing 2 required positional arguments: 'criteria' and 'expected_devlist'".)  I think moving to use pytest14:36
Odd_Bloketo run these tests will address it.14:36
otuboOdd_Bloke: Ok it partially fixed it :) Now I got the same issues whenever I run "tox" on my laptop. I wanted to ask this a while ago, this error is being present for a long time, but I always forget.14:52
otuboOdd_Bloke: https://kojipkgs.fedoraproject.org//work/tasks/5322/56705322/build.log14:52
otuboI don't see that on travis-ci, but I always see that on my laptop even with an untouched checkout.14:54
Odd_Blokeotubo: That looks like insufficient sandboxing to me; we wouldn't have noticed it because every Ubuntu system has /etc/ca-certificates.conf.14:54
otuboOdd_Bloke: ok, so it's not an obvious misconfiguration on my side. Good to know :D I'll skip those, in the meantime I'll try to fix and send a PR14:56
otuboOdd_Bloke: Thanks for the help :)14:56
Odd_Blokeotubo: Does https://paste.ubuntu.com/p/9PCN3KKfdg/ fix it?15:01
blackboxswOdd_Bloke: I'm going through https://github.com/canonical/cloud-init/pull/702 now. thanks!16:50
Odd_Blokefalcojr: blackboxsw: Fairly small integration testing PR: https://github.com/canonical/cloud-init/pull/70817:31
Odd_Blokeblackboxsw: Looking at your comment on #702 now. :)17:32
blackboxswOdd_Bloke: falcojr, do we expect failures locally from integration_tests  tests/integration_tests/modules/test_ssh_keys_provided.py?  I've got something amuck on my groovy and focal dev systems causing integration_test failures on master and Dan's PR 702. `tox -e integration-tests-ci   tests/integration_tests/modules/test_ssh_keys_provided.py`17:34
blackboxswseems to fail finding /etc/ssh/ssh_host_rsa_key-cert.pub17:36
falcojrWe're not expecting failures anywhere, but that doesn't mean we got everything perfect 😉17:37
falcojrCurrently lunching but I'll take a look when I'm back at my desk17:38
Odd_BlokeWe would expect failures if you aren't specifying a CLOUD_INIT_SOURCE pointing at either master (IN_PLACE, daily PPA) or at proposed (PROPOSED).17:42
Odd_Bloke(I wonder if we should change that default behaviour?)17:42
Odd_Blokefalcojr: https://github.com/canonical/cloud-init/pull/706/files#r535448031 <-- a nit, which I can fix-and-land if you'd like17:45
blackboxswapproved https://github.com/canonical/cloud-init/pull/708 and might switch UA client17:45
blackboxswapproved https://github.com/canonical/cloud-init/pull/708 and might switch UA client integration tests to do the same17:45
Odd_Blokefalcojr: (Or, rather, tell me if you _don't_ want me to do that. :)17:45
blackboxswapproved https://github.com/canonical/cloud-init/pull/702 waiting on CI, will let you merge Odd_Bloke17:47
blackboxswand needs a rebase now17:47
Odd_Blokeblackboxsw: FWIW, as we squash-merge, there's no reason to rebase instead of hitting "Update branch": the merge commit will be squashed away.17:50
blackboxswright right good pt17:51
=== ijohnson is now known as ijohnson|lunch
falcojrOdd_Bloke: sorry, what are you wanting me to capitalize?18:20
falcojrcapitalize RSA or treat the variables as constants?18:22
falcojralso, that merge point is relevant for me too. I have a branch with a conflict and multiple commits, and I was waiting for approval to squash then rebase to avoid the merge commit18:24
falcojrbut that won't matter18:24
=== ijohnson|lunch is now known as ijohnson
Odd_Blokefalcojr: Ah yeah, apologies: I meant treat them as constants.20:14
falcojrgotcha, I also commented on the PR (which I should have done in the first place)20:14
Odd_Blokefalcojr: Is there any way for me to disable the image cleanup via configuration?  I'd like to run with CLOUD_INIT_SOURCE=PROPOSED once, and then just feed the image built by that in as my OS_IMAGE to save myself ~45s per test run.20:59
falcojrhmmm, no, I hadn't considered that use case21:06
falcojrfor now you can comment this line, but that's obviously not a long term solution21:07
nibalizerHi folks I have a draft up here: https://github.com/canonical/cloud-init/pull/710 ... I need to write tests and docs and so on still but is that looking about right?21:10
Odd_Blokeotubo: I'm out tomorrow, but if that test patch does fix the issue, feel free to put up a PR with it so we don't lose it. :)22:46

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!