otuboOdd_Bloke: Yes it did work! I'll open a PR for that. While we don't merge it and have it backported I'll keep that patch downstream for Fedora.10:26
otuboOdd_Bloke: thanks!10:26
smosersomeone really should look at https://github.com/canonical/cloud-init/pull/69114:21
smoserthat is a big deal.  that is vmware saying "here, we changed our platform to better serve cloud-init".14:21
smoseri think there are one or two users of vmware in the world.14:21
blackboxsw+1 smoser rick as asking one of us to look this over yesterday14:23
blackboxswhe wanted to gauge impact/risk14:24
falcojrblackboxsw: 2 PRs for you16:51
blackboxswfalcojr: fire away16:52
falcojrhttps://github.com/canonical/cloud-init/pull/711 a simple change to allow us to keep images as requested yesterday16:52
falcojrand https://github.com/canonical/cloud-init/pull/712 , another test16:52
blackboxswfalcojr: clarification question: generally for a single full integration test run, the test image is shared across multiple test cases right?16:53
blackboxswthis just allows you to preserve it even once the test suite is done running right?16:54
blackboxswok good, thx16:54
blackboxswfalcojr: https://github.com/canonical/cloud-init/pull/712/files#r53630490818:46
blackboxswone question here about how we generally expect the integration tests to run for SRU manual testing. I *think* we should be strict about expecting no errors across reboots in most tests.  or explicitly check that cloud-init status didn't report error after the reboot completes. Not sure what you'd prefer there18:47
falcojrOK, I can add some error checking too.18:55
falcojrblackboxsw: do you think passing through "raise_on_failure" to the restart would be sufficient?19:47
falcojrit'll raise if "cloud-init status --wait --long" returns non-zero, but I don't know offhand the conditions it would return non-019:47
blackboxswfalcojr: it would return non-0 if we had tracebacks/errors in the cloud-init logs on the new clean boot. which I think is exactly what we want to gate against19:48
falcojrok, cool, I'll add the option to pass it through then19:49
blackboxswand I think passing through raise_on_failure to IntregrationInstance.restart is good19:49
blackboxswyeah the only time we do want to hide restart errors on restart(which seems to be our default setting)  is if we are expecting to validate a failure case19:49
blackboxswI expect a trusty -> xenial upgrade of cloud-init to return a non-zero after reboot per this bug: https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/189929919:50
ubot5Ubuntu bug 1899299 in cloud-init (Ubuntu) "do-release-upgrade from Trusty to Xenial breaks cloud-init init-local on reboot" [Undecided,Triaged]19:50
blackboxswor if we are launching a with userdata that we know will fail prior to upgrading to cloud-init from -proposed19:51
blackboxswfalcojr: landed https://github.com/canonical/cloud-init/pull/71220:55

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!