mupPR snapcraft#3375 closed: [wip] ci: migrate spread tests to github actions <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3375>00:02
mwhudsonhuh i wonder what is breaking here https://launchpad.net/~mwhudson/+snap/go115/+build/120380103:29
mwhudsoni guess i should look at the diff to the previous version ... but not today03:29
mupPR snapd#9747 closed: interfaces/builtin/log_observe.go: allow controlling apparmor audit levels <Needs security review> <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9747>06:11
mupPR snapd#9746 closed: bootloader: add check for prepare-image time and more tests validating options <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9746>07:16
mborzeckilooked at the layout docs again, we do not prohibit using $SNAP as a target right?08:58
mupPR snapd#9736 closed: o/devicestate: save model with serial in the device save db <Run nested> <Squash-merge> <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9736>09:22
mupPR snapd#9742 closed: gadget,o/devicestate: hybrid 18->20 ready volume setups should be valid <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9742>09:27
pstolowskipedronis: hey, i've introduced naming.SnapRef and SnapSet in #9732, turned out nicely i think, also local snaps are now handled09:45
mupPR #9732: asserts: snapasserts method to validate installed snaps against validation sets <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9732>09:45
=== pedronis_ is now known as pedronis
pedronispstolowski: thx, not sure I can look at it today but Monday09:52
pedronispstolowski: about #9429,  does it need a master merge and then it's ready to review or is there more to that?09:52
mupPR #9429: [RFC] o/daemon: validation sets api and basic spread test <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9429>09:52
pstolowskipedronis: yes needs master merge and maybe update of error messages after previous PR, will do shortly09:54
mupPR snapd#9748 opened: gadget: start separating rule/convention validation from basic soundness  <Created by pedronis> <https://github.com/snapcore/snapd/pull/9748>11:17
pedronismvo: mborzecki: baby steps ^11:18
mborzeckipedronis: thanks11:18
mupPR snapd#9590 closed: tests: download timeout spread test <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9590>11:22
pstolowskipedronis: i've updated #942911:45
mupPR #9429: o/daemon: validation sets api and basic spread test <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9429>11:45
pedronispstolowski: thx, I put it into my queue12:05
pedronismvo: I reviewed the fde PRs, some questions there12:29
mvopedronis: thank you!12:30
mupPR snapd#9749 opened: tests: fix lp-1899664 test when snapd_x1 is not installed in the system <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9749>12:58
mborzeckiijohnson: hey13:25
ijohnsonmorning mborzecki!13:27
niemeyerHey hey13:35
niemeyerQuickie, probably for mborzecki13:36
niemeyerWe never went past after/stop13:36
niemeyerErm, sorry.. I mean, we never went past after/before.. the original design had the idea of starts-with13:37
niemeyerI suppose we never needed that because the snap generally starts everything13:38
niemeyerHas our understanding of the problem changed since then?13:38
mupPR snapd#9750 opened: tests: fix the scenario when the "$SRC".orig file does not exist <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9750>13:38
mborzeckiniemeyer: we didn't, iirc there was no agreement about keywords and the discussion got derailed with cross snap dependencies at some point13:39
mborzeckiniemeyer: if it's just about start-with within a single snap it should be easy enough to do ;)13:41
niemeyerYeah, I'm mainly wondering if anything has changed, as I'm about to replicate the design on something where different startup settings will be more common, so this will come at play quickly13:43
niemeyerSo just checking if we've learned anything since the discussed this, and whether we still have the same design, meaning after/before do not imply start/stop-with13:43
niemeyerIdeally we can use the exact same design, so people learning about one mechanism already know the other13:44
mupPR snapd#9751 opened: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9751>13:53
mupPR snapd#9743 closed: daemon: split unsupported buy implementation to its own api_*.go files <Cleanup :broom:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9743>14:48
zygamborzecki interesting bug15:01
niemeyerpedronis, mborzecki: I wonder if there's a reason for it to be "starts-with" vs. "start-with"15:26
niemeyerYeah, I think "start-with" is actually more natural... there are several "start-" and "restart-" prefixes15:28
pedronisthey have a bit of a different role15:30
pedronisthere start/restart are nouns15:30
pedronishere start would be a verb15:32
pedronisstart-with and starts-with have a bit of different connotation, the first is command/order, the second more declarative15:32
pedronisfor this kind of settings systemd itself prefers the indicative over the imperative: BindsTo JoinsNamespaceOf15:36
niemeyerIndeed, but I wonder if consistency would win15:37
niemeyerLet me look again at the docs15:37
pedronisI think consistency would be easier for non-native speakers, but conceptually is a bit off15:37
pedronisfor this15:38
niemeyerSeems analogous to start-timeout15:38
niemeyerAgain, I get that in terms of grammar it's slightly different, but I'm not sure people would understand that rather than just finding it inconsistent15:39
niemeyerIs there a better term to use instead of -with that would make it a more natural noun15:40
pedronisto have a name, you would need some like start-companions or something, it gets odd I think15:43
mupPR snapcraft#3375 opened: ci: migrate spread tests to github actions <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3375>15:45
niemeyerpedronis: start-friends15:47
niemeyerpedronis: "start-group" is not too bad15:49
* cachio lunch15:49
pedronisthat could work15:49
niemeyerand the semantics seems right.. it's really a group. The statement binds them bilaterally15:50
ijohnsonpedronis: ok, I addressed your comments on #969516:15
mupPR #9695: bootloader/lk: add support for UC20 lk bootloader with V2 lkenv structs <Squash-merge> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9695>16:15
=== JanC is now known as Guest22061
=== JanC_ is now known as JanC
blathijsHey folks, got a question about snap and apparmor profiles. I'm getting some apparmor denials in my logs from the spotify snap, which would be fixed by adding some extra allows (or silent denies) in /var/lib/snapd/apparmor/profiles/snap.spotify.spotify. Now my question is: Where does the content of that file come from? Is that shipped as part of the snap? Or is it generated by snapd based on snap metadata?16:53
ijohnsonblathijs: it's generated by snapd based on snap metadata16:53
blathijs(and the underlying question is: Where should I be asking to get this fixed, in snap or in spotify?)16:53
ijohnsonblathijs: I would recommend starting a forum topic at forum.snapcraft.io, it's unclear whether it's something that the snap author (i.e. spotify) needs to adjust or whether it's something that snapd would need to adjust, but it's easier to gather such details in a more persistent setting16:54
blathijsijohnson: Will do, thanks for the quick reply :-)16:56
ijohnsonpedronis: also regarding the degraded mode pr that failed, from the log in install mode there is this bit: https://pastebin.ubuntu.com/p/RNqY5vDPBT/16:57
ijohnsonso the degraded mode itself wasn't flaky, it was the installation that was flaky16:57
ijohnsonunfortunately without an active shell I can't tell what went wrong to cause "device /dev/vda4 not available"16:57
mupPR snapcraft#3390 opened: project_loader, meta, formatting_utils: account for empty env <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3390>17:05
blathijsijohnson: Created a post, thanks again: https://forum.snapcraft.io/t/apparmor-related-denials-for-spotify-snap/2147917:32
mborzeckiijohnson: zyga: thanks for reviews, i've updated https://github.com/snapcore/snapd/pull/975117:54
mupPR #9751: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9751>17:54
ijohnsonNice thanks mborzecki !17:55
* ijohnson lunches 17:55
zygaijohnson hi19:00
zygaijohnson should I apply s/!/not / suggestions I've made to https://github.com/snapcore/snapd/pull/975119:00
mupPR #9751: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries <Squash-merge> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9751>19:00
zygare, I must say this agresive suspend is annoying19:06
ijohnsonhey zyga19:07
zygahey :)19:07
ijohnsondo you have perms to apply the suggestions ?19:07
ijohnsonif so I'd say go for it19:07
zygacool, doing that now19:08
ijohnsonif you end up backdooring snapd with your spread test changes though I will be very sad19:08
zygashould have used the batch thing but its' done19:08
ijohnsonnot that you couldn't have added backdoors to snapd through any of the other super low level code you worked on throughout the years :-)19:08
zygaI would ! do that :)19:08
zygaI have a secret plan19:09
zygato develop changes to spread that you end up using :)19:09
zygaI have some yocto builds to set up first,19:09
ijohnsonhaha nice19:09
zygaand muxpi and flashing19:09
zygaall the usual suspects19:09
zygaI want to teach spread to run drive metal directly, though some API that matches muxpi and several other things19:10
ograpoor you19:10
zygayeah, it's a different planet19:10
zygabut I'm not touching yocto myself; I'm the CI guy19:10
zygathat bit is fun, I've learned a lot in just one month already19:10
ijohnsoninteresting, did you ever play with testflinger ?19:10
ijohnsonseems similar in purpose19:11
zygaijohnson somewhat, I watched its development from the side19:11
ijohnsonthough I guess testflinger integration with spread is more like, spread sends bits to some server, then the server does the metal bits and returns some IP address19:11
ijohnsonit sounds like you would be eliminating that middle server bit19:11
zygayeah, I want spread metal:19:11
zygaijohnson actually19:11
zygalet me show you19:11
zygatests: use not instead of !19:12
zygabad paste19:12
zygait's WIP, there are issues and there are PRs that change bits19:12
zygabut you can find the general idea here https://git.ostc-eu.org/docs/ci#test-process19:12
* ijohnson reads the README and sees mention of kubernetes19:13
* ijohnson squints19:13
zygaijohnson gitlab does k8s19:13
zygait's super cool actually19:13
zygaremember how we have github workers19:13
zygagitlab has runners, different name, but also different model19:13
zygayou set up a runner19:13
zygaand configure a runner executor19:13
zygathere's a dozen of those19:14
zygafrom virtualization stuff like qemu or virtualbox19:14
zygato dockers19:14
zygato k8s19:14
zygaincluding auto-scaling19:14
zygato simple shell and custom19:14
zygayou can have one runner that spawns new containers in an auto-scaling k8s cluster19:14
zygait's veeeeery nice19:14
zygaand extremely fast19:14
mupPR snapd#9752 opened: gadget,o/devicestate: set implicit values for schema and role directly instead of relying on Effective* accessors <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9752>19:14
zygaso you can have really high throughput quickly19:15
zygaand since for most of the tests you don't need a VM this is really faster19:15
ijohnsonthat does sound nice19:15
zygae.g. building19:15
zygagitlab has some nice bits19:15
zygaI was surprised by how small this difference is and how big impact it makes19:15
zygaso anyway, I want to extend spread, perhaps so that I can make spread a gitlab executor19:16
zygagitlab runner is written in go19:16
zygaso ... that's really close :)19:16
zygaso that I can have pipelines that run on metal19:16
zyga(pipelines are like actions, somewhat)19:16
zygaand that the metal deployment can use an OS image build by an earlier pipeline19:16
zygaI need an API because one worker will "see" many devices19:17
ijohnsonthat does sound really cool, I oftentimes have had this desire to hook up some extra machines I have to maas to do a similar kind of thing19:17
zygaso that in the end one test can be really spread across several devices19:17
ijohnsonbut really to do spread tests directly that way would be nice19:17
ijohnsonwould cut out the middle man again, this time a different middle man19:18
zygaI need to think about the API, should be both simple and match spread19:18
zygait will probably be some local or network IPC because I want those jobs to come in and run in the sandbox provided by gitlab19:18
zygaso probably like a very simple cloud api: allocate, deploy, connect, etc19:19
zygaI'm not there yet19:19
mupPR snapd#9753 opened: daemon: split aliases support to its own api_*.go files <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9753>19:19
zygaso small bits of spread, packaging, and I can share the design as it's fully public :)19:19
zygamaybe some of that can help you19:20
ijohnsonyeah if you have spread pr's I'd be interested to see19:21
zygaijohnson I'll start with a for but I will upstream them (that's even in the spec already) when I think they are good and we have something to show19:22
zygaijohnson: given I work on muxpi I think those may really apply19:22
zygathere are also some bits that are not described here but may apply to even wider audience19:22
zygawhere a pi can drive simpler boards without any other help19:23
zygaijohnson: I need to write some flashing tools as well19:23
zygaijohnson: I'm very keen to get boot-from-usb to work19:23
zygaijohnson: did you know raspberry pi can power down USB ports?19:23
zygayou can boot many devices by powering them from usb and talking to the on-chip bootloader19:23
zygaijohnson: feed a 2nd stage bootloader and you are good, no need for muxpi if you have network19:24
zyga(you can fetch stuff from uboot, for example)19:24
zygaand write to SD directly19:24
zygaeven if you only fetch and boot a small kernel19:24
zygathen you can eventually get to the right stage where your card is ready and you just ... power cycle19:25
zygaall over usb19:25
ijohnsonyou should talk to ondra, he has all sorts of flashing tools19:25
zygaondra ^^ hey19:25
zygaondra I'm working with someone who used to work with _you_ as a customer btw19:25
zygahe's at H now19:25
zygafrom e.on IIRC19:25
zygaweird small world19:26
mupPR snapd#9754 opened: o/devicestate: save model with serial in the device save db (2.48) <Created by pedronis> <https://github.com/snapcore/snapd/pull/9754>19:29
pedronisijohnson: I re-reviewed the lk PR19:42
ijohnsonthanks pedronis19:44
* ijohnson looks19:44
ijohnsonpedronis: do you want me to address that point in the pr or can it be a follow up ?19:46
ijohnsonI guess I would prefer a followup since it's green except for debian with dbus problems19:47
pedronisijohnson: a follow up is ok19:48
ijohnsongreat, do you want to squash merge it for me then?19:48
mupPR snapd#9753 closed: daemon: split aliases support to its own api_*.go files <Cleanup :broom:> <Created by pedronis> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/9753>19:50
pedronisijohnson: #9705 needs your review btw19:51
mupPR #9705: devicestate: add runFDESetupHook() helper <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9705>19:51
ijohnsonyes I'm working on that today19:51
ijohnsonalmost done with it19:51
mupPR snapd#9695 closed: bootloader/lk: add support for UC20 lk bootloader with V2 lkenv structs <Squash-merge> <UC20> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9695>19:55
* cachio afk19:55
mupPR snapd#9755 opened: daemon: split aliases support to its own api_*.go files <Created by pedronis> <https://github.com/snapcore/snapd/pull/9755>20:05
pedronisijohnson: do you need anything else from me?20:10
ijohnsonpedronis no I'm good but nezt week we should talk about the devmode snaps stuff20:11
ijohnsonHave a good weekend pedronis20:11
pedronisyes about devmode. thanks, same to you20:11
mupPR snapcraft#3375 closed: ci: migrate spread tests to github actions <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3375>20:21
mupPR snapd#9756 opened: bootloader/{lk,lkenv}: followups from #9695 <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9756>21:05

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!