| mup | PR snapcraft#3375 closed: [wip] ci: migrate spread tests to github actions <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3375> | 00:02 |
|---|---|---|
| mwhudson | huh i wonder what is breaking here https://launchpad.net/~mwhudson/+snap/go115/+build/1203801 | 03:29 |
| mwhudson | i guess i should look at the diff to the previous version ... but not today | 03:29 |
| mup | PR snapd#9747 closed: interfaces/builtin/log_observe.go: allow controlling apparmor audit levels <Needs security review> <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9747> | 06:11 |
| mborzecki | morning | 06:56 |
| mup | PR snapd#9746 closed: bootloader: add check for prepare-image time and more tests validating options <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9746> | 07:16 |
| pstolowski | morning | 08:01 |
| mborzecki | looked at the layout docs again, we do not prohibit using $SNAP as a target right? | 08:58 |
| mup | PR snapd#9736 closed: o/devicestate: save model with serial in the device save db <Run nested> <Squash-merge> <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9736> | 09:22 |
| mup | PR snapd#9742 closed: gadget,o/devicestate: hybrid 18->20 ready volume setups should be valid <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9742> | 09:27 |
| pstolowski | pedronis: hey, i've introduced naming.SnapRef and SnapSet in #9732, turned out nicely i think, also local snaps are now handled | 09:45 |
| mup | PR #9732: asserts: snapasserts method to validate installed snaps against validation sets <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9732> | 09:45 |
| === pedronis_ is now known as pedronis | ||
| pedronis | pstolowski: thx, not sure I can look at it today but Monday | 09:52 |
| pedronis | pstolowski: about #9429, does it need a master merge and then it's ready to review or is there more to that? | 09:52 |
| mup | PR #9429: [RFC] o/daemon: validation sets api and basic spread test <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9429> | 09:52 |
| pstolowski | pedronis: yes needs master merge and maybe update of error messages after previous PR, will do shortly | 09:54 |
| mup | PR snapd#9748 opened: gadget: start separating rule/convention validation from basic soundness <Created by pedronis> <https://github.com/snapcore/snapd/pull/9748> | 11:17 |
| pedronis | mvo: mborzecki: baby steps ^ | 11:18 |
| mborzecki | pedronis: thanks | 11:18 |
| mup | PR snapd#9590 closed: tests: download timeout spread test <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9590> | 11:22 |
| pstolowski | pedronis: i've updated #9429 | 11:45 |
| mup | PR #9429: o/daemon: validation sets api and basic spread test <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9429> | 11:45 |
| pedronis | pstolowski: thx, I put it into my queue | 12:05 |
| pedronis | mvo: I reviewed the fde PRs, some questions there | 12:29 |
| mvo | pedronis: thank you! | 12:30 |
| mup | PR snapd#9749 opened: tests: fix lp-1899664 test when snapd_x1 is not installed in the system <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9749> | 12:58 |
| mborzecki | ijohnson: hey | 13:25 |
| ijohnson | morning mborzecki! | 13:27 |
| niemeyer | Hey hey | 13:35 |
| niemeyer | Quickie, probably for mborzecki | 13:36 |
| niemeyer | We never went past after/stop | 13:36 |
| niemeyer | Erm, sorry.. I mean, we never went past after/before.. the original design had the idea of starts-with | 13:37 |
| niemeyer | I suppose we never needed that because the snap generally starts everything | 13:38 |
| niemeyer | Has our understanding of the problem changed since then? | 13:38 |
| mup | PR snapd#9750 opened: tests: fix the scenario when the "$SRC".orig file does not exist <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9750> | 13:38 |
| mborzecki | niemeyer: we didn't, iirc there was no agreement about keywords and the discussion got derailed with cross snap dependencies at some point | 13:39 |
| mborzecki | niemeyer: if it's just about start-with within a single snap it should be easy enough to do ;) | 13:41 |
| niemeyer | Yeah, I'm mainly wondering if anything has changed, as I'm about to replicate the design on something where different startup settings will be more common, so this will come at play quickly | 13:43 |
| niemeyer | So just checking if we've learned anything since the discussed this, and whether we still have the same design, meaning after/before do not imply start/stop-with | 13:43 |
| niemeyer | Ideally we can use the exact same design, so people learning about one mechanism already know the other | 13:44 |
| mup | PR snapd#9751 opened: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9751> | 13:53 |
| mup | PR snapd#9743 closed: daemon: split unsupported buy implementation to its own api_*.go files <Cleanup :broom:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9743> | 14:48 |
| zyga | mborzecki interesting bug | 15:01 |
| niemeyer | pedronis, mborzecki: I wonder if there's a reason for it to be "starts-with" vs. "start-with" | 15:26 |
| niemeyer | Yeah, I think "start-with" is actually more natural... there are several "start-" and "restart-" prefixes | 15:28 |
| pedronis | they have a bit of a different role | 15:30 |
| pedronis | there start/restart are nouns | 15:30 |
| pedronis | here start would be a verb | 15:32 |
| pedronis | start-with and starts-with have a bit of different connotation, the first is command/order, the second more declarative | 15:32 |
| pedronis | for this kind of settings systemd itself prefers the indicative over the imperative: BindsTo JoinsNamespaceOf | 15:36 |
| niemeyer | Indeed, but I wonder if consistency would win | 15:37 |
| niemeyer | Let me look again at the docs | 15:37 |
| pedronis | I think consistency would be easier for non-native speakers, but conceptually is a bit off | 15:37 |
| pedronis | for this | 15:38 |
| niemeyer | Seems analogous to start-timeout | 15:38 |
| niemeyer | Again, I get that in terms of grammar it's slightly different, but I'm not sure people would understand that rather than just finding it inconsistent | 15:39 |
| niemeyer | Is there a better term to use instead of -with that would make it a more natural noun | 15:40 |
| pedronis | to have a name, you would need some like start-companions or something, it gets odd I think | 15:43 |
| mup | PR snapcraft#3375 opened: ci: migrate spread tests to github actions <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3375> | 15:45 |
| niemeyer | pedronis: start-friends | 15:47 |
| niemeyer | :P | 15:47 |
| niemeyer | start-buddy | 15:48 |
| niemeyer | pedronis: "start-group" is not too bad | 15:49 |
| * cachio lunch | 15:49 | |
| pedronis | that could work | 15:49 |
| niemeyer | and the semantics seems right.. it's really a group. The statement binds them bilaterally | 15:50 |
| ijohnson | pedronis: ok, I addressed your comments on #9695 | 16:15 |
| mup | PR #9695: bootloader/lk: add support for UC20 lk bootloader with V2 lkenv structs <Squash-merge> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9695> | 16:15 |
| === JanC is now known as Guest22061 | ||
| === JanC_ is now known as JanC | ||
| blathijs | Hey folks, got a question about snap and apparmor profiles. I'm getting some apparmor denials in my logs from the spotify snap, which would be fixed by adding some extra allows (or silent denies) in /var/lib/snapd/apparmor/profiles/snap.spotify.spotify. Now my question is: Where does the content of that file come from? Is that shipped as part of the snap? Or is it generated by snapd based on snap metadata? | 16:53 |
| ijohnson | blathijs: it's generated by snapd based on snap metadata | 16:53 |
| blathijs | (and the underlying question is: Where should I be asking to get this fixed, in snap or in spotify?) | 16:53 |
| ijohnson | blathijs: I would recommend starting a forum topic at forum.snapcraft.io, it's unclear whether it's something that the snap author (i.e. spotify) needs to adjust or whether it's something that snapd would need to adjust, but it's easier to gather such details in a more persistent setting | 16:54 |
| blathijs | ijohnson: Will do, thanks for the quick reply :-) | 16:56 |
| ijohnson | pedronis: also regarding the degraded mode pr that failed, from the log in install mode there is this bit: https://pastebin.ubuntu.com/p/RNqY5vDPBT/ | 16:57 |
| ijohnson | so the degraded mode itself wasn't flaky, it was the installation that was flaky | 16:57 |
| ijohnson | unfortunately without an active shell I can't tell what went wrong to cause "device /dev/vda4 not available" | 16:57 |
| mup | PR snapcraft#3390 opened: project_loader, meta, formatting_utils: account for empty env <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3390> | 17:05 |
| blathijs | ijohnson: Created a post, thanks again: https://forum.snapcraft.io/t/apparmor-related-denials-for-spotify-snap/21479 | 17:32 |
| ijohnson | np | 17:32 |
| mborzecki | ijohnson: zyga: thanks for reviews, i've updated https://github.com/snapcore/snapd/pull/9751 | 17:54 |
| mup | PR #9751: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9751> | 17:54 |
| ijohnson | Nice thanks mborzecki ! | 17:55 |
| * ijohnson lunches | 17:55 | |
| zyga | ijohnson hi | 19:00 |
| zyga | ijohnson should I apply s/!/not / suggestions I've made to https://github.com/snapcore/snapd/pull/9751 | 19:00 |
| mup | PR #9751: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries <Squash-merge> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9751> | 19:00 |
| zyga | re, I must say this agresive suspend is annoying | 19:06 |
| ijohnson | hey zyga | 19:07 |
| zyga | hey :) | 19:07 |
| ijohnson | do you have perms to apply the suggestions ? | 19:07 |
| zyga | yeah | 19:07 |
| ijohnson | if so I'd say go for it | 19:07 |
| zyga | cool, doing that now | 19:08 |
| ijohnson | if you end up backdooring snapd with your spread test changes though I will be very sad | 19:08 |
| zyga | should have used the batch thing but its' done | 19:08 |
| ijohnson | not that you couldn't have added backdoors to snapd through any of the other super low level code you worked on throughout the years :-) | 19:08 |
| zyga | I would ! do that :) | 19:08 |
| ijohnson | :-D | 19:08 |
| zyga | I have a secret plan | 19:09 |
| zyga | to develop changes to spread that you end up using :) | 19:09 |
| zyga | I have some yocto builds to set up first, | 19:09 |
| ijohnson | haha nice | 19:09 |
| zyga | and muxpi and flashing | 19:09 |
| zyga | all the usual suspects | 19:09 |
| zyga | I want to teach spread to run drive metal directly, though some API that matches muxpi and several other things | 19:10 |
| ogra | poor you | 19:10 |
| zyga | hehe | 19:10 |
| ogra | (yocto) | 19:10 |
| zyga | yeah, it's a different planet | 19:10 |
| zyga | but I'm not touching yocto myself; I'm the CI guy | 19:10 |
| zyga | that bit is fun, I've learned a lot in just one month already | 19:10 |
| ijohnson | interesting, did you ever play with testflinger ? | 19:10 |
| ijohnson | seems similar in purpose | 19:11 |
| zyga | ijohnson somewhat, I watched its development from the side | 19:11 |
| ijohnson | though I guess testflinger integration with spread is more like, spread sends bits to some server, then the server does the metal bits and returns some IP address | 19:11 |
| ijohnson | it sounds like you would be eliminating that middle server bit | 19:11 |
| zyga | yeah, I want spread metal: | 19:11 |
| zyga | ijohnson actually | 19:11 |
| zyga | let me show you | 19:11 |
| zyga | tests: use not instead of ! | 19:12 |
| zyga | er | 19:12 |
| zyga | bad paste | 19:12 |
| zyga | https://git.ostc-eu.org/docs/ci | 19:12 |
| zyga | it's WIP, there are issues and there are PRs that change bits | 19:12 |
| zyga | but you can find the general idea here https://git.ostc-eu.org/docs/ci#test-process | 19:12 |
| * ijohnson reads the README and sees mention of kubernetes | 19:13 | |
| * ijohnson squints | 19:13 | |
| zyga | ijohnson gitlab does k8s | 19:13 |
| zyga | it's super cool actually | 19:13 |
| zyga | remember how we have github workers | 19:13 |
| ijohnson | yep | 19:13 |
| zyga | gitlab has runners, different name, but also different model | 19:13 |
| zyga | you set up a runner | 19:13 |
| zyga | and configure a runner executor | 19:13 |
| zyga | there's a dozen of those | 19:14 |
| zyga | from virtualization stuff like qemu or virtualbox | 19:14 |
| zyga | to dockers | 19:14 |
| zyga | to k8s | 19:14 |
| zyga | including auto-scaling | 19:14 |
| zyga | to simple shell and custom | 19:14 |
| zyga | you can have one runner that spawns new containers in an auto-scaling k8s cluster | 19:14 |
| zyga | it's veeeeery nice | 19:14 |
| zyga | and extremely fast | 19:14 |
| mup | PR snapd#9752 opened: gadget,o/devicestate: set implicit values for schema and role directly instead of relying on Effective* accessors <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9752> | 19:14 |
| zyga | so you can have really high throughput quickly | 19:15 |
| zyga | and since for most of the tests you don't need a VM this is really faster | 19:15 |
| zyga | s/tests/tasks/ | 19:15 |
| ijohnson | that does sound nice | 19:15 |
| zyga | e.g. building | 19:15 |
| zyga | gitlab has some nice bits | 19:15 |
| zyga | I was surprised by how small this difference is and how big impact it makes | 19:15 |
| zyga | so anyway, I want to extend spread, perhaps so that I can make spread a gitlab executor | 19:16 |
| zyga | gitlab runner is written in go | 19:16 |
| zyga | so ... that's really close :) | 19:16 |
| zyga | so that I can have pipelines that run on metal | 19:16 |
| zyga | (pipelines are like actions, somewhat) | 19:16 |
| zyga | and that the metal deployment can use an OS image build by an earlier pipeline | 19:16 |
| zyga | I need an API because one worker will "see" many devices | 19:17 |
| ijohnson | that does sound really cool, I oftentimes have had this desire to hook up some extra machines I have to maas to do a similar kind of thing | 19:17 |
| zyga | so that in the end one test can be really spread across several devices | 19:17 |
| ijohnson | but really to do spread tests directly that way would be nice | 19:17 |
| ijohnson | would cut out the middle man again, this time a different middle man | 19:18 |
| zyga | I need to think about the API, should be both simple and match spread | 19:18 |
| zyga | it will probably be some local or network IPC because I want those jobs to come in and run in the sandbox provided by gitlab | 19:18 |
| zyga | so probably like a very simple cloud api: allocate, deploy, connect, etc | 19:19 |
| zyga | I'm not there yet | 19:19 |
| mup | PR snapd#9753 opened: daemon: split aliases support to its own api_*.go files <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9753> | 19:19 |
| zyga | so small bits of spread, packaging, and I can share the design as it's fully public :) | 19:19 |
| zyga | maybe some of that can help you | 19:20 |
| ijohnson | yeah if you have spread pr's I'd be interested to see | 19:21 |
| zyga | ijohnson I'll start with a for but I will upstream them (that's even in the spec already) when I think they are good and we have something to show | 19:22 |
| zyga | ijohnson: given I work on muxpi I think those may really apply | 19:22 |
| zyga | there are also some bits that are not described here but may apply to even wider audience | 19:22 |
| zyga | where a pi can drive simpler boards without any other help | 19:23 |
| zyga | ijohnson: I need to write some flashing tools as well | 19:23 |
| zyga | ijohnson: I'm very keen to get boot-from-usb to work | 19:23 |
| zyga | ijohnson: did you know raspberry pi can power down USB ports? | 19:23 |
| zyga | you can boot many devices by powering them from usb and talking to the on-chip bootloader | 19:23 |
| zyga | ijohnson: feed a 2nd stage bootloader and you are good, no need for muxpi if you have network | 19:24 |
| zyga | (you can fetch stuff from uboot, for example) | 19:24 |
| zyga | and write to SD directly | 19:24 |
| zyga | even if you only fetch and boot a small kernel | 19:24 |
| ijohnson | right | 19:24 |
| zyga | then you can eventually get to the right stage where your card is ready and you just ... power cycle | 19:25 |
| zyga | all over usb | 19:25 |
| ijohnson | you should talk to ondra, he has all sorts of flashing tools | 19:25 |
| zyga | ondra ^^ hey | 19:25 |
| zyga | ondra I'm working with someone who used to work with _you_ as a customer btw | 19:25 |
| zyga | he's at H now | 19:25 |
| zyga | from e.on IIRC | 19:25 |
| zyga | weird small world | 19:26 |
| mup | PR snapd#9754 opened: o/devicestate: save model with serial in the device save db (2.48) <Created by pedronis> <https://github.com/snapcore/snapd/pull/9754> | 19:29 |
| pedronis | ijohnson: I re-reviewed the lk PR | 19:42 |
| ijohnson | thanks pedronis | 19:44 |
| * ijohnson looks | 19:44 | |
| ijohnson | pedronis: do you want me to address that point in the pr or can it be a follow up ? | 19:46 |
| ijohnson | I guess I would prefer a followup since it's green except for debian with dbus problems | 19:47 |
| pedronis | ijohnson: a follow up is ok | 19:48 |
| ijohnson | great, do you want to squash merge it for me then? | 19:48 |
| mup | PR snapd#9753 closed: daemon: split aliases support to its own api_*.go files <Cleanup :broom:> <Created by pedronis> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/9753> | 19:50 |
| pedronis | ijohnson: #9705 needs your review btw | 19:51 |
| mup | PR #9705: devicestate: add runFDESetupHook() helper <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9705> | 19:51 |
| ijohnson | yes I'm working on that today | 19:51 |
| ijohnson | almost done with it | 19:51 |
| mup | PR snapd#9695 closed: bootloader/lk: add support for UC20 lk bootloader with V2 lkenv structs <Squash-merge> <UC20> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9695> | 19:55 |
| * cachio afk | 19:55 | |
| mup | PR snapd#9755 opened: daemon: split aliases support to its own api_*.go files <Created by pedronis> <https://github.com/snapcore/snapd/pull/9755> | 20:05 |
| pedronis | ijohnson: do you need anything else from me? | 20:10 |
| ijohnson | pedronis no I'm good but nezt week we should talk about the devmode snaps stuff | 20:11 |
| ijohnson | Have a good weekend pedronis | 20:11 |
| pedronis | yes about devmode. thanks, same to you | 20:11 |
| mup | PR snapcraft#3375 closed: ci: migrate spread tests to github actions <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3375> | 20:21 |
| mup | PR snapd#9756 opened: bootloader/{lk,lkenv}: followups from #9695 <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9756> | 21:05 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!