mwhudson | bah snapcraft just said this to me: | 00:15 |
---|---|---|
mwhudson | Sorry, an error occurred in Snapcraft: | 00:15 |
mwhudson | 'ReviewInProgress' is not one of ['Published', 'Unpublished', 'ManualReviewPending', 'NeedsInformation', 'AutomaticallyRejected', 'Rejected'] | 00:15 |
mwhudson | doing list-revisions | 00:15 |
mborzecki | morning | 06:47 |
zyga | good morning, hey mborzecki | 07:03 |
mborzecki | zyga: hey | 07:03 |
mborzecki | quick errand, back in 30 | 07:53 |
pstolowski | morning | 08:02 |
zyga | hey pstolowski | 08:03 |
zyga | hey mvo, good morning | 08:08 |
mvo | good morning zyga ! | 08:17 |
mvo | zyga: quick question - you had a pi and an sd card that was affected by this vfat write bug iirc. we have a fix in the pi gadget in edge, would be be easy for you to test? if not that would be lovely. otherwise I will test but I need to find an sd card first that I can reproudce the original issue with :( | 08:18 |
zyga | xnox pinged me on Friday | 08:19 |
zyga | yeah, I'm going to be working on a pi today | 08:19 |
zyga | do you think I can test this on core or do I need cassic | 08:19 |
zyga | *classic | 08:19 |
mborzecki | re | 08:24 |
mborzecki | pstolowski: mvo: hey | 08:24 |
mborzecki | mvo: can you take a look at https://github.com/snapcore/snapd/pull/9751 ? | 08:25 |
mup | PR #9751: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries <Squash-merge> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9751> | 08:25 |
mvo | zyga: core is fine (sorry for the delay) | 08:38 |
mvo | mborzecki: sure | 08:39 |
zyga | mvo, thanks! | 08:41 |
mup | PR snapd#9754 closed: o/devicestate: save model with serial in the device save db (2.48) <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9754> | 08:50 |
mup | PR snapd#9751 closed: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries <Squash-merge> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9751> | 08:55 |
mup | PR snapd#9750 closed: tests: fix the scenario when the "$SRC".orig file does not exist <Simple 😃> <Created by sergiocazzolato> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9750> | 09:10 |
mup | PR snapd#9749 closed: tests: fix lp-1899664 test when snapd_x1 is not installed in the system <Simple 😃> <Created by sergiocazzolato> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9749> | 09:15 |
zyga | ok, morning meetings over, I'll work on some packaging and then switch gears to pi | 09:32 |
xnox | zyga: we have new uboot in both core (edge) and in classic (enable & upgrade to proposed) so whichever. | 09:38 |
zyga | xnox yeah, that's best, I have a core installation and that will be easier for me to work with | 09:39 |
xnox | zyga: we don't bump the edition in the gadget.... so you might need to copy things out by hand from the new gadget =) or like copy things from the edge channel build of the image. | 09:39 |
zyga | that's okay | 09:40 |
zyga | xnox do you plan to bump it? | 09:40 |
xnox | not until we have dtbs sorted. | 09:41 |
zyga | xnox that's smart, I was about to ask | 09:41 |
zyga | right now old installs are hosed by both bugs | 09:41 |
zyga | thanks | 09:41 |
* mvo hugs pstolowski for his review of 9738 | 09:57 | |
pstolowski | mvo: yw, i hope it makes sense | 09:59 |
mvo | pstolowski: I think so, thanks! | 09:59 |
mup | PR snapd#9738 closed: secboot: use `fde-reveal-key` if available to unseal key <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9738> | 10:15 |
mup | PR snapd#9757 opened: tests: move snapstate config defaults tests to a separate file <Created by stolowski> <https://github.com/snapcore/snapd/pull/9757> | 10:15 |
mup | PR snapd#9758 opened: secboot: add new LockSealedKeys() that uses either TPM/fde-reveal-key <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9758> | 10:20 |
mup | PR snapd#9759 opened: cmd/snap-update-ns: add better unit test for overname sorting <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9759> | 10:35 |
ogra | error: error running snapctl: snap "scummvm" has "install-snap" change in progress | 11:08 |
ogra | is that known ? (the install hook runs "snapctl", it works fine on a 20.10 install but not on a PiOS install (same snapd version) | 11:09 |
ogra | ) | 11:09 |
ogra | (see https://forum.snapcraft.io/t/scummvm-snap-failing-to-install-on-rpi-4/21394 for details) | 11:09 |
ogra | alan_g, ^^^ | 11:10 |
mup | PR snapd#9759 closed: cmd/snap-update-ns: add better unit test for overname sorting <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9759> | 11:16 |
mup | PR snapd#9748 closed: gadget: start separating rule/convention validation from basic soundness <Cleanup :broom:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9748> | 11:21 |
pedronis | pstolowski: seems preseed reset needs tweaks maybe, it failed here: https://github.com/snapcore/snapd/pull/9755/checks?check_run_id=1510031487 | 11:21 |
mup | PR #9755: daemon: split aliases support to its own api_*.go files <Created by pedronis> <https://github.com/snapcore/snapd/pull/9755> | 11:22 |
pstolowski | pedronis: looking | 11:22 |
pedronis | pstolowski: might also be not preseed that needs tweaks but the inhbit lock logic vs preseed itself | 11:23 |
pedronis | *not preseed reset | 11:23 |
* pstolowski lunch | 11:47 | |
=== ddstreet_away is now known as ddstreet | ||
pstolowski | re | 12:56 |
pedronis | pstolowski: I did a pass on #9732 as well | 12:57 |
mup | PR #9732: asserts: snapasserts method to validate installed snaps against validation sets <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9732> | 12:57 |
pstolowski | ty | 12:57 |
=== hggdh_ is now known as hggdh | ||
mup | PR snapd#9760 opened: cmd/snap-preseed: reset run inhibit locks on --reset <Created by stolowski> <https://github.com/snapcore/snapd/pull/9760> | 14:01 |
pedronis | pstolowski: btw I left some comments in https://github.com/snapcore/snapd/pull/9513 let me know if you have questions | 14:31 |
mup | PR #9513: snapshotstate: detect duplicated snapshot imports <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9513> | 14:31 |
pstolowski | ok | 14:45 |
mup | PR snapd#9755 closed: daemon: split aliases support to its own api_*.go files <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9755> | 15:27 |
pstolowski | pedronis: re your validation sets comment, for snaps at wrong revisions the error would show the required revision coming from assertion, wdyt? | 15:41 |
pedronis | pstolowski: that seems a good step | 15:41 |
pedronis | pstolowski: to be clear if the validation sets itself is not in conflict, there should be exactly one value | 15:42 |
pstolowski | pedronis: good point | 15:43 |
* zyga-mbp fiddles with pi which no longer prints anything on serial | 15:54 | |
pedronis | pstolowski: https://github.com/snapcore/snapd/pull/9761 is the PR I mentioned in the standup | 15:54 |
mup | PR #9761: daemon: actually move APIBaseSuite to daemon_test.apiBaseSuite <Created by pedronis> <https://github.com/snapcore/snapd/pull/9761> | 15:55 |
mup | PR snapd#9761 opened: daemon: actually move APIBaseSuite to daemon_test.apiBaseSuite <Created by pedronis> <https://github.com/snapcore/snapd/pull/9761> | 15:57 |
zyga-mbp | weird | 15:58 |
zyga-mbp | took of the hat, fixed the problem | 15:59 |
pstolowski | pedronis: ack, ty | 16:00 |
pstolowski | pedronis: i updated validation-sets PR | 16:06 |
pedronis | mvo: I made a high-level comment here https://github.com/snapcore/snapd/pull/9149/files#r537628269 let me know if you want to chat about it | 16:09 |
mup | PR #9149: gadget: provide new gadget.ResolveContentPaths() (2/N) <Needs Samuele review> <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9149> | 16:09 |
pedronis | pstolowski: thx | 16:10 |
ijohnson | mvo: pedronis: should I include mvo in our sync tomorrow to talk about next things for me? I think so, but the calendar is rather tight tomorrow for both of you together | 16:14 |
pedronis | ijohnson: I suppose after standup should work? usually standup is shortish these days | 16:15 |
mvo | +1 | 16:15 |
ijohnson | ok that sounds good then | 16:15 |
ijohnson | thanks | 16:15 |
ijohnson | sent for half past the hour | 16:16 |
zyga-mbp | xnox verifying now | 16:23 |
zyga-mbp | xnox I even found the card | 16:23 |
zyga-mbp | mvo if you are interested it is a 8GB samsung evo | 16:24 |
zyga-mbp | probably bottom barrel card | 16:24 |
mvo | zyga-mbp: great, thank you! | 16:24 |
zyga-mbp | grabbing new pi snap | 16:26 |
pedronis | pstolowski: I did a pass on #9429 too | 16:26 |
mup | PR #9429: o/daemon: validation sets api and basic spread test <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9429> | 16:27 |
pstolowski | pedronis: ty. i reviewed 9761 | 16:29 |
pedronis | thx | 16:29 |
zyga-mbp | heh | 16:41 |
zyga-mbp | what a day | 16:41 |
zyga-mbp | sna zyga@pi3-2:~$ snap | 16:41 |
zyga-mbp | [ 162.936252] SQUASHFS error: xz decompression failed, data probably corrupt | 16:41 |
zyga-mbp | [ 162.943214] SQUASHFS error: squashfs_read_data failed to read block 0x576e07 | 16:41 |
zyga-mbp | [ 162.967676] SQUASHFS error: xz decompression failed, data probably corrupt | 16:41 |
zyga-mbp | [ 162.974650] SQUASHFS error: squashfs_read_data failed to read block 0x576e07 | 16:41 |
zyga-mbp | [ 162.998901] SQUASHFS error: xz decompression failed, data probably corrupt | 16:41 |
zyga-mbp | [ 163.005899] SQUASHFS error: squashfs_read_data failed to read block 0x576e07 | 16:41 |
zyga-mbp | fatal error: unexpected signal during runtime execution | 16:41 |
zyga-mbp | [signal SIGBUS: bus error code=0x2 addr=0xa5396c pc=0x5d4dc] | 16:41 |
pstolowski | oh sdcard failed? | 16:42 |
zyga-mbp | pstolowski not sure yet, maybe | 16:43 |
mvo | pedronis: I updated 9741, hope I did not miss anything :) | 16:47 |
pedronis | pstolowski: I re-reviewed 9732, some ideas there | 16:48 |
pstolowski | thanks | 16:48 |
xnox | zyga-mbp: is that mbp M1 ?! | 16:48 |
pstolowski | xnox: not *yet* i think ;) | 16:50 |
zyga-mbp | xnox nah, my "old" 9th gen 16" | 16:50 |
zyga-mbp | vintage intel ;) | 16:50 |
zyga-mbp | xnox if you want m1 status ask kissiel | 16:55 |
zyga-mbp | xnox m1 is oOOh fast in his words, x2 speed of 4800u ryzen thinkpad t14 | 16:55 |
mup | PR snapd#9752 closed: gadget,o/devicestate: set implicit values for schema and role directly instead of relying on Effective* accessors <Cleanup :broom:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9752> | 17:12 |
=== ijohnson is now known as ijohnson|lunch | ||
mup | PR snapd#9762 opened: gadget: prepare gadget kernel refs (0/N) <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9762> | 19:18 |
=== ijohnson|lunch is now known as ijohnson | ||
stgraber | root@snap-ubuntu-core-20:~# snap refresh | 20:25 |
stgraber | error: cannot perform the following tasks: | 20:25 |
stgraber | - Download snap "pc" (115) from channel "20/stable" (cannot read device key pair: cannot find key pair) | 20:25 |
stgraber | root@snap-ubuntu-core-20:~# | 20:26 |
stgraber | how do I fix that? :) | 20:26 |
stgraber | it's breaking LXD's CI on Ubuntu Core 20 | 20:26 |
stgraber | ijohnson: looks like you saw a similar report on the forum a few weeks back? | 20:27 |
ijohnson | stgraber: this is from old uc20 images | 20:27 |
ijohnson | you need to reinstall that uc20 image with newer snaps in the image | 20:27 |
ijohnson | s/uc20 image/uc20 system/ | 20:27 |
stgraber | well, that's gonna be fun | 20:28 |
ijohnson | it's a consequence of the changes we needed to make for uc20 fde support, we needed to move where keys are located and this breaks old systems unfortunately | 20:28 |
ijohnson | I thought that images should have been respun already if you pull from cdimage automatically or something | 20:28 |
ijohnson | but I haven't checked cdimages in a while | 20:29 |
stgraber | it's a persistent test system | 20:29 |
stgraber | hence the "fun" | 20:29 |
stgraber | since I need to figure out how it was built and then go to create it, update DNS records, re-setup snap proxy and the like | 20:29 |
stgraber | anyway, it as pre-release so I can't complain too much other than make a mental note not to setup CI for Core 22 until it's fully released ;) | 20:30 |
ijohnson | yeah it's definitely unfortunate we didn't intend to break unencrypted systems like this but we just didn't have the time to try and implement support for both key locations | 20:32 |
stgraber | ijohnson: the images your doc points to date from May, so presumably will hit the exact same issue? | 20:36 |
stgraber | http://cdimage.ubuntu.com/ubuntu-core/20/beta/current/ | 20:36 |
ijohnson | stgraber: good point we need to update that , but try http://cdimage.ubuntu.com/ubuntu-core/20/candidate/pending/ instead | 20:36 |
ijohnson | candidate > beta :-) | 20:36 |
mup | PR snapd#9761 closed: daemon: actually move APIBaseSuite to daemon_test.apiBaseSuite <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9761> | 22:04 |
mup | PR snapd#9763 opened: daemon: split find support to its own api_*.go files and move some helpers <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9763> | 22:09 |
mup | PR snapd#9764 opened: interfaces/builtin/docker-support: allow /run/containerd/s/ <Needs security review> <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9764> | 22:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!