[00:15] bah snapcraft just said this to me: [00:15] Sorry, an error occurred in Snapcraft: [00:15] 'ReviewInProgress' is not one of ['Published', 'Unpublished', 'ManualReviewPending', 'NeedsInformation', 'AutomaticallyRejected', 'Rejected'] [00:15] doing list-revisions [06:47] morning [07:03] good morning, hey mborzecki [07:03] zyga: hey [07:53] quick errand, back in 30 [08:02] morning [08:03] hey pstolowski [08:08] hey mvo, good morning [08:17] good morning zyga ! [08:18] zyga: quick question - you had a pi and an sd card that was affected by this vfat write bug iirc. we have a fix in the pi gadget in edge, would be be easy for you to test? if not that would be lovely. otherwise I will test but I need to find an sd card first that I can reproudce the original issue with :( [08:19] xnox pinged me on Friday [08:19] yeah, I'm going to be working on a pi today [08:19] do you think I can test this on core or do I need cassic [08:19] *classic [08:24] re [08:24] pstolowski: mvo: hey [08:25] mvo: can you take a look at https://github.com/snapcore/snapd/pull/9751 ? [08:25] PR #9751: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries [08:38] zyga: core is fine (sorry for the delay) [08:39] mborzecki: sure [08:41] mvo, thanks! [08:50] PR snapd#9754 closed: o/devicestate: save model with serial in the device save db (2.48) [08:55] PR snapd#9751 closed: cmd/snap-update-ns: fix sorting of overname mount entries wrt other entries [09:10] PR snapd#9750 closed: tests: fix the scenario when the "$SRC".orig file does not exist [09:15] PR snapd#9749 closed: tests: fix lp-1899664 test when snapd_x1 is not installed in the system [09:32] ok, morning meetings over, I'll work on some packaging and then switch gears to pi [09:38] zyga: we have new uboot in both core (edge) and in classic (enable & upgrade to proposed) so whichever. [09:39] xnox yeah, that's best, I have a core installation and that will be easier for me to work with [09:39] zyga: we don't bump the edition in the gadget.... so you might need to copy things out by hand from the new gadget =) or like copy things from the edge channel build of the image. [09:40] that's okay [09:40] xnox do you plan to bump it? [09:41] not until we have dtbs sorted. [09:41] xnox that's smart, I was about to ask [09:41] right now old installs are hosed by both bugs [09:41] thanks [09:57] * mvo hugs pstolowski for his review of 9738 [09:59] mvo: yw, i hope it makes sense [09:59] pstolowski: I think so, thanks! [10:15] PR snapd#9738 closed: secboot: use `fde-reveal-key` if available to unseal key [10:15] PR snapd#9757 opened: tests: move snapstate config defaults tests to a separate file [10:20] PR snapd#9758 opened: secboot: add new LockSealedKeys() that uses either TPM/fde-reveal-key [10:35] PR snapd#9759 opened: cmd/snap-update-ns: add better unit test for overname sorting [11:08] error: error running snapctl: snap "scummvm" has "install-snap" change in progress [11:09] is that known ? (the install hook runs "snapctl", it works fine on a 20.10 install but not on a PiOS install (same snapd version) [11:09] ) [11:09] (see https://forum.snapcraft.io/t/scummvm-snap-failing-to-install-on-rpi-4/21394 for details) [11:10] alan_g, ^^^ [11:16] PR snapd#9759 closed: cmd/snap-update-ns: add better unit test for overname sorting [11:21] PR snapd#9748 closed: gadget: start separating rule/convention validation from basic soundness [11:21] pstolowski: seems preseed reset needs tweaks maybe, it failed here: https://github.com/snapcore/snapd/pull/9755/checks?check_run_id=1510031487 [11:22] PR #9755: daemon: split aliases support to its own api_*.go files [11:22] pedronis: looking [11:23] pstolowski: might also be not preseed that needs tweaks but the inhbit lock logic vs preseed itself [11:23] *not preseed reset [11:47] * pstolowski lunch === ddstreet_away is now known as ddstreet [12:56] re [12:57] pstolowski: I did a pass on #9732 as well [12:57] PR #9732: asserts: snapasserts method to validate installed snaps against validation sets [12:57] ty === hggdh_ is now known as hggdh [14:01] PR snapd#9760 opened: cmd/snap-preseed: reset run inhibit locks on --reset [14:31] pstolowski: btw I left some comments in https://github.com/snapcore/snapd/pull/9513 let me know if you have questions [14:31] PR #9513: snapshotstate: detect duplicated snapshot imports [14:45] ok [15:27] PR snapd#9755 closed: daemon: split aliases support to its own api_*.go files [15:41] pedronis: re your validation sets comment, for snaps at wrong revisions the error would show the required revision coming from assertion, wdyt? [15:41] pstolowski: that seems a good step [15:42] pstolowski: to be clear if the validation sets itself is not in conflict, there should be exactly one value [15:43] pedronis: good point [15:54] * zyga-mbp fiddles with pi which no longer prints anything on serial [15:54] pstolowski: https://github.com/snapcore/snapd/pull/9761 is the PR I mentioned in the standup [15:55] PR #9761: daemon: actually move APIBaseSuite to daemon_test.apiBaseSuite [15:57] PR snapd#9761 opened: daemon: actually move APIBaseSuite to daemon_test.apiBaseSuite [15:58] weird [15:59] took of the hat, fixed the problem [16:00] pedronis: ack, ty [16:06] pedronis: i updated validation-sets PR [16:09] mvo: I made a high-level comment here https://github.com/snapcore/snapd/pull/9149/files#r537628269 let me know if you want to chat about it [16:09] PR #9149: gadget: provide new gadget.ResolveContentPaths() (2/N) [16:10] pstolowski: thx [16:14] mvo: pedronis: should I include mvo in our sync tomorrow to talk about next things for me? I think so, but the calendar is rather tight tomorrow for both of you together [16:15] ijohnson: I suppose after standup should work? usually standup is shortish these days [16:15] +1 [16:15] ok that sounds good then [16:15] thanks [16:16] sent for half past the hour [16:23] xnox verifying now [16:23] xnox I even found the card [16:24] mvo if you are interested it is a 8GB samsung evo [16:24] probably bottom barrel card [16:24] zyga-mbp: great, thank you! [16:26] grabbing new pi snap [16:26] pstolowski: I did a pass on #9429 too [16:27] PR #9429: o/daemon: validation sets api and basic spread test [16:29] pedronis: ty. i reviewed 9761 [16:29] thx [16:41] heh [16:41] what a day [16:41] sna zyga@pi3-2:~$ snap [16:41] [ 162.936252] SQUASHFS error: xz decompression failed, data probably corrupt [16:41] [ 162.943214] SQUASHFS error: squashfs_read_data failed to read block 0x576e07 [16:41] [ 162.967676] SQUASHFS error: xz decompression failed, data probably corrupt [16:41] [ 162.974650] SQUASHFS error: squashfs_read_data failed to read block 0x576e07 [16:41] [ 162.998901] SQUASHFS error: xz decompression failed, data probably corrupt [16:41] [ 163.005899] SQUASHFS error: squashfs_read_data failed to read block 0x576e07 [16:41] fatal error: unexpected signal during runtime execution [16:41] [signal SIGBUS: bus error code=0x2 addr=0xa5396c pc=0x5d4dc] [16:42] oh sdcard failed? [16:43] pstolowski not sure yet, maybe [16:47] pedronis: I updated 9741, hope I did not miss anything :) [16:48] pstolowski: I re-reviewed 9732, some ideas there [16:48] thanks [16:48] zyga-mbp: is that mbp M1 ?! [16:50] xnox: not *yet* i think ;) [16:50] xnox nah, my "old" 9th gen 16" [16:50] vintage intel ;) [16:55] xnox if you want m1 status ask kissiel [16:55] xnox m1 is oOOh fast in his words, x2 speed of 4800u ryzen thinkpad t14 [17:12] PR snapd#9752 closed: gadget,o/devicestate: set implicit values for schema and role directly instead of relying on Effective* accessors === ijohnson is now known as ijohnson|lunch [19:18] PR snapd#9762 opened: gadget: prepare gadget kernel refs (0/N) === ijohnson|lunch is now known as ijohnson [20:25] root@snap-ubuntu-core-20:~# snap refresh [20:25] error: cannot perform the following tasks: [20:25] - Download snap "pc" (115) from channel "20/stable" (cannot read device key pair: cannot find key pair) [20:26] root@snap-ubuntu-core-20:~# [20:26] how do I fix that? :) [20:26] it's breaking LXD's CI on Ubuntu Core 20 [20:27] ijohnson: looks like you saw a similar report on the forum a few weeks back? [20:27] stgraber: this is from old uc20 images [20:27] you need to reinstall that uc20 image with newer snaps in the image [20:27] s/uc20 image/uc20 system/ [20:28] well, that's gonna be fun [20:28] it's a consequence of the changes we needed to make for uc20 fde support, we needed to move where keys are located and this breaks old systems unfortunately [20:28] I thought that images should have been respun already if you pull from cdimage automatically or something [20:29] but I haven't checked cdimages in a while [20:29] it's a persistent test system [20:29] hence the "fun" [20:29] since I need to figure out how it was built and then go to create it, update DNS records, re-setup snap proxy and the like [20:30] anyway, it as pre-release so I can't complain too much other than make a mental note not to setup CI for Core 22 until it's fully released ;) [20:32] yeah it's definitely unfortunate we didn't intend to break unencrypted systems like this but we just didn't have the time to try and implement support for both key locations [20:36] ijohnson: the images your doc points to date from May, so presumably will hit the exact same issue? [20:36] http://cdimage.ubuntu.com/ubuntu-core/20/beta/current/ [20:36] stgraber: good point we need to update that , but try http://cdimage.ubuntu.com/ubuntu-core/20/candidate/pending/ instead [20:36] candidate > beta :-) [22:04] PR snapd#9761 closed: daemon: actually move APIBaseSuite to daemon_test.apiBaseSuite [22:09] PR snapd#9763 opened: daemon: split find support to its own api_*.go files and move some helpers [22:39] PR snapd#9764 opened: interfaces/builtin/docker-support: allow /run/containerd/s/