=== benj_- is now known as benj_
=== cpaelzer__ is now known as cpaelzer
otuboAnyone interested on taking a quick look at my PR regarding resizing LVM? https://github.com/canonical/cloud-init/pull/72115:00
otubosmoser: Odd_Bloke15:01
smoserotubo: looking15:11
=== cpaelzer__ is now known as cpaelzer
smoserotubo: just hit submit15:41
smosermeena is much faster than me15:43
otubosmoser: very interesting insights on how to get it better. Thanks a lot. Will work on that15:44
smoserotubo: i try to mix in possibly useful comments with my syntax/style complaints.15:45
smoserthe 'is_lvm' though needs to be fixed for sure, and checking whether or not 'lvm' is present.15:45
otubosmoser: indeed. Agree15:46
minimalotubo: Hi. Haven't had a chance to have a proper look at your LVM PR yet. From a brief scan it handles native LVM (i.e. on block device) but doesn't handle LVM on LUKS. Did you consider that as well?15:50
otubominimal: I realized it was mssing LUKS support yesterday when it was working on my laptop (LUKS) but not working on the VM (no LUKS) :-D So yeah, I'm aware of it, but will probably be another separate PR in the future.15:52
minimalotubo: Ok. Am currently building LVM and LVM-on-LUKS VMs for other purposes (using cloud-init) so will be able to help out15:54
otubominimal: nice! One problem though is that I'm leaving for vacation tomorrow and will probably be back only jan/4th. But yeah, I can ping you15:55
smoserotubo: enjoy your time off.15:58
otubosmoser: man, I'm looking forward15:58
meenasmoser, i might have been quicker, but your review was way more useful16:03
=== cpaelzer__ is now known as cpaelzer
smosermeena: does alpine not have udev ?16:36
minimalsmoser: yes Alpine has udev but its not used by default16:41
minimalhowever as the Alpine packager for cloud-init the package has a dependancy on udev16:41
minimalwhat's the Alpine issue exactly?16:42
smoseryou commented about lack of udevadm in alpine on otubo's PR16:44
smoserhow does device discovery work without udev ?16:44
smoser(not that it *can't* work, just what do they use ?)16:44
minimalsmoser: PR 721? I haven't commented on that yet. I see igalic's comment however16:46
smoseroh. sorry. tab complete fail.16:47
smoserminimal != meena16:47
minimalnormally on Alpine mdev is used. However when I packaged cloud-init for Alpine I ensured that the Alpine package depends on udev rather than mdev as I saw that both the persistent net device naming and the disk setup modules in cloud-init expect udev16:47
minimalI'm the Alpine cloud-init package manintainer and also the person who upstreamed Alpine support in cloud-init :-)16:48
smoseri didnt realize mdev was actually in use anywhere.16:48
smoseri had seen it in buildroot and the like, but didn't realize it was used for anything larger16:49
minimalyupe, remember Alpine comes from a minimal (no pun intended) background which is why it also prefers busybox or other stripped down alternatives to standard tools16:49
minimalI'll add a comment in the PR in reply to igalic but in summary if you are using the Alpine packaged version of cloud-init then udev will be present.16:51
minimalsmoser: I think Archlinux and Voidlinuxmight also have mdev.16:57
meenaminimal, does your package depend on bash?17:13
minimalnope, Alpine has ash by default. Have I missed some bash script actually used in cloud-init?17:14
minimalon the link I posted in my MR comments on the top right of the page is a Depends dropdown17:15
meenaminimal, OpenNebula and Illumos need it, everything else used sh17:24
meenasmoser, to summarise: minimal => Alpine, meena => FreeBSD17:25
minimalAlpine doesn't use typical sysvinit for example with scripts written in either Sh or Bash, it uses OpenRC instead (like Gentoo, indeed for cloud-init we re-use the Gentoo files in the cloud-init repo)17:26
minimalmeena: Alpine is minimal but "minimal" is not Alpine ;-)17:26
smoserit'd be more helpful if one of you changed your name....17:27
smoseris that too much to askk ?17:27
* smoser ducks17:27
minimalsmoser: to mo-minimal? ;-)17:27
minimalor you mean something not beginning with "m"? sure there's 25 options to choose from....17:27
smoserbummer. it appears you have to use ascii.17:30
smoseror at least my attempt at changing my nick to ⓜoser failed17:30
meenaIRCv3 surely will fix that17:32
minimalI could change my name to "niche" (i.e. Alpine) and meena to "almost-niche" (i.e. FreeBSD) ;-)17:32
otubosmoser: should cloudinit/cmd/main.py have python shebang? Fedora build is complaining that I'm not packaging it with an executable flag17:36
otuboAnd I'm trying to set 755 on the specfile but it's worthless17:37
smoseri dont htink it should... i wonder why it would think it should.17:37
otubosmoser: look https://fedora.softwarefactory-project.io/zuul/build/b799345fa34f48d3a21674d369fc4bc317:38
otubosmoser: you don't think it should have a shebang or be executable? :)17:38
smoseri think the shebang should just be dropped17:38
otubooh nice, much easier17:38
smoserOdd_Bloke or blackboxsw  ? agree/disagree ?17:39
smoser(and its wrong anyway at this point)17:39
blackboxswsmoser: otubo I think it can be dropped and perms set to 644 on main.py right?17:41
blackboxswrunning cloud-init CLI with that change (perms and dropped shebang) wfm17:41
otuboblackboxsw: it's already 644, rpmlint is complaining that it has shebang && is 64417:41
otuboblackboxsw: nice thanks :)17:42
blackboxswoops I misread long listing on my vm17:42
blackboxswright 644 already17:42
smoseryeah. otubo  submit PR ?17:43
otubosmoser: right away17:44
blackboxswlooks like the only file with that shebanh17:44
blackboxswlooks like the only file with that shebang17:44
otubosmoser: blackboxsw  https://github.com/canonical/cloud-init/pull/72217:49
Odd_Blokefalcojr: blackboxsw: lucasmoura: First SRU verification PR up: https://github.com/cloud-init/ubuntu-sru/pull/16817:54
blackboxswOdd_Bloke: approved18:01
Odd_BlokeI'm still having issues running xenial LXD VMs on my machine for some reason; could someone who _can_ run `CLOUD_INIT_OS_IMAGE=xenial CLOUD_INIT_PLATFORM=lxd_vm CLOUD_INIT_CLOUD_INIT_SOURCE=PROPOSED pytest --log-cli-level=INFO tests/integration_tests/bugs/test_lp1897099.py` for me and pastebin the output?18:05
=== ijohnson is now known as ijohnson|lunch
powersjOdd_Bloke, https://pastebin.ubuntu.com/p/MvZSJ6PptB/18:56
powersjthat was against master18:57
Odd_Blokepowersj: Perfect, thanks!20:06
=== ijohnson|lunch is now known as ijohnson
Odd_Blokefalcojr: https://github.com/canonical/cloud-init/pull/723 <-- the corresponding cloud-init pycloudlib dependency bump20:27
Odd_BlokeNext SRU verification PR: https://github.com/cloud-init/ubuntu-sru/pull/16920:46
Odd_BlokeAnd another one: https://github.com/cloud-init/ubuntu-sru/pull/17020:50
Odd_BlokeAnd: https://github.com/cloud-init/ubuntu-sru/pull/17121:04
Odd_BlokeStill going: https://github.com/cloud-init/ubuntu-sru/pull/17221:16
chillysurfercan anybody confirm this: cloud-init dhclient cannot work if /var/tmp is noexec, is that right? https://github.com/canonical/cloud-init/blob/master/cloudinit/net/dhcp.py#L160-L164 seems to validate that21:17
chillysurferthe "needs exe" dir is /var/tmp: https://github.com/canonical/cloud-init/blob/00dbc1447bbf8ecf611653a1af50af958ac5aeb4/cloudinit/temp_utils.py#L1121:18
rharperchillysurfer: yes.. that sounds right;  cloud-init copies a dhclient there to run it in a way that won't leave artifacts on the rootfs that we might not be able to easily remove (dhclient script hooks) etc.21:25
chillysurferrharper: thanks for the confirmation!21:29
rharperchillysurfer: you may be interested in this recent (Aug 2020) commit to this region of code; db86753f81af73826158c9522f2521f210300e2b21:31
rharperwhich addresses this: https://bugzilla.redhat.com/show_bug.cgi?id=185730921:32
ubot5bugzilla.redhat.com bug 1857309 in cloud-init "[Azure][RHEL 8] cloud-init Permission denied with the use of mount option noexec" [High,Verified]21:32
rharperthough, I would say, that does leave the potential for artifacts around on the system since it runs the original dhclient path21:32
chillysurferrharper: what is the point of copying dhclient and then running the copied version?21:34
rharperchillysurfer: as I said, to prevent leaving artifacts on the system due to running dhclient;  it execs scripts in the OS which may do things like write nameservers and *anything* that you want via hooks;21:44
rharperthis dhclient runs very early to bring up networking to query IMDS;  the IMDS result may send a network config which doesn't even specify DHCP etc ...21:45
rharperideally cloud-init would use a python-based dhcp client so we don't have to use anything from the OS or leave anything around; but it's not something that's been implemented yet;21:46
chillysurferrharper: makes sense thanks!21:48
meenaskipping modules 'ssh-import-id' because they are not verified on distro 'freebsd'22:34
Odd_BlokeAnd my last one for the day (and week): https://github.com/cloud-init/ubuntu-sru/pull/17322:35
Odd_Blokefalcojr: Thanks for all those reviews!22:36
blackboxswhave a good one Odd_Bloke22:43
falcojrHappy weekend!23:16

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!