[07:02] <mborzecki> morning
[07:02] <mborzecki> zyga: hey
[07:02] <zyga> hey :)
[07:02] <zyga> https://listed.zygoon.pl/20686/raspberry-pi-4b-and-4k-display-at-60hz battle from last evening
[07:17] <mborzecki> zyga: btw. this is interesting: https://gist.github.com/dmp1ce/8a321608fbcf4c3ea61fce134e1f0b0d there's apparmor enabled, but /proc/self/attr/apparmor/current does not exist
[07:17] <zyga> mborzecki how about /proc/self/attr/current
[07:17] <zyga> the apparmor sub-directory is relatively recent addition
[07:18] <mborzecki> the user has that, maybe it's the lts kernel they are booting, suggested using the non lts one to see
[07:18] <mborzecki> fwiw, this code is supposed to guess the right location: https://gitlab.com/apparmor/apparmor/-/blob/master/libraries/libapparmor/src/kernel.c#L235
[07:19] <mborzecki> zyga: it eventually gets called from aa_getcon()
[07:19] <zyga> right
[07:20] <zyga> what arch? do you have uname?
[07:20] <zyga> maybe wonky kernel from some cloud
[07:20] <zyga> or arm gizmo kernel
[07:20] <mborzecki> zyga: they said it's an lts server, so probably 5.4.82-1
[07:21] <mborzecki> hm maybe i should ask them to build and run a snippet like this: https://gist.github.com/dmp1ce/8a321608fbcf4c3ea61fce134e1f0b0d
[07:21] <zyga> hmm
[07:26]  * zyga changes hosts
[07:38] <mup> PR snapcraft#3391 opened: plugins v2: port the qmake plugin <Created by jhenstridge> <https://github.com/snapcore/snapcraft/pull/3391>
[07:44] <zyga> mborzecki, pi4 desktop is quite nice
[07:44] <zyga> such a long way from "it barely works" to "4K 60Hz"
[08:03] <pstolowski> morning
[08:03] <zyga> good morning pawel
[08:03] <zyga> I managed to sort out my alt-desktop for now :)
[08:22] <zyga> hello mvo
[08:22] <mvo> good morning zyga! how are you doing?
[08:22] <zyga> hey :-)
[08:22] <zyga> I'm working on a pi desktop today
[08:23] <zyga> feeling good, trying to build a pipeline for debian packaging now
[08:26] <pstolowski> hey mvo, zyga!
[08:30] <mvo> zyga: nice!
[08:30] <mvo> pstolowski: good morning
[08:36] <mborzecki> pstolowski: mvo: hey
[08:37] <mborzecki> mvo: we should land it when the spread jobs finishes: https://github.com/snapcore/snapd/pull/9785
[08:37] <mup> PR #9785: tests/main/fake-netplan-apply: disable test on xenial for now <Simple 😃> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9785>
[08:51] <mvo> mborzecki: ineed
[08:52] <mvo> mborzecki: we need this for 2.48 too, right?
[08:53] <mvo> a review for 9758 would be really good
[08:57] <mborzecki> mvo: yes, i think so, unless we can get #9784 (or both?)
[08:57] <mup> PR #9784: interfaces/builtin/network-setup-{control,observe}: allow using netplan directly <Needs security review> <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9784>
[08:59] <pedronis> I don't understand the last change in #9784 fwiw
[08:59] <mup> PR #9784: interfaces/builtin/network-setup-{control,observe}: allow using netplan directly <Needs security review> <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9784>
[08:59] <pedronis> also it really needs security reviews
[09:05] <mup> PR snapd#9785 closed: tests/main/fake-netplan-apply: disable test on xenial for now <Simple 😃> <Squash-merge> <⚠ Critical> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9785>
[09:10] <mup> PR snapd#9786 opened: tests: backport netplan workarounds from #9785 (2.48) <Run nested> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9786>
[09:31] <pedronis> mvo: I re-reviewed 9783, it's now failing on classic/hotplug :/
[09:35] <pstolowski> Sergio mentioned it, i'll take a look at this test
[09:37] <mvo> pedronis: thanks for this!
[09:56] <mborzecki> mvo: we need this now? https://github.com/snapcore/snapd/pull/9783
[09:56] <mup> PR #9783: gadget: use "sealed-keys" to determine what method to use for reseal <Run nested> <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9783>
[09:58] <mvo> mborzecki: yeah, this pr will unblock master
[10:03] <pedronis> mborzecki: I reviewed 9781, it conflicts with some of my incoming PRs but not too badly fwiw
[10:04] <pedronis> yes, we should really try to land 9783 as quickly as possible, it also unblocks my PRs
[10:07] <pedronis> mvo: in theory we could just force land it, and then have a follow with the small changes suggested by Ian and me?
[10:08] <pedronis> mvo: is it blocked by something else?
[10:08] <mvo> pedronis: that sounds good, no
[10:08] <mvo> pedronis: not blocked
[10:08] <mvo> pedronis: I can squash merge it now
[10:09] <mborzecki> pedronis: thanks, we can land it before of after, wahtever is easier to do
[10:09] <mborzecki> whichever
[10:13] <pedronis> mborzecki: I tried after
[10:13] <pedronis> fwiw
[10:13] <mvo> pedronis: merged and cherry-picked, I will do the tweaks in a small followup
[10:13] <pedronis> mvo: thanks
[10:13] <pedronis> I will merge master in my gadget PR
[10:14] <mvo> +1
[10:14] <pedronis> I have follow ups but that one needs to land first
[10:15] <mup> PR snapd#9783 closed: gadget: use "sealed-keys" to determine what method to use for reseal <Run nested> <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9783>
[10:20] <mborzecki> yay
[10:22] <mborzecki> pedronis: so let's merge #9775, then #9781
[10:22] <mup> PR #9775: gadget,o/devicestate,tests: drop EffectiveFilesystemLabel and instead set the implicit labels when loading the yaml <Cleanup :broom:> <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9775>
[10:22] <mup> PR #9781: gadget/quantity: introduce Offset, start using it for offset related fields in the gadget <Run nested> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9781>
[10:22] <mborzecki> in the meantime i'll look at updating #9771
[10:22] <mup> PR #9771: boot: boot config update & reseal <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9771>
[10:25] <mvo> mborzecki: should I do this?
[10:28] <mvo> mborzecki: I will force-merge 9781
[10:30] <mup> PR snapd#9781 closed: gadget/quantity: introduce Offset, start using it for offset related fields in the gadget <Run nested> <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9781>
[10:40] <pedronis> mvo: that's not the order mborzecki suggested though
[10:40] <mup> PR snapd#9758 closed: secboot: add new LockSealedKeys() that uses either TPM/fde-reveal-key <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9758>
[10:40] <mup> PR snapd#9787 opened: boot: tweak resealing with fde-setup hooks <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9787>
[10:41] <pedronis> mvo: now 9775 has conflicts :/
[10:41] <pedronis> so it will need a new test run
[10:42] <pedronis> :/
[10:44] <mvo> pedronis: oh no! I'm sorry!
[10:45] <mvo> sorry, should not have interefreed
[11:00] <mborzecki> pedronis: i can help you and fix conflicts in 9775
[11:00] <pedronis> mborzecki: I'm fixing them but we need anyway to wait the current test run
[11:00] <mborzecki> right
[11:01] <pedronis> if we hope to avoid two nested runs
[11:01] <paul424> heh is it fair to duplicate the questions from #snapcraft here ?
[11:01] <paul424> and don't get banned ?
[11:06] <pstolowski> paul424: you won't get banned, but forum.snapcraft.io is the best place for questions with most visibility and chances for answers
[11:07] <paul424> Heh witam jakie miasto ? :D
[11:08] <paul424> mogę dobrze napisać po polsku w czym rzecz :D
[11:08] <paul424> oki no more polish
[11:09] <pstolowski> paul424: sorry, please use our forums
[11:35] <pstolowski> the nested hotplug test failure seems to be caused by a change in qemu, the usb serial port doesn't show up on the bus
[11:48] <ogra> oSoMoN, do we not update the chromium snap installer version alongside a new stable release ? (chromium-browser is at 85...)
[11:49] <ogra> if we dont, we should probably not try to match the chromium version string in the deb package
[11:49] <ogra> (there is a user asking about it in #ubuntu)
[11:49] <oSoMoN> ogra, we don't, unless there are other changes to the packaging
[11:50] <oSoMoN> I agree it's misleading, but it's also harmless
[11:50] <ogra> right ... so it should probably just use a native debian version instead of suggesting to the users they get an old version
[11:50] <oSoMoN> because the user will always get the latest stable update through the snap
[11:50] <ogra> indeed
[11:51] <oSoMoN> ogra, do you have a suggestion for a version number that would not be misleading?
[11:52] <ogra> 1
[11:52] <ogra> 🙂
[11:52] <ogra> or 1-ubuntu1 if you want
[11:53] <ogra> just not the chromium version string
[11:58] <ackk> ogra, that's pretty much what we did for the maas package in focal, which installs/transitions to the snap
[11:58] <ogra> yeah
[11:58] <ackk> (plus epoch)
[12:12] <oSoMoN> we already have an epoch, so it would need to be bumped to ensure a greater version number than the current 1:85.0.4183.83-0ubuntu2
[12:12] <ogra> "2:1-0ubuntu1"
[12:13] <oSoMoN> yeah, something like that I guess
[12:17] <oSoMoN> ackk, so for maas, you changed the version number to 0.x and added an epoch in focal, and removed the package altogether in groovy onwards?
[12:31] <ackk> oSoMoN, correct
[12:47]  * cachio afk
[13:09] <mborzecki> mvo: https://github.com/snapcore/snapd/pull/9786/ mostly passed, there's a failure in tests/core20/basic but unrelated to the PR
[13:09] <mup> PR #9786: tests: backport netplan workarounds from #9785 (2.48) <Run nested> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9786>
[13:10] <mborzecki> the failure is intersting though, become-operational does not complete
[13:16] <mup> PR snapd#9775 closed: gadget,o/devicestate,tests: drop EffectiveFilesystemLabel and instead set the implicit labels when loading the yaml <Cleanup :broom:> <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9775>
[13:17] <pedronis> mborzecki: I'm getting internal errors from shellcheck :/
[13:17] <mborzecki> pedronis: got log? which test?
[13:17] <mborzecki> pedronis: or do you mean actual shellcheck is failing?
[13:18] <pedronis> I'm getting this
[13:18] <pedronis> running unit tests in wrappers
[13:19] <pedronis> mborzecki: https://paste.ubuntu.com/p/QXBgGQxf6j/
[13:21] <pedronis> mborzecki: it's https://github.com/snapcore/snapd/pull/9779 perhaps ?
[13:21] <mup> PR #9779: testutil: make DBusTest use a custom bus configuration file <Created by jhenstridge> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9779>
[13:22] <pedronis> I got it only now after merging master
[13:23] <pedronis> ah, mess
[13:23] <mborzecki> hmm
[13:23] <pedronis> I have shellcheck installed as a snap
[13:24] <pedronis> but now we can't run snaps from inside our tests I suppose
[13:24] <pedronis> it's snap run trying to talk to systemd and failing
[13:25] <mborzecki> heh, as in real system apparently
[13:26] <mborzecki> so why dont i see it too?
[13:26] <pedronis> do you have shellcheck as a snap?
[13:27] <pedronis> I'm not even sure why that code gets involved
[13:27] <mborzecki> hm i have, maybe it isn't used
[13:28] <mborzecki> pedronis: dbustest.go sets DBUS_SESSION_BUS_ADDRESS
[13:29] <mborzecki> in env
[13:29] <mborzecki> that's probably why snap run connects to the session bus (although is the one for tests) and attempts to chat with systemd user session manager
[13:32] <pedronis> so, yes, if I got back before that was merged things don't explode
[13:32] <pedronis> for me
[13:35] <pedronis> bit of a mess
[13:37] <mborzecki> pedronis: https://paste.ubuntu.com/p/33RHztGMJd/ ?
[13:38] <mborzecki> i can propose taht
[13:38] <pedronis> I suppose, but there should be something easier
[13:38] <pedronis> no, let me try something else
[13:38] <pedronis> first
[13:38] <mborzecki> with the diff the tests work for me if they involve shellcheck from a snap
[13:39] <mborzecki> (actually had to remove the shellcheck package, somehow it was picked first in the go workspace i have)
[13:39] <pedronis> mborzecki: I have a shorter change
[13:40] <mborzecki> oh, nice, can you propose it?
[13:40] <pedronis> yes
[13:43] <pedronis> mborzecki: https://github.com/snapcore/snapd/pull/9788
[13:43] <mup> PR #9788: testutil: use the original environment when calling shellcheck <Created by pedronis> <https://github.com/snapcore/snapd/pull/9788>
[13:46] <mup> PR snapd#9788 opened: testutil: use the original environment when calling shellcheck <Created by pedronis> <https://github.com/snapcore/snapd/pull/9788>
[13:46] <mup> PR snapd#9789 opened: many: separate consistency/content validation into gadget.Validate|Content <Cleanup :broom:> <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9789>
[13:51] <mup> PR snapd#9790 opened: gadget: move BuildPartitionList to install and make it unexported <Cleanup :broom:> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9790>
[13:54] <mborzecki> pedronis: thanks, lgtm and works locally here too
[14:44] <ijohnson> pedronis: mvo: the cloud-init pr is ready to merge, I reviewed all the spread failures they are all unrelated or already fixed in master, see https://github.com/snapcore/snapd/pull/9770#issuecomment-743231366
[14:44] <mup> PR #9770: sysconfig/cloudinit.go: add "manual_cache_clean: true" to cloud-init restrict file <Bug> <Run nested> <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9770>
[14:45] <zyga> after a day of work on aarch64 desktop the only thing that I find annoying is ports.ubuntu.com vs archive.ubuntu.com, it's surprisingly smooth otherwise
[14:59] <ijohnson> hey zyga
[14:59] <zyga> hey :)
[14:59] <ijohnson> I noticed you mentioned in your blog post the whole switching between bootloaders on your rpi
[14:59] <ijohnson> did you try dave's new tool for doing just that ?
[14:59] <zyga> ijohnson, no
[14:59] <ijohnson> I think it's like pibootctl or something
[14:59] <zyga> I just dsit-upgraded, I wasn't aware
[14:59] <zyga> ah
[14:59] <zyga> I know about pibootctl
[15:00] <zyga> I think here the problem was that 20.04 desktop and 20.10 desktop have totally different boot setup
[15:00] <ijohnson> it's pretty snazzy I used it for my pi that I upgraded from focal to groovy and eliminated uboot that way
[15:00] <zyga> and regular package updates just don't handle the transition
[15:00] <ijohnson> zyga: see https://waldorf.waveform.org.uk/2020/introducing-pibootctl.html
[15:00] <zyga> right, he shared that with me
[15:00] <ijohnson> you can even backup/restore changes to config.txt and such
[15:00] <zyga> my point was for simple guide, to avoid debugging, just reinstall
[15:01] <ijohnson> anyways I thought it was a cool tool that worked really well when I used it
[15:01] <ijohnson> but yes agreed reinstall is much simpler
[15:01] <zyga> if you copy the right dbts and config yeah, it will wrok
[15:01] <zyga> *work
[15:01] <zyga> are you using your groovy pi?
[15:01] <ijohnson> yeah
[15:01] <ijohnson> well I use it headlessly
[15:02] <mup> PR snapd#9791 opened: devicestate: implement checkFDEFeatures() <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9791>
[15:03] <ijohnson> I don't use desktop just server
[15:03] <zyga> ijohnson, I was mainly after a working desktop with 60Hz in 4K
[15:03] <zyga> now it works but I had my doubts along the way :)
[15:04] <mvo> ijohnson: merged and cherry-picked
[15:04] <ijohnson> thanks
[15:07] <mup> PR snapd#9770 closed: sysconfig/cloudinit.go: add "manual_cache_clean: true" to cloud-init restrict file <Bug> <Run nested> <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9770>
[15:25] <mborzecki> need to wrap it up, enjoy your holidays
[15:49] <mvo> reviews for 9769 and 9791 would be amazing, it's the last fde-hook bits
[15:52]  * cachio lunch
[15:58] <pstolowski> ok, i think i know what's wrong with hotplug tests... it's shockingly simple
[15:58] <pstolowski> and embarassing
[16:04] <zyga> pstolowski, what is ti?
[16:05] <pstolowski> zyga: apt install -y "linux-modules-extra-$(uname -r)"' || true
[16:05] <zyga> || true :D
[16:06] <zyga> lol
[16:06] <pstolowski> it seems to be linux-modules-extra-...-generic now
[16:06] <zyga> kernel vs headers mismatch?
[16:06] <zyga> ohhh
[16:06] <zyga> man
[16:06] <zyga> nice :)
[16:06] <pstolowski> and a multitude of other variants
[16:06] <zyga> I'll gladly review that :)
[16:06] <pstolowski> the above is still fine on old releases
[16:07] <pstolowski> needs to support both i think, testing now... nested is terribly sloooow
[16:24] <ijohnson> wow look at that a green pr
[16:24] <ijohnson> a thing of beauty that is
[16:24] <ijohnson> nice work pstolowski !
[16:27] <mup> PR snapd#9788 closed: testutil: use the original environment when calling shellcheck <Created by pedronis> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9788>
[16:46] <pstolowski> hmm there is more to it but i'm confused
[16:49] <pstolowski> apart from package name change, it doesn't provide ftdi_sio and usbserial  modules for 5.8.0-31-generic kernel; in fact no other package has them
[16:49] <pstolowski> that's 20.10
[16:50] <zyga> pstolowski, I see this on my pi
[16:50] <zyga> linux-modules-5.8.0-1006-raspi: /lib/modules/5.8.0-1006-raspi/kernel/drivers/usb/serial/usbserial.ko
[16:51] <pstolowski> zyga: i'm talking about -31- specifically. it see it for older versions too
[16:53] <pstolowski> zyga: i mean this: https://pastebin.ubuntu.com/p/WnmkdMmZ7y/
[16:54] <zyga> yeah, that's weird for sure
[16:54] <zyga> no idea
[16:58] <pstolowski> hmm no fix for nested today i guess :/
[17:06] <pstolowski> cachio: ping
[17:20] <pstolowski> cachio: the reason nested/classic/hostplug is failing is we are missing ftdi_sio and usbserial modules; we try to install modules-extra in the test (and ignore errors if it's missing), but this package was renamed with -31- kernel. but oddly, these modules are no longer provided by any package for that kernel. i'm stopping investigating this for today; if you have some time or any ideas then feel free to look at it; if not then
[17:20] <pstolowski>  i'll continue on Monday. in any case, happy holidays!
[17:20]  * pstolowski eow
[18:23] <mup> PR snapd#9792 opened: tests: enable ubuntu 21.04 for spread tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9792>
[22:29] <mup> PR snapd#9737 closed: tests: use os.query tool instead of comparing the system var <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9737>
[22:29] <mup> PR snapd#9793 opened: tests: add os query commands for subsystems and architectures <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9793>