=== jamesh__ is now known as jamesh
mupIssue core20#98 closed: add btrfs-progs to core, please? <Created by montvid> <Closed by montvid> <https://github.com/snapcore/core20/issues/98>01:54
mupPR snapd#9774 closed: o/snapshotstate: don't set auto flag in the snapshot file <Needs Samuele review> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9774>06:13
zygapstolowski, hey, good morning08:08
zygamvo, good morning :)08:40
mvozyga: good morning to you too!08:40
pstolowskihey mvo08:47
mvohey pstolowski ! good morning08:49
mvopstolowski: 9429 looks good, if it needs a force-merge just let me know (looks like tests are still running though)08:53
mvopstolowski: thanks for updating the tests :)08:53
pstolowskimvo: sure, thanks for suggestions08:54
pstolowskiso classic/hotplug issue was apparently an issue with the image that got fixed10:29
mvopstolowski: that is good to know11:10
pstolowskii'm preparing a pr that will improve diagnosing such issue11:13
mvopedronis: fun! trying to workaround issue #13 first killed dbus and now crashed my session. "assertion 's' failed on src/core/service.c:3223 in systemd. we are having fun here11:19
mupPR #13: Bugfix/review tools reenable <Created by mvo5> <Merged by elopio> <https://github.com/snapcore/snapd/pull/13>11:19
pedronismvo: I reviewed #979111:38
mupPR #9791: devicestate: implement checkFDEFeatures() <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9791>11:38
mvopedronis: thank you11:40
pstolowskihmm gdrive/google acting up11:51
pstolowskihmm and www.googleapis.com/compute11:56
ograyeah, seems all og google services11:57
pstolowskithanks for confirmation12:01
degvillegoogle is having problems: https://news.ycombinator.com/item?id=2541598912:02
ograat least their search still works (probably fell back to the bing backend)12:03
mupPR snapd#8620 closed: spdx: add GPL-3.0-or-later license <⛔ Blocked> <Created by prabhu> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8620>12:10
pedronis#9778 needs 2nd reviews12:12
mupPR #9778: asserts/repair.go: add "bases" and "modes" support to the repair assertion <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9778>12:12
pedronispstolowski: what should we do with https://github.com/snapcore/snapd/pull/8532 ?12:15
mupPR #8532: tests: install new snapd deb into preseed image <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8532>12:15
pstolowskipedronis: i need to think. i'm slightly inclined to close it12:16
pedronisthat's fine if you think we don't need it or doesn't help enough12:18
ijohnsonnot a great start to the day, my internet speed is at like kilobits and on top of this google is down12:29
* ijohnson considers going back to bed and trying again later 12:29
cmatsuokaijohnson: we'll have a solar eclipse here in a few hours. it's the end of the world12:30
ijohnsoncmatsuoka: haha nice12:31
pstolowskiijohnson: hey ijohnson . yep, i also saw 500s on github12:38
ijohnsonhey pstolowski12:38
ijohnsonyeah feels like a "week before holiday break" kind of week :-P12:39
zygathe end of 2020 is when google deletes all gmail databases12:41
pedronisijohnson: thanks for reviewing #9790, it needs a 2nd review now12:42
mupPR #9790: gadget: move BuildPartitionList to install and make it unexported <Cleanup :broom:> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9790>12:42
pedronisijohnson: #9789 could also use a review12:42
mupPR #9789: many: separate consistency/content validation into gadget.Validate|Content <Cleanup :broom:> <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9789>12:42
ijohnsonpedronis: yes it's in my queue for today12:42
mupPR snapd#9793 closed: tests: add os query commands for subsystems and architectures <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9793>12:45
mupPR snapd#9794 opened: daemon: start moving implementation to api_snaps.go <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9794>12:45
slvn_hello, I've developed a few small games and published them as snap packages, 4yrs ago.12:53
slvn_now, I am updating them and it needs manual review. Should I just wait or ask for review ?12:53
slvn_Also, it relies on SDL2 libs, and it isn't fully fonctionnal: since, it can't access libGL with dlopen, there is no hardware rendering,12:59
slvn_and fallback to software rendering which is slower and looks bad for some points.12:59
slvn_This was the case before, not sure how it's has improved now ?12:59
pedronisslvn_: what kind of errors are triggering the manual review? depending on that you might need to change some things or to ask for extra permissions through the process https://forum.snapcraft.io/t/process-for-aliases-auto-connections-and-tracks/455 , in case of doubt the expedient things would be to explain the issues within a forum post13:15
slvn_pedronis, re-doing the snap-review in console, it says:13:23
slvn_ - declaration-snap-v2:plugs_installation:1bsyl:unity813:23
slvn_human review required due to 'allow-installation' constraint (bool)13:23
slvn_ok, not sure why I have this plug set. I struggle a little bit to recompile the snap13:23
pedronisit's a legacy plug at this point, a snap shouldn't need it13:24
mupPR snapd#9795 opened: tests: improve hotplug test setup on classic <Run nested> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9795>13:25
slvn_I'll remove it and retry then. I think because the former version was published with unity7 plug13:26
slvn_anyone now if there is a work-around for SDL2 using libGL within snap ?13:26
slvn_I found this: https://forum.snapcraft.io/t/how-best-to-link-to-sdl2/5721/313:27
slvn_I don't understand the last message: "At my end, this works properly with the LD_LIBRARY_PATH set by desktop-launch script from snapcraft-desktop-helpers"13:28
slvn_pedronis, I removed the unity8 plug and the snap-review passed13:54
slvn_it makes me rememeber that maybe unity7 plug one was added because sdl2 access mir on ubuntu 16.13:55
slvn_so I am not even sure that the snap would still work on ubuntu 16, any idea how i could test this ?13:56
pstolowskipedronis, mvo : i'm  going to address this comment in the existing snapshots PR: "instead of failing we also have the option to change import to return the old ...". anything else missing for the existing PR to land? The "// XXX: deal with import in progress..." would be a followup14:36
mvopstolowski: deal with import in progress should be a followup yes, no opinion on the other one14:39
mvoijohnson: 9787 is ready for a re-review14:48
ijohnsonoooh github has a dark mode now14:50
ijohnsonmvo: +114:51
mvothank you!14:54
mvoalso 9769 needs reviews :)14:54
ijohnsonadded that one to my queue as well :-)15:10
mvoijohnson: thank you!15:15
mvopedronis: I replied to 9791, not 100% sure I got what you had in mind15:16
pedronismvo: I maybe confused but I looked again and errors from there seems to be eaten and just turn into false, nil one level up?15:19
mvopedronis: oh, sorry, let me double check15:20
mvopedronis: I think you are right, the code is confusing15:20
pedronismaybe we should log one level up?15:21
mvopedronis: yeah, I think we also not log seccomp errors there :/15:21
mvopedronis: so let me add logging and a test15:22
ijohnsonpstolowski: is there any reason in theory we couldn't do `snap debug state --timings file.json` like `snap debug timings` but for local offline state.json ? does debug timings rely on snapd being active ?15:36
mvopedronis: what is your sense, should we log the tpm/fde errors as debug or notice? right now I have debug15:38
pedronismvo: this is for install right?  I would say notice15:39
mvopedronis: yes, install15:39
mvopedronis: sounds good to me, thank you!15:39
pstolowskiijohnson: there is not reason, can be done. it's just historical, timings were implemented long before the idea for offline debug15:41
pstolowski*no reason15:41
ijohnsonyeah it would be useful to do offline debugging for this very slow system we are debugging right now15:41
ijohnsonmaybe I'll have a quick stab at it if I get bored15:41
pstolowskiijohnson: the only slightly annoying detail is that the api side of debug takes care of combining timings with task doing/undoing, nothing complex about that, but it's slightly more convoluted than just printing timings15:47
ijohnsonhmm I see, perhaps we could push that code into the client for `snap debug state ...` specifically15:47
ijohnsonor share that code15:47
pstolowskiyes sharing would be nice, otherwise a lot needs to be duplicated15:48
pstolowskiand yes, offline timings would be nice imho15:48
mupPR snapd#9787 closed: boot: tweak resealing with fde-setup hooks <Skip spread> <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9787>15:51
mupPR core20#99 opened: hooks: update xdg-settings to support subcommands <Created by seb128> <https://github.com/snapcore/core20/pull/99>16:30
mupPR core18#175 opened: hooks: update xdg-settings to support subcommands <Created by seb128> <https://github.com/snapcore/core18/pull/175>16:39
slvn_... some follow-up, I fix my issue: passed review, access to libGL and audio, and now I am trying my updated snap to an old ubuntu 16 machine17:05
slvn_and I got this failing message when installing:17:06
mupPR snapd#9791 closed: devicestate: implement checkFDEFeatures() <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9791>17:06
slvn_snap assumes unsupported features: command-chain (try new ubuntu-core)17:06
slvn_it works on ubuntu 20, but no 1617:07
ijohnsonslvn_: what is `snap version` ?17:07
slvn_ijohnson, what do  you mean ?17:07
ijohnsonslvn_: on the system that you try to install the snap on, can you run the command `snap version` ?17:07
slvn_unknow command on ubuntu 1617:07
slvn_:) so quite old17:08
slvn_snap --version:17:08
ijohnsonwow, yeah that's positively ancient17:08
ijohnsonyou will need to do `snap install core` I think17:08
slvn_ijohnson, done, but the version of snap hasn't changed17:10
slvn_and still not working17:10
ijohnsonslvn_: what is `snap list` ?17:11
slvn_ubuntu-core 16-217:11
slvn_and core 16-217:11
slvn_core 16-2.4817:11
ijohnsoncan you try `sudo apt update && sudo apt install snapd`17:11
pedronismvo: did you forget to push to #9791 ?17:11
mupPR #9791: devicestate: implement checkFDEFeatures() <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9791>17:11
ijohnsonpedronis: yeah I didn't see the code that was mentioned either17:12
slvn_ijohnson, snapd is already the newest version 2.1617:13
ijohnsonslvn_: but that's not the newest snapd ... package, what is `cat /etc/os-release` ?17:13
slvn_ubuntu 16.1017:13
slvn_I'm try on an old ubuntu my updated snap17:14
ijohnsonyou are using an eol distro and so there are no more updates17:14
mvopedronis: silly me, I push an updated PR17:14
pedronisit's ok but bit confusing :)17:14
ijohnsonslvn_: you should really upgrade to 18.04 or an ubuntu series that is still supported, 16.10 is no longer supported at all17:14
slvn_sorry, I am away17:14
slvn_ijohnson, I try a regression to test my snap on an older VM17:14
mvopedronis: pushed 979617:17
mupPR snapd#9796 opened: devicestate: log checkEncryption errors via logger.Noticef <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9796>17:21
pedronismvo: commented17:27
ijohnsonpedronis: reviewed #9789, seems we lost a couple tests ?17:28
mupPR #9789: many: separate consistency/content validation into gadget.Validate|Content <Cleanup :broom:> <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9789>17:28
pedronisijohnson: yes, a couple of tests were removed as they don't apply anymore17:29
ijohnsonso we don't validate the bootloader setting in the gadget.yaml ?17:30
ijohnsonthat doesn't seem like an expected chagne17:30
pedronisijohnson: we do17:30
pedronisthere's more tests17:30
ijohnsonwhere ?17:30
pedronisyou need to consider the tests that are there17:30
pedronisare you looking at the tests or just the diff?17:30
ijohnsonI searched the full file where you deleted that test from and couldn't find one which checks for an invalid bootloader setting in the gadget.yaml17:31
ijohnsonare you saying the existing test is in a different file?17:31
pedronisijohnson: notice that per comment &gadget.ValidationConstraints{} and nil are not equivalent17:31
pedronisijohnson: gadget_test has tests about that17:32
pedronisijohnson: Validate doesn't redo the job of InfoFromGadgetYaml given that now it takes a parsed gadget.Info17:33
ijohnsonpedronis: I responded in the pr with a new comment17:39
ijohnsonI see the tests now17:39
pedronisijohnson: I tried to answer17:44
ijohnsonpedronis: I responded with another suggestion, my concern is really that the behavior to a casual reader/reviewer is non-standard and thus subject to bugs where folks don't fully comprehend the change they are making17:50
ijohnsonpedronis: mvo: are there any other pr's that I should review in my afternoon, I think I have reviewed them all except #9780 which I think can wait a bit if not until after the break at least tomorrow/wednesday17:51
mupPR #9780: many: use ResolvedSource() from gadget content when writing boot assets <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9780>17:51
mvoijohnson: I will push something shortly to workaround the systemd-run issue in initrd17:54
mvoijohnson: it will be a bit ugly17:54
ijohnsonmmm ok17:55
pedronisijohnson: not from me, my follow up in gadget probably is better submitted after we have landed the rest18:00
=== ijohnson is now known as ijohnson|lunch
mvopedronis, ijohnson|lunch I pushed 9797 as a draft but I really hope to land 9769 soon so that the diff is nicer to read18:05
ijohnson|lunchsounds good to me18:05
mupPR snapd#9797 opened: secboot: add workaround for snapcore/core-initrd issue #13 <Created by mvo5> <https://github.com/snapcore/snapd/pull/9797>18:06
mupPR snapd#9769 closed: tests: add nested spread end-to-end test for fde-hooks <Run nested> <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9769>18:16
mvopedronis, ijohnson|lunch 9797 is updated, I will look at 9796 after dinner18:21
=== ijohnson|lunch is now known as ijohnson
mvoijohnson: I call it a day now, feel free to apply tweaks/fixes etc to 9797 as needed, it's the last PR for 2.48.2 we really need (same for 9796 but that is slightly less critical)20:11
ijohnsonmvo: ok, sounds good I am reviewing it now20:11
ijohnsonI will push any suggestions I ahve20:11
mvothank you!20:13
pedronisI asked some questions there, in 979720:14
ijohnsonpedronis: is it okay to address the things you mentioned  in a push to mvo's branch ?20:33
ijohnsonI responded to you points in 979720:33
pedronisijohnson: thanks, yes I think it's ok to try to push forward there20:35
ijohnsonpedronis: ack will push in a little bit20:35
pedronisijohnson: preopening the files seems the path forward, I see *Mode options for directories but not for those files20:38
pedronisat least pre-creating doesn't sound wrong20:39
pedronisalso because by default systemd doesn't truncate them according to docs20:39
ijohnsonpedronis: if you're still around I pushed a couple fixes to 979721:52
ijohnsonspent a bit of time writing an overly paranoid unit test which may have been overkill, but I don't think it hurts21:52
pedronisijohnson: thx, it's slightly late for me to do a poper review but I'll try to do it first thing in the morning21:56
ijohnsonsounds good21:56
ijohnsonhave a nice evening, ttyl21:56
pedronisthx, same to you21:57
mupPR snapd#9790 closed: gadget: move BuildPartitionList to install and make it unexported <Cleanup :broom:> <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9790>23:18
mupPR snapd#9798 opened: o/{device,snap}state: enable devmode snaps with dangerous model assertions <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9798>23:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!