[05:54] <mup> PR snapd#9429 closed: o/daemon: validation sets api and basic spread test <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9429>
[07:50] <zyga> good morning
[08:00] <pstolowski> morning
[09:03] <mup> PR snapcraft#3392 opened: plugins v2: add support for out of source tree builds <Created by jhenstridge> <https://github.com/snapcore/snapcraft/pull/3392>
[09:20] <mup> PR snapd#9796 closed: devicestate: log checkEncryption errors via logger.Noticef <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9796>
[09:35] <mup> PR snapd#9797 closed: secboot: add workaround for snapcore/core-initrd issue #13 <Run nested> <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9797>
[10:01] <pstolowski> pedronis: hey, i've updated #9513
[10:01] <mup> PR #9513: snapshotstate: detect duplicated snapshot imports <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9513>
[10:02] <pedronis> pstolowski: thx
[10:28] <zyga> hey guys
[10:36] <mup> PR snapd#9799 opened: secboot: add extra paranoia when waiting for that fde-reveal-key <Squash-merge> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9799>
[10:37] <pstolowski> pedronis: are you working on any changes to api_snapshots_test.go to make it use apiBaseSuite or can I do it? I noticed invalid endpoints there (/v2/snapshot/import) which of course do not affect the test but are confusing
[10:45] <pedronis> pstolowski: no, not working on it, you can change it if it makes sense. ATM my work in progress there is about api.go itself
[10:46] <pstolowski> ack
[11:51] <mup> PR snapd#9800 opened: tests: use apiBaseSuite for snapshots tests, fix import endpoint path <Created by stolowski> <https://github.com/snapcore/snapd/pull/9800>
[12:51] <pedronis> pstolowski: thanks for #9800, I made some remarks, let me know if they make sense or you we should chat more
[12:52] <mup> PR #9800: tests: use apiBaseSuite for snapshots tests, fix import endpoint path <Created by stolowski> <https://github.com/snapcore/snapd/pull/9800>
[12:54] <pstolowski> thanks, looking
[12:58] <pstolowski> pedronis: i think we actually have what you suggested there, daemonWithOverlordMock(c) in apiBase (I missed that), or I misunderstood?
[12:59] <pedronis> pstolowski: yes, but we do something about store, but the store shouldn't be involved here, so maybe the old code was also strange
[12:59] <pedronis> and just copied from somewhere else?
[13:00] <pstolowski> pedronis: ah i see
[13:14] <pstolowski> pedronis: i've renamed the old helper to s.daemonWithOverlordMockAndStore(c) (and with that updated a bunch of api tests to use that) and added a new one s.daemonWithOverlordMock(c) that is used now by snapshots tests, does this sound ok?
[13:15] <pstolowski> the new helper doesn't create store
[13:23] <pedronis> sounds reasonable
[13:31] <pstolowski> pedronis: pushed
[13:33] <mvo> hey pstolowski and pedronis - anything I should look at?
[13:35] <pedronis> mvo: I made some changes to https://github.com/snapcore/snapd/pull/9789 prompted by Ian, maybe you want to look, I'm not 100% happy with them
[13:35] <mup> PR #9789: many: separate consistency/content validation into gadget.Validate|Content <Cleanup :broom:> <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9789>
[13:38] <mvo> pedronis: ok
[13:38] <pedronis> mvo: it's the last commit there
[13:47] <pstolowski> mvo: hey, you can look at my changes to snapshots PR
[13:48] <mvo> pstolowski: sure thing
[13:53] <pedronis> pstolowski: I will also review those
[14:48] <pedronis> ijohnson: I did a pass on #9798, thanks for it
[14:48] <mup> PR #9798: o/{device,snap}state: enable devmode snaps with dangerous model assertions <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9798>
[14:48] <ijohnson> thanks
[14:51] <ijohnson> pedronis: I responded can you take a look?
[15:26] <mvo> pedronis: core20/basic test is failing in release/2.48 because it cannot get a serial from the store for our custom model, do you remember what PR/commit I should search for that needs cherry-picking to 2.48?
[15:26] <pedronis> mvo: one sec
[15:28] <pedronis> mvo: this one I think: https://github.com/snapcore/snapd/pull/9713
[15:28] <mup> PR #9713: tests: sign new nested-18|20* models to allow for generic serials <Run nested> <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9713>
[15:28] <mvo> pedronis: thank you!
[15:42] <pedronis> mvo: pstolowski: https://github.com/snapcore/snapd/pull/9513#discussion_r543455554
[15:42] <mup> PR #9513: snapshotstate: detect duplicated snapshot imports <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9513>
[15:48] <pstolowski> ty
[15:48] <pedronis> mvo: pstolowski: also "// XXX: Something needs to cleanup incomplete imports. This is conceptually" has been addressed, right?
[15:48] <pedronis> I see code in StartUp for that
[15:50] <mvo> pedronis: yes
[15:51] <pedronis> we should remove the XXX in one of the PRs
[15:51] <pstolowski> ok
[15:52] <mup> PR snapd#9786 closed: tests: backport netplan workarounds from #9785 (2.48) <Run nested> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9786>
[15:52] <mup> PR snapd#9801 opened: tests: sign new nested-18|20* models to allow for generic serials (2.48) <Created by mvo5> <https://github.com/snapcore/snapd/pull/9801>
[15:54] <pstolowski> pedronis: it sounds to me like the snapshot mgr local lock that you suggested should be a followup, this may touch a number of places?
[15:55] <pedronis> pstolowski: yea, I fear we'll have to split import into prepare and import (like some things are split already in snapshotmgr.go if you look)
[15:56] <pedronis> pstolowski: export might have the same problem?
[15:58] <pedronis> pstolowski: or maybe the fix is easy, because we don't worry too much about blocking expiration
[15:58] <pedronis> export and import are rare enough
[15:58] <pstolowski> pedronis: i'd expect export to fail (potentially in the middle of doing things) though?
[16:00] <pedronis> no, we care about blocking expiration too much because is done from Ensure
[16:00] <pedronis> :/
[16:15] <pedronis> pstolowski: mvo: now that I look at the code we have some issues for sure still pending
[16:20] <pstolowski> pedronis: should we discuss in a HO?
[16:23] <pedronis> pstolowski: I wrote a note in the PR, let me know if need to chat more
[16:23] <pedronis> it all be for after the break anyway at this point
[16:23] <pedronis> *it might all be
[16:25] <pedronis> pstolowski: https://github.com/snapcore/snapd/pull/9513#issuecomment-745401821
[16:25] <mup> PR #9513: snapshotstate: detect duplicated snapshot imports <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9513>
[16:27] <pstolowski> pedronis: yes and i don't think we should block this PR, it seems like a change on its own
[16:30] <mvo> pedronis: did you had a chance to look at 9799? if it makes it into 2.48.2 that would be nice but I think it's not essetnial. I want to release later tonight
[16:38] <pedronis> mvo: yes, but I forgot to comment on it, also maybe ijohnson should look at it
[16:39] <ijohnson> mvo: pedronis: sure I will look at it, but probably in my PM at this point, have a meeting and then lunch for me
[16:59] <mup> PR snapcraft#3393 opened: requirements: uprev python-apt <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3393>
[16:59] <mup> PR snapcraft#3394 opened: requirements: rely on host's python3-apt <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3394>
[17:58] <mup> PR snapcraft#3393 closed: requirements: uprev python-apt <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3393>
[17:59] <mup> PR snapcraft#3384 closed: Add core20 to various /Dockerfile/s <Created by martijnbastiaan> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3384>
[18:04] <mup> PR snapcraft#3374 closed: [wip] ci: migrate spread tests to github actions <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3374>
[18:14] <mup> PR snapcraft#3365 closed: github actions: bootstrap CI workflow <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3365>
[18:15] <mup> PR snapcraft#3367 closed: requirements: pin pip to 20.1.1 for devel <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3367>
[18:53] <mup> PR snapd#9799 closed: secboot: add extra paranoia when waiting for that fde-reveal-key <Squash-merge> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9799>
[18:55] <mup> PR snapcraft#3347 closed: Create an extra 'build' directory for plugins <Created by artivis> <Closed by artivis> <https://github.com/snapcore/snapcraft/pull/3347>
[19:00] <mup> PR snapcraft#3348 closed: ROS plugins use plugins' build directory <Created by artivis> <Closed by artivis> <https://github.com/snapcore/snapcraft/pull/3348>
[19:15] <mup> PR snapcraft#3381 closed: multipass build provider: check if instance exists before deleting <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3381>
[19:15] <mup> PR snapcraft#3389 closed: plugins v1: move build base test in v1 plugins to base class <Created by cmatsuoka> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3389>
[19:16] <mvo> hm, 9702 is the last pr tagged 2.48 but it has no security review
[19:16] <mvo> so tough luck I guess
[19:17] <ijohnson> mvo: that pr is not high priortiy so that's fine I think
[19:17] <ijohnson> it's more of a "nice to have some day"
[19:18] <mup> PR snapd#9801 closed: tests: sign new nested-18|20* models to allow for generic serials (2.48) <Run nested> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9801>
[19:40] <mup> PR snapcraft#3107 closed: fix yarn version url <maintenance> <Created by fkromer> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3107>
[19:55] <mup> PR snapcraft#3144 closed: docker: setup a multiarch build for snapcraft docker images <tooling> <Created by adferrand> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3144>
[20:00] <mup> PR snapcraft#3243 closed: Add skip-keys to catkin plugin <enhancement> <Created by Levi-Armstrong> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3243>
[20:00] <mup> PR snapcraft#3262 closed: specifications: configurable apt mirror <specification> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3262>
[20:04] <pedronis> ijohnson: do you need me to review something?
[20:05] <mup> PR snapcraft#3283 closed: specifications: unified provider <specification> <Created by cjp256> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3283>
[20:05] <mup> PR snapcraft#3300 closed: [wip] remote lxd / cross-arch support <Created by cjp256> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3300>
[20:07] <ijohnson> pedronis: not right now, I just pushed the tests for my devmode pr
[20:08] <ijohnson> but that can be reviewed tomorrow
[20:08] <ijohnson> oh I forgot the nested label
[20:10] <mup> PR snapcraft#3309 closed: Rough draft of changes needed to separate python versions between gno… <Created by hellsworth> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3309>
[20:25] <mup> PR snapcraft#3284 closed: build providers: rename clean() -> clean_parts() to clarify scope <enhancement> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3284>
[20:25] <mup> PR snapcraft#3291 closed: build providers: make mount_project() interface private <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3291>
[20:28] <mup> PR snapd#9802 opened: release: 2.48.2 <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9802>
[20:36] <pedronis> ijohnson: I made this self-comment in my open PR: https://github.com/snapcore/snapd/pull/9789#discussion_r543662855
[20:36] <mup> PR #9789: many: separate consistency/content validation into gadget.Validate|Content <Cleanup :broom:> <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9789>
[20:40]  * ijohnson looks
[20:41] <ijohnson> pedronis hmm I'll need to think on it, I'll try to review that pr again this afternoon
[20:42] <pedronis> ijohnson: it's the principle that if the argument carry too much behavior change maybe one needs more function variant, it can combersome but it's usually the right call
[20:43] <ijohnson> I see yeah that makes sense
[20:48] <mvo> ijohnson, pedronis I call it a day (and a year :) I talked to the taipei guys about 2.48.2, if there are any issues just ping me on telegram I will try to help.
[21:08] <ijohnson> pedronis: I like your newest proposal the best
[21:08] <pedronis> ijohnson: ok, I'm working on it
[21:08] <ijohnson> nice thanks for that
[21:15] <mup> PR snapcraft#3380 closed: snap packaging: fix broken path check when copying local icon <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3380>
[21:37] <pedronis> ijohnson: pushed
[21:38] <ijohnson> pedronis: ok, will take a look
[21:40] <pedronis> the diff should also be smaller as a consequence
[21:40] <mup> PR snapcraft#3356 closed: extensions: correctly spell the GTK_USE_PORTAL variable <Created by seb128> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3356>
[21:40] <mup> PR snapcraft#3362 closed: project loader grammar: do not transform build-packages <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3362>
[21:55] <mup> PR snapcraft#3387 closed: ci: migrate snap publishing to github actions <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3387>
[23:25] <cachio> ijohnson, hey
[23:25] <cachio> ijohnson, around?
[23:27] <cachio> ijohnson, netplan test failing like https://paste.ubuntu.com/p/yyVDwTcd5p/
[23:27] <cachio> during beta validation