| mup | PR snapcraft#3369 closed: sources: enable 7z, bzr, hg, svn, zip for non-linux <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3369> | 02:31 |
|---|---|---|
| mborzecki | morning | 06:37 |
| zyga | good morning | 07:34 |
| mborzecki | zyga: hey | 07:35 |
| mborzecki | quick errand, back in 30 | 08:03 |
| pstolowski | morning | 08:20 |
| mborzecki | re | 08:44 |
| pstolowski | hey | 08:50 |
| mborzecki | anyone looking at fixing tests broken by cgorup v2 on sid? | 09:27 |
| mborzecki | pstolowski: mvo: trvial comment fix https://github.com/snapcore/snapd/pull/9826 can you take a look? | 09:28 |
| mup | PR #9826: interfaces/apparmor: drive by comment fix <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9826> | 09:28 |
| pstolowski | sure | 09:28 |
| mup | PR snapd#9826 opened: interfaces/apparmor: drive by comment fix <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9826> | 09:29 |
| mborzecki | thanks! | 09:34 |
| mborzecki | heh, found some apparmor related deadcode too | 09:40 |
| mvo | mborzecki: sure thing, in a meeting right now but will do when this is finished | 09:44 |
| mborzecki | pstolowski: another trivial one: https://github.com/snapcore/snapd/pull/9827 | 09:50 |
| mup | PR #9827: interfaces/builtin: more drive by fixes, import ordering, removing dead code <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9827> | 09:50 |
| pstolowski | ackk: hi, https://bugs.launchpad.net/snapd/+bug/1901212 is yours right? | 09:50 |
| mup | Bug #1901212: snaps break after upgrade, snapd claims meta/snap.yaml is missing <snapd:Triaged> <https://launchpad.net/bugs/1901212> | 09:50 |
| ackk | pstolowski, yes | 09:51 |
| pstolowski | ackk: i guess it's safe to assume unclean/abrupt shutdowns or fs corruption can be ruled out right? | 09:52 |
| ackk | pstolowski, correct. I just found them broken at some point. I don't have any broken right now, though | 09:52 |
| pstolowski | ackk: may i ask you to send me your /var/lib/snapd/state.json next time you see this problem (you may want to remove your store macaroon from it before sending)? | 09:53 |
| ackk | pstolowski, sure, can you comment on the bug ? | 09:54 |
| mup | PR snapd#9827 opened: interfaces/builtin: more drive by fixes, import ordering, removing dead code <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9827> | 09:54 |
| pstolowski | ackk: thanks. done. | 09:56 |
| ackk | ps | 09:56 |
| ackk | pstolowski, ty | 09:56 |
| mup | PR snapd#9826 closed: interfaces/apparmor: drive by comment fix <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9826> | 10:59 |
| mup | PR snapd#9821 closed: tests: skip interfaces-openvswitch spread test on debian sid <Simple 😃> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9821> | 11:14 |
| mup | PR snapd#9824 closed: interfaces/greengrass-support: back-port interface changes to 2.48 <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9824> | 11:14 |
| mup | PR snapd#9827 closed: interfaces/builtin: more drive by fixes, import ordering, removing dead code <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9827> | 11:19 |
| mup | PR snapd#9828 opened: sandbox/cgroup, tess/main: fix unit tests on v2 system, disable broken tests on sid <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9828> | 11:19 |
| mborzecki | pedronis: hi, do you think you'll be able to take a look at https://github.com/snapcore/snapd/pull/9771 this week? | 11:59 |
| mup | PR #9771: boot: boot config update & reseal <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9771> | 11:59 |
| pedronis | mborzecki: yes, either today or tomorrow | 11:59 |
| mborzecki | pedronis: great, thank you | 11:59 |
| mborzecki | mvo: shall I push the change with gzip compression of the install log to #9545 ? | 13:10 |
| mup | PR #9545: devicestate: keep log from install-mode on installed system <Run nested> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9545> | 13:10 |
| mup | PR snapd#9829 opened: tests: cleanup the run-checks script <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9829> | 13:20 |
| mvo | mborzecki: yeah, please do | 13:33 |
| mvo | mborzecki: I can do to but busy with $stuff :/ | 13:33 |
| mborzecki | mvo: ok, spread test is running now, i'll push when it's done | 13:33 |
| mvo | mborzecki: \o/ | 13:34 |
| mborzecki | mvo: and pushed | 13:42 |
| mvo | nice | 13:43 |
| ogra | did anythig change WRT hook handling in UC20 ?`i end up with weird apparmor denials and a non-functioning hook | 14:27 |
| pstolowski | cachio: i tried to run 21.04 image with your PR (also tried with the specific image you found was ok) but spread was failing (on prepare i think) | 14:28 |
| ogra | https://paste.ubuntu.com/p/V2NHdz9tFd/ if anyone has an idea why the configure hook would nowadas hard-require CAP_NET_ADMIN without reason, please speak up :) | 14:31 |
| ogra | (and no i is neither date, not md5sum or tr that trigger the denial, the code was changed several times and still triggers the denial) | 14:33 |
| ijohnson | ogra: can you reproduce only on pi, or also on amd64 ? | 14:42 |
| ogra | i have not tried on amd64 yet | 14:44 |
| ogra | (that snap does not run on non-pi HW and i have not really used any x86 UC20 yet) | 14:47 |
| ogra | it smells like something else beyond the hook is executed by snapd or so ... | 14:47 |
| ijohnson | well the denial has snap-exec as the comm | 14:48 |
| ijohnson | so it's not your hook, it's something in snapd | 14:48 |
| ogra | right | 14:48 |
| ogra | the snap has the desktop plug definied (but indeed not connected on UC20) ... i wonder if it is related to the recent fontconfig hacks | 14:49 |
| * ogra moves the hook from confgure to install ... perhaps that helps | 15:02 | |
| ogra | ... doesnt ... moving it to a launch wrapper then ... that will work in any case | 15:18 |
| pstolowski | mvo: no sync today in case you were not following preseed channel | 15:34 |
| mvo | pstolowski: yeah, just got the mail, thank you! | 15:41 |
| mvo | pedronis: just fyi, I updated 9819 and moved the test to a different snap | 15:42 |
| mvo | pedronis: eh, moved the test to a different file :) | 15:42 |
| pedronis | thx | 15:42 |
| pedronis | I'm going back to reviewing now | 15:42 |
| ogra | ijohnson, so it seems snapctl also causes this denial (i have a wrapper calling "snapctl is-connected", disconnecting network-control for the app causes the same denial on app restart) | 15:53 |
| ijohnson | yeah not surprised that's what I would have expected | 15:53 |
| pedronis | pstolowski,mvo: #9513 needs a 2nd review from sombody that didn't look at/touch it yet | 16:28 |
| mup | PR #9513: snapshotstate: detect duplicated snapshot imports <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9513> | 16:28 |
| pstolowski | yes | 16:29 |
| pstolowski | maybe ijohnson ? | 16:32 |
| ijohnson | sure I'll have a look | 16:35 |
| pstolowski | thanks! | 16:37 |
| pedronis | pstolowski: I asked some questions in #9820 | 16:50 |
| mup | PR #9820: o/snapshotstate: handle conflicts between snapshot forget, export and import <Created by stolowski> <https://github.com/snapcore/snapd/pull/9820> | 16:50 |
| zyga | cachio, hey | 16:52 |
| zyga | cachio, I was pretty busy with office work today but I'll send some more fixes for spread in my late evening | 16:52 |
| pstolowski | pedronis: thanks. i'm tweaking this right now, found an issue causing spread test failures | 16:53 |
| cachio | zyga, hey, nice | 17:13 |
| cachio | I have time for that today | 17:13 |
| cachio | I can review that for sure | 17:13 |
| mup | PR snapcraft#3411 opened: repo: install apt build packages marked for installation <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3411> | 17:17 |
| * cachio afk | 17:26 | |
| === ijohnson is now known as ijohnson|lunch | ||
| mup | PR snapcraft#3411 closed: repo: only install build packages marked for installation <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3411> | 18:57 |
| mup | PR snapd#9822 closed: tests: new action-add-labels workflow to autotically tag a PR with "Run Nested" <â›” Blocked> <Created by sergiocazzolato> <Closed by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9822> | 20:27 |
| === ijohnson|lunch is now known as ijohnson | ||
| zyga | cachio, https://github.com/snapcore/spread/pull/112 | 22:38 |
| mup | PR spread#112: Bump base version of go to 1.13 <Created by zyga> <https://github.com/snapcore/spread/pull/112> | 22:38 |
| zyga | cachio, trivial bump, just to see if it passes | 22:39 |
| zyga | it worked for me locally (for go get) and then failed on the go vet issues | 22:39 |
| zyga | cachio, if you agree we should prepare a single branch that has 1.10 -> 1.13 bump, and two go vet fixes and propose that instead, it should pass ci | 22:41 |
| mup | PR snapcraft#3412 opened: grammar: ensure all dictionary primitives are captured <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3412> | 23:28 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!