| smoser | Odd_Bloke: i dont know how i'm supposed to do https://github.com/canonical/cloud-init/pull/771 . | 13:30 |
|---|---|---|
| smoser | can i "approve with author changes" ? | 13:30 |
| smoser | or will i have to approve again (which is also fine) | 13:30 |
| Odd_Bloke | smoser: So our documented process is that if you're +1 with nits/minor changes, you can push those changes and land it; if you aren't happy with a PR landing in its current state, you should not Approve (because that risks it getting landed by someone who hasn't noticed you were +1 with conditions). I believe that your Approve will carry over to my modifications, let's find out. | 14:47 |
| Odd_Bloke | smoser: Yeah, it's still showing me as having "1 approval", so I could land. I took your suggestion but modified the first sentence: what the parentheses were failing to communicate is that command runs regardless of whether data is specified, so I tweaked your proposed wording a bit (to "If the ``command`` key is specified, the given command will be executed. This will happen after ``file`` has been | 14:57 |
| Odd_Bloke | populated."). | 14:57 |
| Odd_Bloke | (I'll give you a few minutes to object to that before using your existing Approve to land it. ;) | 14:57 |
| smoser | thank | 15:20 |
| smoser | s | 15:20 |
| smoser | If a command is | 15:20 |
| smoser | specified that cannot be run, no error will be reported unless | 15:20 |
| smoser | just a comment ... ^ is weird behavior. | 15:20 |
| smoser | i think it was slop that we/i added to allow you to do pollinate even if pollinate wasn't in the image. | 15:21 |
| Odd_Bloke | Looks like it dates back to 2014, yeah: https://github.com/canonical/cloud-init/commit/778d2015ec49170ff4525b63903d7a656ad44b2e | 15:24 |
| smoser | lets not do crap like that in the future | 15:26 |
| Odd_Bloke | Agreed. | 15:26 |
| Odd_Bloke | (Thanks for that review, BTW :) | 15:26 |
| minimal | you've just reminded me that I've been meaning to package pollinate for Alpine... | 15:30 |
| meena | what's that? | 18:30 |
| minimal | meena: pollinate? the "entropy-as-a-service" pollen/pollinate client/server software | 18:33 |
| meena | that sounds weird. where are you getting entropy from? over the network? | 18:35 |
| minimal | meena: yupe, the idea is that a server with a good supply of entropy can provide it to other machines. The software was written several years ago by a then-Canonical-employee: https://github.com/dustinkirkland/pollinate and https://github.com/dustinkirkland/pollen | 18:53 |
| blackboxsw | at long last, VMWare allowing for users to provide raw cloud-init userdata is going to be supported, Just approved https://github.com/canonical/cloud-init/pull/691. will land it once CI finished | 22:15 |
| blackboxsw | thanks xiaofeng-vmware | 22:16 |
| Odd_Bloke | falcojr: Is that our first community-contributed integration test I just saw land? | 22:37 |
| Odd_Bloke | blackboxsw: https://github.com/canonical/uss-tableflip/pull/71 | 22:38 |
| blackboxsw | Odd_Bloke: falcojr just landed https://github.com/canonical/cloud-init/pull/691 vmware support for raw userdata and metadata as provided by vsphere users. my apologies for those looking over the git commit msg on that... I totally blew threw the commit msg length during the squashmerge in the UI | 23:19 |
| falcojr | Nice! | 23:20 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!