mborzecki | morning | 07:04 |
---|---|---|
mborzecki | mvo: morning | 07:56 |
mvo | good morning mborzecki | 07:56 |
mup | PR snapd#9835 closed: tests: apply workaround done for snap-advise-command to apt-hooks test <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9835> | 07:59 |
mborzecki | mvo: can you land https://github.com/snapcore/snapd/pull/9831 ? the failures are in apt-hooks and snap-advise-command again | 08:08 |
mup | PR #9831: interfaces/builtin: fix unit test expecting snap-device-helper at /usr/lib/snapd <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9831> | 08:08 |
mvo | mborzecki: sure thing | 08:17 |
mborzecki | mvo: https://github.com/snapcore/snapd/pull/9819#discussion_r556493129 /etc/dbus-1 is in centos-*, amzn2, 14.04, and must be in other other systems too | 08:19 |
mup | PR #9819: snap-confine: make host /etc/ssl available for snaps on classic <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9819> | 08:19 |
mup | PR snapd#9831 closed: interfaces/builtin: fix unit test expecting snap-device-helper at /usr/lib/snapd <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9831> | 08:19 |
mborzecki | i can push a tweak there | 08:19 |
mvo | mborzecki: but dbus-1 does not come from the host? | 08:20 |
mvo | mborzecki: or am I missing something? | 08:20 |
mborzecki | mvo: ahh right, i need my morning coffee clearly | 08:21 |
mvo | mborzecki: does my reply in there make sense? | 08:21 |
mvo | mborzecki: ok :) no worries! | 08:21 |
pstolowski | morning | 08:22 |
mborzecki | mvo: /etc/nsswitch is doubly problematic, it's a file in most systems, but a symlink on fedora ;) which we skip by default | 08:22 |
mborzecki | let me check /etc/alternatives | 08:22 |
mvo | mborzecki: alternatives are a debian thing, not sure if those ever were adopted someplace else | 08:24 |
mborzecki | mvo: hm looks like only arch is missing it, which is ok i think? | 08:26 |
zyga | mvo, I think suse has those as well | 08:31 |
zyga | are we finally exploring untangling /etc | 08:31 |
zyga | good morning | 08:34 |
* zyga is trying to drop the coffee | 08:34 | |
mvo | mborzecki: +1 | 08:39 |
mvo | mborzecki: I can update (unless you have this ready) | 08:39 |
mborzecki | zyga: hey, can you take a quick look at https://build.opensuse.org/request/show/862869 with your morning coffee? | 08:39 |
zyga | mborzecki, I stopped using coffee :) | 08:40 |
zyga | but yeah, sure :) | 08:40 |
mborzecki | mvo: the spread run is still in progress, if it's successful i'd rather merge it and do a follow up | 08:40 |
mvo | mborzecki: sounds great | 08:40 |
mvo | mborzecki: fwiw, samuele marked it as "needs-samuele-review" so we only only land after his +1 | 08:41 |
mborzecki | mvo: right, in which case i may push a tweak for that test then :) | 08:41 |
mvo | zyga: no untangling of etc yet :( not sure I will ever see this day | 08:41 |
mvo | mborzecki: yeah | 08:41 |
pstolowski | mborzecki: thanks for the review of validation-sets | 09:06 |
mborzecki | pstolowski: yw | 09:07 |
pstolowski | mborzecki: btw, snapd-generator fix is ready fo re-review ;) | 09:07 |
zyga | mborzecki, is the system:snappy approval enough or do you need me to do some follow up steps? | 09:24 |
mborzecki | zyga: no, having a 2nd pair of eyes glance at the spec is enough, thanks! | 09:25 |
mup | PR snapd#9513 closed: snapshotstate: detect duplicated snapshot imports <Needs Samuele review> <Created by mvo5> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9513> | 09:29 |
ogra | mvo, did anyone test the classic snap on UC20 (should we delist it finally ? or just make it print "please use lxd" ... or something like that) ... https://forum.snapcraft.io/t/uc-20-snapcraft-install-issue/22162/4 | 09:30 |
mvo | ogra: great point, we should probably suggest using lxd at this point | 09:30 |
pstolowski | mvo: ^ #9513, finally! \o/ | 09:30 |
mup | PR #9513: snapshotstate: detect duplicated snapshot imports <Needs Samuele review> <Created by mvo5> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9513> | 09:31 |
ogra | yeah | 09:31 |
mvo | pstolowski: nice | 09:31 |
pstolowski | any idea why tests/go.mod gets updated behind my back sometimes? | 09:31 |
mvo | pstolowski: compiling go things inside tests | 09:32 |
mvo | pstolowski: in a meeting | 09:32 |
pstolowski | hmm, interesting, thanks | 09:33 |
jamesh | mvo: here's the output run against the snapd snap: https://paste.ubuntu.com/p/m5RHWNs7jn/ -- there's obviously some false positives w.r.t. the NSS plugins, since they look like regular libraries | 09:36 |
mvo | jamesh: thanks, still in a meeting but will get back to you | 09:38 |
mborzecki | mvo: #9819 failed in the dirs-not-shared-with-host test, i'll push a tweak to use /etc/alternatives | 09:42 |
mup | PR #9819: snap-confine: make host /etc/ssl available for snaps on classic <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9819> | 09:42 |
mborzecki | mvo: hah, there's no /etc/alternatives in the core snap | 10:01 |
mvo | mborzecki: oh, fun! | 10:01 |
mborzecki | maybe it got removed at some point | 10:01 |
mborzecki | mvo: i suppose we stay with apparmor.d for now, and just blacklist the systems where it's not on the host | 10:02 |
mvo | mborzecki: do we need to blacklist? /etc/ssl is also not available and still works, no? | 10:04 |
mvo | mborzecki: also in a meeting still | 10:04 |
mborzecki | mvo: haha, more fun, /etc/os-release on debian has no ID_LIKE=debian ;) | 10:18 |
mvo | mborzecki: woah! just woah! | 10:23 |
mvo | mborzecki: well, I guess it makes sense | 10:23 |
mvo | mborzecki: but :) | 10:23 |
mborzecki | mvo: i'm looking into fixing that | 10:23 |
mvo | mborzecki: ta | 10:24 |
mup | PR snapd#9838 opened: asserts: sort by revision with Sort interface <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9838> | 10:40 |
pstolowski | mborzecki: ^ | 10:54 |
mborzecki | pstolowski: will look in a bit | 10:57 |
mborzecki | mvo: pushed the changes to #9819 please take a look | 10:57 |
mup | PR #9819: snap-confine: make host /etc/ssl available for snaps on classic <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9819> | 10:57 |
mborzecki | ogra: have you already applied for BeagleV? | 10:58 |
mborzecki | looks like the initial batch of those boards is going to be quite small | 10:59 |
mvo | mborzecki: thank you, checking | 10:59 |
ogra | mborzecki, only heard about it yesterday ... havent yet,m no ... but i plan to in a later batch | 11:15 |
mborzecki | pstolowski: couple more comments https://github.com/snapcore/snapd/pull/9817 | 11:53 |
mup | PR #9817: cmd/snapd-generator: don't create mount overrides for snap-try snaps inside lxc <Bug> <Needs security review> <Squash-merge> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9817> | 11:53 |
pstolowski | ty | 11:53 |
mborzecki | pstolowski: mvo: can we merge https://github.com/snapcore/snapd/pull/9732 ? 2 +1, the error on xenial is unrelated | 12:38 |
mup | PR #9732: asserts: snapasserts method to validate installed snaps against validation sets <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9732> | 12:38 |
pstolowski | mborzecki: yes, totally, but may need manual merge again | 12:42 |
mup | PR snapd#9839 opened: tests: spread log analyzer that could be used for re execute failed tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9839> | 12:45 |
mup | PR snapd#9840 opened: interfaces/builtin: Allow DBus property access on org.freedesktop.Notifications <Created by kbroulik> <https://github.com/snapcore/snapd/pull/9840> | 12:45 |
pstolowski | pedronis: #8532 has +1 from me, with some tweaks | 13:01 |
mup | PR #8532: tests: install new snapd deb into preseed image <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8532> | 13:01 |
pedronis | pstolowski: thx, I queued it but not sure when I'll get to it | 13:06 |
pedronis | pstolowski: I might have questions | 13:06 |
ijohnson | morning folks | 13:28 |
mup | PR snapcraft#3404 closed: build(deps): bump lxml from 4.5.0 to 4.6.2 <dependencies> <python> <Created by dependabot[bot]> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3404> | 13:52 |
mup | PR snapcraft#3417 closed: Allow validation assertions to be revoked <Created by nessita> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3417> | 13:52 |
mvo | pstolowski: I can merge 9732 if the current run is not green, just ping me | 13:59 |
pstolowski | mvo: ty | 13:59 |
mup | PR snapd#9834 closed: tests: normalize test tools - part 1 <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9834> | 14:01 |
zyga | good morning ijohnson | 15:04 |
ijohnson | hey zyga | 15:04 |
zyga | ijohnson, how do you find focus to work in the last few days? | 15:04 |
ijohnson | ha | 15:04 |
ijohnson | memes, lots and lots of memes | 15:04 |
zyga | is sergio around? | 15:04 |
zyga | ijohnson, I think we all want to wake up in Feb | 15:05 |
ijohnson | zyga: huh yeah Sergio was in SU, not sure why he's not on IRC | 15:05 |
zyga | ah, no worries, I'll wait | 15:05 |
ijohnson | zyga: yeah that's what everybody kept saying about after November "I can't wait for XXX to be over" :-P | 15:06 |
mup | PR snapd#9732 closed: asserts: snapasserts method to validate installed snaps against validation sets <validation-sets :white_check_mark:> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9732> | 15:06 |
zyga | ijohnson, yeah, I really hope it's one of those shows where the finale is just boring though | 15:06 |
ijohnson | indeed, that's all our hopes really | 15:07 |
zyga | ijohnson, not sure how it looks from your point of view but I was not expecting any of that to happen | 15:07 |
* zyga waits for debootstrap to run | 15:07 | |
zyga | let me grab some water quickly | 15:07 |
ijohnson | yeah it was really unexpected, I mean I was nervous something was gonna happen, but I never imagined that it would come to that | 15:07 |
mvo | pstolowski: if you merged master into 9838 it will be a lot smaller now, yes? | 15:11 |
pstolowski | mvo: yes, going to do in a sec | 15:13 |
mvo | mborzecki: I added some comments to 9819. thanks a lot for updating it! | 15:18 |
mup | PR snapcraft#3418 closed: project: always set target arch even if not cross compiling <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3418> | 15:22 |
* cachio lunch | 15:31 | |
pstolowski | mvo: updated | 15:31 |
mvo | ta | 15:38 |
pstolowski | mborzecki: can you +1 #9838? | 15:45 |
mup | PR #9838: asserts: sort by revision with Sort interface <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9838> | 15:45 |
pstolowski | just saw interesting failure of uc20-create-partitions test: https://paste.ubuntu.com/p/VCjQWKwP72/ | 16:58 |
pstolowski | mvo: ^ | 16:58 |
mvo | pstolowski: woah, "bad message" ?!? | 17:10 |
pstolowski | mvo: that was on #9838, so nothing related to my branch | 17:11 |
mup | PR #9838: asserts: sort by revision with Sort interface <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9838> | 17:11 |
mup | PR snapcraft#3410 closed: project: enable experimental target-arch support for core20 <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3410> | 17:12 |
mvo | pstolowski: right | 17:12 |
ijohnson | mvo: that mount error message seems to be because the kernel is returning silly error messages for bad CRC detection: | 18:01 |
ijohnson | > This is because kernel uses EBADMSG errno for "Bad CRC detected" situation. | 18:01 |
ijohnson | from https://bugzilla.redhat.com/show_bug.cgi?id=1496764 | 18:01 |
mvo | ijohnson: thanks | 18:31 |
jdstrand | jjohansen: hey, what is the status of the quiet profile flag? | 18:54 |
jjohansen | jdstrand: currently scheduled for 3.1 but it could get pushed to 3.2 if higher priority items don't give me time to finish up the work on it | 18:59 |
jdstrand | jjohansen: thanks! | 19:02 |
ijohnson | hey jdstrand, what is the status of https://bugs.launchpad.net/snapd/+bug/1868051? the mentioned pr was merged, so can I mark it as fixed ? | 19:28 |
mup | Bug #1868051: browser-support[allow-sandbox=true] should not grant access to /var/lib/snapd/desktop/applications <snapd:In Progress by jdstrand> <https://launchpad.net/bugs/1868051> | 19:28 |
mup | PR snapcraft#3350 closed: project loader, schema: add advanced grammar support for build-environment <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3350> | 19:52 |
mup | PR snapd#9829 closed: tests: cleanup the run-checks script <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9829> | 19:57 |
* cachio afk | 20:04 | |
jdstrand | ijohnson: let me check | 20:10 |
jdstrand | ijohnson: yep, fixed. I updated the bug | 20:16 |
jwheare | does anyone in here use the irccloud snap? if so would you mind testing the latest edge/candidate release before i promote it to stable? i just significantly rejigged our build process and bumped the main deps (including electron) several major versions and want to make sure i didn't mess anything up. thanks https://snapcraft.io/irccloud | 20:17 |
zyga | jwheare, that's nice, I suggest talking about it on the forum as well | 20:28 |
ijohnson | thanks jdstrand | 20:59 |
ijohnson | jwheare: sure I can give it a spin | 21:00 |
ijohnson | jwheare: seems to work fine for me, no problems that I can tell, I'm on revision 43 | 21:24 |
=== ubott2 is now known as ubottu | ||
jwheare | ijohnson: amazing, thanks so much for checking | 21:32 |
ijohnson | np | 22:29 |
mup | PR snapcraft#3336 closed: package repositories: introduce path property for exact paths <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3336> | 23:38 |
mup | PR snapcraft#3416 closed: repo: default to target arch for stage package cache <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3416> | 23:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!