| === xclaesse5 is now known as xclaesse | ||
| === meetingology` is now known as meetingology | ||
| jibel | Good morning | 06:07 |
|---|---|---|
| callmepk | morning jibel | 06:27 |
| jibel | Hi callmepk | 06:29 |
| oSoMoN | good morning desktoppers | 07:05 |
| jibel | Salut oSoMoN | 07:11 |
| callmepk | hi oSoMoN | 07:11 |
| seb128 | hey oSoMoN, jibel, callmepk, how are you? | 07:16 |
| callmepk | seb128, I am fine, just completed my morning class... | 07:17 |
| oSoMoN | salut jibel, seb128 | 07:19 |
| oSoMoN | hey callmepk | 07:19 |
| oSoMoN | I'm doing alright, caught in the morning rush to take my daughters to school… | 07:20 |
| jibel | Salut seb128 | 07:37 |
| marcustomlinson | morning jibel callmepk oSoMoN seb128 | 08:11 |
| jibel | Hi marcustomlinson | 08:14 |
| didrocks | good morning | 08:32 |
| marcustomlinson | hey didrocks | 08:35 |
| didrocks | hey marcustomlinson | 08:38 |
| jibel | Salut didrocks | 08:44 |
| didrocks | salut jibel | 08:44 |
| callmepk | hi marcustomlinson | 08:49 |
| Laney | heya | 09:02 |
| marcustomlinson | hey Laney | 09:04 |
| jamesh | marcustomlinson: I know you did some work a while back on shrinking snaps, so you might find this interesting: https://github.com/snapcore/snapcraft/pull/3413 | 09:30 |
| seb128 | callmepk, did you see my review comments on the wslu merge request? | 09:51 |
| marcustomlinson | jamesh: nice! what about dependencies that are linked at runtime though? | 10:01 |
| marcustomlinson | dlopen() and the like | 10:02 |
| jamesh | marcustomlinson: it tries to add plugin-style shared libraries to the starting kernel when determining what libraries are used. | 10:03 |
| jamesh | marcustomlinson: at first I was using the heuristic of "elf files without sonames", but that didn't work so well, so the current version is "elf files not directly in a lib/ or lib/${arch_triplet} directory" | 10:04 |
| jamesh | which also isn't perfect, but gets closer | 10:05 |
| marcustomlinson | ah, very cool | 10:05 |
| jamesh | it turns out there are a lot of dlopen() style plugins that have a soname set, and a few libraries linked with DT_NEEDED without a soname | 10:07 |
| jamesh | it's a bit of a mess | 10:07 |
| marcustomlinson | oh absolutely it’s a mess | 10:20 |
| callmepk | seb128, yep I see it, I am right now switching to the patch method on wslutilities/wslu.git at ubuntu/master branch, would that be better? | 10:23 |
| seb128 | callmepk, yes, better to the use the upstream patch if possible | 10:24 |
| oSoMoN | ricotz, FYI, I just pushed 2 revisions to the firefox-beta.xenial branch (and the corresponding package to the firefox-next PPA): I did some patch cleanup, and updated the test expectations | 11:14 |
| oSoMoN | I am doing the same for other releases now | 11:14 |
| ricotz | oSoMoN, did you actually runtime tested those changes | 11:22 |
| oSoMoN | ricotz, autopkgtests passed for all the architectures | 11:23 |
| ricotz | e.g. ppc-no-static-sizes.patch and s390x-ycbcr.patch are not build fixes | 11:23 |
| oSoMoN | ppc-no-static-sizes.patch is already upstream | 11:25 |
| ricotz | autopkgtests doesn't cover rendering issues like what s390x-ycbcr.patch is for | 11:26 |
| oSoMoN | true, but the patch didn't have any metadata and it really looked like a build fix, I'm happy to add it back if you have a pointer to a bug or a description of the problem it solves | 11:27 |
| oSoMoN | and we should upstream it | 11:27 |
| ricotz | so don't remove it without having any feedback | 11:29 |
| oSoMoN | ricotz, was there someone who reported the problem and verified the fix at the time you added the patch? | 11:29 |
| oSoMoN | ricotz, the changelog entry for when that patch was added says "Fix skia build on arm64 and s390x", which is why I assumed it was a build fix | 11:31 |
| ricotz | oSoMoN, there are likely more color conversion issue regarding big-endian archs, e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1672395 | 11:34 |
| ubot5 | Mozilla bug 1672395 in Graphics "[s390x] [big endian?] Some images have wrong colors in Firefox" [S3,New] | 11:34 |
| ricotz | sorry I don't have time now | 11:34 |
| ricotz | might be better to postpone such a clean up until after xenial is EOL | 11:35 |
| ricotz | oSoMoN, I am going to force push and revert you updates | 11:36 |
| oSoMoN | ricotz, please don't | 11:38 |
| oSoMoN | I'll revert it myself | 11:38 |
| ricotz | no | 11:38 |
| oSoMoN | why not? | 11:39 |
| ricotz | because I haven't pushed my local change yet anyway | 11:39 |
| ricotz | (I wanted to wait for beta 9) | 11:39 |
| oSoMoN | I have taken that into account and your changelog entries are there | 11:40 |
| ricotz | basically a simple question before doing this, would have been nice | 11:40 |
| oSoMoN | I should have asked indeed, but the changelog entry really implied it was a build-time fix and my test builds without the patch succeeded, so I didn't really think that required further discussion | 11:42 |
| oSoMoN | I'll add back the patch with better metadata so this doesn't happen again | 11:42 |
| ricotz | please cancel all the ppa builds | 11:44 |
| seb128 | ricotz, sounds like an honest mistake, errors happen... | 11:44 |
| ricotz | seb128, hi, I realize that | 11:44 |
| oSoMoN | builds cancelled | 11:47 |
| ricotz | oSoMoN, thank you for looking into cleaning things up, but you are usually not pushing to the beta branches or beta ppa build, so there is more than just a warning wanted from my side | 11:48 |
| callmepk | hey seb128, messed up the local git during the patch, so delayed a bit... I had to create a new MR here: https://code.launchpad.net/~callmepk/ubuntu/+source/wslu/+git/wslu/+merge/396311 | 12:59 |
| ItzSwirlz | good morning/afternoon :D | 13:07 |
| seb128 | hey ItzSwirlz | 13:09 |
| seb128 | callmepk, I saw it, no conflict and it seems to address the review issues, I will sponsor it today | 13:09 |
| ItzSwirlz | o/ | 13:09 |
| callmepk | thanks seb128 | 13:11 |
| seb128 | np! | 13:11 |
| oSoMoN | ricotz, re firefox on s390x, there's also https://bugzilla.mozilla.org/show_bug.cgi?id=1626236 | 13:55 |
| ubot5 | Mozilla bug 1626236 in ImageLib "[s390x / Big endian] - Image decoders produce swizzled output" [S3,Unconfirmed] | 13:56 |
| oSoMoN | but none of these two bugs mention or link to the patch that we currently have in our packages | 13:56 |
| oSoMoN | I'm guessing it is coming from https://chromium.googlesource.com/chromium/src/+/fbf038170dc0bd29ead8630013b28c6008047ec1, but I would like to see/read a confirmation from someone who actually tested it that it makes things better | 13:57 |
| oSoMoN | and then we could upstream it | 13:57 |
| oSoMoN | otherwise I feel like we're carrying a patch for no real added value | 13:57 |
| oSoMoN | but I'm fine leaving it there until we figure it out | 13:58 |
| ricotz | oSoMoN, I don't remember where it came from, but it serves a purpose. I don't have a s390x instance to give a build some runtime testing, I am going to try setting one up with qemu if that is possible | 15:22 |
| oSoMoN | ricotz, cool | 15:22 |
| ricotz | oSoMoN, afair seb gave s390x some runtime testing last time when the bigendian icu patches were merged | 15:23 |
| ricotz | it better to target the ff trunk builds here | 15:24 |
| cpaelzer | ricotz: oSoMoN: I'd not recommend to try s390x-qemu emulation; by far the simplest way is getting an s390x instance on canonistack | 15:31 |
| oSoMoN | yeah, I got one of those running, I'll see if I can run tests | 15:31 |
| ricotz | cpaelzer, I see, I assume it would be very slow? | 15:34 |
| ricotz | oSoMoN, thanks | 15:36 |
| cpaelzer | ricotz: it is not supporting all instructions a new kernel&glibc might issue, so expect breakage in the worst case | 15:39 |
| oSoMoN | ricotz, here are some screenshots taken on s390x: https://people.canonical.com/~osomon/ff-s390x/ | 15:56 |
| oSoMoN | the first 3 are with the version in the hirsute archive (84.0.2), the 4th one is a 85.0~b8 from my PPA without the s390x patch | 15:57 |
| oSoMoN | I'm not seeing any difference in image rendering between the two versions | 15:57 |
| oSoMoN | i.e. image colors are wrong in both cases | 15:57 |
| xnox | we don't care about s390x though =) | 16:03 |
| hellsworth | good morning desktopers | 16:07 |
| oSoMoN | good morning hellsworth | 16:11 |
| hellsworth | hi there oSoMoN | 16:11 |
| marcustomlinson | hey hellsworth | 16:11 |
| hellsworth | o/ marcustomlinson | 16:11 |
| ricotz | oSoMoN, I assumed this color format is used in videos, but its might be obsolete | 16:15 |
| ricotz | oSoMoN, could you compare these https://people.ubuntu.com/~ricotz/firefox/ | 16:23 |
| ricotz | oSoMoN, could you compare these https://people.ubuntu.com/~ricotz/firefox/ | 16:34 |
| xnox | horay! new laptop bad screen resolution =) | 16:39 |
| xnox | i'm confused if i have hidh-dpi laptop or not, and if i should have scaling or not, and how things should look like on it | 16:40 |
| oSoMoN | ricotz, it looks like my last messages didn't go through as I was having issues connecting to my IRC bouncer | 21:24 |
| oSoMoN | <oSoMoN> ricotz, see the first 4 screenshots in https://people.canonical.com/~osomon/ff-s390x/ | 21:24 |
| oSoMoN | <oSoMoN> (ff84 is the archive build, ff85 is my custom build without the patch) | 21:24 |
| oSoMoN | <oSoMoN> looks the same to me | 21:24 |
| ricotz | <ricotz> oSoMoN, I assumed this color format is used in videos, but its might be obsolete | 21:26 |
| ricotz | <ricotz> oSoMoN, could you compare these https://people.ubuntu.com/~ricotz/firefox/ | 21:26 |
| oSoMoN | ricotz, yes, and the above was my answer to your request for comparison | 21:27 |
| ricotz | ok | 21:28 |
| ricotz | oSoMoN, uploaded beta 9 | 22:12 |
| oSoMoN | ack, thanks | 22:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!